)]}'
{"zuul.d/playbooks/run-scripts.yml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ceddb2d9f07e9a99809121fbc90895ce7d117d76","unresolved":false,"context_lines":[{"line_number":125,"context_line":"          set_fact:"},{"line_number":126,"context_line":"            script_list: \"{{ _script_list | difference(_blacklisted_scripts) | sort }}\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    - name: Run scripts with overrides if necessary, relatively to the root_path"},{"line_number":129,"context_line":"      shell: |"},{"line_number":130,"context_line":"         set -xe;"},{"line_number":131,"context_line":"         {{ item.replace(root_path,\u0027\u0027) }}"},{"line_number":132,"context_line":"      environment:"},{"line_number":133,"context_line":"        #OSH_OPENSTACK_RELEASE: \"{{ osh_openstack_release }}\"               #TBD if it is still needed"},{"line_number":134,"context_line":"        OSH_EXTRA_HELM_ARGS: \"{% for element in scripts_overrides|default([]) %}{% if element.matcher is defined and element.matcher in item %}--values\u003d./{{ element.override }}{% endif %}{% endfor %}\""},{"line_number":135,"context_line":"        #OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\" #TBD if it is still needed"},{"line_number":136,"context_line":"        zuul_site_mirror_fqdn: \"{{ zuul_site_mirror_fqdn }}\""},{"line_number":137,"context_line":"      with_items: \"{{ script_list }}\""},{"line_number":138,"context_line":"      args:"},{"line_number":139,"context_line":"        executable: /bin/bash"},{"line_number":140,"context_line":"        chdir: \"{{ root_path }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_4052f869","line":140,"range":{"start_line":128,"start_character":0,"end_line":140,"end_character":32},"updated":"2018-10-12 17:38:31.000000000","message":"could we iterate over a role here? It would offer clearer feedback I think than iterating through a task.","commit_id":"5fe79c436c4bf8e780d606b73bf4fca3d3174c98"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"06a4052ff7e354c2b47017bd6c9bbc1819c428a1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"          set_fact:"},{"line_number":126,"context_line":"            script_list: \"{{ _script_list | difference(_blacklisted_scripts) | sort }}\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    - name: Run scripts with overrides if necessary, relatively to the root_path"},{"line_number":129,"context_line":"      shell: |"},{"line_number":130,"context_line":"         set -xe;"},{"line_number":131,"context_line":"         {{ item.replace(root_path,\u0027\u0027) }}"},{"line_number":132,"context_line":"      environment:"},{"line_number":133,"context_line":"        #OSH_OPENSTACK_RELEASE: \"{{ osh_openstack_release }}\"               #TBD if it is still needed"},{"line_number":134,"context_line":"        OSH_EXTRA_HELM_ARGS: \"{% for element in scripts_overrides|default([]) %}{% if element.matcher is defined and element.matcher in item %}--values\u003d./{{ element.override }}{% endif %}{% endfor %}\""},{"line_number":135,"context_line":"        #OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\" #TBD if it is still needed"},{"line_number":136,"context_line":"        zuul_site_mirror_fqdn: \"{{ zuul_site_mirror_fqdn }}\""},{"line_number":137,"context_line":"      with_items: \"{{ script_list }}\""},{"line_number":138,"context_line":"      args:"},{"line_number":139,"context_line":"        executable: /bin/bash"},{"line_number":140,"context_line":"        chdir: \"{{ root_path }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_0fbbcbbd","line":140,"range":{"start_line":128,"start_character":0,"end_line":140,"end_character":32},"in_reply_to":"3f79a3b5_4052f869","updated":"2018-10-12 21:48:06.000000000","message":"could you explain why carry the burden of a complete role _for the iterations_, as no variable need to be involved and would be more complex at the end...\n\nI\u0027d understand for the whole play though, but I am not sure it solves what you are asking :)","commit_id":"5fe79c436c4bf8e780d606b73bf4fca3d3174c98"}]}