)]}'
{"helm-toolkit/templates/scripts/_rally_test.sh.tpl":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"c84d533545436dd5c62539c38520ece634c57f1f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"rally task start /etc/rally/rally_tests.yaml"},{"line_number":62,"context_line":"rally deployment destroy --deployment \"${RALLY_ENV_NAME}\""},{"line_number":63,"context_line":"rally task sla-check"},{"line_number":64,"context_line":"{{- if $rallyTests.delete_test_user }}"},{"line_number":65,"context_line":"openstack user delete ${SERVICE_OS_USERNAME}"},{"line_number":66,"context_line":"openstack project delete ${SERVICE_OS_PROJECT_NAME}"},{"line_number":67,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_b1ec3cbc","line":64,"updated":"2018-10-16 18:38:24.000000000","message":"Is there any reason not to *always* delete the rally credentials after completing the test?","commit_id":"0fbbf9c36739e2e1c0fd7d975cfd055e9626ee3b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2d4e7938454935554afaefa6f4d6d2bc95d52f48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"rally task start /etc/rally/rally_tests.yaml"},{"line_number":62,"context_line":"rally deployment destroy --deployment \"${RALLY_ENV_NAME}\""},{"line_number":63,"context_line":"rally task sla-check"},{"line_number":64,"context_line":"{{- if $rallyTests.delete_test_user }}"},{"line_number":65,"context_line":"openstack user delete ${SERVICE_OS_USERNAME}"},{"line_number":66,"context_line":"openstack project delete ${SERVICE_OS_PROJECT_NAME}"},{"line_number":67,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_bc15f33f","line":64,"in_reply_to":"3f79a3b5_b1ec3cbc","updated":"2018-10-16 18:52:38.000000000","message":"It would be helpful for debugging if the test data remains, but this value could be set to true by default, only retaining test data if an issue arises.","commit_id":"0fbbf9c36739e2e1c0fd7d975cfd055e9626ee3b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"40702820b7cad9d2f8a27fdc8a73c7daa9b76e1c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"rally task start /etc/rally/rally_tests.yaml"},{"line_number":62,"context_line":"rally deployment destroy --deployment \"${RALLY_ENV_NAME}\""},{"line_number":63,"context_line":"rally task sla-check"},{"line_number":64,"context_line":"{{- if $rallyTests.delete_test_user }}"},{"line_number":65,"context_line":"openstack user delete ${SERVICE_OS_USERNAME}"},{"line_number":66,"context_line":"openstack project delete ${SERVICE_OS_PROJECT_NAME}"},{"line_number":67,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_7773f4b4","line":64,"in_reply_to":"3f79a3b5_bc15f33f","updated":"2018-10-16 19:27:48.000000000","message":"this value should be false by default, you don\u0027t ever delete users/projects unless explicitly told to. eg what would happen if the \u0027service\u0027 project was used to run the test?","commit_id":"0fbbf9c36739e2e1c0fd7d975cfd055e9626ee3b"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7183fdec965ab2b1d3b911a0656f8621aa5a7ed","unresolved":false,"context_lines":[{"line_number":63,"context_line":"rally task sla-check"},{"line_number":64,"context_line":"{{- if $rallyTests.delete_test_user }}"},{"line_number":65,"context_line":"openstack user delete ${SERVICE_OS_USERNAME}"},{"line_number":66,"context_line":"openstack project delete ${SERVICE_OS_PROJECT_NAME}"},{"line_number":67,"context_line":"{{- end }}"},{"line_number":68,"context_line":"{{- end }}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_7c9e7b69","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":50},"updated":"2018-10-16 19:06:50.000000000","message":"Is this variable not the one defined in [0]:\n\n[0] https://github.com/openstack/openstack-helm-infra/blob/master/helm-toolkit/templates/scripts/_ks-user.sh.tpl#L49\n\nCan we safely delete these things?  I think perhaps we should create new users instead of using ${SERVICE_OS_*}","commit_id":"0fbbf9c36739e2e1c0fd7d975cfd055e9626ee3b"}]}