)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"401eeab7ff63819b4a8a06f70fbc75fb4e512e16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Egress Helm-toolkit function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This PS implements the helm toolkit function to generate the"},{"line_number":10,"context_line":"Egress in kubernetes network policy manifest based on overrideable values."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icbe2a18c98dba795d15398dcdcac64228f6a7b4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3f79a3b5_c7cd372e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":74},"updated":"2018-12-13 22:37:33.000000000","message":"Looks like this patch does alot more than just implement the helm toolkit function. Can you add more about the other changes in this patch?","commit_id":"daed581872687894510f62b48bf59bd759ce4e5f"},{"author":{"_account_id":28592,"name":"Mike Pham","email":"tp6510@att.com","username":"tp6510"},"change_message_id":"abfed63c4dc0299eaa240faa0a9ee7cdcde39da1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Egress Helm-toolkit function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This PS implements the helm toolkit function to generate the"},{"line_number":10,"context_line":"Egress in kubernetes network policy manifest based on overrideable values."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icbe2a18c98dba795d15398dcdcac64228f6a7b4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3f79a3b5_e35cd958","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":74},"in_reply_to":"3f79a3b5_c7cd372e","updated":"2018-12-14 14:53:17.000000000","message":"Done","commit_id":"daed581872687894510f62b48bf59bd759ce4e5f"}],"elasticsearch/values.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"401eeab7ff63819b4a8a06f70fbc75fb4e512e16","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        internal: 5000"},{"line_number":594,"context_line":"      http:"},{"line_number":595,"context_line":"        default: 80"},{"line_number":596,"context_line":"  default:"},{"line_number":597,"context_line":"    namespace: default"},{"line_number":598,"context_line":"  kube_system:"},{"line_number":599,"context_line":"    namespace: kube-system"},{"line_number":600,"context_line":"  kube_public:"},{"line_number":601,"context_line":"    namespace: kube-public"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"monitoring:"},{"line_number":604,"context_line":"  prometheus:"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"3f79a3b5_479047f3","line":601,"range":{"start_line":596,"start_character":0,"end_line":601,"end_character":26},"updated":"2018-12-13 22:37:33.000000000","message":"Are these really endpoints? If I was just reading through this values.yaml document, it would be unclear to me as to why these values are here. Can there be some indicator that these are for egress network policy enforcement? Seems like these values should be in a separate section.","commit_id":"daed581872687894510f62b48bf59bd759ce4e5f"}],"helm-toolkit/templates/manifests/_network_policy.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7177743931cacf84eb91b05633f85612b80d22f7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"{{- if $k }}"},{"line_number":96,"context_line":"{{- range $pk, $pv :\u003d $v }}"},{"line_number":97,"context_line":"{{- if $v.protocol }}"},{"line_number":98,"context_line":"      - port: {{ $v.default }}"},{"line_number":99,"context_line":"        protocol: {{ $v.protocol }}"},{"line_number":100,"context_line":"{{- else }}"},{"line_number":101,"context_line":"      - port: {{ $pv }}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3f79a3b5_ce06c01c","line":98,"range":{"start_line":98,"start_character":19,"end_line":98,"end_character":27},"updated":"2018-11-01 04:13:50.000000000","message":"why pick the \".default\" if there is a \".protocol\"?","commit_id":"cb38f985f4803ccfc4b60ac6eefbb70cff9d0ce7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7177743931cacf84eb91b05633f85612b80d22f7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"{{- end }}"},{"line_number":108,"context_line":"{{- end }}"},{"line_number":109,"context_line":"{{- end }}"},{"line_number":110,"context_line":"{{- if hasKey (index $envAll.Values \"network_policy\") $label }}"},{"line_number":111,"context_line":"{{- if index $envAll.Values.network_policy $label \"egress\" }}"},{"line_number":112,"context_line":"{{ index $envAll.Values.network_policy $label \"egress\" | toYaml | indent 4 }}"},{"line_number":113,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3f79a3b5_b30c0b45","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":63},"updated":"2018-11-01 04:13:50.000000000","message":"instead of making this a duplicate check with L115, we can just move the egress stuff inside the same check","commit_id":"cb38f985f4803ccfc4b60ac6eefbb70cff9d0ce7"}],"tools/deployment/network-policy/040-ldap.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0c2fba6700dc74070e952607b9eb5c40aeeb9296","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          port: 80"},{"line_number":49,"context_line":"    egress:"},{"line_number":50,"context_line":"      - to:"},{"line_number":51,"context_line":"        - namespaceSelector:"},{"line_number":52,"context_line":"            matchLabels:"},{"line_number":53,"context_line":"              name: default"},{"line_number":54,"context_line":"        - namespaceSelector:"},{"line_number":55,"context_line":"            matchLabels:"},{"line_number":56,"context_line":"              name: kube-public"},{"line_number":57,"context_line":"        - namespaceSelector:"},{"line_number":58,"context_line":"            matchLabels:"},{"line_number":59,"context_line":"              name: kube-system"},{"line_number":60,"context_line":"        - podSelector:"},{"line_number":61,"context_line":"            matchLabels:"},{"line_number":62,"context_line":"              application: ingress"},{"line_number":63,"context_line":"      - to:"},{"line_number":64,"context_line":"        ports:"},{"line_number":65,"context_line":"          - port: 443"},{"line_number":66,"context_line":"            protocol: TCP"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f79a3b5_e1b4f883","line":63,"range":{"start_line":51,"start_character":0,"end_line":63,"end_character":11},"updated":"2018-11-14 17:19:22.000000000","message":"shouldn\u0027t these be generated by the endpoint?","commit_id":"e9e613f718d849b7010ae55f4713da4c49b257ed"}],"tools/deployment/network-policy/045-mariadb.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0c2fba6700dc74070e952607b9eb5c40aeeb9296","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          port: 4567"},{"line_number":40,"context_line":"        - protocol: TCP"},{"line_number":41,"context_line":"          port: 80"},{"line_number":42,"context_line":"    egress:"},{"line_number":43,"context_line":"      - to:"},{"line_number":44,"context_line":"        - namespaceSelector:"},{"line_number":45,"context_line":"            matchLabels:"},{"line_number":46,"context_line":"              name: default"},{"line_number":47,"context_line":"        - namespaceSelector:"},{"line_number":48,"context_line":"            matchLabels:"},{"line_number":49,"context_line":"              name: kube-public"},{"line_number":50,"context_line":"        - namespaceSelector:"},{"line_number":51,"context_line":"            matchLabels:"},{"line_number":52,"context_line":"              name: kube-system"},{"line_number":53,"context_line":"      - to:"},{"line_number":54,"context_line":"        ports:"},{"line_number":55,"context_line":"        - port: 443"},{"line_number":56,"context_line":"          protocol: TCP"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f79a3b5_81a98427","line":53,"range":{"start_line":42,"start_character":0,"end_line":53,"end_character":11},"updated":"2018-11-14 17:19:22.000000000","message":"ditto","commit_id":"e9e613f718d849b7010ae55f4713da4c49b257ed"}],"tools/deployment/network-policy/050-prometheus.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0c2fba6700dc74070e952607b9eb5c40aeeb9296","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        - protocol: TCP"},{"line_number":58,"context_line":"          port: 80"},{"line_number":59,"context_line":"    egress:"},{"line_number":60,"context_line":"      - to:"},{"line_number":61,"context_line":"        - namespaceSelector:"},{"line_number":62,"context_line":"            matchLabels:"},{"line_number":63,"context_line":"              name: default"},{"line_number":64,"context_line":"        - namespaceSelector:"},{"line_number":65,"context_line":"            matchLabels:"},{"line_number":66,"context_line":"              name: kube-public"},{"line_number":67,"context_line":"        - namespaceSelector:"},{"line_number":68,"context_line":"            matchLabels:"},{"line_number":69,"context_line":"              name: kube-system"},{"line_number":70,"context_line":"      - to:"},{"line_number":71,"context_line":"        ports:"},{"line_number":72,"context_line":"        - port: 443"},{"line_number":73,"context_line":"          protocol: TCP"},{"line_number":74,"context_line":"        - port: 6443"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f79a3b5_41a36c45","line":71,"range":{"start_line":60,"start_character":0,"end_line":71,"end_character":14},"updated":"2018-11-14 17:19:22.000000000","message":"ditto","commit_id":"e9e613f718d849b7010ae55f4713da4c49b257ed"}],"tools/deployment/network-policy/100-grafana.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0c2fba6700dc74070e952607b9eb5c40aeeb9296","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        - protocol: TCP"},{"line_number":34,"context_line":"          port: 3000"},{"line_number":35,"context_line":"        - protocol: TCP"},{"line_number":36,"context_line":"          port: 80"},{"line_number":37,"context_line":"    egress:"},{"line_number":38,"context_line":"      - to:"},{"line_number":39,"context_line":"        - namespaceSelector:"},{"line_number":40,"context_line":"            matchLabels:"},{"line_number":41,"context_line":"              name: default"},{"line_number":42,"context_line":"        - namespaceSelector:"},{"line_number":43,"context_line":"            matchLabels:"},{"line_number":44,"context_line":"              name: kube-public"},{"line_number":45,"context_line":"        - namespaceSelector:"},{"line_number":46,"context_line":"            matchLabels:"},{"line_number":47,"context_line":"              name: kube-system"},{"line_number":48,"context_line":"      - to:"},{"line_number":49,"context_line":"        ports:"},{"line_number":50,"context_line":"        - port: 443"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f79a3b5_61a0e837","line":47,"range":{"start_line":36,"start_character":0,"end_line":47,"end_character":31},"updated":"2018-11-14 17:19:22.000000000","message":"ditto","commit_id":"e9e613f718d849b7010ae55f4713da4c49b257ed"}]}