)]}'
{"ceph-osd/templates/bin/osd/_block.sh.tpl":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"c7b91596951fabab98af3bec667c5ee12a8d4de7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    chown ceph. \"${JOURNAL_PART}\" \"${DATA_PART}\""},{"line_number":171,"context_line":"    OSD_JOURNAL\u003d\"${JOURNAL_PART}\""},{"line_number":172,"context_line":"  fi"},{"line_number":173,"context_line":"  #CEPH_OSD_OPTIONS\u003d\"${CEPH_OSD_OPTIONS} --osd-journal ${OSD_JOURNAL}\""},{"line_number":174,"context_line":"fi"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"if [ \"x${JOURNAL_TYPE}\" \u003d\u003d \"xdirectory\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3f79a3b5_a23022b9","line":173,"updated":"2018-11-20 18:15:43.000000000","message":"We can likely just uncomment this, and change the line to\nCEPH_OSD_OPTIONS\u003d\"${CEPH_OSD_OPTIONS}\"","commit_id":"0231c5f443f8a7918e55ed5c3e09f8d283f045ef"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"c7b91596951fabab98af3bec667c5ee12a8d4de7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    chown ceph. \"${JOURNAL_PART}\" \"${DATA_PART}\""},{"line_number":171,"context_line":"    OSD_JOURNAL\u003d\"${JOURNAL_PART}\""},{"line_number":172,"context_line":"  fi"},{"line_number":173,"context_line":"  # Let ceph-osd create/manage partitions for journal"},{"line_number":174,"context_line":"  #CEPH_OSD_OPTIONS\u003d\"${CEPH_OSD_OPTIONS} --osd-journal ${OSD_JOURNAL}\""},{"line_number":175,"context_line":"fi"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_26271420","line":173,"updated":"2018-11-20 18:15:43.000000000","message":"We should probably remove this rather then comment it out.","commit_id":"003dbe036c4444e64cf6c9a9f5ed59258c64571c"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"091c001e829bca1fa46e5ed4cc4d2ee565a7be8f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    chown ceph. \"${JOURNAL_PART}\" \"${DATA_PART}\""},{"line_number":171,"context_line":"    OSD_JOURNAL\u003d\"${JOURNAL_PART}\""},{"line_number":172,"context_line":"  fi"},{"line_number":173,"context_line":"  # Let ceph-osd create/manage partitions for journal"},{"line_number":174,"context_line":"  #CEPH_OSD_OPTIONS\u003d\"${CEPH_OSD_OPTIONS} --osd-journal ${OSD_JOURNAL}\""},{"line_number":175,"context_line":"fi"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_e774ac9d","line":173,"in_reply_to":"3f79a3b5_26271420","updated":"2018-11-21 10:23:14.000000000","message":"Done","commit_id":"003dbe036c4444e64cf6c9a9f5ed59258c64571c"}],"ceph-osd/templates/bin/osd/_init.sh.tpl":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"f4d837cb7bde1198887a4e1348d56bca30fc5940","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"    echo \"${OSD_DEVICE}${OSD_PARTITION}\""},{"line_number":76,"context_line":"  fi"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function journal_partition_creation {"},{"line_number":80,"context_line":"  # Given disk (dev/vde2) and partition number (2), create partition."},{"line_number":81,"context_line":"  local J_DEVICE\u003d${1}"},{"line_number":82,"context_line":"  local J_PARTITION\u003d${2}"},{"line_number":83,"context_line":"  echo \"Preparing for disk ${J_DEVICE} to be partition at ${J_PARTITION}\""},{"line_number":84,"context_line":"  # Check env for PARTITION_START and PARTITION_END."},{"line_number":85,"context_line":"  # We somehow to specify which number to assign for the partition. In this case 2"},{"line_number":86,"context_line":"  # parted -s ${OSD_JOURNAL} mklabel msdos "},{"line_number":87,"context_line":"  # parted  --script /dev/${DEVICE} mkpart primary 1MiB 10241Mib"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"function check_journal_partition_needed {"},{"line_number":91,"context_line":"  echo \"function check_journal_partition_needed\""},{"line_number":92,"context_line":"  local J_DEVICE\u003d${1}"},{"line_number":93,"context_line":"  echo \"Chosen drive ${J_DEVICE}\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  if [ -n \"${J_DEVICE}\" ]; then"},{"line_number":96,"context_line":"    if ! [ -b $J_DEVICE ]; then"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      local JPART\u003d`echo ${J_DEVICE} | sed \u0027s/\\(.*[^0-9]\\)[0-9]*$/\\1/\u0027`"},{"line_number":99,"context_line":"      echo \"${JPART}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      if ! [ -d /sys/block/`basename $JPART`/`basename $J_DEVICE` ]; then"},{"line_number":102,"context_line":"        if [ -d /sys/block/`basename $JPART`/ ]; then"},{"line_number":103,"context_line":"          local J_P_NUM\u003d`echo ${J_DEVICE} | sed \u0027s/.*[^0-9]\\([0-9]*\\)$/\\1/\u0027`"},{"line_number":104,"context_line":"          echo \"Call journal_partition_creation ${JPART}, ${J_P_NUM}\""},{"line_number":105,"context_line":"          journal_partition_creation $JPART $J_P_NUM"},{"line_number":106,"context_line":"        fi"},{"line_number":107,"context_line":"      fi"},{"line_number":108,"context_line":"    fi"},{"line_number":109,"context_line":"  fi"},{"line_number":110,"context_line":"  "},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function osd_disk_prepare {"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3f79a3b5_e2dffa64","line":110,"range":{"start_line":77,"start_character":0,"end_line":110,"end_character":2},"updated":"2018-11-02 02:52:30.000000000","message":"all these changes will be removed.","commit_id":"0231c5f443f8a7918e55ed5c3e09f8d283f045ef"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"f4d837cb7bde1198887a4e1348d56bca30fc5940","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    fi"},{"line_number":196,"context_line":"  fi"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  if [ \"${OSD_BLUESTORE:-0}\" -ne 1 ]; then"},{"line_number":199,"context_line":"    check_journal_partition_needed ${OSD_JOURNAL}"},{"line_number":200,"context_line":"  fi"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  if [ \"${OSD_BLUESTORE:-0}\" -ne 1 ]; then"},{"line_number":203,"context_line":"    # we only care about journals for filestore."}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3f79a3b5_a2cb42a5","line":200,"range":{"start_line":198,"start_character":0,"end_line":200,"end_character":4},"updated":"2018-11-02 02:52:30.000000000","message":"then changes will be removed.","commit_id":"0231c5f443f8a7918e55ed5c3e09f8d283f045ef"}],"ceph-osd/values.yaml":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"20e17295d7994e2e5689a9d231f6e94511d78e5b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        journal:"},{"line_number":117,"context_line":"          type: directory"},{"line_number":118,"context_line":"          location: /var/lib/openstack-helm/ceph/osd/journal-one"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# In order for us to create partition, we need additional information."},{"line_number":121,"context_line":"      # - data:"},{"line_number":122,"context_line":"      #     type: block-logical"},{"line_number":123,"context_line":"      #     location: /dev/sde"},{"line_number":124,"context_line":"      #   journal:"},{"line_number":125,"context_line":"      #     type: block-logical"},{"line_number":126,"context_line":"      #     location: /dev/sdf2"},{"line_number":127,"context_line":"      #     partition_start: 1MiB"},{"line_number":128,"context_line":"      #     partition_end: 10241Mib"},{"line_number":129,"context_line":"      # - data:"},{"line_number":130,"context_line":"      #     type: block-logical"},{"line_number":131,"context_line":"      #     location: /dev/sdg"},{"line_number":132,"context_line":"      #   journal:"},{"line_number":133,"context_line":"      #     type: block-logical"},{"line_number":134,"context_line":"      #     location: /dev/sdf3"},{"line_number":135,"context_line":"      #     partition_start: 1024MiB"},{"line_number":136,"context_line":"      #     partition_end: 20481Mib"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# NOTE(portdirect): for heterogeneous clusters the overrides section can be used to define"},{"line_number":139,"context_line":"# OSD pods that will be deployed upon specifc nodes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_c9520c37","line":136,"range":{"start_line":119,"start_character":0,"end_line":136,"end_character":35},"updated":"2018-11-02 20:59:57.000000000","message":"Need to update this. \nFor this PS to work, we need to define osds as\n      # - data:\n      #     type: block-logical\n      #     location: /dev/sde\n      #   journal:\n      #     type: block-logical\n      #     location: /dev/sdf\n      # - data:\n      #     type: block-logical\n      #     location: /dev/sdg\n      #   journal:\n      #     type: block-logical\n      #     location: /dev/sdf","commit_id":"f411bccbbb04d30010b3d1632ec4f9433733c46d"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"c7b91596951fabab98af3bec667c5ee12a8d4de7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        journal:"},{"line_number":118,"context_line":"          type: directory"},{"line_number":119,"context_line":"          location: /var/lib/openstack-helm/ceph/osd/journal-one"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# In order for us to create partition, we need additional information."},{"line_number":122,"context_line":"      # - data:"},{"line_number":123,"context_line":"      #     type: block-logical"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_a61b24ca","line":120,"updated":"2018-11-20 18:15:43.000000000","message":"Is this still needed? ceph-disk should automatically create the paritions based off of the defined osd_journal_size option.","commit_id":"003dbe036c4444e64cf6c9a9f5ed59258c64571c"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"091c001e829bca1fa46e5ed4cc4d2ee565a7be8f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        journal:"},{"line_number":118,"context_line":"          type: directory"},{"line_number":119,"context_line":"          location: /var/lib/openstack-helm/ceph/osd/journal-one"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# In order for us to create partition, we need additional information."},{"line_number":122,"context_line":"      # - data:"},{"line_number":123,"context_line":"      #     type: block-logical"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_c76f30c5","line":120,"in_reply_to":"3f79a3b5_a61b24ca","updated":"2018-11-21 10:23:14.000000000","message":"Done","commit_id":"003dbe036c4444e64cf6c9a9f5ed59258c64571c"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"df10958b925f3ca1f904fd084613d7595c2ae826","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      # - data:"},{"line_number":153,"context_line":"      #     type: block-logical"},{"line_number":154,"context_line":"      #     location: /dev/sdg"},{"line_number":155,"context_line":"      #   journal:"},{"line_number":156,"context_line":"      #     type: block-logical"},{"line_number":157,"context_line":"      #     location: /dev/sdf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# NOTE(portdirect): for heterogeneous clusters the overrides section can be used to define"},{"line_number":160,"context_line":"# OSD pods that will be deployed upon specifc nodes."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_864c4175","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":30},"updated":"2018-12-12 18:08:32.000000000","message":"does this ps remove the ability to have mixed types of backing (ie block osd, and directory journal?)","commit_id":"07db03b761799466dde391ef22ef3a7e26004cf7"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"80e196fdd06816e212880e5925a4de260b7c30b5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      # - data:"},{"line_number":153,"context_line":"      #     type: block-logical"},{"line_number":154,"context_line":"      #     location: /dev/sdg"},{"line_number":155,"context_line":"      #   journal:"},{"line_number":156,"context_line":"      #     type: block-logical"},{"line_number":157,"context_line":"      #     location: /dev/sdf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# NOTE(portdirect): for heterogeneous clusters the overrides section can be used to define"},{"line_number":160,"context_line":"# OSD pods that will be deployed upon specifc nodes."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_9c09f0dc","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":30},"in_reply_to":"3f79a3b5_864c4175","updated":"2018-12-12 19:39:34.000000000","message":"no it wont , updated  this section back \nthank you","commit_id":"07db03b761799466dde391ef22ef3a7e26004cf7"}]}