)]}'
{"ceph-client/templates/bin/utils/_checkDNS.sh.tpl":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5a78c40f79f96ba9f10b5c5377fe76698d5d25d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"function cache_mon_endpoint () {"},{"line_number":25,"context_line":"  if [[ ${IP_ENDPOINT} !\u003d \"\" ]]; then"},{"line_number":26,"context_line":"    HOSTS_LINE1\u003d\"${IP_ENDPOINT}\\tceph-mon.${NAMESPACE}.svc.cluster.local\""},{"line_number":27,"context_line":"    HOSTS_LINE2\u003d\"${IP_ENDPOINT}\\tceph-mon-discovery.${NAMESPACE}.svc.cluster.local\""},{"line_number":28,"context_line":"    sh -c -e \"echo \u0027${HOSTS_LINE1}\\n${HOSTS_LINE2}\u0027 | tee -a ${ETC_HOSTS}\" \u003e /dev/null 2\u003e\u00261"},{"line_number":29,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_724acdae","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":37},"updated":"2018-11-02 13:23:59.000000000","message":"is this correct ? not ceph ?","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"13595a6873bcec002e3ffbb6c6ecc70aee174b0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"function cache_mon_endpoint () {"},{"line_number":25,"context_line":"  if [[ ${IP_ENDPOINT} !\u003d \"\" ]]; then"},{"line_number":26,"context_line":"    HOSTS_LINE1\u003d\"${IP_ENDPOINT}\\tceph-mon.${NAMESPACE}.svc.cluster.local\""},{"line_number":27,"context_line":"    HOSTS_LINE2\u003d\"${IP_ENDPOINT}\\tceph-mon-discovery.${NAMESPACE}.svc.cluster.local\""},{"line_number":28,"context_line":"    sh -c -e \"echo \u0027${HOSTS_LINE1}\\n${HOSTS_LINE2}\u0027 | tee -a ${ETC_HOSTS}\" \u003e /dev/null 2\u003e\u00261"},{"line_number":29,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_0d4ede38","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":37},"in_reply_to":"3f79a3b5_5259d159","updated":"2018-11-02 13:34:07.000000000","message":"ohh ok","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"a9fcd9b9bc02e8e75dcf788929a4afc80bf8fd2d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"function cache_mon_endpoint () {"},{"line_number":25,"context_line":"  if [[ ${IP_ENDPOINT} !\u003d \"\" ]]; then"},{"line_number":26,"context_line":"    HOSTS_LINE1\u003d\"${IP_ENDPOINT}\\tceph-mon.${NAMESPACE}.svc.cluster.local\""},{"line_number":27,"context_line":"    HOSTS_LINE2\u003d\"${IP_ENDPOINT}\\tceph-mon-discovery.${NAMESPACE}.svc.cluster.local\""},{"line_number":28,"context_line":"    sh -c -e \"echo \u0027${HOSTS_LINE1}\\n${HOSTS_LINE2}\u0027 | tee -a ${ETC_HOSTS}\" \u003e /dev/null 2\u003e\u00261"},{"line_number":29,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_5259d159","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":37},"in_reply_to":"3f79a3b5_724acdae","updated":"2018-11-02 13:29:06.000000000","message":"\\t it will add a tab space, so yes it\u0027s correct","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"f4a64918c0c5fdcf70583529dec179174f1a045d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ETC_HOSTS\u003d\"/etc/hosts\""},{"line_number":20,"context_line":"DNS_CHECK\u003d$1"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function check_mon_dns () {"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_13db26eb","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":22},"updated":"2018-11-06 05:45:50.000000000","message":"i don\u0027t think rewriting /etc/hosts is a good idea","commit_id":"30e708acb46e2daa0023bbace938feff4a47aa39"}],"ceph-client/templates/bin/utils/_checkDNS_helper.sh.tpl":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"16d0c9822f1b944177757596aa3f28fdaeefb2e4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"else"},{"line_number":34,"context_line":"  for POD in ${PODS}; do"},{"line_number":35,"context_line":"    kubectl exec -t ${POD} --namespace\u003d${NAMESPACE} -- \\"},{"line_number":36,"context_line":"    sh -c -e \"/tmp/utils-checkDNS.sh up\""},{"line_number":37,"context_line":"  done"},{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_ce853d55","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":39},"updated":"2018-11-02 14:24:35.000000000","message":"this script expects two arguments  right ? are we missing one  more here ?","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"51bd2c3a0fba97a301a675b034ff7d0a33297cab","unresolved":false,"context_lines":[{"line_number":33,"context_line":"else"},{"line_number":34,"context_line":"  for POD in ${PODS}; do"},{"line_number":35,"context_line":"    kubectl exec -t ${POD} --namespace\u003d${NAMESPACE} -- \\"},{"line_number":36,"context_line":"    sh -c -e \"/tmp/utils-checkDNS.sh up\""},{"line_number":37,"context_line":"  done"},{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_44558151","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":39},"in_reply_to":"3f79a3b5_b1df0066","updated":"2018-11-02 21:32:34.000000000","message":"JC is correct. Only two arguements are used when DNS is down.","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"},{"author":{"_account_id":29053,"name":"Jean-Charles Lopez","email":"jl970p@att.com","username":"vcppds7878"},"change_message_id":"804355855de5b36e5dc00b090dfeb68625d2cea9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"else"},{"line_number":34,"context_line":"  for POD in ${PODS}; do"},{"line_number":35,"context_line":"    kubectl exec -t ${POD} --namespace\u003d${NAMESPACE} -- \\"},{"line_number":36,"context_line":"    sh -c -e \"/tmp/utils-checkDNS.sh up\""},{"line_number":37,"context_line":"  done"},{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_b1df0066","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":39},"in_reply_to":"3f79a3b5_ce853d55","updated":"2018-11-02 14:56:42.000000000","message":"The additional parameter is not used when processing the \"up\" phase and the script will be immune to it being absent as I understand it.","commit_id":"4b0163916ec12486690c77a38a6359436c98ab67"}],"ceph-client/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4beab3cee488ab4bf71ac1fc273f0d0cbf9aad05","unresolved":false,"context_lines":[{"line_number":133,"context_line":"      tunables: null"},{"line_number":134,"context_line":"    target:"},{"line_number":135,"context_line":"      #NOTE(portdirect): arbitrarily we set the default number of expected OSD\u0027s to 5"},{"line_number":136,"context_line":"      # to match the number of nodes in the OSH gate (used only for helm tests)."},{"line_number":137,"context_line":"      osd: 5"},{"line_number":138,"context_line":"      pg_per_osd: 100"},{"line_number":139,"context_line":"      protected: true"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_bae649db","line":136,"range":{"start_line":136,"start_character":53,"end_line":136,"end_character":79},"updated":"2018-11-29 03:15:47.000000000","message":"has the pg calc logic changed?","commit_id":"d2914aabd9b9d3ee00083007d657f4bb4248e97e"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"679122a650680370fd081c15b45ecf3366860d0f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"      tunables: null"},{"line_number":134,"context_line":"    target:"},{"line_number":135,"context_line":"      #NOTE(portdirect): arbitrarily we set the default number of expected OSD\u0027s to 5"},{"line_number":136,"context_line":"      # to match the number of nodes in the OSH gate (used only for helm tests)."},{"line_number":137,"context_line":"      osd: 5"},{"line_number":138,"context_line":"      pg_per_osd: 100"},{"line_number":139,"context_line":"      protected: true"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_8a59b469","line":136,"range":{"start_line":136,"start_character":53,"end_line":136,"end_character":79},"in_reply_to":"3f79a3b5_bae649db","updated":"2018-11-29 15:09:20.000000000","message":"Yes in https://review.openstack.org/#/c/619817/","commit_id":"d2914aabd9b9d3ee00083007d657f4bb4248e97e"}]}