)]}'
{"kibana/templates/bin/_create_kibana_index_patterns.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"efe4fd042ff59e4214c197fb2cb5ef5f3eca42d7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":20,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/logstash-*\u0027 \\"},{"line_number":21,"context_line":"  -d \u0027{\"title\":\"logstash-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":22,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":23,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/horizon-*\u0027 \\"},{"line_number":24,"context_line":"  -d \u0027{\"title\":\"horizon-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":25,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":26,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/glance-*\u0027 \\"},{"line_number":27,"context_line":"  -d \u0027{\"title\":\"glance-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":28,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":29,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/nova-*\u0027 \\"},{"line_number":30,"context_line":"  -d \u0027{\"title\":\"nova-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":31,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":32,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/cinder-*\u0027 \\"},{"line_number":33,"context_line":"  -d \u0027{\"title\":\"cinder-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":34,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":35,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/heat-*\u0027 \\"},{"line_number":36,"context_line":"  -d \u0027{\"title\":\"heat-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":37,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":38,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/keystone-*\u0027 \\"},{"line_number":39,"context_line":"  -d \u0027{\"title\":\"keystone-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":40,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":41,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/auth-*\u0027 \\"},{"line_number":42,"context_line":"  -d \u0027{\"title\":\"auth-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":43,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":44,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/config/5.6.4\u0027 \\"},{"line_number":45,"context_line":"  -d \u0027{\"defaultIndex\" : \"logstash-*\"}\u0027"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f79a3b5_96b1212f","line":45,"range":{"start_line":19,"start_character":0,"end_line":45,"end_character":38},"updated":"2018-11-26 20:54:15.000000000","message":"We should handle this as a bootstrap job instead, similar to the openstack services (https://github.com/openstack/openstack-helm/blob/master/keystone/templates/bin/_bootstrap.sh.tpl). The reason being that we shouldn\u0027t assume these indexes will be the ones desired when we deploy the charts","commit_id":"168da7afac64a9229b2dcaf1aab7ca4ecec8858a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":15,"context_line":"limitations under the License."},{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":"{{- if .Values.conf.create_kibana_indexes.enabled }}"},{"line_number":19,"context_line":"{{- range .Values.conf.create_kibana_index.indexes }}"},{"line_number":20,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":21,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/{{ . }}-*\u0027 \\"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_ee3787db","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":52},"updated":"2018-12-19 17:19:05.000000000","message":"We can remove this conditional check, as simply checking this condition for the job template should be enough","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":"{{- if .Values.conf.create_kibana_indexes.enabled }}"},{"line_number":19,"context_line":"{{- range .Values.conf.create_kibana_index.indexes }}"},{"line_number":20,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":21,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/{{ . }}-*\u0027 \\"},{"line_number":22,"context_line":"  -d \u0027{\"title\":\"{{ . }}-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_2e349fa9","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":42},"updated":"2018-12-19 17:19:05.000000000","message":"This should be .Values.conf.create_kibana_indexes","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":"{{- if .Values.conf.create_kibana_indexes.enabled }}"},{"line_number":19,"context_line":"{{- range .Values.conf.create_kibana_index.indexes }}"},{"line_number":20,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":21,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/{{ . }}-*\u0027 \\"},{"line_number":22,"context_line":"  -d \u0027{\"title\":\"{{ . }}-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":23,"context_line":"{{- end}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_ae566ff9","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":66},"updated":"2018-12-19 17:19:05.000000000","message":"Instead of this, can we use a heredoc instead? This allows us to prevent the username and password being printed to the console.  For reference, see: https://github.com/openstack/openstack-helm-infra/blob/master/elasticsearch/templates/bin/_helm-tests.sh.tpl#L21\n\nWe also need to enclose the \"--user username:password\" combination in double quotes","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- if .Values.conf.create_kibana_indexes.enabled }}"},{"line_number":19,"context_line":"{{- range .Values.conf.create_kibana_index.indexes }}"},{"line_number":20,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":21,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/{{ . }}-*\u0027 \\"},{"line_number":22,"context_line":"  -d \u0027{\"title\":\"{{ . }}-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":23,"context_line":"{{- end}}"},{"line_number":24,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_6e7b777c","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":61},"updated":"2018-12-19 17:19:05.000000000","message":"We need to enclose this in double quotes instead of single quotes for proper bash variable expansion","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/index-pattern/{{ . }}-*\u0027 \\"},{"line_number":22,"context_line":"  -d \u0027{\"title\":\"{{ . }}-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":23,"context_line":"{{- end}}"},{"line_number":24,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":25,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/config/5.6.4\u0027 \\"},{"line_number":26,"context_line":"  -d \u0027{\"defaultIndex\" : \"{{ .Values.conf.create_kibana_index.default_index }}-*\"}\u0027"},{"line_number":27,"context_line":"{{- end}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_2e71ff99","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":66},"updated":"2018-12-19 17:19:05.000000000","message":"Same as above, wrt using a heredoc instead and double quoting","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  -d \u0027{\"title\":\"{{ . }}-*\",\"timeFieldName\":\"@timestamp\",\"notExpandable\":true}\u0027"},{"line_number":23,"context_line":"{{- end}}"},{"line_number":24,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":25,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/config/5.6.4\u0027 \\"},{"line_number":26,"context_line":"  -d \u0027{\"defaultIndex\" : \"{{ .Values.conf.create_kibana_index.default_index }}-*\"}\u0027"},{"line_number":27,"context_line":"{{- end}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_ce816b48","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":50},"updated":"2018-12-19 17:19:05.000000000","message":"Ditto with the double quotes. We\u0027ll also need to consider a way to determine the version to use, but we can handle that as a follow up change","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{- end}}"},{"line_number":24,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":25,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/config/5.6.4\u0027 \\"},{"line_number":26,"context_line":"  -d \u0027{\"defaultIndex\" : \"{{ .Values.conf.create_kibana_index.default_index }}-*\"}\u0027"},{"line_number":27,"context_line":"{{- end}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_6e57f7cd","line":26,"range":{"start_line":26,"start_character":28,"end_line":26,"end_character":60},"updated":"2018-12-19 17:19:05.000000000","message":"This should be .Values.conf.create_kibana_indexes","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":24,"context_line":"curl -XPOST -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} -H \u0027Content-Type: application/json\u0027 \\"},{"line_number":25,"context_line":"  \u0027${ELASTICSEARCH_ENDPOINT}/.kibana/config/5.6.4\u0027 \\"},{"line_number":26,"context_line":"  -d \u0027{\"defaultIndex\" : \"{{ .Values.conf.create_kibana_index.default_index }}-*\"}\u0027"},{"line_number":27,"context_line":"{{- end}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f79a3b5_0e3523d3","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":9},"updated":"2018-12-19 17:19:05.000000000","message":"This could be removed as well","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"}],"kibana/templates/job-index-patterns.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2bf7d031b81228829e5186c347611341a31dc387","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.register_dashboards }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"kibana-index-patterns\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_ecf2da9b","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":44},"updated":"2018-12-11 14:28:51.000000000","message":"This will need to be enabled in values.yaml, under the manifests: key. also, can we rename this to job_register_dashboards?","commit_id":"c804e577fccf0dcc9f9c985b9e6e059a4de0698f"}],"kibana/templates/job-register-dashboards.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_cd599190","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":4},"updated":"2018-12-18 14:37:19.000000000","message":"Can we rename this template to job-register-indexes instead?","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_register_dashboards }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"register_dashboards\" }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_ed5ecd76","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":48},"updated":"2018-12-18 14:37:19.000000000","message":"job_register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.job_register_dashboards }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"register_dashboards\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"register_dashboards\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: batch/v1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_0de789da","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":47},"updated":"2018-12-18 14:37:19.000000000","message":"needs to be \"register-indexes\" -- the name here can\u0027t contain underscores","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"register_dashboards\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"register_dashboards\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: batch/v1"},{"line_number":24,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_ad545556","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":37},"updated":"2018-12-18 14:37:19.000000000","message":"register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"apiVersion: batch/v1"},{"line_number":24,"context_line":"kind: Job"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: register_dashboards"},{"line_number":27,"context_line":"spec:"},{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_4d4d81c4","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":27},"updated":"2018-12-18 14:37:19.000000000","message":"register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    metadata:"},{"line_number":30,"context_line":"      labels:"},{"line_number":31,"context_line":"{{ tuple $envAll \"kibana\" \"register_dashboards\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":32,"context_line":"    spec:"},{"line_number":33,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":34,"context_line":"      restartPolicy: OnFailure"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_0d43099a","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":46},"updated":"2018-12-18 14:37:19.000000000","message":"register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      nodeSelector:"},{"line_number":36,"context_line":"        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}"},{"line_number":37,"context_line":"      initContainers:"},{"line_number":38,"context_line":"{{ tuple $envAll \"register_dashboards\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_dashboards"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_dashboards\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_2d40458a","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":37},"updated":"2018-12-18 14:37:19.000000000","message":"register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      initContainers:"},{"line_number":38,"context_line":"{{ tuple $envAll \"register_dashboards\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_dashboards"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_dashboards\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":42,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.register_dashboards | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":43,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_edc32d04","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":35},"updated":"2018-12-18 14:37:19.000000000","message":"indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{{ tuple $envAll \"register_dashboards\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_dashboards"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_dashboards\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":42,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.register_dashboards | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":43,"context_line":"          env:"},{"line_number":44,"context_line":"            - name: ELASTICSEARCH_USERNAME"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_8dc4f90d","line":41,"range":{"start_line":41,"start_character":27,"end_line":41,"end_character":37},"updated":"2018-12-18 14:37:19.000000000","message":"indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_dashboards"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_dashboards\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":42,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.register_dashboards | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":43,"context_line":"          env:"},{"line_number":44,"context_line":"            - name: ELASTICSEARCH_USERNAME"},{"line_number":45,"context_line":"              valueFrom:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_2dd5a5b5","line":42,"range":{"start_line":42,"start_character":60,"end_line":42,"end_character":70},"updated":"2018-12-18 14:37:19.000000000","message":"indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"}],"kibana/templates/job-register-indexes.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":23,"context_line":"apiVersion: batch/v1"},{"line_number":24,"context_line":"kind: Job"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: register_indexes"},{"line_number":27,"context_line":"spec:"},{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_0ed1a35a","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":24},"updated":"2018-12-19 17:19:05.000000000","message":"Let\u0027s change this to \"register-kibana-indexes\"","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      initContainers:"},{"line_number":38,"context_line":"{{ tuple $envAll \"register_indexes\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_indexes"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_indexes\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":42,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.register_indexes | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":43,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_6ec937ac","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":32},"updated":"2018-12-19 17:19:05.000000000","message":"Let\u0027s change this to \"register-kibana-indexes\" as well","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"}],"kibana/templates/job-register-kibana-indexes.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7793c9b8fed0b03e93568ce9f539faa296741e3d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"apiVersion: batch/v1"},{"line_number":24,"context_line":"kind: Job"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: register_kibana_indexes"},{"line_number":27,"context_line":"spec:"},{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f769fc5_427615db","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":31},"updated":"2018-12-26 14:01:04.000000000","message":"this will need to be changed to register-kibana-indexes, as underscores aren\u0027t allowed as the name here must be dns compliant","commit_id":"33f74bde83147c8a2e2f33363ce21f0e052f1b96"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7793c9b8fed0b03e93568ce9f539faa296741e3d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      initContainers:"},{"line_number":38,"context_line":"{{ tuple $envAll \"register_kibana_indexes\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":39,"context_line":"      containers:"},{"line_number":40,"context_line":"        - name: register_kibana_indexes"},{"line_number":41,"context_line":"{{ tuple $envAll \"register_kibana_indexes\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":42,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.register_kibana_indexes | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":43,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f769fc5_627311e9","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":39},"updated":"2018-12-26 14:01:04.000000000","message":"can we change this to register-kibana-indexes as well, to match the pod name?","commit_id":"33f74bde83147c8a2e2f33363ce21f0e052f1b96"}],"kibana/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c9a0afb8b83f339c327aa3dd1109998344c2a1d3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    kibana: docker.io/kibana:5.6.4"},{"line_number":27,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":28,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":29,"context_line":"    kibana_job_create_index_pattern: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":30,"context_line":"  pull_policy: IfNotPresent"},{"line_number":31,"context_line":"  local_registry:"},{"line_number":32,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_0c59d9fe","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":35},"updated":"2018-11-20 19:46:26.000000000","message":"Can we shorten this down to just \u0027kibana_index_patterns\u0027?","commit_id":"b2ff41b3f7813e93b892464ef9fbd3e6bf54a7ca"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    kibana: docker.io/kibana:5.6.4"},{"line_number":27,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":28,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":29,"context_line":"    register_dashboards: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":30,"context_line":"  pull_policy: IfNotPresent"},{"line_number":31,"context_line":"  local_registry:"},{"line_number":32,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_2d39253c","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":72},"updated":"2018-12-18 14:37:19.000000000","message":"This should use the LOCI equivalent, ie: https://github.com/openstack/openstack-helm-infra/blob/master/elasticsearch/values.yaml#L31","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    kibana: docker.io/kibana:5.6.4"},{"line_number":27,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":28,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":29,"context_line":"    register_dashboards: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":30,"context_line":"  pull_policy: IfNotPresent"},{"line_number":31,"context_line":"  local_registry:"},{"line_number":32,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_cde751ae","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":23},"updated":"2018-12-18 14:37:19.000000000","message":"register_indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - dep_check"},{"line_number":35,"context_line":"      - image_repo_sync"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"create_kibana_index:"},{"line_number":38,"context_line":"  enabled: true"},{"line_number":39,"context_line":"  indexes:"},{"line_number":40,"context_line":"    - logstash"},{"line_number":41,"context_line":"    - openstack"},{"line_number":42,"context_line":"  default_index: logstash"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"pod:"},{"line_number":45,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_4d36e152","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":25},"updated":"2018-12-18 14:37:19.000000000","message":"Can we move this under the conf: key?  We shouldnt need to create a new top level key.","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        limits:"},{"line_number":83,"context_line":"          memory: \"1024Mi\""},{"line_number":84,"context_line":"          cpu: \"2000m\""},{"line_number":85,"context_line":"      register_dashboards:"},{"line_number":86,"context_line":"        requests:"},{"line_number":87,"context_line":"          memory: \"128Mi\""},{"line_number":88,"context_line":"          cpu: \"100m\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_edec8d92","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":25},"updated":"2018-12-18 14:37:19.000000000","message":"indexes","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3360782d9439b8287f4019db69cba345527f1be7","unresolved":false,"context_lines":[{"line_number":338,"context_line":"  secret_ingress_tls: true"},{"line_number":339,"context_line":"  service: true"},{"line_number":340,"context_line":"  service_ingress: true"},{"line_number":341,"context_line":"  job_register_dashboards: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_cd70b112","line":341,"range":{"start_line":341,"start_character":2,"end_line":341,"end_character":25},"updated":"2018-12-18 14:37:19.000000000","message":"Can we change this to \"job_register_indexes\"? I think that\u0027s more descriptive of what\u0027s happening here","commit_id":"bf00f5d8c715a3f2ccf4ceeecc6ec46a87e1a99d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        services:"},{"line_number":101,"context_line":"          - endpoint: node"},{"line_number":102,"context_line":"            service: local_image_registry"},{"line_number":103,"context_line":"  static:"},{"line_number":104,"context_line":"    image_repo_sync:"},{"line_number":105,"context_line":"      services:"},{"line_number":106,"context_line":"        - endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_ceaf2bc6","line":103,"range":{"start_line":103,"start_character":2,"end_line":103,"end_character":8},"updated":"2018-12-19 17:19:05.000000000","message":"We should add an entry here for the new job for registering the indexes.  This would look like:\n    register_indexes:\n      services:\n        - endpoint: internal\n          service: kibana","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f8eb987587839159a16fd0afc8655766b9ffea95","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      - logstash"},{"line_number":235,"context_line":"      - openstack"},{"line_number":236,"context_line":"    default_index: logstash"},{"line_number":237,"context_line":"    "},{"line_number":238,"context_line":"endpoints:"},{"line_number":239,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":240,"context_line":"  local_image_registry:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_82d7c94d","line":237,"range":{"start_line":237,"start_character":0,"end_line":237,"end_character":4},"updated":"2018-12-19 17:19:05.000000000","message":"whitespace","commit_id":"8f3b0bc18d249bb697de0b19b8ed5c97d2e51db0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"ad252b0f550d7378fdbe9a458aa0417b0ce8ce25","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    indexes:"},{"line_number":238,"context_line":"      - logstash"},{"line_number":239,"context_line":"      - openstack"},{"line_number":240,"context_line":"    default_index: logstash"},{"line_number":241,"context_line":"endpoints:"},{"line_number":242,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":243,"context_line":"  local_image_registry:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f769fc5_35220854","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":27},"updated":"2019-01-02 14:56:32.000000000","message":"Can we also add a new line between this line and the \u0027endpoints:\u0027 top level key below it?","commit_id":"87c0839e95168435bf914f72087cadd679d89714"}]}