)]}'
{"ceph-rgw/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"37ba0ff5be3a43c543ecf6125c64f0322ee6d3eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function rgw_bucket_validation ()"},{"line_number":20,"context_line":"{"},{"line_number":21,"context_line":"  openstack service list"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  echo \"--\u003e creating container\""},{"line_number":24,"context_line":"  openstack container create \u0027mytestcontainer\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  echo \"--\u003e rgw bucket list\""},{"line_number":27,"context_line":"  radosgw-admin bucket list"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  all_buckets_stats\u003d$(radosgw-admin bucket stats --format json)"},{"line_number":30,"context_line":"  bucket_stat\u003d$(echo $all_buckets_stats | jq -c \u0027.[] | select(.bucket | contains(\"mytestcontainer\"))\u0027)"},{"line_number":31,"context_line":"  if [[ -z ${bucket_stat} ]]; then"},{"line_number":32,"context_line":"    echo \"--\u003e rgw bucket mytestcontainer not found\""},{"line_number":33,"context_line":"    exit 1"},{"line_number":34,"context_line":"  else"},{"line_number":35,"context_line":"    echo \"--\u003e rgw bucket mytestcontainer found\""},{"line_number":36,"context_line":"    exit 0"},{"line_number":37,"context_line":"  fi"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"rgw_bucket_validation"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3f79a3b5_ced72b4d","line":40,"range":{"start_line":19,"start_character":0,"end_line":40,"end_character":21},"updated":"2018-12-06 16:17:58.000000000","message":"this would only work if keystone auth enabled, we should also account for the case without.","commit_id":"8ea797179e2c3ac0ac6e5b0adf7a4b965fa491b1"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"958ebd610071d1fff5edb6294737b3e66c16ba16","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if [ $? -eq 0 ]; then"},{"line_number":48,"context_line":"    echo \"Bucket $bucket created\""},{"line_number":49,"context_line":"    echo \"Hello world!\" \u003e /tmp/hello.txt"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    s3cmd put /tmp/hello.txt $bucket --host\u003d$RGW_HOST --access_key\u003d$S3_ADMIN_ACCESS_KEY --secret_key\u003d$S3_ADMIN_SECRET_KEY --no-encrypt --no-check-certificate"},{"line_number":52,"context_line":"    if [ $? -ne 0 ]; then"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"3f79a3b5_061ded76","line":49,"updated":"2018-12-07 21:51:54.000000000","message":"It would be cleaner to use tee here instead of a redirect imho, but this is still passable.","commit_id":"c673033da94ce8d025f81a538346cfb5d9fc9dcb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6fed18823c9fbb7d15c99bf53b780bd9b8ded09f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  fi"},{"line_number":99,"context_line":"}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"if [ -z \"${RGW_HOST}\" ] \u0026\u0026 [ -z \"${S3_ADMIN_ACCESS_KEY}\" ] \u0026\u0026 [ -z \"${S3_ADMIN_SECRET_KEY}\" ];"},{"line_number":102,"context_line":"then"},{"line_number":103,"context_line":"  rgw_keystone_bucket_validation"},{"line_number":104,"context_line":"else"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"3f79a3b5_ac4adbaa","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":94},"updated":"2018-12-07 22:41:09.000000000","message":"this seems fragile, would it not be better to use https://github.com/openstack/openstack-helm-infra/blob/master/ceph-rgw/values.yaml#L277 to drive the selection here? also would we not want to test both s3 and swift based access in the case where we have keystone active?","commit_id":"c673033da94ce8d025f81a538346cfb5d9fc9dcb"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f0d92b886cd3d26f6148917dfba0caeaf0d11b67","unresolved":false,"context_lines":[{"line_number":15,"context_line":"See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":"set -ex"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"function rgw_replicas_validation()"},{"line_number":21,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_b7d662c1","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2018-12-11 20:40:32.000000000","message":"Just curious - why was this removed?","commit_id":"b591e0754a313e59321c0aea1c9b63c2234f82ea"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a642f214d529912f540b951249222a5f71a67801","unresolved":false,"context_lines":[{"line_number":15,"context_line":"See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":"set -ex"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"function rgw_replicas_validation()"},{"line_number":21,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_decf47b4","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"3f79a3b5_5a6e1534","updated":"2018-12-13 17:04:27.000000000","message":"we should put it back in really, at a minimum `set -e` should be present.","commit_id":"b591e0754a313e59321c0aea1c9b63c2234f82ea"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"4bedf0e1c35ff3cb924f466a427c67b926e7cb21","unresolved":false,"context_lines":[{"line_number":15,"context_line":"See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":"set -ex"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"function rgw_replicas_validation()"},{"line_number":21,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_5a6e1534","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"3f79a3b5_b7d662c1","updated":"2018-12-11 21:21:56.000000000","message":"`radosgw-admin bucket stats` produces large output. It was just hard to look at what happened in test. So i removed it.","commit_id":"b591e0754a313e59321c0aea1c9b63c2234f82ea"}]}