)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a767720ebff252ff169bd5c29e7a1e730811f9b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chris Wedgwood \u003ccw@f00f.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-21 19:15:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] [CEPH] Fix race conditions with OSD POD initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Under POD restart conditions there is a race condition with lsblk"},{"line_number":10,"context_line":"causing the helm chart to zap a fully working OSD disk. We refactor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_a4fd0007","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2018-12-21 20:09:42.000000000","message":"what else remains to be done?","commit_id":"a201e298769c8190bb0d59c76e2fd6c952050a02"}],"ceph-osd/templates/daemonset-osd.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ff9b5eb9fb99851b0610c48e21410bd6cc8af5a9","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        - name: pod-var-lib-ceph"},{"line_number":296,"context_line":"          emptyDir: {}"},{"line_number":297,"context_line":"        - name: pod-var-lib-ceph-tmp"},{"line_number":298,"context_line":"          hostPath:"},{"line_number":299,"context_line":"            path: /var/tmp"},{"line_number":300,"context_line":"            type: Directory"},{"line_number":301,"context_line":"        - name: pod-var-log"},{"line_number":302,"context_line":"          hostPath:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_d8182288","line":299,"range":{"start_line":298,"start_character":9,"end_line":299,"end_character":26},"updated":"2018-12-21 17:38:18.000000000","message":"should it be /vat/tmp on the host ... we have /var/lip/openstack-helm/ and similar elsewhere","commit_id":"b68af618863d1a85fed9ec2266076bd72d5f3558"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bd01376a5b703ae5d3ceb8f7f09ec285a15e7479","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        - name: pod-var-lib-ceph-tmp"},{"line_number":298,"context_line":"          hostPath:"},{"line_number":299,"context_line":"            path: /var/lib/openstack-helm/ceph/tmp"},{"line_number":300,"context_line":"            type: Directory"},{"line_number":301,"context_line":"        - name: pod-var-log"},{"line_number":302,"context_line":"          hostPath:"},{"line_number":303,"context_line":"            path: {{ print \"/var/log/ceph/\" $envAll.Release.Name }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_41441e17","line":300,"range":{"start_line":300,"start_character":0,"end_line":300,"end_character":27},"updated":"2018-12-21 19:15:29.000000000","message":"will fail is this isn\u0027t there","commit_id":"0743531032a5e8cf2aa1a4df41739fca64c2048a"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7ff23c768cb83fa73858c85cc557e14807d94538","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            - name: pod-var-lib-ceph"},{"line_number":80,"context_line":"              mountPath: /var/lib/ceph"},{"line_number":81,"context_line":"              readOnly: false"},{"line_number":82,"context_line":"            - name: pod-var-lib-ceph-tmp"},{"line_number":83,"context_line":"              mountPath: /var/lib/ceph/tmp"},{"line_number":84,"context_line":"              readOnly: false"},{"line_number":85,"context_line":"            - name: pod-run"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f769fc5_2b698424","line":82,"updated":"2018-12-24 15:13:07.000000000","message":"How are these used? I\u0027m missing the connection between these and the changes to the script.","commit_id":"30b57ba671ab7ce1d8f73c2689a49212fec7c68e"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"87f8eec1fbb9ff98f1b45dbb54b53b515754cd9e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            - name: pod-var-lib-ceph"},{"line_number":80,"context_line":"              mountPath: /var/lib/ceph"},{"line_number":81,"context_line":"              readOnly: false"},{"line_number":82,"context_line":"            - name: pod-var-lib-ceph-tmp"},{"line_number":83,"context_line":"              mountPath: /var/lib/ceph/tmp"},{"line_number":84,"context_line":"              readOnly: false"},{"line_number":85,"context_line":"            - name: pod-run"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f769fc5_eb4b8cad","line":82,"in_reply_to":"1f769fc5_2b698424","updated":"2018-12-24 15:15:37.000000000","message":"There are two race conditions being fixed in this PS. This specific change required for the second fix.\n\n\"Additonally the new automatic journal partitioning code has a race condition.. To resolve this we share a common tmp directory from the node to all of the OSD pods on that node. \"","commit_id":"30b57ba671ab7ce1d8f73c2689a49212fec7c68e"}]}