)]}'
{"id":"openstack%2Fopenstack-helm-infra~628314","triplet_id":"openstack%2Fopenstack-helm-infra~master~I5a52397185610e19ce5861ce3c3b3303006a296b","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"I5a52397185610e19ce5861ce3c3b3303006a296b","subject":"Parameterize hugepage pod cgroup","status":"MERGED","created":"2019-01-03 22:13:14.000000000","updated":"2019-01-05 09:17:11.000000000","submitted":"2019-01-05 09:17:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"628314-1546679831768-76a6aaaf","meta_rev_id":"10450be03f94b364155c3a985005c06cb96219c0","_number":628314,"virtual_id_number":628314,"owner":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-01-05 09:17:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-01-05 06:43:52.000000000","_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"recommended":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},{"value":1,"date":"2019-01-03 22:25:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2019-01-04 23:48:09.000000000","_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},{"value":2,"date":"2019-01-04 16:58:43.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"date":"2019-01-03 22:40:17.000000000","_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},{"value":1,"date":"2019-01-05 04:35:39.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-01-03 22:25:38.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-01-03 22:40:17.000000000","updated_by":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"reviewer":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"state":"REVIEWER"},{"updated":"2019-01-04 23:48:09.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2019-01-05 04:35:39.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-01-05 09:17:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"245c0f150ebafd5c147c6359fb48d9abba2dbc97","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2019-01-03 22:13:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82ed469cb353b85217b0963f35251a4348db6591","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-01-03 22:25:38.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9eb2b02bb9e01be6e25fed2e99d15a7ad3578c4a","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2019-01-03 22:39:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"66a87853f4222ea0aeebad9ba0409a1aecc3a144","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-01-03 22:55:52.000000000","message":"Patch Set 1:\n\nwhere is that at in the context of 1.12.x ?","accounts_in_message":[],"_revision_number":1},{"id":"6fd71f71e671167528a37baec79f164a830db50a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-03 23:44:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/14/628314/1/check/openstack-tox-docs/3ad89c5/html/ : SUCCESS in 3m 54s\n- openstack-helm-lint http://logs.openstack.org/14/628314/1/check/openstack-helm-lint/b1f3eda/ : SUCCESS in 1m 31s\n- openstack-helm-infra-five-ubuntu http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-five-ubuntu/7c10ac1/ : SUCCESS in 1h 21m 07s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-logging/ea3cbb7/ : SUCCESS in 37m 12s (non-voting)\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-monitoring/583ebd5/ : SUCCESS in 21m 21s (non-voting)\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-network-policy/db1ee5c/ : SUCCESS in 24m 36s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-openstack-support/cf852a8/ : SUCCESS in 25m 54s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-kubernetes-keystone-auth/43e531c/ : SUCCESS in 29m 14s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-airship-divingbell/5107980/ : SUCCESS in 18m 46s (non-voting)\n- openstack-helm-infra-tenant-ceph http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-tenant-ceph/e95dd84/ : SUCCESS in 51m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a42d82a27cd179ac166dd671fd29352474da5f8b","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-01-04 06:34:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"80a51d3b38d08e9a9309fb7fe7e23c63e080f3a8","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-01-04 16:58:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f236101d49f3f8bca299c9b3de22a1befbc1ce85","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2019-01-04 17:02:14.000000000","message":"Patch Set 1:\n\nI think we just need an answer: if we use an alternative cgroup root (e.g. kubelet --cgroup-root\u003d/kube_whitelist), are any of the settings we do/inject within libvirt.sh required for hugepages? If not, we should reduce it to validation checks only (can I use hugepages)","accounts_in_message":[],"_revision_number":1},{"id":"a52870b6b3826c541b5dbee993167514b6a7ca1b","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2019-01-04 23:48:09.000000000","message":"Patch Set 1: Code-Review+2\n\nI\u0027ve answered this myself - using an alternate cgroup root the adjustments are still required.","accounts_in_message":[],"_revision_number":1},{"id":"82c523540bba5ca84ea63844d23dc28db8c4fe53","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-01-05 04:35:39.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"74e08c79bee267db318729f1f85ea43bb067de39","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 04:35:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4f60501288f744eea5a74be626c728882e66ff21","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 05:45:39.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/14/628314/1/gate/openstack-tox-docs/bc8a9fa/html/ : SUCCESS in 3m 04s\n- openstack-helm-lint http://logs.openstack.org/14/628314/1/gate/openstack-helm-lint/ffb5e6f/ : SUCCESS in 1m 27s\n- openstack-helm-infra-five-ubuntu http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-five-ubuntu/36f3b2b/ : SUCCESS in 1h 04m 18s\n- openstack-helm-infra-openstack-support http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-openstack-support/4658550/ : FAILURE in 5m 24s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-kubernetes-keystone-auth/c1921d0/ : SUCCESS in 30m 56s","accounts_in_message":[],"_revision_number":1},{"id":"52afa3461d4d5ca32d5131214632eab0014c99b8","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2019-01-05 06:43:52.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"256ab262df52549bfe4a2a06cd5bc5ab7c8cbd33","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 08:05:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/14/628314/1/check/openstack-tox-docs/b33a68a/html/ : SUCCESS in 3m 30s\n- openstack-helm-lint http://logs.openstack.org/14/628314/1/check/openstack-helm-lint/b89f3d2/ : SUCCESS in 1m 39s\n- openstack-helm-infra-five-ubuntu http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-five-ubuntu/4b17105/ : SUCCESS in 1h 18m 14s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-logging/4eb598a/ : SUCCESS in 29m 55s (non-voting)\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-monitoring/fc61ffe/ : SUCCESS in 21m 00s (non-voting)\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-aio-network-policy/26e2c24/ : SUCCESS in 24m 28s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-openstack-support/074661f/ : SUCCESS in 25m 50s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-kubernetes-keystone-auth/5644408/ : SUCCESS in 32m 42s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-airship-divingbell/fbe64ce/ : SUCCESS in 18m 53s (non-voting)\n- openstack-helm-infra-tenant-ceph http://logs.openstack.org/14/628314/1/check/openstack-helm-infra-tenant-ceph/010b475/ : SUCCESS in 52m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"79693547fb1657c855df0552ee1be81f696bcc69","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 08:05:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"364120e4b8a7d0ceecab811b4b46e16b314f4103","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 09:17:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/14/628314/1/gate/openstack-tox-docs/471783f/html/ : SUCCESS in 3m 37s\n- openstack-helm-lint http://logs.openstack.org/14/628314/1/gate/openstack-helm-lint/202ae7a/ : SUCCESS in 1m 29s\n- openstack-helm-infra-five-ubuntu http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-five-ubuntu/d7888c3/ : SUCCESS in 1h 06m 03s\n- openstack-helm-infra-openstack-support http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-openstack-support/61d9064/ : SUCCESS in 22m 43s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/14/628314/1/gate/openstack-helm-infra-kubernetes-keystone-auth/057c4f5/ : SUCCESS in 29m 28s","accounts_in_message":[],"_revision_number":1},{"id":"10450be03f94b364155c3a985005c06cb96219c0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-05 09:17:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ff7985e391379336a9b9821307c267559ac12075","revisions":{"ff7985e391379336a9b9821307c267559ac12075":{"kind":"REWORK","_number":1,"created":"2019-01-03 22:13:14.000000000","uploader":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"ref":"refs/changes/14/628314/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/14/628314/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/628314/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/628314/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/628314/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/628314/1"}}},"commit":{"parents":[{"commit":"38199863980b865d13617374ae01e3b8efb064d2","subject":"Merge \"Fluent-logging: Add input and output for qemu logs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/38199863980b865d13617374ae01e3b8efb064d2"}]}],"author":{"name":"Anderson, Craig (ca846m)","email":"craig.anderson@att.com","date":"2019-01-03 22:12:30.000000000","tz":-480},"committer":{"name":"Anderson, Craig (ca846m)","email":"craig.anderson@att.com","date":"2019-01-03 22:13:13.000000000","tz":-480},"subject":"Parameterize hugepage pod cgroup","message":"Parameterize hugepage pod cgroup\n\nChange-Id: I5a52397185610e19ce5861ce3c3b3303006a296b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ff7985e391379336a9b9821307c267559ac12075"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ff7985e391379336a9b9821307c267559ac12075"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"38199863980b865d13617374ae01e3b8efb064d2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}