)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"75e3d0570ef4410fc146acb7186fb9c04c6b351d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohan Vennapureddy \u003cmohanvdevops@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-03 22:59:48 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding logging section to PostGRE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to create logging section in potgresql.conf"},{"line_number":10,"context_line":"followed by overriding it using values.yaml."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfd5e7cf_9e60ee34","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":33},"updated":"2019-01-07 18:52:27.000000000","message":"PostgreSQL","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"75e3d0570ef4410fc146acb7186fb9c04c6b351d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding logging section to PostGRE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to create logging section in potgresql.conf"},{"line_number":10,"context_line":"followed by overriding it using values.yaml."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I05a92203586879f51d4b9f84b43549a344467e2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfd5e7cf_3e554251","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":53},"updated":"2019-01-07 18:52:27.000000000","message":"check","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"}],"postgresql/templates/bin/_postgres.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"75e3d0570ef4410fc146acb7186fb9c04c6b351d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"dfd5e7cf_decbd61b","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":14},"updated":"2019-01-07 18:52:27.000000000","message":"what if we already have one of\n\n# log_statement ...\nlog_statement ...","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":29117,"name":"Mohan V","email":"mohanvdevops@gmail.com","username":"mohanvdevops"},"change_message_id":"d782db79d5af34b7c5fac050e089b2b19bc48e2f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"dfd5e7cf_6af9b27e","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":14},"in_reply_to":"dfd5e7cf_9c1236b1","updated":"2019-01-08 15:03:09.000000000","message":"Yes, the change is part of configuration file  and is being applied while container start up and the configuration is set with sed command.","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":29117,"name":"Mohan V","email":"mohanvdevops@gmail.com","username":"mohanvdevops"},"change_message_id":"d782db79d5af34b7c5fac050e089b2b19bc48e2f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"dfd5e7cf_cab69eda","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":14},"in_reply_to":"dfd5e7cf_decbd61b","updated":"2019-01-08 15:03:09.000000000","message":"The sed command is to just to enable the debug log by replacing #log_statement with log_statement\u003dAll.\nIf there is an already entry of  log_statement, it means there is already log enabled and sed command won\u0027t run.","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6d6580c40311b847bbcd24e138b450a3d4de3695","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"dfd5e7cf_9c1236b1","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":14},"in_reply_to":"dfd5e7cf_decbd61b","updated":"2019-01-07 20:11:29.000000000","message":"Why is this being handled via sed?  Is setting a value in the configuration file not sufficient?","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"96201560109772fa69a33b0fe421d39eb5b4dfb2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9fdfeff1_b256fa5b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2019-01-24 21:04:08.000000000","message":"You have changed nothing in the chart that would cause this file to ever be run.","commit_id":"23f6319e45130d2b05a109ec5595741c6c666991"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"96201560109772fa69a33b0fe421d39eb5b4dfb2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9fdfeff1_b277dad4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":3},"updated":"2019-01-24 21:04:08.000000000","message":"\"sed\" is not a good option for the long-term maintenance of the chart. It\u0027s fragile (may stop working if the upstream config file changes in the postgreql image) and hard to interpret for someone reading the chart. Instead, you should do one of two things:\n1. Create a template for the whole file, or\n2. update _start.sh.tpl with these options as command-line arguments. For example, postgres --help shows you that you can specify debugging level:\n  -d 1-5             debugging level","commit_id":"23f6319e45130d2b05a109ec5595741c6c666991"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"96201560109772fa69a33b0fe421d39eb5b4dfb2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sed -i  \"s/^#log_statement .*/log_statement \u003d \u0027all\u0027/g\"  $PGDATA/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9fdfeff1_9272d610","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":51},"updated":"2019-01-24 21:04:08.000000000","message":"This is a separate thing from setting the log level. Setting log_statement to \u0027all\u0027 will cause all SQL transactions to be logged, potentially creating high disk space and I/O utilization. You can expose this logging option as well, but you can\u0027t have it be the default.\n\n\"log_min_error_statement\" is a separate parameter (the one you want originally) that can be set to \"INFO\", \"ERROR\", etc. Please read https://www.postgresql.org/docs/9.5/runtime-config-logging.html","commit_id":"23f6319e45130d2b05a109ec5595741c6c666991"}],"postgresql/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6d6580c40311b847bbcd24e138b450a3d4de3695","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    max_connections: 100"},{"line_number":146,"context_line":"    shared_buffers: 128MB"},{"line_number":147,"context_line":"    logging:"},{"line_number":148,"context_line":"      log_level: \u0027DEBUG\u0027"},{"line_number":149,"context_line":"secrets:"},{"line_number":150,"context_line":"  postgresql:"},{"line_number":151,"context_line":"    admin: postgresql-admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd5e7cf_bc137ab8","line":148,"range":{"start_line":148,"start_character":18,"end_line":148,"end_character":23},"updated":"2019-01-07 20:11:29.000000000","message":"This should default to INFO, at least. DEBUG isn\u0027t a very sane default option here","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"75e3d0570ef4410fc146acb7186fb9c04c6b351d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    max_connections: 100"},{"line_number":146,"context_line":"    shared_buffers: 128MB"},{"line_number":147,"context_line":"    logging:"},{"line_number":148,"context_line":"      log_level: \u0027DEBUG\u0027"},{"line_number":149,"context_line":"secrets:"},{"line_number":150,"context_line":"  postgresql:"},{"line_number":151,"context_line":"    admin: postgresql-admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd5e7cf_9ed54ebc","line":148,"range":{"start_line":148,"start_character":6,"end_line":148,"end_character":24},"updated":"2019-01-07 18:52:27.000000000","message":"defined but not used","commit_id":"62eb4fb8088faa84898c8fb7268998d6be666c96"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"96201560109772fa69a33b0fe421d39eb5b4dfb2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  postgresql:"},{"line_number":145,"context_line":"    max_connections: 100"},{"line_number":146,"context_line":"    shared_buffers: 128MB"},{"line_number":147,"context_line":"    logging:"},{"line_number":148,"context_line":"      log_level: \u0027INFO\u0027"},{"line_number":149,"context_line":"secrets:"},{"line_number":150,"context_line":"  postgresql:"},{"line_number":151,"context_line":"    admin: postgresql-admin"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_b2983ac0","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":23},"updated":"2019-01-24 21:04:08.000000000","message":"What\u0027s the point of this if you never reference the variable set here?","commit_id":"23f6319e45130d2b05a109ec5595741c6c666991"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"b3ade773a1147a1382d68aa46e9c8520c2d2a590","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    max_connections: 100"},{"line_number":146,"context_line":"    shared_buffers: 128MB"},{"line_number":147,"context_line":"    logging:"},{"line_number":148,"context_line":"      log_level: \u0027INFO\u0027"},{"line_number":149,"context_line":"secrets:"},{"line_number":150,"context_line":"  postgresql:"},{"line_number":151,"context_line":"    admin: postgresql-admin"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_37c1852f","line":148,"range":{"start_line":148,"start_character":6,"end_line":148,"end_character":23},"updated":"2019-01-25 21:20:00.000000000","message":"Have you validated actually works? The documentation for \"-d\" says:\n-d 1-5             debugging level\nSo I would not expect \"INFO\" to work since the documentation says it expects a number from 1 to 5. Please investigate this postgres option and test it to ensure it works as you expect.","commit_id":"c473663cbd6e7c1229876d3430e827cc0698c813"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"57c1f44ff51899a4b3a522b249c381049663b7b6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  postgresql:"},{"line_number":145,"context_line":"    max_connections: 100"},{"line_number":146,"context_line":"    shared_buffers: 128MB"},{"line_number":147,"context_line":"    logging:"},{"line_number":148,"context_line":"      log_min_messages: debug2"},{"line_number":149,"context_line":"secrets:"},{"line_number":150,"context_line":"  postgresql:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_e3796393","line":147,"updated":"2019-02-05 15:42:53.000000000","message":"Is there any specific reason you have added the log_min_messages under logging section?","commit_id":"c1ecb74be36197d1d0a7cdd1f451af93fe9580fc"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"3ba5d9b62b6058ce5818ee91f243d3451f10a8f2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  postgresql:"},{"line_number":196,"context_line":"    max_connections: 100"},{"line_number":197,"context_line":"    shared_buffers: 128MB"},{"line_number":198,"context_line":"    log_min_messages: 2"},{"line_number":199,"context_line":"  backup:"},{"line_number":200,"context_line":"    enabled: true"},{"line_number":201,"context_line":"    base_path: /var/backup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_74d8317a","line":198,"updated":"2019-05-28 10:48:59.000000000","message":"can it be replaced by a verbose string mapped to the integer?","commit_id":"14504a4bd8b3d53efece7e16191305e43e51ea4e"},{"author":{"_account_id":22279,"name":"deepak","email":"dg443v@att.com","username":"deepak"},"change_message_id":"50cba167f50111ab020da7e7cd538061b11ffbcc","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  postgresql:"},{"line_number":196,"context_line":"    max_connections: 100"},{"line_number":197,"context_line":"    shared_buffers: 128MB"},{"line_number":198,"context_line":"    log_min_messages: 2"},{"line_number":199,"context_line":"  backup:"},{"line_number":200,"context_line":"    enabled: true"},{"line_number":201,"context_line":"    base_path: /var/backup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_74f6f165","line":198,"in_reply_to":"bfb3d3c7_74d8317a","updated":"2019-05-28 11:29:53.000000000","message":"replacing with verbose string is not possible as in postgres -d option takes values as integer.","commit_id":"14504a4bd8b3d53efece7e16191305e43e51ea4e"}],"tools/deployment/osh-infra-postgresql/130-postgresql.sh":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"1edb29d1ec8de62d937c84cf8a1b184670392846","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        --selector\u003d\"application\u003dpostgresql\" \\"},{"line_number":40,"context_line":"        --no-headers | awk \u0027{ print $1; exit }\u0027)"},{"line_number":41,"context_line":"    if [ $(kubectl logs ${POSTGRE_POD} -n osh-infra | sed -n \u00273p\u0027| tail -c 2) -eq ${LOG_LEVEL} ]; then"},{"line_number":42,"context_line":"        echo pass"},{"line_number":43,"context_line":"    else"},{"line_number":44,"context_line":"        echo failed"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dfbec78f_bee1b19d","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":19},"updated":"2019-05-13 17:31:04.000000000","message":"make this a little more verbose for someone who would see error messages in zuul gates. e.g.:\n\necho LOG_LEVEL test at log level \u0027${LOG_LEVEL}\u0027 passed\necho LOG_LEVEL test at log level \u0027${LOG_LEVEL}\u0027 failed","commit_id":"f54a001add9dcc3b8d72dbfa7008f5e3cf2aaeef"},{"author":{"_account_id":22279,"name":"deepak","email":"dg443v@att.com","username":"deepak"},"change_message_id":"e03ff65958f9b33af54941f6f4a244e8814f250f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        --selector\u003d\"application\u003dpostgresql\" \\"},{"line_number":40,"context_line":"        --no-headers | awk \u0027{ print $1; exit }\u0027)"},{"line_number":41,"context_line":"    if [ $(kubectl logs ${POSTGRE_POD} -n osh-infra | sed -n \u00273p\u0027| tail -c 2) -eq ${LOG_LEVEL} ]; then"},{"line_number":42,"context_line":"        echo pass"},{"line_number":43,"context_line":"    else"},{"line_number":44,"context_line":"        echo failed"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dfbec78f_63cf1456","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":19},"in_reply_to":"dfbec78f_bee1b19d","updated":"2019-05-14 10:15:32.000000000","message":"Done","commit_id":"f54a001add9dcc3b8d72dbfa7008f5e3cf2aaeef"}],"zuul.d/project.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"1edb29d1ec8de62d937c84cf8a1b184670392846","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        - openstack-helm-infra-aio-logging"},{"line_number":23,"context_line":"        - openstack-helm-infra-aio-monitoring"},{"line_number":24,"context_line":"        - openstack-helm-infra-postgresql:"},{"line_number":25,"context_line":"            voting: false"},{"line_number":26,"context_line":"        - openstack-helm-infra-aio-network-policy:"},{"line_number":27,"context_line":"            voting: false"},{"line_number":28,"context_line":"        - openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_3e8061bf","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":25},"updated":"2019-05-13 17:31:04.000000000","message":"I don\u0027t recommend making voting false unless you have reason to believe that this job is unstable","commit_id":"f54a001add9dcc3b8d72dbfa7008f5e3cf2aaeef"},{"author":{"_account_id":22279,"name":"deepak","email":"dg443v@att.com","username":"deepak"},"change_message_id":"e03ff65958f9b33af54941f6f4a244e8814f250f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        - openstack-helm-infra-aio-logging"},{"line_number":23,"context_line":"        - openstack-helm-infra-aio-monitoring"},{"line_number":24,"context_line":"        - openstack-helm-infra-postgresql:"},{"line_number":25,"context_line":"            voting: false"},{"line_number":26,"context_line":"        - openstack-helm-infra-aio-network-policy:"},{"line_number":27,"context_line":"            voting: false"},{"line_number":28,"context_line":"        - openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_8332485d","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":25},"in_reply_to":"dfbec78f_3e8061bf","updated":"2019-05-14 10:15:32.000000000","message":"changed to voting","commit_id":"f54a001add9dcc3b8d72dbfa7008f5e3cf2aaeef"}]}