)]}'
{"ceph-osd/templates/bin/osd/_block.sh.tpl":[{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"3101f6fbfb373ca5a0b02860dcc9ca97930d547a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        OSD_JOURNAL\u003d\"${OSD_JOURNAL_DISK}\""},{"line_number":82,"context_line":"      fi"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":"    if [ \"x${JOURNAL_TYPE}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":85,"context_line":"      OSD_JOURNAL\u003d\"${OSD_JOURNAL}/journal.${OSD_ID}\""},{"line_number":86,"context_line":"      touch ${OSD_JOURNAL}"},{"line_number":87,"context_line":"      wait_for_file \"${OSD_JOURNAL}\""},{"line_number":88,"context_line":"      chown ceph. \"${OSD_JOURNAL}\""},{"line_number":89,"context_line":"    else"},{"line_number":90,"context_line":"      if [ ! -b \"${OSD_JOURNAL}\" ]; then"},{"line_number":91,"context_line":"        echo \"ERROR: Unable to find journal device ${OSD_JOURNAL}\""},{"line_number":92,"context_line":"        exit 1"},{"line_number":93,"context_line":"      else"},{"line_number":94,"context_line":"        chown ceph. \"${OSD_JOURNAL}\""},{"line_number":95,"context_line":"      fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"  else"},{"line_number":98,"context_line":"    wait_for_file \"${OSD_JOURNAL}\""},{"line_number":99,"context_line":"    chown ceph. \"${OSD_JOURNAL}\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfdaf3ff_024fc1bd","line":96,"range":{"start_line":84,"start_character":0,"end_line":96,"end_character":6},"updated":"2019-01-11 19:44:38.000000000","message":"This will not work if OSD_BLUESTORE \u003d\u003d 1\n\nCan you move this to Line No: 72. ? This will make sure that if journal is set to directory, it will create the file and change ownership irrespective of OSD_BLUESTORE values","commit_id":"b2627d6bff77b4cb09982b431ead4f94554d43e0"},{"author":{"_account_id":29106,"name":"kranthi kiran guttikonda","email":"kranthi.guttikonda@att.com","username":"kranthikirang"},"change_message_id":"bda78b62301fa7976302479562ed6c5e0901068f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        OSD_JOURNAL\u003d\"${OSD_JOURNAL_DISK}\""},{"line_number":82,"context_line":"      fi"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":"    if [ \"x${JOURNAL_TYPE}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":85,"context_line":"      OSD_JOURNAL\u003d\"${OSD_JOURNAL}/journal.${OSD_ID}\""},{"line_number":86,"context_line":"      touch ${OSD_JOURNAL}"},{"line_number":87,"context_line":"      wait_for_file \"${OSD_JOURNAL}\""},{"line_number":88,"context_line":"      chown ceph. \"${OSD_JOURNAL}\""},{"line_number":89,"context_line":"    else"},{"line_number":90,"context_line":"      if [ ! -b \"${OSD_JOURNAL}\" ]; then"},{"line_number":91,"context_line":"        echo \"ERROR: Unable to find journal device ${OSD_JOURNAL}\""},{"line_number":92,"context_line":"        exit 1"},{"line_number":93,"context_line":"      else"},{"line_number":94,"context_line":"        chown ceph. \"${OSD_JOURNAL}\""},{"line_number":95,"context_line":"      fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"  else"},{"line_number":98,"context_line":"    wait_for_file \"${OSD_JOURNAL}\""},{"line_number":99,"context_line":"    chown ceph. \"${OSD_JOURNAL}\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfdaf3ff_5d660af0","line":96,"range":{"start_line":84,"start_character":0,"end_line":96,"end_character":6},"in_reply_to":"bfdaf3ff_024fc1bd","updated":"2019-01-11 20:04:57.000000000","message":"Simply moving to line 72 may not work without having JOURNAL file absolute path. OSD_JOURNAL\u003d\"${OSD_JOURNAL}/journal.${OSD_ID}\"\n\nPlease check now","commit_id":"b2627d6bff77b4cb09982b431ead4f94554d43e0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"1a386323dda4c54a9230e534a64833038b7b578d","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"if [ \"x${JOURNAL_TYPE}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":74,"context_line":"      OSD_JOURNAL\u003d\"${OSD_JOURNAL}/journal.${OSD_ID}\""},{"line_number":75,"context_line":"      touch ${OSD_JOURNAL}"},{"line_number":76,"context_line":"fi"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"if [ \"${OSD_BLUESTORE:-0}\" -ne 1 ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"bfdaf3ff_7d6c2e08","line":75,"updated":"2019-01-11 20:56:08.000000000","message":"can you also add \"chown ceph. \"${OSD_JOURNAL}\"\" to this block. it will be good if we handle ownership also at the time or creation itself","commit_id":"5e3590e9bc43c11dda6290ddecd92d6b8a6590ba"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"a7b9edc84204525ee1951a100c7950191d748f86","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# NOTE(supamatt): add or move the OSD\u0027s CRUSH location"},{"line_number":71,"context_line":"crush_location"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"if [ \"${OSD_BLUESTORE:-0}\" -ne 1 ]; then"},{"line_number":75,"context_line":"  if [ -n \"${OSD_JOURNAL}\" ]; then"},{"line_number":76,"context_line":"    if [ -b \"${OSD_JOURNAL}\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"bfdaf3ff_b3b725d9","line":73,"updated":"2019-01-11 23:06:05.000000000","message":"We can remove this, as it\u0027s just a blank line.","commit_id":"12ff10062491fd6c2283aabd9d02dfd25ad97a13"}]}