)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"07df2ac7842b064e5cc653643087a761539820e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jagan Kavva \u003cjk330k@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-17 16:51:59 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[679023] Pentest - NC1.0 K8S –Security HTTP Headers Not Present – TCP 6443"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The server should send an X-Content-Type-Options: nosniff to make sure"},{"line_number":10,"context_line":"the browser does not try to detect a different Content-Type than what is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_220a1326","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2019-01-20 23:03:30.000000000","message":"no need for tracking # to be in the git short log.","commit_id":"949c9e16698dac344b55221767acfe9cd0e5138b"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"b64a6e293a367d7250946beda40444ef75757657","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jagan Kavva \u003cjk330k@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-17 16:51:59 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[679023] Pentest - NC1.0 K8S –Security HTTP Headers Not Present – TCP 6443"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The server should send an X-Content-Type-Options: nosniff to make sure"},{"line_number":10,"context_line":"the browser does not try to detect a different Content-Type than what is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_6a38e8d2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"9fdfeff1_220a1326","updated":"2019-01-21 13:41:58.000000000","message":"Done","commit_id":"949c9e16698dac344b55221767acfe9cd0e5138b"}],"ingress/templates/ingress.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"07df2ac7842b064e5cc653643087a761539820e6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\"; |"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"},{"line_number":32,"context_line":"  name: {{ .Release.Namespace }}-{{ .Release.Name }}"},{"line_number":33,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_42139767","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":59},"updated":"2019-01-20 23:03:30.000000000","message":"is this extra?","commit_id":"949c9e16698dac344b55221767acfe9cd0e5138b"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"b64a6e293a367d7250946beda40444ef75757657","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\"; |"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"},{"line_number":32,"context_line":"  name: {{ .Release.Namespace }}-{{ .Release.Name }}"},{"line_number":33,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_ca4c7478","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":59},"in_reply_to":"9fdfeff1_42139767","updated":"2019-01-21 13:41:58.000000000","message":"Done","commit_id":"949c9e16698dac344b55221767acfe9cd0e5138b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7e940cc3a50040c726b0e5dc75e94e5677c916e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":25,"context_line":"kind: Ingress"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_0dbff6fb","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":35},"updated":"2019-01-21 14:40:08.000000000","message":"this duplicates line 32.","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"ace07c3a0527cfb98823d1aa6cc43f2c2855f75c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":25,"context_line":"kind: Ingress"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_d903ec0c","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":35},"in_reply_to":"9fdfeff1_0dbff6fb","updated":"2019-01-21 17:31:44.000000000","message":"Done","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7e940cc3a50040c726b0e5dc75e94e5677c916e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"kind: Ingress"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_ed3b9299","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":14},"updated":"2019-01-21 14:40:08.000000000","message":"duplicates line 33","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"ace07c3a0527cfb98823d1aa6cc43f2c2855f75c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"kind: Ingress"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_7908c027","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":14},"in_reply_to":"9fdfeff1_ed3b9299","updated":"2019-01-21 17:31:44.000000000","message":"Done","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7e940cc3a50040c726b0e5dc75e94e5677c916e1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"},{"line_number":32,"context_line":"  name: {{ .Release.Namespace }}-{{ .Release.Name }}"},{"line_number":33,"context_line":"  annotations:"},{"line_number":34,"context_line":"{{ toYaml .Values.network.ingress.annotations | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_6d47a21f","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":47},"updated":"2019-01-21 14:40:08.000000000","message":"this can be applied via the values.yaml, if the desire is for this to be the default. Or via over-rides supplied to the chart during deployment - either method would be preferable to the hardcoding here.","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"ace07c3a0527cfb98823d1aa6cc43f2c2855f75c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: nginx-configuration-snippet"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    nginx.ingress.kubernetes.io/configuration-snippet: |"},{"line_number":30,"context_line":"      more_set_headers \"X-Content-Type-Options: nosniff\";"},{"line_number":31,"context_line":"      more_set_headers \"X-Frame-Options: deny\";"},{"line_number":32,"context_line":"  name: {{ .Release.Namespace }}-{{ .Release.Name }}"},{"line_number":33,"context_line":"  annotations:"},{"line_number":34,"context_line":"{{ toYaml .Values.network.ingress.annotations | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_59385cd2","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":47},"in_reply_to":"9fdfeff1_6d47a21f","updated":"2019-01-21 17:31:44.000000000","message":"I agree with you. I moved this to values.yaml","commit_id":"de518ca37e53702bdfc701d1ef8ff7471feaebfc"}],"ingress/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"91a711b74990295d808fa53f19d669158fbdbf4e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      # .deployment.cluster.class"},{"line_number":112,"context_line":"      kubernetes.io/ingress.class: null"},{"line_number":113,"context_line":"      nginx.ingress.kubernetes.io/proxy-body-size: \"0\""},{"line_number":114,"context_line":"      nginx.ingress.kubernetes.io/X-Content-Type-Options: \"nosniff\""},{"line_number":115,"context_line":"      nginx.ingress.kubernetes.io/X-Frame-Options: \"deny\""},{"line_number":116,"context_line":"  external_policy_local: false"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_2fcf4a80","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":57},"updated":"2019-01-21 19:50:46.000000000","message":"should be:\n```\n    nginx.ingress.kubernetes.io/configuration-snippet: |\n      more_set_headers \"X-Content-Type-Options: nosniff\";\n      more_set_headers \"X-Frame-Options: deny\";\n```\n?","commit_id":"21e46d16547da106748aaa539c6f662f0ae04447"},{"author":{"_account_id":29298,"name":"Jagan Mohan Kavva","email":"jk330k@att.com","username":"jk330k"},"change_message_id":"361c73d615909582519940ebf59c097ddb6978fc","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      # .deployment.cluster.class"},{"line_number":112,"context_line":"      kubernetes.io/ingress.class: null"},{"line_number":113,"context_line":"      nginx.ingress.kubernetes.io/proxy-body-size: \"0\""},{"line_number":114,"context_line":"      nginx.ingress.kubernetes.io/X-Content-Type-Options: \"nosniff\""},{"line_number":115,"context_line":"      nginx.ingress.kubernetes.io/X-Frame-Options: \"deny\""},{"line_number":116,"context_line":"  external_policy_local: false"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_6b3b05d1","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":57},"in_reply_to":"9fdfeff1_2fcf4a80","updated":"2019-01-21 20:45:51.000000000","message":"Done","commit_id":"21e46d16547da106748aaa539c6f662f0ae04447"}]}