)]}'
{"tools/deployment/common/000-install-packages.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8d5336d62ab17e72f1b70aa033ef4689ca77cdfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fdfeff1_40d9ca7c","updated":"2019-01-28 16:53:36.000000000","message":"id be tempted to move these back - as this script deployed the packages required for osh, and the additional ones are required for k8s deployment - we should probably do a better job of communicating that though.","commit_id":"ee2d5a620cb32647ed4f13933d2f543c5474cbce"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"a30b1b9ee8b37ecabe5dd837347342f3f17d03a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fdfeff1_0603da74","in_reply_to":"9fdfeff1_40d9ca7c","updated":"2019-01-28 18:39:03.000000000","message":"\u003e id be tempted to move these back - as this script deployed the\n \u003e packages required for osh, and the additional ones are required for\n \u003e k8s deployment - we should probably do a better job of\n \u003e communicating that though.\n\nUnderstood; done.","commit_id":"ee2d5a620cb32647ed4f13933d2f543c5474cbce"}],"tools/deployment/common/005-deploy-k8s.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3a782d0e9336715be12531adb433324135bf2f4b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"helm repo add local http://localhost:8879/charts"},{"line_number":133,"context_line":"helm repo update"},{"line_number":134,"context_line":"uptime"},{"line_number":135,"context_line":"make"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# NOTE: Set required labels on host(s)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_5cf01768","side":"PARENT","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":4},"updated":"2019-01-23 22:47:21.000000000","message":"You need to add this back in, as the errors you\u0027re seeing are because helm-toolkit hasn\u0027t been packaged after this was removed.","commit_id":"cd4ec0b4b22f44673f66f42240a11131a6950ed9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"e734c6e5331f9fed0dc3a38330fa19254638b8f8","unresolved":false,"context_lines":[{"line_number":132,"context_line":"helm repo add local http://localhost:8879/charts"},{"line_number":133,"context_line":"helm repo update"},{"line_number":134,"context_line":"uptime"},{"line_number":135,"context_line":"make"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# NOTE: Set required labels on host(s)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_622e9644","side":"PARENT","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":4},"in_reply_to":"9fdfeff1_5cf01768","updated":"2019-01-24 01:03:47.000000000","message":"\u003e You need to add this back in, as the errors you\u0027re seeing are\n \u003e because helm-toolkit hasn\u0027t been packaged after this was removed.\n\nThanks for the look, Steve. Giving this a try.","commit_id":"cd4ec0b4b22f44673f66f42240a11131a6950ed9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"789ddcfa32ffda2c736b2e814f0d1b51166f79a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"install rbd /bin/true"},{"line_number":36,"context_line":"EOF"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Setup resolv.conf to use the k8s api server, which is required for the"},{"line_number":39,"context_line":"# kubelet to resolve cluster services."},{"line_number":40,"context_line":"sudo mv /etc/resolv.conf /etc/resolv.conf.backup"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo bash -c \"echo \u0027search svc.cluster.local cluster.local\u0027 \u003e /etc/resolv.conf\""},{"line_number":43,"context_line":"sudo bash -c \"echo \u0027nameserver 10.96.0.10\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE(drewwalters96): Use the Google DNS servers to prevent local addresses in"},{"line_number":46,"context_line":"# the resolv.conf file unless using a proxy, then use the existing DNS servers,"},{"line_number":47,"context_line":"# as custom DNS nameservers are commonly required when using a proxy server."},{"line_number":48,"context_line":"if [ -z \"${HTTP_PROXY}\" ]; then"},{"line_number":49,"context_line":"  sudo bash -c \"echo \u0027nameserver 8.8.8.8\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":50,"context_line":"  sudo bash -c \"echo \u0027nameserver 8.8.4.4\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":51,"context_line":"else"},{"line_number":52,"context_line":"  sed -ne \"s/nameserver //p\" /etc/resolv.conf.backup | while read -r ns; do"},{"line_number":53,"context_line":"    sudo bash -c \"echo \u0027nameserver ${ns}\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":54,"context_line":"  done"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"sudo bash -c \"echo \u0027options ndots:5 timeout:1 attempts:1\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":58,"context_line":"sudo rm /etc/resolv.conf.backup"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Install minikube and kubectl"},{"line_number":61,"context_line":"URL\u003d\"https://storage.googleapis.com\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9fdfeff1_60b64e41","line":58,"range":{"start_line":38,"start_character":0,"end_line":58,"end_character":31},"updated":"2019-01-28 16:51:54.000000000","message":"i\u0027d wrap these in a function - simply to help show the contained nature of this operation. Also - out of interest, why move these to the start?","commit_id":"ee2d5a620cb32647ed4f13933d2f543c5474cbce"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"a30b1b9ee8b37ecabe5dd837347342f3f17d03a4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"install rbd /bin/true"},{"line_number":36,"context_line":"EOF"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Setup resolv.conf to use the k8s api server, which is required for the"},{"line_number":39,"context_line":"# kubelet to resolve cluster services."},{"line_number":40,"context_line":"sudo mv /etc/resolv.conf /etc/resolv.conf.backup"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo bash -c \"echo \u0027search svc.cluster.local cluster.local\u0027 \u003e /etc/resolv.conf\""},{"line_number":43,"context_line":"sudo bash -c \"echo \u0027nameserver 10.96.0.10\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE(drewwalters96): Use the Google DNS servers to prevent local addresses in"},{"line_number":46,"context_line":"# the resolv.conf file unless using a proxy, then use the existing DNS servers,"},{"line_number":47,"context_line":"# as custom DNS nameservers are commonly required when using a proxy server."},{"line_number":48,"context_line":"if [ -z \"${HTTP_PROXY}\" ]; then"},{"line_number":49,"context_line":"  sudo bash -c \"echo \u0027nameserver 8.8.8.8\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":50,"context_line":"  sudo bash -c \"echo \u0027nameserver 8.8.4.4\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":51,"context_line":"else"},{"line_number":52,"context_line":"  sed -ne \"s/nameserver //p\" /etc/resolv.conf.backup | while read -r ns; do"},{"line_number":53,"context_line":"    sudo bash -c \"echo \u0027nameserver ${ns}\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":54,"context_line":"  done"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"sudo bash -c \"echo \u0027options ndots:5 timeout:1 attempts:1\u0027 \u003e\u003e /etc/resolv.conf\""},{"line_number":58,"context_line":"sudo rm /etc/resolv.conf.backup"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Install minikube and kubectl"},{"line_number":61,"context_line":"URL\u003d\"https://storage.googleapis.com\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9fdfeff1_e6fd766e","line":58,"range":{"start_line":38,"start_character":0,"end_line":58,"end_character":31},"in_reply_to":"9fdfeff1_60b64e41","updated":"2019-01-28 18:39:03.000000000","message":"\u003e i\u0027d wrap these in a function - simply to help show the contained\n \u003e nature of this operation. Also - out of interest, why move these to\n \u003e the start?\n\nDone. If a host has local addresses in resolv.conf, CoreDNS will crash. By moving them to the top, we replace local addresses with the Google nameservers before it causes issues during deployment.","commit_id":"ee2d5a620cb32647ed4f13933d2f543c5474cbce"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38518ca10f1b8ce99f061a5cbe18ae4c2013fa91","unresolved":false,"context_lines":[{"line_number":22,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive DEBCONF_NONINTERACTIVE_SEEN\u003dtrue"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE: Clean Up hosts file"},{"line_number":25,"context_line":"sudo sed -i \u0027/^127.0.0.1/c\\127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4\u0027 /etc/hosts"},{"line_number":26,"context_line":"sudo sed -i \u0027/^::1/c\\::1 localhost6 localhost6.localdomain6\u0027 /etc/hosts"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# NOTE: Install required packages on host"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_077505cb","side":"PARENT","line":25,"range":{"start_line":25,"start_character":79,"end_line":25,"end_character":80},"updated":"2019-01-29 15:57:24.000000000","message":"Is the removal of this space intentional? This doesn\u0027t look right to me","commit_id":"f0f1b57b3c4b4b821b5715dda034314aeba96ea9"}]}