)]}'
{"ceph-rgw/values.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8ad1fb1a63d43a14622c8be732a9e31329300285","unresolved":false,"context_lines":[{"line_number":121,"context_line":"network_policy:"},{"line_number":122,"context_line":"  ceph:"},{"line_number":123,"context_line":"    ingress:"},{"line_number":124,"context_line":"      - {}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"ceph_client:"},{"line_number":127,"context_line":"  configmap: ceph-etc"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fdfeff1_0dbd1f01","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":10},"updated":"2019-01-29 22:03:47.000000000","message":"Why is this an empty set?","commit_id":"a0d85415f8f12e5d290d69b2ab4028fff2fe6e75"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"11bbb57536055bd4df0e48f5788100bd0603cf4f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"network_policy:"},{"line_number":122,"context_line":"  ceph:"},{"line_number":123,"context_line":"    ingress:"},{"line_number":124,"context_line":"      - {}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"ceph_client:"},{"line_number":127,"context_line":"  configmap: ceph-etc"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fdfeff1_771b48c9","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":10},"in_reply_to":"9fdfeff1_0dbd1f01","updated":"2019-01-30 17:42:01.000000000","message":"this will allow all  by default and we are going to override this list on gate scripts","commit_id":"a0d85415f8f12e5d290d69b2ab4028fff2fe6e75"}],"tools/deployment/multinode/115-radosgw-osh-infra.sh":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8ad1fb1a63d43a14622c8be732a9e31329300285","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"}],"source_content_type":"text/x-sh","patch_set":12,"id":"9fdfeff1_4dc7a797","line":60,"range":{"start_line":48,"start_character":0,"end_line":60,"end_character":20},"updated":"2019-01-29 22:03:47.000000000","message":"Shouldn\u0027t this be in the values.yaml instead of empty brackets?","commit_id":"a0d85415f8f12e5d290d69b2ab4028fff2fe6e75"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"11bbb57536055bd4df0e48f5788100bd0603cf4f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"}],"source_content_type":"text/x-sh","patch_set":12,"id":"9fdfeff1_77702809","line":60,"range":{"start_line":48,"start_character":0,"end_line":60,"end_character":20},"in_reply_to":"9fdfeff1_4dc7a797","updated":"2019-01-30 17:42:01.000000000","message":"this to align with other netpol implementation for other services also user will override this depends on the needs.","commit_id":"a0d85415f8f12e5d290d69b2ab4028fff2fe6e75"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"3849a8e1133956d0a9da6f3afd004f0f8f83a7cf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"}],"source_content_type":"text/x-sh","patch_set":12,"id":"9fdfeff1_8058df55","line":60,"range":{"start_line":48,"start_character":0,"end_line":60,"end_character":20},"in_reply_to":"9fdfeff1_77702809","updated":"2019-01-31 03:49:10.000000000","message":"Ok, your explanation makes sense. I\u0027ll remove the -1.","commit_id":"a0d85415f8f12e5d290d69b2ab4028fff2fe6e75"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"b0f161e36e8da9aed14701e45690f28c0dbf2b9d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":64,"context_line":"  --set manifests.network_policy\u003dtrue \\"},{"line_number":65,"context_line":"  --values\u003d/tmp/radosgw-osh-infra.yaml"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9fdfeff1_7e954b86","line":64,"range":{"start_line":48,"start_character":0,"end_line":64,"end_character":39},"updated":"2019-01-31 16:36:28.000000000","message":"Ideally, we don\u0027t want to add this to the multinode check.  This should instead be included in the network-policy deployment we have for vetting these changes","commit_id":"cc3fba59c3987e7f270e847d09937b681db9db35"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"96b0aa660029780a8c77ddcb43a9608604de91fb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":64,"context_line":"  --set manifests.network_policy\u003dtrue \\"},{"line_number":65,"context_line":"  --values\u003d/tmp/radosgw-osh-infra.yaml"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9fdfeff1_fe3cdb93","line":64,"range":{"start_line":48,"start_character":0,"end_line":64,"end_character":39},"in_reply_to":"9fdfeff1_7e954b86","updated":"2019-01-31 16:42:09.000000000","message":"As mentioned, strike the above comment.  However, can you move the manifests.network_policy\u003dtrue override to the above values override file please","commit_id":"cc3fba59c3987e7f270e847d09937b681db9db35"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"c660eaa4f944f9e2bb657cce8aa92650b2f75574","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled: false"},{"line_number":46,"context_line":"  rgw_s3:"},{"line_number":47,"context_line":"    enabled: true"},{"line_number":48,"context_line":"network_policy:"},{"line_number":49,"context_line":"  ceph:"},{"line_number":50,"context_line":"    ingress:"},{"line_number":51,"context_line":"      - from:"},{"line_number":52,"context_line":"        - podSelector:"},{"line_number":53,"context_line":"            matchLabels:"},{"line_number":54,"context_line":"              application: elasticsearch"},{"line_number":55,"context_line":"        - podSelector:"},{"line_number":56,"context_line":"            matchLabels:"},{"line_number":57,"context_line":"              application: ceph"},{"line_number":58,"context_line":"        ports:"},{"line_number":59,"context_line":"        - protocol: TCP"},{"line_number":60,"context_line":"          port: 8088"},{"line_number":61,"context_line":"EOF"},{"line_number":62,"context_line":"helm upgrade --install radosgw-osh-infra ./ceph-rgw \\"},{"line_number":63,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":64,"context_line":"  --set manifests.network_policy\u003dtrue \\"},{"line_number":65,"context_line":"  --values\u003d/tmp/radosgw-osh-infra.yaml"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9fdfeff1_52539be2","line":64,"range":{"start_line":48,"start_character":0,"end_line":64,"end_character":39},"in_reply_to":"9fdfeff1_fe3cdb93","updated":"2019-01-31 17:29:48.000000000","message":"Done","commit_id":"cc3fba59c3987e7f270e847d09937b681db9db35"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"da2252aacac4f651a26fc020fc3acc902df511c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9fdfeff1_5e764772","line":74,"updated":"2019-01-31 16:42:44.000000000","message":"Do we have any good netpol test we can add here, either success or failure cases?","commit_id":"cc3fba59c3987e7f270e847d09937b681db9db35"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"27c8ec648e005c8f0dba82556bdc62f95c7a0e81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9fdfeff1_866c65ce","line":74,"in_reply_to":"9fdfeff1_5e764772","updated":"2019-01-31 20:38:24.000000000","message":"https://github.com/openstack/openstack-helm/blob/master/tools/deployment/common/test-networkpolicy.sh\n\nthis should do the job, but we need to enhance it","commit_id":"cc3fba59c3987e7f270e847d09937b681db9db35"}]}