)]}'
{"ceph-osd/templates/bin/osd/_block.sh.tpl":[{"author":{"_account_id":29106,"name":"kranthi kiran guttikonda","email":"kranthi.guttikonda@att.com","username":"kranthikirang"},"change_message_id":"792cc917079acce0fc2d75ebb2c9a015ee7d7258","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    -i 0 \\"},{"line_number":133,"context_line":"    --setuser ceph \\"},{"line_number":134,"context_line":"    --setgroup disk \\"},{"line_number":135,"context_line":"    --no-mon-config \\"},{"line_number":136,"context_line":"    --mkjournal"},{"line_number":137,"context_line":"fi"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"9fdfeff1_6957df59","line":135,"updated":"2019-02-15 00:16:37.000000000","message":"last time folks didn\u0027t agree with me on this","commit_id":"1a15f7b92d71e74d441541889617c08106a85a84"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"5af7499f43c60ac34b0d7a23de2e6dde58d4ad7f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    -i 0 \\"},{"line_number":133,"context_line":"    --setuser ceph \\"},{"line_number":134,"context_line":"    --setgroup disk \\"},{"line_number":135,"context_line":"    --no-mon-config \\"},{"line_number":136,"context_line":"    --mkjournal"},{"line_number":137,"context_line":"fi"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"9fdfeff1_a96aa7e9","line":135,"in_reply_to":"9fdfeff1_6957df59","updated":"2019-02-15 00:33:37.000000000","message":"It\u0027s needed. I do recall your commit though, however at the time I wasn\u0027t able to give input into it. By the time I was able too, it was abandonned.","commit_id":"1a15f7b92d71e74d441541889617c08106a85a84"}],"ceph-osd/templates/bin/osd/_common.sh.tpl":[{"author":{"_account_id":29106,"name":"kranthi kiran guttikonda","email":"kranthi.guttikonda@att.com","username":"kranthikirang"},"change_message_id":"2b81169ee2790769e0dc4ff8da3e1b75db2bd157","unresolved":false,"context_lines":[{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function disk_zap {"},{"line_number":152,"context_line":"  local device\u003d${1}"},{"line_number":153,"context_line":"  dmsetup remove_all"},{"line_number":154,"context_line":"  for device_part in $(pvscan | grep ${OSD_DEVICE} | cut -f4 -d\u0027 \u0027); do"},{"line_number":155,"context_line":"    # NOTE(supamatt): clean up the leftover lvm bits"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"9fdfeff1_9c634842","line":152,"updated":"2019-02-16 00:13:16.000000000","message":"Can we add a description to function here? So that it would be easy to understand while trying in different setups","commit_id":"0792dc4a44d793482c4f301dbd2c403aac463a1f"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"137d1bde4de066714fa27ccf91ce10b6da8439db","unresolved":false,"context_lines":[{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function disk_zap {"},{"line_number":152,"context_line":"  local device\u003d${1}"},{"line_number":153,"context_line":"  dmsetup remove_all"},{"line_number":154,"context_line":"  for device_part in $(pvscan | grep ${OSD_DEVICE} | cut -f4 -d\u0027 \u0027); do"},{"line_number":155,"context_line":"    # NOTE(supamatt): clean up the leftover lvm bits"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"9fdfeff1_7fb8d673","line":152,"in_reply_to":"9fdfeff1_9c634842","updated":"2019-02-16 02:09:45.000000000","message":"Done","commit_id":"0792dc4a44d793482c4f301dbd2c403aac463a1f"}],"ceph-osd/templates/bin/osd/_init.sh.tpl":[{"author":{"_account_id":29106,"name":"kranthi kiran guttikonda","email":"kranthi.guttikonda@att.com","username":"kranthikirang"},"change_message_id":"2b81169ee2790769e0dc4ff8da3e1b75db2bd157","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    CLI_OPTS\u003d\"${CLI_OPTS} --filestore\""},{"line_number":146,"context_line":"  else"},{"line_number":147,"context_line":"    OSD_JOURNAL\u003d\u0027\u0027"},{"line_number":148,"context_line":"    CLI_OPTS\u003d\"${CLI_OPTS} --bluestore\""},{"line_number":149,"context_line":"  fi"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  udev_settle"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"9fdfeff1_dc4c70c9","line":148,"updated":"2019-02-16 00:13:16.000000000","message":"We are not using bluestore at all as per my understanding. At least there is no values is being passed. Is this we are going to add in future?","commit_id":"0792dc4a44d793482c4f301dbd2c403aac463a1f"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"137d1bde4de066714fa27ccf91ce10b6da8439db","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    CLI_OPTS\u003d\"${CLI_OPTS} --filestore\""},{"line_number":146,"context_line":"  else"},{"line_number":147,"context_line":"    OSD_JOURNAL\u003d\u0027\u0027"},{"line_number":148,"context_line":"    CLI_OPTS\u003d\"${CLI_OPTS} --bluestore\""},{"line_number":149,"context_line":"  fi"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  udev_settle"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"9fdfeff1_bfc2bee7","line":148,"in_reply_to":"9fdfeff1_dc4c70c9","updated":"2019-02-16 02:09:45.000000000","message":"Not now, but perhaps someday.","commit_id":"0792dc4a44d793482c4f301dbd2c403aac463a1f"}],"ceph-osd/values.yaml":[{"author":{"_account_id":29106,"name":"kranthi kiran guttikonda","email":"kranthi.guttikonda@att.com","username":"kranthikirang"},"change_message_id":"792cc917079acce0fc2d75ebb2c9a015ee7d7258","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    # deployed across the cluster."},{"line_number":152,"context_line":"    # NOTE(supamatt): Using directory type storage is only supported if both the data and journal of an OSD"},{"line_number":153,"context_line":"    # are of the same type. Mixed heterogeneous (block-logical and directory) types are deprecated and will"},{"line_number":154,"context_line":"    # be removed in later releases."},{"line_number":155,"context_line":"    osd:"},{"line_number":156,"context_line":"      - data:"},{"line_number":157,"context_line":"          type: directory"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fdfeff1_e9c8af22","line":154,"updated":"2019-02-15 00:16:37.000000000","message":"One question; Why are we removing these for heterogeneous model?","commit_id":"1a15f7b92d71e74d441541889617c08106a85a84"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"5af7499f43c60ac34b0d7a23de2e6dde58d4ad7f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    # deployed across the cluster."},{"line_number":152,"context_line":"    # NOTE(supamatt): Using directory type storage is only supported if both the data and journal of an OSD"},{"line_number":153,"context_line":"    # are of the same type. Mixed heterogeneous (block-logical and directory) types are deprecated and will"},{"line_number":154,"context_line":"    # be removed in later releases."},{"line_number":155,"context_line":"    osd:"},{"line_number":156,"context_line":"      - data:"},{"line_number":157,"context_line":"          type: directory"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fdfeff1_4979bbc2","line":154,"in_reply_to":"9fdfeff1_e9c8af22","updated":"2019-02-15 00:33:37.000000000","message":"They are not supported with ceph-volume, it\u0027s only available with ceph-disk. ceph-disk is being removed in the next release, Nautilus.","commit_id":"1a15f7b92d71e74d441541889617c08106a85a84"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"51b5327c21f78f459c497a57f7b97b067a4ef462","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    # Bluestore support is nascent at best. Use at your own risk and only with non-production data!"},{"line_number":152,"context_line":"    # `filestore`: Enable the Filestore backend for OSDs"},{"line_number":153,"context_line":"    # `bluestore`: Enable the Bluestore backend for OSDs (currently only available for co-located OSDs)"},{"line_number":154,"context_line":"    backend: \"bluestore\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # NOTE(portdirect): for homogeneous clusters the `osd` key can be used to define OSD pods that will be"},{"line_number":157,"context_line":"    # deployed across the cluster."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"9fdfeff1_119708ee","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":23},"updated":"2019-03-04 18:19:21.000000000","message":"Shouldn\u0027t this be change to filestore as default?","commit_id":"633b9f731106a5d9094deaa116e82286a19f3c5a"}]}
