)]}'
{"ceph-rgw/templates/bin/rgw/_init.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6f129f304c4986ffd4362dbab63b0470cd6a6a3a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{{ $key }} \u003d {{ $value | quote  }}"},{"line_number":38,"context_line":"{{ end -}}"},{"line_number":39,"context_line":"{{- end -}}"},{"line_number":40,"context_line":"{{ else }}"},{"line_number":41,"context_line":"{{ range $key, $value :\u003d .Values.conf.rgw_s3.config -}}"},{"line_number":42,"context_line":"{{- if kindIs \"slice\" $value -}}"},{"line_number":43,"context_line":"{{ $key }} \u003d {{ include \"helm-toolkit.joinListWithComma\" $value | quote }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9fdfeff1_ef1c0115","line":40,"updated":"2019-02-04 11:56:25.000000000","message":"Are the options specified in .values.conf.rgw_s3.config mutually exclusive with enabling keystone auth on the swift API?","commit_id":"d60405bf70c93970eb3164bf83874c44bf4b78d4"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"70d2aeb22175a508d573635d796fa55359e63495","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{{ $key }} \u003d {{ $value | quote  }}"},{"line_number":38,"context_line":"{{ end -}}"},{"line_number":39,"context_line":"{{- end -}}"},{"line_number":40,"context_line":"{{ else }}"},{"line_number":41,"context_line":"{{ range $key, $value :\u003d .Values.conf.rgw_s3.config -}}"},{"line_number":42,"context_line":"{{- if kindIs \"slice\" $value -}}"},{"line_number":43,"context_line":"{{ $key }} \u003d {{ include \"helm-toolkit.joinListWithComma\" $value | quote }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9fdfeff1_9848195d","line":40,"in_reply_to":"9fdfeff1_b5e1682d","updated":"2019-02-04 14:50:44.000000000","message":"lets then consolidate down to a single place for common tunables - rather than having the same things specified twice in the values.yaml","commit_id":"d60405bf70c93970eb3164bf83874c44bf4b78d4"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"2b401794ad407fe628bdadcca92c9ef8f7732cf3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{{ $key }} \u003d {{ $value | quote  }}"},{"line_number":38,"context_line":"{{ end -}}"},{"line_number":39,"context_line":"{{- end -}}"},{"line_number":40,"context_line":"{{ else }}"},{"line_number":41,"context_line":"{{ range $key, $value :\u003d .Values.conf.rgw_s3.config -}}"},{"line_number":42,"context_line":"{{- if kindIs \"slice\" $value -}}"},{"line_number":43,"context_line":"{{ $key }} \u003d {{ include \"helm-toolkit.joinListWithComma\" $value | quote }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9fdfeff1_b5e1682d","line":40,"in_reply_to":"9fdfeff1_ef1c0115","updated":"2019-02-04 14:09:26.000000000","message":"The keystone config already has these same tunables, so they are mutually exclusive as duplicate configuration entries will bork the rgw client.","commit_id":"d60405bf70c93970eb3164bf83874c44bf4b78d4"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ca218c40aa8535d846fbb7da6ddbf4ffa14ec707","unresolved":false,"context_lines":[{"line_number":23,"context_line":"cat \u003e\u003e /etc/ceph/ceph.conf \u003c\u003cEOF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[client.rgw.$(hostname -s)]"},{"line_number":26,"context_line":"rgw_frontends \u003d \"beast port\u003d${RGW_FRONTEND_PORT}\""},{"line_number":27,"context_line":"{{ if .Values.conf.rgw_ks.enabled }}"},{"line_number":28,"context_line":"rgw_keystone_url \u003d \"${KEYSTONE_URL}\""},{"line_number":29,"context_line":"rgw_keystone_admin_user \u003d \"${OS_USERNAME}\""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fdfeff1_589951ce","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":49},"updated":"2019-02-04 14:52:31.000000000","message":"with this change - are we removing luminous support explicitly?","commit_id":"0c8cbf9b9980babda73f02839e89fa02f1524fc6"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"dee574e36719f6118b8a792c48d86b90dc7655f6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"cat \u003e\u003e /etc/ceph/ceph.conf \u003c\u003cEOF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[client.rgw.$(hostname -s)]"},{"line_number":26,"context_line":"rgw_frontends \u003d \"beast port\u003d${RGW_FRONTEND_PORT}\""},{"line_number":27,"context_line":"{{ if .Values.conf.rgw_ks.enabled }}"},{"line_number":28,"context_line":"rgw_keystone_url \u003d \"${KEYSTONE_URL}\""},{"line_number":29,"context_line":"rgw_keystone_admin_user \u003d \"${OS_USERNAME}\""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fdfeff1_03659ee1","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":49},"in_reply_to":"9fdfeff1_589951ce","updated":"2019-02-04 15:34:55.000000000","message":"Yes.. if you are deploying off this code then you are running Mimic already. We can keep it if you\u0027d like, but I don\u0027t know if it\u0027s worth the baggage.","commit_id":"0c8cbf9b9980babda73f02839e89fa02f1524fc6"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cc0915647f6ae8f036c2ca534248e7e6da3615a3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ $key }} \u003d {{ $value | quote  }}"},{"line_number":45,"context_line":"{{ end -}}"},{"line_number":46,"context_line":"{{- end -}}"},{"line_number":47,"context_line":"{{ else }}"},{"line_number":48,"context_line":"{{ range $key, $value :\u003d .Values.conf.rgw_s3.config -}}"},{"line_number":49,"context_line":"{{- if kindIs \"slice\" $value -}}"},{"line_number":50,"context_line":"{{ $key }} \u003d {{ include \"helm-toolkit.joinListWithComma\" $value | quote }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"9fdfeff1_cec49662","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":10},"updated":"2019-02-04 20:04:09.000000000","message":"not sure why these need to be exclusive?","commit_id":"80538867a227b8262153c23367def03a410b9249"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"dbf1db1708e5bf5f52f15bd7c428eb6311df053e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ $key }} \u003d {{ $value | quote  }}"},{"line_number":45,"context_line":"{{ end -}}"},{"line_number":46,"context_line":"{{- end -}}"},{"line_number":47,"context_line":"{{ else }}"},{"line_number":48,"context_line":"{{ range $key, $value :\u003d .Values.conf.rgw_s3.config -}}"},{"line_number":49,"context_line":"{{- if kindIs \"slice\" $value -}}"},{"line_number":50,"context_line":"{{ $key }} \u003d {{ include \"helm-toolkit.joinListWithComma\" $value | quote }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"9fdfeff1_aed8321e","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":10},"in_reply_to":"9fdfeff1_cec49662","updated":"2019-02-04 20:09:10.000000000","message":"Good eye.","commit_id":"80538867a227b8262153c23367def03a410b9249"}],"ceph-rgw/templates/bin/rgw/_start.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"790170741aade15cb7a9b3490b5be379ff5864d4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  chmod 0600 \"${RGW_KEYRING}\""},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"if [[ $(ceph -v | egrep -c \"luminous\" | xargs echo) -gt 0 ]]; then"},{"line_number":58,"context_line":"  RGW_FRONTENDS\u003d\"civitweb port\u003d${RGW_FRONTEND_PORT}\""},{"line_number":59,"context_line":"else"},{"line_number":60,"context_line":"  RGW_FRONTENDS\u003d\"beast port\u003d${RGW_FRONTEND_PORT}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9fdfeff1_efcac16c","line":57,"updated":"2019-02-04 12:01:02.000000000","message":"Where is the var set here consumed? If it\u0027s not, how do we specify the port that rgw is serving on?","commit_id":"d60405bf70c93970eb3164bf83874c44bf4b78d4"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"2b401794ad407fe628bdadcca92c9ef8f7732cf3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  chmod 0600 \"${RGW_KEYRING}\""},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"if [[ $(ceph -v | egrep -c \"luminous\" | xargs echo) -gt 0 ]]; then"},{"line_number":58,"context_line":"  RGW_FRONTENDS\u003d\"civitweb port\u003d${RGW_FRONTEND_PORT}\""},{"line_number":59,"context_line":"else"},{"line_number":60,"context_line":"  RGW_FRONTENDS\u003d\"beast port\u003d${RGW_FRONTEND_PORT}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9fdfeff1_35a818da","line":57,"in_reply_to":"9fdfeff1_efcac16c","updated":"2019-02-04 14:09:26.000000000","message":"Good catch, cleaning this up as well. They are specified in the ceph.conf of the rgw client (see _init.sh.tpl).","commit_id":"d60405bf70c93970eb3164bf83874c44bf4b78d4"}],"ceph-rgw/templates/pod-helm-tests.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b19c338f63e910f3b95634c3c3e5c40f893b5465","unresolved":false,"context_lines":[{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  restartPolicy: Never"},{"line_number":33,"context_line":"  serviceAccountName: {{ $serviceAccountName }}"},{"line_number":34,"context_line":"  initContainers:"},{"line_number":35,"context_line":"{{ tuple $envAll \"tests\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 4 }}"},{"line_number":36,"context_line":"    - name: ceph-keyring-placement"},{"line_number":37,"context_line":"{{ tuple $envAll \"ceph_config_helper\" | include \"helm-toolkit.snippets.image\" | indent 6 }}"},{"line_number":38,"context_line":"      securityContext:"},{"line_number":39,"context_line":"        runAsUser: 0"},{"line_number":40,"context_line":"      command:"},{"line_number":41,"context_line":"        - /tmp/ceph-admin-keyring.sh"},{"line_number":42,"context_line":"      volumeMounts:"},{"line_number":43,"context_line":"        - name: etcceph"},{"line_number":44,"context_line":"          mountPath: /etc/ceph"},{"line_number":45,"context_line":"        - name: ceph-rgw-bin"},{"line_number":46,"context_line":"          mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":47,"context_line":"          subPath: ceph-admin-keyring.sh"},{"line_number":48,"context_line":"          readOnly: true"},{"line_number":49,"context_line":"        - name: ceph-keyring"},{"line_number":50,"context_line":"          mountPath: /tmp/client-keyring"},{"line_number":51,"context_line":"          subPath: key"},{"line_number":52,"context_line":"          readOnly: true"},{"line_number":53,"context_line":"  containers:"},{"line_number":54,"context_line":"{{ if .Values.conf.rgw_ks.enabled }}"},{"line_number":55,"context_line":"    - name: ceph-rgw-ks-validation"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_de2f40a5","side":"PARENT","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":24},"updated":"2019-02-06 14:50:36.000000000","message":"we should not have removed this - sorry i did not catch it in review.","commit_id":"1c33bc8719207608b85ba2e8aa741ed6fe1d945e"}]}