)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"03d58da96431a5cedfb08811b6492cade9018d98","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Helm test should only executed when deploying chart with"},{"line_number":11,"context_line":"client_secrets: true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Not validating CephFS storageclass since testing would require"},{"line_number":14,"context_line":"kernal update and reboot of node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I33421249246dfaf6ea4f835e76a74813dfb3b595"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"9fb8cfa7_1ce58ea8","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":33},"updated":"2019-06-07 18:26:13.000000000","message":"This is actually being tested in the script now.","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"d0b5c2148688df7e1aea78ba4eb0fb2f7f9a0db6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Helm test should only executed when deploying chart with"},{"line_number":11,"context_line":"client_secrets: true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Not validating CephFS storageclass since testing would require"},{"line_number":14,"context_line":"kernal update and reboot of node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I33421249246dfaf6ea4f835e76a74813dfb3b595"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"9fb8cfa7_3c8e52d0","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":33},"in_reply_to":"9fb8cfa7_1ce58ea8","updated":"2019-06-07 18:28:55.000000000","message":"removed it now , thanks","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"}],"ceph-provisioners/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"58c32fa4ddc500066ee33349d99f47896829dedc","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function reset_test_env()"},{"line_number":22,"context_line":"{"},{"line_number":23,"context_line":"  echo \"--\u003e Resetting POD and PVC before/after test\""},{"line_number":24,"context_line":"  if kubectl get pod -n $rbd_storageclass_namespace $pod_name; then"},{"line_number":25,"context_line":"    kubectl delete pod -n $rbd_storageclass_namespace $pod_name"},{"line_number":26,"context_line":"  fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if kubectl get pvc -n $rbd_storageclass_namespace $pvc_name; then"},{"line_number":29,"context_line":"    kubectl delete pvc -n $rbd_storageclass_namespace $pvc_name;"},{"line_number":30,"context_line":"  fi"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function rbd_storageclass_validation()"},{"line_number":34,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_f96fb5c2","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":1},"updated":"2019-05-20 19:20:24.000000000","message":"perhaps put this as a trap to clean up regardless of what else the script does.","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"719206e40ef75f5797de7f0639ba09c2619ab17e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function reset_test_env()"},{"line_number":22,"context_line":"{"},{"line_number":23,"context_line":"  echo \"--\u003e Resetting POD and PVC before/after test\""},{"line_number":24,"context_line":"  if kubectl get pod -n $rbd_storageclass_namespace $pod_name; then"},{"line_number":25,"context_line":"    kubectl delete pod -n $rbd_storageclass_namespace $pod_name"},{"line_number":26,"context_line":"  fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if kubectl get pvc -n $rbd_storageclass_namespace $pvc_name; then"},{"line_number":29,"context_line":"    kubectl delete pvc -n $rbd_storageclass_namespace $pvc_name;"},{"line_number":30,"context_line":"  fi"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function rbd_storageclass_validation()"},{"line_number":34,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_6ab8c529","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":1},"in_reply_to":"bfb3d3c7_f96fb5c2","updated":"2019-05-20 21:55:35.000000000","message":"handled it in the down , please let me know for any other improvements on it .","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"58c32fa4ddc500066ee33349d99f47896829dedc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    exit 1"},{"line_number":41,"context_line":"  fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cat \u003c\u003cEOF | kubectl apply -n $rbd_storageclass_namespace -f -"},{"line_number":44,"context_line":"---"},{"line_number":45,"context_line":"kind: PersistentVolumeClaim"},{"line_number":46,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_b9693dbf","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":3},"updated":"2019-05-20 19:20:24.000000000","message":"tee would also show this to stdout, also would be good to indent (where possible) consistently.","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"719206e40ef75f5797de7f0639ba09c2619ab17e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    exit 1"},{"line_number":41,"context_line":"  fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cat \u003c\u003cEOF | kubectl apply -n $rbd_storageclass_namespace -f -"},{"line_number":44,"context_line":"---"},{"line_number":45,"context_line":"kind: PersistentVolumeClaim"},{"line_number":46,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_2a9badc9","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":3},"in_reply_to":"bfb3d3c7_b9693dbf","updated":"2019-05-20 21:55:35.000000000","message":"Done","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"58c32fa4ddc500066ee33349d99f47896829dedc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"spec:"},{"line_number":72,"context_line":"  containers:"},{"line_number":73,"context_line":"  - name: task-pv-storage"},{"line_number":74,"context_line":"    image: busybox"},{"line_number":75,"context_line":"    command:"},{"line_number":76,"context_line":"    - \"/bin/sh\""},{"line_number":77,"context_line":"    args:"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_9947994c","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":18},"updated":"2019-05-20 19:20:24.000000000","message":"this should be exposed via a param, also potentially used the same image as the test pod to save on pulls?","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"719206e40ef75f5797de7f0639ba09c2619ab17e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"spec:"},{"line_number":72,"context_line":"  containers:"},{"line_number":73,"context_line":"  - name: task-pv-storage"},{"line_number":74,"context_line":"    image: busybox"},{"line_number":75,"context_line":"    command:"},{"line_number":76,"context_line":"    - \"/bin/sh\""},{"line_number":77,"context_line":"    args:"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_4aa061f5","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":18},"in_reply_to":"bfb3d3c7_9947994c","updated":"2019-05-20 21:55:35.000000000","message":"Done","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"58c32fa4ddc500066ee33349d99f47896829dedc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"},{"line_number":100,"context_line":"then"},{"line_number":101,"context_line":"  echo \"--\u003e Checking RBD storage class.\""},{"line_number":102,"context_line":"  storageclass\u003d{{ .Values.storageclass.rbd.metadata.name }}"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_d93d11bc","line":99,"updated":"2019-05-20 19:20:24.000000000","message":"why not test all storageclasses supported by the chart?","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1f11c805d19e6784cdace315c117fa9b44b34909","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"},{"line_number":100,"context_line":"then"},{"line_number":101,"context_line":"  echo \"--\u003e Checking RBD storage class.\""},{"line_number":102,"context_line":"  storageclass\u003d{{ .Values.storageclass.rbd.metadata.name }}"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"9fb8cfa7_97772bd5","line":99,"in_reply_to":"bfb3d3c7_365b0855","updated":"2019-06-06 23:35:22.000000000","message":"is this still the case? I wrote that back in January 2018. We also have a role for this if required: https://github.com/openstack/openstack-helm-infra/blame/master/roles/upgrade-host/tasks/main.yaml","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"db169e0bb7850a0750928c75169e25c7941639f5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"},{"line_number":100,"context_line":"then"},{"line_number":101,"context_line":"  echo \"--\u003e Checking RBD storage class.\""},{"line_number":102,"context_line":"  storageclass\u003d{{ .Values.storageclass.rbd.metadata.name }}"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"9fb8cfa7_528e94d0","line":99,"in_reply_to":"bfb3d3c7_365b0855","updated":"2019-06-07 16:14:10.000000000","message":"sorry , got confused with my dev env where i have kernel 4.4, it seems we have required kernel versions every where and there wont be any issues to mount cephfs pvc.","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"a2f0ed8e31cabead298f22b135c39e63e8d89201","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"},{"line_number":100,"context_line":"then"},{"line_number":101,"context_line":"  echo \"--\u003e Checking RBD storage class.\""},{"line_number":102,"context_line":"  storageclass\u003d{{ .Values.storageclass.rbd.metadata.name }}"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_365b0855","line":99,"in_reply_to":"bfb3d3c7_caabf1d3","updated":"2019-05-21 15:12:18.000000000","message":"In order to test cephfs, you need HWE kernal\nhttps://docs.openstack.org/openstack-helm/latest/troubleshooting/ubuntu-hwe-kernel.html","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"719206e40ef75f5797de7f0639ba09c2619ab17e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"},{"line_number":100,"context_line":"then"},{"line_number":101,"context_line":"  echo \"--\u003e Checking RBD storage class.\""},{"line_number":102,"context_line":"  storageclass\u003d{{ .Values.storageclass.rbd.metadata.name }}"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"bfb3d3c7_caabf1d3","line":99,"in_reply_to":"bfb3d3c7_d93d11bc","updated":"2019-05-20 21:55:35.000000000","message":"sure , i will extend this to cephfs in a different ps","commit_id":"d4dc73452287bf1620d8a527cccbee17d3176d51"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_1fca1b1a","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":14},"updated":"2019-06-12 14:36:12.000000000","message":"2019","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_05808e45","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":14},"in_reply_to":"9fb8cfa7_1fca1b1a","updated":"2019-06-12 15:10:57.000000000","message":"Done","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"EOF"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  # waiting for pvc to get create"},{"line_number":60,"context_line":"  sleep 20"},{"line_number":61,"context_line":"  if ! kubectl get pvc -n $storageclass_namespace $pvc_name|grep Bound; then"},{"line_number":62,"context_line":"    echo \"Storageclass is available but can\u0027t create PersistentVolumeClaim.\""},{"line_number":63,"context_line":"    exit 1"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_022404ae","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":10},"updated":"2019-06-12 14:36:12.000000000","message":"Are we certain 20 seconds is enough to wait here?","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"EOF"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  # waiting for pvc to get create"},{"line_number":60,"context_line":"  sleep 20"},{"line_number":61,"context_line":"  if ! kubectl get pvc -n $storageclass_namespace $pvc_name|grep Bound; then"},{"line_number":62,"context_line":"    echo \"Storageclass is available but can\u0027t create PersistentVolumeClaim.\""},{"line_number":63,"context_line":"    exit 1"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_05f5eeec","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":10},"in_reply_to":"9fb8cfa7_022404ae","updated":"2019-06-12 15:10:57.000000000","message":"yes, in all  tests we performed .\nto be  safe  increasing to 30 sec.","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"spec:"},{"line_number":73,"context_line":"  containers:"},{"line_number":74,"context_line":"  - name: task-pv-storage"},{"line_number":75,"context_line":"    image: $pod_image"},{"line_number":76,"context_line":"    command:"},{"line_number":77,"context_line":"    - \"/bin/sh\""},{"line_number":78,"context_line":"    args:"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_02a7240d","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":21},"updated":"2019-06-12 14:36:12.000000000","message":"We should just consume this via values instead of an arbitrary variable","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"spec:"},{"line_number":73,"context_line":"  containers:"},{"line_number":74,"context_line":"  - name: task-pv-storage"},{"line_number":75,"context_line":"    image: $pod_image"},{"line_number":76,"context_line":"    command:"},{"line_number":77,"context_line":"    - \"/bin/sh\""},{"line_number":78,"context_line":"    args:"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_65e5ca37","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":21},"in_reply_to":"9fb8cfa7_02a7240d","updated":"2019-06-12 15:10:57.000000000","message":"doing the same in down .","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":100,"context_line":"pvc_name\u003dceph-prov-test-pvc"},{"line_number":101,"context_line":"pod_name\u003dcephprov-test-pod"},{"line_number":102,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_e2ca109f","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":27},"updated":"2019-06-12 14:36:12.000000000","message":"Why not scope this under the rbd conditional below, like you did with cephfs?  Alternatively, it may be cleaner to just handle this via args to the function your calling to test this","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":100,"context_line":"pvc_name\u003dceph-prov-test-pvc"},{"line_number":101,"context_line":"pod_name\u003dcephprov-test-pod"},{"line_number":102,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_e53f7a84","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":27},"in_reply_to":"9fb8cfa7_e2ca109f","updated":"2019-06-12 15:10:57.000000000","message":"trying to  clean the test env  if there are any resources leftover from previous  tests.","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":100,"context_line":"pvc_name\u003dceph-prov-test-pvc"},{"line_number":101,"context_line":"pod_name\u003dcephprov-test-pod"},{"line_number":102,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"reset_test_env"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_02f5e4ec","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":26},"updated":"2019-06-12 14:36:12.000000000","message":"Why not just make this static?","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a8e233de8b3c16c981662c18925e78a474ac3136","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":100,"context_line":"pvc_name\u003dceph-prov-test-pvc"},{"line_number":101,"context_line":"pod_name\u003dcephprov-test-pod"},{"line_number":102,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"reset_test_env"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_ff6e27fe","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":26},"updated":"2019-06-12 14:15:02.000000000","message":"this should be parameterised.","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":100,"context_line":"pvc_name\u003dceph-prov-test-pvc"},{"line_number":101,"context_line":"pod_name\u003dcephprov-test-pod"},{"line_number":102,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"reset_test_env"}],"source_content_type":"text/x-smarty","patch_set":57,"id":"9fb8cfa7_253a7298","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":26},"in_reply_to":"9fb8cfa7_ff6e27fe","updated":"2019-06-12 15:10:57.000000000","message":"Done","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4e6b82e6a4258d0ccd4fc1fbd04618ec1c86178c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"spec:"},{"line_number":81,"context_line":"  containers:"},{"line_number":82,"context_line":"  - name: task-pv-storage"},{"line_number":83,"context_line":"    image: $pod_image"},{"line_number":84,"context_line":"    command:"},{"line_number":85,"context_line":"    - \"/bin/sh\""},{"line_number":86,"context_line":"    args:"}],"source_content_type":"text/x-smarty","patch_set":61,"id":"9fb8cfa7_a52ae2d7","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":21},"updated":"2019-06-12 15:24:52.000000000","message":"Can we just set this via values directly instead of through a variable?  This allows us to remove the pod_image variable assignment below and remove the args from the function calls","commit_id":"877fb898e4903a3e6d91dc232fdf13f3b9a16817"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4e6b82e6a4258d0ccd4fc1fbd04618ec1c86178c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"storageclass_namespace\u003d$CEPH_DEPLOYMENT_NAMESPACE"},{"line_number":108,"context_line":"pvc_name\u003d{{ .Values.pod.test_pod.pvc_name }}"},{"line_number":109,"context_line":"pod_name\u003d{{ .Values.pod.test_pod.name }}"},{"line_number":110,"context_line":"pod_image\u003d{{ .Values.images.tags.ceph_config_helper }}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"reset_test_env $storageclass_namespace $pod_name $pvc_name"}],"source_content_type":"text/x-smarty","patch_set":61,"id":"9fb8cfa7_c525960a","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":40},"updated":"2019-06-12 15:24:52.000000000","message":"Instead of handling these via values, could we pass these in directly as args to the functions below?  ie: \n\nstorageclass_validation $storageclass_namespace rbd-provisioner-test rbd-test-pvc\n\nand\n\nreset_test_env $storageclass_namespace rbd-provisioner-test rbd-test-pvc\nthen the same for cephfs?","commit_id":"877fb898e4903a3e6d91dc232fdf13f3b9a16817"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"bae75b64b27869e60ac8fa5d547f93d335003f8f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"reset_test_env $PVC_NAMESPACE \"rbd-prov-test-pod\" \"rbd-prov-test-pvc\""},{"line_number":108,"context_line":"reset_test_env $PVC_NAMESPACE \"cephfs-prov-test-pod\" \"cephfs-prov-test-pvc\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"}],"source_content_type":"text/x-smarty","patch_set":65,"id":"9fb8cfa7_1310d4a7","line":107,"range":{"start_line":107,"start_character":30,"end_line":107,"end_character":69},"updated":"2019-06-12 16:55:53.000000000","message":"please make these adjustable - at a minimum to expose via review of the values.yaml the objects that this test drives - as it stands right now there is a small chance of cleaning up resources not managed via this chart.","commit_id":"be3c2192d8ed59dea9867c6ee8d074e42fbc01dd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"7e6717068c32e2a08d708738afb9f92c9c605839","unresolved":false,"context_lines":[{"line_number":104,"context_line":"}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"reset_test_env $PVC_NAMESPACE \"rbd-prov-test-pod\" \"rbd-prov-test-pvc\""},{"line_number":108,"context_line":"reset_test_env $PVC_NAMESPACE \"cephfs-prov-test-pod\" \"cephfs-prov-test-pvc\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"if [ {{ .Values.storageclass.rbd.provision_storage_class }} \u003d\u003d true ];"}],"source_content_type":"text/x-smarty","patch_set":65,"id":"9fb8cfa7_2ef32f76","line":107,"range":{"start_line":107,"start_character":30,"end_line":107,"end_character":69},"in_reply_to":"9fb8cfa7_1310d4a7","updated":"2019-06-12 17:46:55.000000000","message":"Sure, fixed it .","commit_id":"be3c2192d8ed59dea9867c6ee8d074e42fbc01dd"}],"ceph-provisioners/templates/pod-helm-tests.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_e23f7084","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2019-06-12 14:36:12.000000000","message":"2019","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_0543ae14","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"in_reply_to":"9fb8cfa7_e23f7084","updated":"2019-06-12 15:10:57.000000000","message":"Done","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"apiVersion: v1"},{"line_number":63,"context_line":"kind: Pod"},{"line_number":64,"context_line":"metadata:"},{"line_number":65,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":66,"context_line":"  labels:"},{"line_number":67,"context_line":"{{ tuple $envAll \"ceph\" \"provisioner-test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":68,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_a276586f","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":33},"updated":"2019-06-12 14:36:12.000000000","message":"Can we be consistent and use the same name we do for the other helm test pods?  ie: https://github.com/openstack/openstack-helm-infra/blob/master/prometheus/templates/pod-helm-tests.yaml#L27\n\nI know this results in the same name here, but it\u0027d be nice to maintain consistency across all charts where possible","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"apiVersion: v1"},{"line_number":63,"context_line":"kind: Pod"},{"line_number":64,"context_line":"metadata:"},{"line_number":65,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":66,"context_line":"  labels:"},{"line_number":67,"context_line":"{{ tuple $envAll \"ceph\" \"provisioner-test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":68,"context_line":"  annotations:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_a54d023f","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":33},"in_reply_to":"9fb8cfa7_a276586f","updated":"2019-06-12 15:10:57.000000000","message":"agree, done","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df3d7f2abe1b741eb2056665cbd547927f29be5c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  initContainers:"},{"line_number":75,"context_line":"{{ tuple $envAll \"tests\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 4 }}"},{"line_number":76,"context_line":"  containers:"},{"line_number":77,"context_line":"    - name: ceph-cluster-helm-test"},{"line_number":78,"context_line":"{{ tuple $envAll \"ceph_config_helper\" | include \"helm-toolkit.snippets.image\" | indent 6 }}"},{"line_number":79,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.tests | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 6 }}"},{"line_number":80,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"test\" \"container\" \"test\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 6 }}"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_c2f6ecd7","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":34},"updated":"2019-06-12 14:36:12.000000000","message":"This should be named to reflect what behavior is being tested -- I think this should be ceph-provisioner-helm-test","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a2594c9987a1177a77b51d2da05866bfe903071a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  initContainers:"},{"line_number":75,"context_line":"{{ tuple $envAll \"tests\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 4 }}"},{"line_number":76,"context_line":"  containers:"},{"line_number":77,"context_line":"    - name: ceph-cluster-helm-test"},{"line_number":78,"context_line":"{{ tuple $envAll \"ceph_config_helper\" | include \"helm-toolkit.snippets.image\" | indent 6 }}"},{"line_number":79,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.tests | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 6 }}"},{"line_number":80,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"test\" \"container\" \"test\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 6 }}"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fb8cfa7_65538ae3","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":34},"in_reply_to":"9fb8cfa7_c2f6ecd7","updated":"2019-06-12 15:10:57.000000000","message":"agree, done .","commit_id":"db1fe6a4f992ab7675c6b43437ff862444e09c60"}],"ceph-provisioners/values.yaml":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5e37c1a0b4bc3bb554b0b782405d4802fd2fcacf","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  configmap_bin: true"},{"line_number":225,"context_line":"  configmap_bin_common: true"},{"line_number":226,"context_line":"  configmap_etc: true"},{"line_number":227,"context_line":"  configmap_test_bin: true"},{"line_number":228,"context_line":"  deployment_rbd_provisioner: true"},{"line_number":229,"context_line":"  deployment_cephfs_provisioner: true"},{"line_number":230,"context_line":"  job_bootstrap: false"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5fc1f717_0625b908","line":227,"range":{"start_line":227,"start_character":21,"end_line":227,"end_character":22},"updated":"2019-03-18 18:40:24.000000000","message":"we are not creating new configmap here right ? is this required ?","commit_id":"093af66a7dcc1eb40f28bc03010e66ba1d5531ce"}],"tools/deployment/osh-infra-logging/020-ceph.sh":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5e37c1a0b4bc3bb554b0b782405d4802fd2fcacf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  ceph: true"},{"line_number":61,"context_line":"  rbd_provisioner: true"},{"line_number":62,"context_line":"  cephfs_provisioner: true"},{"line_number":63,"context_line":"  client_secrets: true"},{"line_number":64,"context_line":"  rgw_keystone_user_and_endpoints: false"},{"line_number":65,"context_line":"bootstrap:"},{"line_number":66,"context_line":"  enabled: true"}],"source_content_type":"text/x-sh","patch_set":14,"id":"5fc1f717_e640ada7","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":22},"updated":"2019-03-18 18:40:24.000000000","message":"why is this required in ceph namespace ?","commit_id":"093af66a7dcc1eb40f28bc03010e66ba1d5531ce"}]}