)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"44eb4fbf00c7a749eb68d8ed23f025d62eaa38a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hemanth Nakkina \u003cnh863p@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-04 10:29:16 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add annotations to podsecuritpolicy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provide support to add annotations to the podsecuritypolicy. This will"},{"line_number":10,"context_line":"allow to add annotations related to seccomp and apparmor in psp."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_86016909","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":35},"updated":"2019-03-05 15:23:07.000000000","message":"podsecuritypolicy ?","commit_id":"b50405903536fdb94d91efcd854b6af9c3d5a42c"}],"podsecuritypolicy/templates/podsecuritypolicy.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3d85336391f6db043dcb707907871fca3fb1aa68","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  name: {{ $pspName }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"podsecuritypolicy\" \"policy\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"  annotations:"},{"line_number":30,"context_line":"{{- if $pspDetails.annotations }}"},{"line_number":31,"context_line":"{{ toYaml $pspDetails.annotations | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_e759395a","line":29,"updated":"2019-03-08 13:30:07.000000000","message":"shouldnt this line come after the conditional?","commit_id":"b5dd3430737b0ec918fd1bc4a056d763853d92e1"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"ac9d28988b98f23b03a1fb1ade2e8d953fd9be4c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  name: {{ $pspName }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"podsecuritypolicy\" \"policy\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"  annotations:"},{"line_number":30,"context_line":"{{- if $pspDetails.annotations }}"},{"line_number":31,"context_line":"{{ toYaml $pspDetails.annotations | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_bd9582e6","line":29,"in_reply_to":"5fc1f717_7d22baa6","updated":"2019-03-08 15:05:59.000000000","message":"I will consider it as a Best practice and updating in PS10. (Having said that I have seen similar coding practice in stable helm chart repo.)","commit_id":"b5dd3430737b0ec918fd1bc4a056d763853d92e1"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"f0fe5e7034fb1848270b071b01395257b6996b9f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  name: {{ $pspName }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"podsecuritypolicy\" \"policy\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"  annotations:"},{"line_number":30,"context_line":"{{- if $pspDetails.annotations }}"},{"line_number":31,"context_line":"{{ toYaml $pspDetails.annotations | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_7d22baa6","line":29,"in_reply_to":"5fc1f717_e707f91b","updated":"2019-03-08 14:33:11.000000000","message":"@Hemanth , still it should be written after the conditional , there is no harm in that.","commit_id":"b5dd3430737b0ec918fd1bc4a056d763853d92e1"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"fe3c1d9ff6ad4199cc1699cc29deeb6dd2f1fe52","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  name: {{ $pspName }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"podsecuritypolicy\" \"policy\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"  annotations:"},{"line_number":30,"context_line":"{{- if $pspDetails.annotations }}"},{"line_number":31,"context_line":"{{ toYaml $pspDetails.annotations | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_e707f91b","line":29,"in_reply_to":"5fc1f717_e759395a","updated":"2019-03-08 13:34:24.000000000","message":"Hi Pete, \nNot necessarily, k8s will remove the annotations if it doesnt see any value. This has been verified.","commit_id":"b5dd3430737b0ec918fd1bc4a056d763853d92e1"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"01dab35a017b5276787a9b69d32e80dcf970c3c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  name: {{ $pspName }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"podsecuritypolicy\" \"policy\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"{{- if $pspDetails.annotations }}"},{"line_number":30,"context_line":"  annotations:"},{"line_number":31,"context_line":"{{ toYaml $pspDetails.annotations | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5fc1f717_333c63c7","line":29,"updated":"2019-03-08 15:56:11.000000000","message":"@Hemanth , Thanks","commit_id":"19c2acff1179c19121996dc838dfd531f65512ad"}],"tools/deployment/podsecuritypolicy/007-podsecuritypolicy.sh":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"de01c360d4d35a8975cda3d8018d234cdaeb9d27","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  echo \"ERROR: podsecuritypolicy incorrectly admitted a privileged pod\""},{"line_number":51,"context_line":"  kubectl delete pod psp-test"},{"line_number":52,"context_line":"  exit 1"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"#NOTE: Deploy with host networking on, and test for success"},{"line_number":56,"context_line":"helm upgrade --install podsecuritypolicy ./podsecuritypolicy \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5fc1f717_ee303beb","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"updated":"2019-03-08 01:45:19.000000000","message":"```\nelse\n  echo \"Failure above is expected. Continuing.\"\nfi\n```","commit_id":"dae9c076a9dc6f5383faf8f06feed4f110125620"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"cc70457457a5f880e4ca85214cc66e868c9ac565","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  echo \"ERROR: podsecuritypolicy incorrectly admitted a privileged pod\""},{"line_number":51,"context_line":"  kubectl delete pod psp-test"},{"line_number":52,"context_line":"  exit 1"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"#NOTE: Deploy with host networking on, and test for success"},{"line_number":56,"context_line":"helm upgrade --install podsecuritypolicy ./podsecuritypolicy \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5fc1f717_4e994f6c","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"5fc1f717_ee303beb","updated":"2019-03-08 02:14:30.000000000","message":"Yes, the error is expected and else condition is added in PS6 as per your suggestion.","commit_id":"dae9c076a9dc6f5383faf8f06feed4f110125620"}]}