)]}'
{"libvirt/templates/daemonset-libvirt.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"00fbbaaf71815ec9e8356e0368a82cbc5ccf88a3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll \"libvirt\" \"libvirt\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"libvirt\" \"containerNames\" (list \"libvirt\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":48,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":49,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_b1595cff","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":174},"updated":"2019-03-06 19:33:12.000000000","message":"You need to have a MAC section in the values.yaml file in order for this to work:\n  mandatory_access_control:\n    type: apparmor\n    libvirt:\n      libvirt: localhost/\u003cprofile_name\u003e","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"d3750bff86151a1d856016ce4a87ac4689c4f9fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll \"libvirt\" \"libvirt\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"libvirt\" \"containerNames\" (list \"libvirt\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":48,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":49,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_517d98af","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":174},"in_reply_to":"5fc1f717_11e2b0d6","updated":"2019-03-06 19:55:45.000000000","message":"I see it now. Thanks.","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"cd6df56066ecde0756df2167aac941a2f4e13d81","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll \"libvirt\" \"libvirt\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"libvirt\" \"containerNames\" (list \"libvirt\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":48,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":49,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_11e2b0d6","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":174},"in_reply_to":"5fc1f717_b1595cff","updated":"2019-03-06 19:38:29.000000000","message":"I have added this in the gate jobs yaml file.","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"00fbbaaf71815ec9e8356e0368a82cbc5ccf88a3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":57,"context_line":"      initContainers:"},{"line_number":58,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_libvirt_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll | include \"helm-toolkit.snippets.kubernetes_apparmor_loader_init_container\" | indent 8 }}"},{"line_number":60,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":61,"context_line":"        {{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":62,"context_line":"        - name: ceph-admin-keyring-placement"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_518ef878","line":59,"range":{"start_line":59,"start_character":57,"end_line":59,"end_character":58},"updated":"2019-03-06 19:33:12.000000000","message":"This function is not yet merged (https://review.openstack.org/#/c/608826/). I\u0027m a bit surprised that this daemonset was able to be deployed without this function being there.\nIf you want to use the init container before it\u0027s merged, you need to check the documentation within that HTK function and also you would have to create a dependency within this commit to that commit.","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"cd6df56066ecde0756df2167aac941a2f4e13d81","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":57,"context_line":"      initContainers:"},{"line_number":58,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_libvirt_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll | include \"helm-toolkit.snippets.kubernetes_apparmor_loader_init_container\" | indent 8 }}"},{"line_number":60,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":61,"context_line":"        {{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":62,"context_line":"        - name: ceph-admin-keyring-placement"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_91f6a08f","line":59,"range":{"start_line":59,"start_character":57,"end_line":59,"end_character":58},"in_reply_to":"5fc1f717_518ef878","updated":"2019-03-06 19:38:29.000000000","message":"Actually I have used the https://review.openstack.org/#/c/608826/ as the base , thats why it worked","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"d3750bff86151a1d856016ce4a87ac4689c4f9fb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":57,"context_line":"      initContainers:"},{"line_number":58,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_libvirt_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll | include \"helm-toolkit.snippets.kubernetes_apparmor_loader_init_container\" | indent 8 }}"},{"line_number":60,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":61,"context_line":"        {{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":62,"context_line":"        - name: ceph-admin-keyring-placement"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_91aea02c","line":59,"range":{"start_line":59,"start_character":57,"end_line":59,"end_character":58},"in_reply_to":"5fc1f717_91f6a08f","updated":"2019-03-06 19:55:45.000000000","message":"Ah ok.  I didn\u0027t see that before. Thanks.","commit_id":"947373a71357f4970b49237d462e02e6530f496f"}],"tools/deployment/apparmor/050-libvirt.sh":[{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"5c7b9f3700936dec9e993bb01a483524f94a6274","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    apparmor_loader: google/apparmor-loader:latest"},{"line_number":25,"context_line":"pod:"},{"line_number":26,"context_line":"  mandatory_access_control:"},{"line_number":27,"context_line":"    type: apparmor"},{"line_number":28,"context_line":"    configmap_apparmor: true"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_9124600f","line":25,"updated":"2019-03-06 19:41:22.000000000","message":"@Cliff here I have provided the MAC keys","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":29254,"name":"Luna Das","email":"luna.das@att.com","username":"ld366r"},"change_message_id":"fb4b7d26ead125a17065e838e6b50503da43cd11","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    apparmor_loader: google/apparmor-loader:latest"},{"line_number":25,"context_line":"pod:"},{"line_number":26,"context_line":"  mandatory_access_control:"},{"line_number":27,"context_line":"    type: apparmor"},{"line_number":28,"context_line":"    configmap_apparmor: true"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_f1efe484","line":25,"in_reply_to":"5fc1f717_9124600f","updated":"2019-03-06 19:46:02.000000000","message":"But this file should be provided as --values\u003d/tmp/libvirt.yaml  to the helm install command","commit_id":"947373a71357f4970b49237d462e02e6530f496f"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"d3750bff86151a1d856016ce4a87ac4689c4f9fb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    apparmor_loader: google/apparmor-loader:latest"},{"line_number":25,"context_line":"pod:"},{"line_number":26,"context_line":"  mandatory_access_control:"},{"line_number":27,"context_line":"    type: apparmor"},{"line_number":28,"context_line":"    configmap_apparmor: true"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_d1a3c84e","line":25,"in_reply_to":"5fc1f717_f1efe484","updated":"2019-03-06 19:55:45.000000000","message":"yes, I see now. It\u0027s been a while since I last looked at apparmor, so I had forgotten. Thanks.","commit_id":"947373a71357f4970b49237d462e02e6530f496f"}]}
