)]}'
{"elasticsearch/values.yaml":[{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8e0178fd374c864467867ed3f77a3b36762ac3a2","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    es:"},{"line_number":519,"context_line":"      all: true"},{"line_number":520,"context_line":"      timeout: 20s"},{"line_number":521,"context_line":"  templates:"},{"line_number":522,"context_line":"    fluent:"},{"line_number":523,"context_line":"      template: \"logstash-*\""},{"line_number":524,"context_line":"      index_patterns: \"logstash-*\""},{"line_number":525,"context_line":"      settings:"},{"line_number":526,"context_line":"        number_of_shards: 1"},{"line_number":527,"context_line":"      mappings:"},{"line_number":528,"context_line":"        fluent:"},{"line_number":529,"context_line":"          properties:"},{"line_number":530,"context_line":"            kubernetes:"},{"line_number":531,"context_line":"              properties:"},{"line_number":532,"context_line":"                container_name:"},{"line_number":533,"context_line":"                  type: keyword"},{"line_number":534,"context_line":"                  index: false"},{"line_number":535,"context_line":"                docker_id:"},{"line_number":536,"context_line":"                  type: keyword"},{"line_number":537,"context_line":"                  index: false"},{"line_number":538,"context_line":"                host:"},{"line_number":539,"context_line":"                  type: keyword"},{"line_number":540,"context_line":"                  index: false"},{"line_number":541,"context_line":"                namespace_name:"},{"line_number":542,"context_line":"                  type: keyword"},{"line_number":543,"context_line":"                  index: false"},{"line_number":544,"context_line":"                pod_id:"},{"line_number":545,"context_line":"                  type: keyword"},{"line_number":546,"context_line":"                  index: false"},{"line_number":547,"context_line":"                pod_name:"},{"line_number":548,"context_line":"                  type: keyword"},{"line_number":549,"context_line":"                  index: false"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"endpoints:"},{"line_number":552,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_de7b2c25","line":549,"range":{"start_line":521,"start_character":2,"end_line":549,"end_character":30},"updated":"2019-03-15 02:48:47.000000000","message":"How can other SW(except fluent-logging)  to use ES define their template after install ES chart?\nAs I said before, the template should be defined by data source (fluent-logging and other things to use ES).","commit_id":"250bec27d28711ccedb1cf21001ae30c1ac881e6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"d23159f03a6d73d5e8069c8a03281484bc407c06","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    es:"},{"line_number":519,"context_line":"      all: true"},{"line_number":520,"context_line":"      timeout: 20s"},{"line_number":521,"context_line":"  templates:"},{"line_number":522,"context_line":"    fluent:"},{"line_number":523,"context_line":"      template: \"logstash-*\""},{"line_number":524,"context_line":"      index_patterns: \"logstash-*\""},{"line_number":525,"context_line":"      settings:"},{"line_number":526,"context_line":"        number_of_shards: 1"},{"line_number":527,"context_line":"      mappings:"},{"line_number":528,"context_line":"        fluent:"},{"line_number":529,"context_line":"          properties:"},{"line_number":530,"context_line":"            kubernetes:"},{"line_number":531,"context_line":"              properties:"},{"line_number":532,"context_line":"                container_name:"},{"line_number":533,"context_line":"                  type: keyword"},{"line_number":534,"context_line":"                  index: false"},{"line_number":535,"context_line":"                docker_id:"},{"line_number":536,"context_line":"                  type: keyword"},{"line_number":537,"context_line":"                  index: false"},{"line_number":538,"context_line":"                host:"},{"line_number":539,"context_line":"                  type: keyword"},{"line_number":540,"context_line":"                  index: false"},{"line_number":541,"context_line":"                namespace_name:"},{"line_number":542,"context_line":"                  type: keyword"},{"line_number":543,"context_line":"                  index: false"},{"line_number":544,"context_line":"                pod_id:"},{"line_number":545,"context_line":"                  type: keyword"},{"line_number":546,"context_line":"                  index: false"},{"line_number":547,"context_line":"                pod_name:"},{"line_number":548,"context_line":"                  type: keyword"},{"line_number":549,"context_line":"                  index: false"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"endpoints:"},{"line_number":552,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_7981734a","line":549,"range":{"start_line":521,"start_character":2,"end_line":549,"end_character":30},"in_reply_to":"5fc1f717_de7b2c25","updated":"2019-04-15 14:19:26.000000000","message":"I\u0027ve been thinking about this, and I disagree that data sources should define the template. The reason I disagree is that these templates define the fields Elasticsearch manages for any given index and aren\u0027t strictly tied to the chart providing the data source. For example, Fluentd, Fluentbit, and Filebeat all include Kubernetes metadata plugins that provide the same fields on a logged event. In heterogeneous environments, it wouldn\u0027t make sense to trigger multiple jobs with multiple values overrides to effectively define a single index template. This especially becomes difficult if we want to update the field settings on indexes -- if we define these templates in the data source, it means we have to potentially perform a disruptive upgrade of a daemonset chart simply to update fields on an index.  If Elasticsearch owns these templates, then we simply updated Elasticsearch once for all templates define - in my mind, this is much less disruptive and is simpler to do.\n\nHaving data sources own these templates also introduces a complex dependency between the data sources and Elasticsearch.  During upgrades, trouble updating Elasticsearch can cause trouble updating the data sources since the data source pods will effectively have to wait until Elasticsearch is deployed and ready before the index jobs can be triggered.  In my mind, we should try to avoid complex dependencies where possible.","commit_id":"250bec27d28711ccedb1cf21001ae30c1ac881e6"}]}
