)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"964ef9151829d94c0991a5d5047a183d48a4a717","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Renis Makadia \u003crenis.makadia@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-14 16:26:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add dependencies for checkpg cron job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia986f11d596044cef10c5c8a1798651ca4ebdc53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_dd47bc4b","line":7,"updated":"2019-03-14 16:34:14.000000000","message":"please update this to specify the chart that this is applicable to, and a comment to explain whats being done.","commit_id":"125177b38a04f54e5975c3899a5b886ce4466f9b"}],"ceph-mon/templates/cronjob-checkPGs.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7e58f125df468e57dcb2bbecbbe8e535bd17b3a3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          nodeSelector:"},{"line_number":76,"context_line":"            {{ .Values.labels.mon.node_selector_key }}: {{ .Values.labels.mon.node_selector_value }}"},{"line_number":77,"context_line":"          initContainers:"},{"line_number":78,"context_line":"{{ tuple $envAll \"pool_checkpgs\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":79,"context_line":"          containers:"},{"line_number":80,"context_line":"          - name: {{ $serviceAccountName }}"},{"line_number":81,"context_line":"{{ tuple $envAll \"ceph_config_helper\" | include \"helm-toolkit.snippets.image\" | indent 12 }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_75710044","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":122},"updated":"2019-03-14 17:40:40.000000000","message":"This needs to be indented 12, not 8: https://github.com/openstack/openstack-helm-infra/blob/master/elasticsearch/templates/cron-job-curator.yaml#L48","commit_id":"f5451360a67a51a1fbf352b963fc4a237dc603bb"}],"ceph-mon/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"36b986e5263a11f635ba47dea1d1ca899579adc3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"      services:"},{"line_number":222,"context_line":"        - endpoint: internal"},{"line_number":223,"context_line":"          service: local_image_registry"},{"line_number":224,"context_line":"    pool-checkpgs:"},{"line_number":225,"context_line":"      jobs:"},{"line_number":226,"context_line":"        - ceph-rbd-pool"},{"line_number":227,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_e2ff75a8","line":224,"range":{"start_line":224,"start_character":4,"end_line":224,"end_character":17},"updated":"2019-03-14 16:04:38.000000000","message":"This should be pool_checkpgs to allow for successful mapping to the serviceaccount on the cronjob template: https://github.com/openstack/openstack-helm-infra/blob/master/ceph-mon/templates/cronjob-checkPGs.yaml#L21","commit_id":"83852d3644124e2addeab3f0ceca870acadd3498"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"06e14f05b2a1ac6835165dc2e4374eab06045946","unresolved":false,"context_lines":[{"line_number":221,"context_line":"      services:"},{"line_number":222,"context_line":"        - endpoint: internal"},{"line_number":223,"context_line":"          service: local_image_registry"},{"line_number":224,"context_line":"    pool-checkpgs:"},{"line_number":225,"context_line":"      jobs:"},{"line_number":226,"context_line":"        - ceph-rbd-pool"},{"line_number":227,"context_line":"      services:"},{"line_number":228,"context_line":"        - endpoint: internal"},{"line_number":229,"context_line":"          service: ceph_mon"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"bootstrap:"},{"line_number":232,"context_line":"  enabled: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_e2bc5507","line":229,"range":{"start_line":224,"start_character":0,"end_line":229,"end_character":27},"updated":"2019-03-14 16:02:32.000000000","message":"The cronjob template needs an init container to actively take advantage of these dependencies","commit_id":"83852d3644124e2addeab3f0ceca870acadd3498"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"bc9cc072d1f6e7c02e106feced592d9a395d2417","unresolved":false,"context_lines":[{"line_number":221,"context_line":"      services:"},{"line_number":222,"context_line":"        - endpoint: internal"},{"line_number":223,"context_line":"          service: local_image_registry"},{"line_number":224,"context_line":"    pool-checkpgs:"},{"line_number":225,"context_line":"      jobs:"},{"line_number":226,"context_line":"        - ceph-rbd-pool"},{"line_number":227,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_02ee41b3","line":224,"range":{"start_line":224,"start_character":4,"end_line":224,"end_character":17},"updated":"2019-03-14 16:15:32.000000000","message":"pool_checkpgs","commit_id":"2435c7264b752f255839ca7a97f3006021d21fbf"}]}