)]}'
{"dnsmasq/requirements.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_4ba82376","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":44},"updated":"2019-04-26 11:38:08.000000000","message":"This can be removed or edited","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_1c1e5c0c","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":44},"in_reply_to":"ffb9cba7_4ba82376","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/templates/bin/_dnsmasq-set-pxe-http.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b53b1987e5756d2cac157b0fe44408abee57aa13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":4,"id":"5fc1f717_71e487e0","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":41},"updated":"2019-03-28 16:12:00.000000000","message":"Please put your company or don\u0027t put that copyright line.","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"0869c6f5886186ca2d9c66a5e9321e74846248b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":4,"id":"5fc1f717_9d6f98fb","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":41},"in_reply_to":"5fc1f717_71e487e0","updated":"2019-04-01 13:09:40.000000000","message":"Done","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"}],"dnsmasq/templates/bin/_dnsmasq.sh.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b53b1987e5756d2cac157b0fe44408abee57aa13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":4,"id":"5fc1f717_31fb5f79","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":42},"updated":"2019-03-28 16:12:00.000000000","message":"ditto","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"0869c6f5886186ca2d9c66a5e9321e74846248b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":4,"id":"5fc1f717_3d7464d0","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":42},"in_reply_to":"5fc1f717_31fb5f79","updated":"2019-04-01 13:09:40.000000000","message":"Done","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"change_message_id":"b97b278ffa6982165eed303293e2ccee801358bb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cp -v /tmp/pod-shared/dnsmasq.conf /etc/dnsmasq.conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"/usr/sbin/dnsmasq --user\u003droot -d --log-dhcp"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3fce034c_443de4b9","line":23,"updated":"2019-04-11 16:02:55.000000000","message":"please make the user that this is run as configurable","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"230bbd71d21fb402e8d093ca35bb2715da0a776c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cp -v /tmp/pod-shared/dnsmasq.conf /etc/dnsmasq.conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"/usr/sbin/dnsmasq --user\u003droot -d --log-dhcp"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3fce034c_858894c6","line":23,"in_reply_to":"3fce034c_443de4b9","updated":"2019-04-12 15:02:33.000000000","message":"Thanks for the review!\nIt\u0027s really valid point. I\u0027ve reworked this.","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"}],"dnsmasq/templates/configmap-bin.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_ebb8f7c8","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"updated":"2019-04-26 11:38:08.000000000","message":"this can be removed or edited","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_bc1ab014","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"ffb9cba7_ebb8f7c8","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/templates/configmap-etc.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_abb2ffe4","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":42},"updated":"2019-04-26 11:38:08.000000000","message":"ditto","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_dc1764ed","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":42},"in_reply_to":"ffb9cba7_abb2ffe4","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/templates/deployment.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_6bcc076a","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":42},"updated":"2019-04-26 11:38:08.000000000","message":"ditto","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_9cd7ac24","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"ffb9cba7_6bcc076a","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/templates/job-image-repo-sync.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_8bc7fb45","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"updated":"2019-04-26 11:38:08.000000000","message":"ditto","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_3cdc8045","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"ffb9cba7_8bc7fb45","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/templates/network_policy.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a9772fd25f5aff7b0934d0886f79b39bb89435e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_2bc60f4a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"updated":"2019-04-26 11:38:08.000000000","message":"ditto","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3efce31bc967db5f5687bdcf447c827e604cf53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_fce5880b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"ffb9cba7_2bc60f4a","updated":"2019-05-03 12:27:38.000000000","message":"Done","commit_id":"f7d0436faa02e129dee1c03315ede9fd28eccb27"}],"dnsmasq/values.yaml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4b9b644a6cd2a1c8c9d8a0aceefe884b1f55ae4c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  tags:"},{"line_number":9,"context_line":"    dnsmasq: docker.io/ohryhorov/ubuntu-binary-dnsmasq:ocata"},{"line_number":10,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":11,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":12,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_6e5ea246","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":60},"updated":"2019-03-20 15:46:45.000000000","message":"temporary thing","commit_id":"a42703804126e319d9012f8c1d2e492044a7916d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b53b1987e5756d2cac157b0fe44408abee57aa13","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      registry:"},{"line_number":52,"context_line":"        node: 5000"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"service:"},{"line_number":55,"context_line":"  type: ClusterIP"},{"line_number":56,"context_line":"  port: 67"},{"line_number":57,"context_line":"  targetPort: 6767"},{"line_number":58,"context_line":"  clusterIP: None"},{"line_number":59,"context_line":"  protocol: UDP"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"network_policy:"},{"line_number":62,"context_line":"  dnsmasq:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_51214bb3","line":59,"range":{"start_line":54,"start_character":0,"end_line":59,"end_character":15},"updated":"2019-03-28 16:12:00.000000000","message":"this looks like a new key","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"0869c6f5886186ca2d9c66a5e9321e74846248b6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      registry:"},{"line_number":52,"context_line":"        node: 5000"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"service:"},{"line_number":55,"context_line":"  type: ClusterIP"},{"line_number":56,"context_line":"  port: 67"},{"line_number":57,"context_line":"  targetPort: 6767"},{"line_number":58,"context_line":"  clusterIP: None"},{"line_number":59,"context_line":"  protocol: UDP"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"network_policy:"},{"line_number":62,"context_line":"  dnsmasq:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_5d1ff06f","line":59,"range":{"start_line":54,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"5fc1f717_51214bb3","updated":"2019-04-01 13:09:40.000000000","message":"Thanks a lot for the review! \n\nIt was created like an example. To make a possibility to expose service ports for instance if dnsmasq is going to be used as alternative DNS or any other reasons.","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b53b1987e5756d2cac157b0fe44408abee57aa13","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    ingress:"},{"line_number":64,"context_line":"      - {}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"network:"},{"line_number":67,"context_line":"  pxe:"},{"line_number":68,"context_line":"    device: br-simulator"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"pod:"},{"line_number":71,"context_line":"  replicas:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_ac005202","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":24},"updated":"2019-03-28 16:12:00.000000000","message":"Pete, isn\u0027t there another way to find the appropriate bridge, depending on the host, nowadays?","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"0869c6f5886186ca2d9c66a5e9321e74846248b6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    ingress:"},{"line_number":64,"context_line":"      - {}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"network:"},{"line_number":67,"context_line":"  pxe:"},{"line_number":68,"context_line":"    device: br-simulator"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"pod:"},{"line_number":71,"context_line":"  replicas:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_dd1c4079","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":24},"in_reply_to":"5fc1f717_ac005202","updated":"2019-04-01 13:09:40.000000000","message":"Surely there are plenty of way to find a bridge in the configuration nowaday but only operator who deploys the chart can be shure that that proper interface is chosen especially if the interface is physical.","commit_id":"86e6b1e51842282b2c8e13cedb98fde07a971885"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"77a22e21e94be27e9c00e3be451b90d9ad6f68d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  tags:"},{"line_number":9,"context_line":"    dnsmasq: docker.io/ohryhorov/ubuntu-binary-dnsmasq:ocata"},{"line_number":10,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":11,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":12,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_bb317c5b","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":60},"updated":"2019-04-10 16:02:38.000000000","message":"though not optimal for size, would it be simpler for now just to reuse the neutron image?","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"19f60101c15466823ca0adcac75ff840ece98a89","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  tags:"},{"line_number":9,"context_line":"    dnsmasq: docker.io/ohryhorov/ubuntu-binary-dnsmasq:ocata"},{"line_number":10,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":11,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":12,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fce034c_5e837305","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":60},"in_reply_to":"5fc1f717_bb317c5b","updated":"2019-04-11 14:44:42.000000000","message":"First of all, thanks a lot for the review!\n\nIndeed if neutron image is used it could be more optimal taking into account that most likely the image had been already pulled. In addition i don\u0027t need to create extra patches for images which could bring some mess here.","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"77a22e21e94be27e9c00e3be451b90d9ad6f68d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          memory: \"1024Mi\""},{"line_number":89,"context_line":"          cpu: \"2000m\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"resources: {}"},{"line_number":92,"context_line":"  # We usually recommend not to specify default resources and to leave this as a conscious"},{"line_number":93,"context_line":"  # choice for the user. This also increases chances charts run on environments with little"},{"line_number":94,"context_line":"  # resources, such as Minikube. If you do want to specify resources, uncomment the following"},{"line_number":95,"context_line":"  # lines, adjust them as necessary, and remove the curly braces after \u0027resources:\u0027."},{"line_number":96,"context_line":"  # limits:"},{"line_number":97,"context_line":"  #  cpu: 100m"},{"line_number":98,"context_line":"  #  memory: 128Mi"},{"line_number":99,"context_line":"  # requests:"},{"line_number":100,"context_line":"  #  cpu: 100m"},{"line_number":101,"context_line":"  #  memory: 128Mi"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"#nodeSelector: {}"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_dbffa863","line":101,"range":{"start_line":91,"start_character":0,"end_line":101,"end_character":18},"updated":"2019-04-10 16:02:38.000000000","message":"is this not a repetition of lines 73-89?","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"19f60101c15466823ca0adcac75ff840ece98a89","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          memory: \"1024Mi\""},{"line_number":89,"context_line":"          cpu: \"2000m\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"resources: {}"},{"line_number":92,"context_line":"  # We usually recommend not to specify default resources and to leave this as a conscious"},{"line_number":93,"context_line":"  # choice for the user. This also increases chances charts run on environments with little"},{"line_number":94,"context_line":"  # resources, such as Minikube. If you do want to specify resources, uncomment the following"},{"line_number":95,"context_line":"  # lines, adjust them as necessary, and remove the curly braces after \u0027resources:\u0027."},{"line_number":96,"context_line":"  # limits:"},{"line_number":97,"context_line":"  #  cpu: 100m"},{"line_number":98,"context_line":"  #  memory: 128Mi"},{"line_number":99,"context_line":"  # requests:"},{"line_number":100,"context_line":"  #  cpu: 100m"},{"line_number":101,"context_line":"  #  memory: 128Mi"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"#nodeSelector: {}"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fce034c_3e7a2724","line":101,"range":{"start_line":91,"start_character":0,"end_line":101,"end_character":18},"in_reply_to":"5fc1f717_dbffa863","updated":"2019-04-11 14:44:42.000000000","message":"Yes, thanks.","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"77a22e21e94be27e9c00e3be451b90d9ad6f68d8","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"#nodeSelector: {}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"tolerations: []"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"affinity: {}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"conf:"},{"line_number":110,"context_line":"  dnsmasq: |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_fb2b84e7","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":12},"updated":"2019-04-10 16:02:38.000000000","message":"these keys would be great under the `pod` key, and targeted against pods/replica controllers in the same way we do for other keys there.","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"19f60101c15466823ca0adcac75ff840ece98a89","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"#nodeSelector: {}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"tolerations: []"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"affinity: {}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"conf:"},{"line_number":110,"context_line":"  dnsmasq: |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fce034c_9e8ebb25","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":12},"in_reply_to":"5fc1f717_fb2b84e7","updated":"2019-04-11 14:44:42.000000000","message":"Done","commit_id":"cae2ecf04bcd760590a221e719978368d38188a1"},{"author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"change_message_id":"b97b278ffa6982165eed303293e2ccee801358bb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          cpu: \"2000m\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"conf:"},{"line_number":98,"context_line":"  dnsmasq: |"},{"line_number":99,"context_line":"    strict-order"},{"line_number":100,"context_line":"    pid-file\u003d/var/run/vbmc-ironic/dnsmasq.pid"},{"line_number":101,"context_line":"    except-interface\u003dlo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_81189e81","line":98,"updated":"2019-04-11 16:02:55.000000000","message":"This should probably be moved to a template","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"21bcbb921f5153de298835c00c816e0026874ffe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          cpu: \"2000m\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"conf:"},{"line_number":98,"context_line":"  dnsmasq: |"},{"line_number":99,"context_line":"    strict-order"},{"line_number":100,"context_line":"    pid-file\u003d/var/run/vbmc-ironic/dnsmasq.pid"},{"line_number":101,"context_line":"    except-interface\u003dlo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_6e70c8a6","line":98,"in_reply_to":"3fce034c_65a8081f","updated":"2019-04-15 15:31:01.000000000","message":"@Randeep - you know, i\u0027ve thought conf should be templatized to it\u0027s maybe useful and this approach sticks to other chars. Therefore i reworked the CR for this.","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"change_message_id":"a38f1d0e020eba5b638772dfef2556ddb53b1b65","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          cpu: \"2000m\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"conf:"},{"line_number":98,"context_line":"  dnsmasq: |"},{"line_number":99,"context_line":"    strict-order"},{"line_number":100,"context_line":"    pid-file\u003d/var/run/vbmc-ironic/dnsmasq.pid"},{"line_number":101,"context_line":"    except-interface\u003dlo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_1ac13a2f","line":98,"in_reply_to":"3fce034c_6e70c8a6","updated":"2019-04-15 18:32:47.000000000","message":"Thanks :)","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"230bbd71d21fb402e8d093ca35bb2715da0a776c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          cpu: \"2000m\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"conf:"},{"line_number":98,"context_line":"  dnsmasq: |"},{"line_number":99,"context_line":"    strict-order"},{"line_number":100,"context_line":"    pid-file\u003d/var/run/vbmc-ironic/dnsmasq.pid"},{"line_number":101,"context_line":"    except-interface\u003dlo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_65a8081f","line":98,"in_reply_to":"3fce034c_81189e81","updated":"2019-04-12 15:02:33.000000000","message":"The main idea was to pass config file which can be required for an particular case instead of to templatize all parameters from dnsmasq.conf.sample through command line or values.","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"change_message_id":"b97b278ffa6982165eed303293e2ccee801358bb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    except-interface\u003dvirbr0"},{"line_number":103,"context_line":"    bind-dynamic"},{"line_number":104,"context_line":"    interface\u003dDNSMASQ_IFACE"},{"line_number":105,"context_line":"    dhcp-range\u003d192.168.90.100,192.168.90.254,12h"},{"line_number":106,"context_line":"    dhcp-no-override"},{"line_number":107,"context_line":"    dhcp-authoritative"},{"line_number":108,"context_line":"    dhcp-lease-max\u003d253"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_210d2a3e","line":105,"updated":"2019-04-11 16:02:55.000000000","message":"could you please take this in as an override for the range?","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"230bbd71d21fb402e8d093ca35bb2715da0a776c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    except-interface\u003dvirbr0"},{"line_number":103,"context_line":"    bind-dynamic"},{"line_number":104,"context_line":"    interface\u003dDNSMASQ_IFACE"},{"line_number":105,"context_line":"    dhcp-range\u003d192.168.90.100,192.168.90.254,12h"},{"line_number":106,"context_line":"    dhcp-no-override"},{"line_number":107,"context_line":"    dhcp-authoritative"},{"line_number":108,"context_line":"    dhcp-lease-max\u003d253"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_c56c5c0a","line":105,"in_reply_to":"3fce034c_210d2a3e","updated":"2019-04-12 15:02:33.000000000","message":"The same as above ops during deployment can pass the range which is used for this case.","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"},{"author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"change_message_id":"a38f1d0e020eba5b638772dfef2556ddb53b1b65","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    except-interface\u003dvirbr0"},{"line_number":103,"context_line":"    bind-dynamic"},{"line_number":104,"context_line":"    interface\u003dDNSMASQ_IFACE"},{"line_number":105,"context_line":"    dhcp-range\u003d192.168.90.100,192.168.90.254,12h"},{"line_number":106,"context_line":"    dhcp-no-override"},{"line_number":107,"context_line":"    dhcp-authoritative"},{"line_number":108,"context_line":"    dhcp-lease-max\u003d253"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_5ac7c246","line":105,"in_reply_to":"3fce034c_c56c5c0a","updated":"2019-04-15 18:32:47.000000000","message":"Thanks :)","commit_id":"afc8fccdf398ff3e66b379e4f1252f412c61d3d0"}]}