)]}'
{"calico/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"953e2f8d548d0f5a3a74312778816ca85da3268b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    name: oci-image-registry"},{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfb3d3c7_56cc7cbb","line":159,"range":{"start_line":159,"start_character":6,"end_line":159,"end_character":20},"updated":"2019-05-21 14:41:38.000000000","message":"would null values for password and username suffice for this?","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"d0256b7d266d7a6a04398277309930d8ba1bdd43","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    name: oci-image-registry"},{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfb3d3c7_021d540e","line":159,"range":{"start_line":159,"start_character":6,"end_line":159,"end_character":20},"in_reply_to":"bfb3d3c7_56cc7cbb","updated":"2019-05-22 06:38:03.000000000","message":"I like the enabled flag for its explicitness but if the general rule is to set password+username to null in order to disable the auth, I can change it.\nYour call.","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"953e2f8d548d0f5a3a74312778816ca85da3268b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"},{"line_number":163,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfb3d3c7_b63a9895","line":160,"range":{"start_line":160,"start_character":6,"end_line":160,"end_character":13},"updated":"2019-05-21 14:41:38.000000000","message":"rather than scope this on a per chart basis would we want to use a common \u0027user\u0027 instead - allowing reuse of values simply across charts?","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"4ff467a8b5ac4d89449dde4bb44b092f6c11476f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"},{"line_number":163,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_8718a781","line":160,"range":{"start_line":160,"start_character":6,"end_line":160,"end_character":13},"in_reply_to":"bfb3d3c7_0ca342a0","updated":"2019-06-03 21:08:01.000000000","message":"Thanks Pete\u0027s suggestion. Yeah, I think that\u0027s more reasonable. If different credentials are needed, it can be easily overrided for the required charts.","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"d0256b7d266d7a6a04398277309930d8ba1bdd43","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"},{"line_number":163,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfb3d3c7_c2165cf2","line":160,"range":{"start_line":160,"start_character":6,"end_line":160,"end_character":13},"in_reply_to":"bfb3d3c7_b63a9895","updated":"2019-05-22 06:38:03.000000000","message":"This would offer the possibility of using different authentication per chart.\nAn obvious use-case we have is that several different team will be in charge of their own charts so they probably have different credentials on our private registry.","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"777b9fd6a6ed8b5f9a7739e9cf1c0d21695bc923","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    namespace: oci-image-registry"},{"line_number":158,"context_line":"    auth:"},{"line_number":159,"context_line":"      enabled: false"},{"line_number":160,"context_line":"      calico:"},{"line_number":161,"context_line":"        username: calico"},{"line_number":162,"context_line":"        password: password"},{"line_number":163,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bfb3d3c7_0ca342a0","line":160,"range":{"start_line":160,"start_character":6,"end_line":160,"end_character":13},"in_reply_to":"bfb3d3c7_c2165cf2","updated":"2019-05-22 14:10:58.000000000","message":"that could be handled by feeding appropriate over-rides for each chart, as in such a world you\u0027d want to presumably want to separate the credentials rather than store in a singular common document. Additionally, with this model how would you handle common images, eg the dep checker/k8s entry point?","commit_id":"1c4e75369865e5e0e8bea63c66ffc9e30c29a826"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"4ff467a8b5ac4d89449dde4bb44b092f6c11476f","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"secrets:"},{"line_number":171,"context_line":"  oci_image_registry:"},{"line_number":172,"context_line":"    calico: calico-oci-image-registry-key"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"endpoints:"},{"line_number":175,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_e32716b6","line":172,"range":{"start_line":172,"start_character":4,"end_line":172,"end_character":10},"updated":"2019-06-03 21:08:01.000000000","message":"registry","commit_id":"a300aead258f5783c829deeda519b34481e36dde"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"f6c1581538f35278b105f1dcc5f28b54fc4fd7ba","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"secrets:"},{"line_number":171,"context_line":"  oci_image_registry:"},{"line_number":172,"context_line":"    calico: calico-oci-image-registry-key"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"endpoints:"},{"line_number":175,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_8cb76287","line":172,"range":{"start_line":172,"start_character":4,"end_line":172,"end_character":10},"in_reply_to":"9fb8cfa7_e32716b6","updated":"2019-06-04 08:36:13.000000000","message":"Done","commit_id":"a300aead258f5783c829deeda519b34481e36dde"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"a04d6b92e81fc10b5675dfd55ebe5f78b09d5d63","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    namespace: oci-image-registry"},{"line_number":191,"context_line":"    auth:"},{"line_number":192,"context_line":"      enabled: false"},{"line_number":193,"context_line":"      registry:"},{"line_number":194,"context_line":"        username: registry-user"},{"line_number":195,"context_line":"        password: password"},{"line_number":196,"context_line":"    hosts:"},{"line_number":197,"context_line":"      default: localhost"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_c9842a0f","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":31},"updated":"2019-05-23 07:48:21.000000000","message":"Pete, would something like this, replaced everywhere, make more sense?","commit_id":"a300aead258f5783c829deeda519b34481e36dde"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"f6c1581538f35278b105f1dcc5f28b54fc4fd7ba","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    namespace: oci-image-registry"},{"line_number":191,"context_line":"    auth:"},{"line_number":192,"context_line":"      enabled: false"},{"line_number":193,"context_line":"      registry:"},{"line_number":194,"context_line":"        username: registry-user"},{"line_number":195,"context_line":"        password: password"},{"line_number":196,"context_line":"    hosts:"},{"line_number":197,"context_line":"      default: localhost"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_cc623a17","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":31},"in_reply_to":"9fb8cfa7_e34cf677","updated":"2019-06-04 08:36:13.000000000","message":"Done for calico in secret_registry.yaml and I changed kubernetes_pod_rbac_serviceaccount.tpl in helm-toolkit accordingly.","commit_id":"a300aead258f5783c829deeda519b34481e36dde"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"4ff467a8b5ac4d89449dde4bb44b092f6c11476f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    namespace: oci-image-registry"},{"line_number":191,"context_line":"    auth:"},{"line_number":192,"context_line":"      enabled: false"},{"line_number":193,"context_line":"      registry:"},{"line_number":194,"context_line":"        username: registry-user"},{"line_number":195,"context_line":"        password: password"},{"line_number":196,"context_line":"    hosts:"},{"line_number":197,"context_line":"      default: localhost"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_e34cf677","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":31},"in_reply_to":"bfb3d3c7_c9842a0f","updated":"2019-06-03 21:08:01.000000000","message":"Hi Pierre, if we want to use common user, the above secrets section should be updated to align with the user name as well as the \".Chart.Name\" referenced in each chart secret_registry.yaml and service account template in helm-toolkit.","commit_id":"a300aead258f5783c829deeda519b34481e36dde"}],"gnocchi/values.yaml":[{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"3ded3f21d4a3bcc73658c40fb67bf1b443e4893f","unresolved":false,"context_lines":[{"line_number":459,"context_line":"  configmap: ceph-etc"},{"line_number":460,"context_line":"  user_secret_name: pvc-ceph-client-key"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"secrets:"},{"line_number":463,"context_line":"  identity:"},{"line_number":464,"context_line":"    admin: gnocchi-keystone-admin"},{"line_number":465,"context_line":"    gnocchi: gnocchi-keystone-user"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_5e0e13e6","line":462,"range":{"start_line":462,"start_character":0,"end_line":462,"end_character":8},"updated":"2019-04-11 15:20:08.000000000","message":"This chart already has secrets: section. You should move the oci_image_registry secret to this existing secrets: .","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"17bd61dac1023241fe05a50857891ad4d8714b32","unresolved":false,"context_lines":[{"line_number":459,"context_line":"  configmap: ceph-etc"},{"line_number":460,"context_line":"  user_secret_name: pvc-ceph-client-key"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"secrets:"},{"line_number":463,"context_line":"  identity:"},{"line_number":464,"context_line":"    admin: gnocchi-keystone-admin"},{"line_number":465,"context_line":"    gnocchi: gnocchi-keystone-user"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_81a3be4f","line":462,"range":{"start_line":462,"start_character":0,"end_line":462,"end_character":8},"in_reply_to":"3fce034c_5e0e13e6","updated":"2019-04-11 15:54:55.000000000","message":"Done. This was the case for some other charts too.","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"}],"helm-toolkit/templates/manifests/_secret-registry.yaml.tpl":[{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"3ded3f21d4a3bcc73658c40fb67bf1b443e4893f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{{/* NOTE(pgaxatte): if we use the default registry port, we should not add it to the host"},{"line_number":11,"context_line":"   * because the url of the image must match the auth section of .docker/config.json"},{"line_number":12,"context_line":"   */}}"},{"line_number":13,"context_line":"{{- if eq $registryPort \"443\" -}}"},{"line_number":14,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $dockerAuthToken | b64enc }}"},{"line_number":15,"context_line":"{{- else -}}"},{"line_number":16,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s:%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $registryPort $dockerAuthToken | b64enc }}"},{"line_number":17,"context_line":"{{- end -}}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: Secret"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fce034c_fee01f99","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":11},"updated":"2019-04-11 15:20:08.000000000","message":"Yes, we should consider that the registry server/URL doesn\u0027t contain a port.\n\nI think we could change the default oci_image_registry port to null instead of 5000 in each chart values.yaml and check the returned port $registryPort is empty or not (add the port the dockerAuth if port is specified, otherwise do not add port)","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"1f15d0d6b0c19bc872846a3baf86af137e89789a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{{/* NOTE(pgaxatte): if we use the default registry port, we should not add it to the host"},{"line_number":11,"context_line":"   * because the url of the image must match the auth section of .docker/config.json"},{"line_number":12,"context_line":"   */}}"},{"line_number":13,"context_line":"{{- if eq $registryPort \"443\" -}}"},{"line_number":14,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $dockerAuthToken | b64enc }}"},{"line_number":15,"context_line":"{{- else -}}"},{"line_number":16,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s:%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $registryPort $dockerAuthToken | b64enc }}"},{"line_number":17,"context_line":"{{- end -}}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: Secret"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fce034c_52984269","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":11},"in_reply_to":"3fce034c_01a82e1d","updated":"2019-04-11 18:49:41.000000000","message":"Yeah, you are right. It\u0027s not allowed to put null for the port.","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"17bd61dac1023241fe05a50857891ad4d8714b32","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{{/* NOTE(pgaxatte): if we use the default registry port, we should not add it to the host"},{"line_number":11,"context_line":"   * because the url of the image must match the auth section of .docker/config.json"},{"line_number":12,"context_line":"   */}}"},{"line_number":13,"context_line":"{{- if eq $registryPort \"443\" -}}"},{"line_number":14,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $dockerAuthToken | b64enc }}"},{"line_number":15,"context_line":"{{- else -}}"},{"line_number":16,"context_line":"    {{- $dockerAuth \u003d printf \"{\\\"auths\\\": {\\\"%s:%s\\\": {\\\"auth\\\": \\\"%s\\\"}}}\" $registryHost $registryPort $dockerAuthToken | b64enc }}"},{"line_number":17,"context_line":"{{- end -}}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: Secret"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fce034c_01a82e1d","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":11},"in_reply_to":"3fce034c_fee01f99","updated":"2019-04-11 15:54:55.000000000","message":"The 5000 default port is OK I guess but setting the port null in the endpoint would probably break endpoint_port_lookup","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"}],"helm-toolkit/templates/snippets/_kubernetes_pod_rbac_serviceaccount.tpl":[{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"3ded3f21d4a3bcc73658c40fb67bf1b443e4893f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{{- $_ :\u003d set $allNamespace $saNamespace  (printf \"%s%s\" \"pods,\" ((index $allNamespace $saNamespace) | default \"\")) }}"},{"line_number":62,"context_line":"{{- end -}}"},{"line_number":63,"context_line":"{{- end -}}"},{"line_number":64,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":65,"context_line":"imagePullSecrets:"},{"line_number":66,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry $envAll.Chart.Name }}"},{"line_number":67,"context_line":"{{- end }}"},{"line_number":68,"context_line":"{{- $_ :\u003d unset $allNamespace $randomKey }}"},{"line_number":69,"context_line":"{{- range $ns, $vv :\u003d $allNamespace }}"},{"line_number":70,"context_line":"{{- $resourceList :\u003d (splitList \",\" (trimSuffix \",\" $vv)) }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fce034c_5ecb73a4","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":10},"updated":"2019-04-11 15:20:08.000000000","message":"It will be more readable if you can move this section right after the above namespace: {{ $saNamespace }} because this is part of serviceAccount template.","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"17bd61dac1023241fe05a50857891ad4d8714b32","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{{- $_ :\u003d set $allNamespace $saNamespace  (printf \"%s%s\" \"pods,\" ((index $allNamespace $saNamespace) | default \"\")) }}"},{"line_number":62,"context_line":"{{- end -}}"},{"line_number":63,"context_line":"{{- end -}}"},{"line_number":64,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":65,"context_line":"imagePullSecrets:"},{"line_number":66,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry $envAll.Chart.Name }}"},{"line_number":67,"context_line":"{{- end }}"},{"line_number":68,"context_line":"{{- $_ :\u003d unset $allNamespace $randomKey }}"},{"line_number":69,"context_line":"{{- range $ns, $vv :\u003d $allNamespace }}"},{"line_number":70,"context_line":"{{- $resourceList :\u003d (splitList \",\" (trimSuffix \",\" $vv)) }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fce034c_417396e8","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":10},"in_reply_to":"3fce034c_5ecb73a4","updated":"2019-04-11 15:54:55.000000000","message":"Done","commit_id":"1a6368306cc4cef1f699615dcb8cf9470c038917"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"8be64d47e6ad37b271f76bcfa9cef873b6308385","unresolved":false,"context_lines":[{"line_number":44,"context_line":"metadata:"},{"line_number":45,"context_line":"  name: {{ $saName }}"},{"line_number":46,"context_line":"  namespace: {{ $saNamespace }}"},{"line_number":47,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":48,"context_line":"imagePullSecrets:"},{"line_number":49,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry \"registry\" }}"},{"line_number":50,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7faddb67_643002ea","line":47,"updated":"2019-08-08 18:48:22.000000000","message":"This will fail if Values.endpoints.oci_image_registry.auth doesn\u0027t exist, and that\u0027s making the fluentbit chart fail build.  Although you probably want to add it to fluentbit, can we also make this check resilient against the key being missing, for the sake of backwards-compatibility?  There are out-of-tree consumers of this (airship) and it would be good to allow them to add this on their own timeline.","commit_id":"8118ba14f0f4591de4f51aee5342389edd4f08f7"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"85094f7dd8314407fcdb0463b83683ff66016e77","unresolved":false,"context_lines":[{"line_number":44,"context_line":"metadata:"},{"line_number":45,"context_line":"  name: {{ $saName }}"},{"line_number":46,"context_line":"  namespace: {{ $saNamespace }}"},{"line_number":47,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":48,"context_line":"imagePullSecrets:"},{"line_number":49,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry \"registry\" }}"},{"line_number":50,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7faddb67_3b4304b2","line":47,"in_reply_to":"7faddb67_643002ea","updated":"2019-08-09 06:58:26.000000000","message":"Indeed the key will be added everywhere but it doesn\u0027t hurt to add a check.","commit_id":"8118ba14f0f4591de4f51aee5342389edd4f08f7"}]}