)]}'
{"helm-toolkit/templates/manifests/_job-ks-user.yaml.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{- $serviceUser :\u003d index . \"serviceUser\" | default $serviceName -}}"},{"line_number":28,"context_line":"{{- $secretBin :\u003d index . \"secretBin\" | default false -}}"},{"line_number":29,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" | default false -}}"},{"line_number":30,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" | default false -}}"},{"line_number":31,"context_line":"{{- $serviceUserPretty :\u003d $serviceUser | replace \"_\" \"-\" -}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceUserPretty \"ks-user\" }}"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_39e5be09","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":77},"updated":"2019-07-16 19:09:57.000000000","message":"why would this default to a boolean?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{- $serviceUser :\u003d index . \"serviceUser\" | default $serviceName -}}"},{"line_number":28,"context_line":"{{- $secretBin :\u003d index . \"secretBin\" | default false -}}"},{"line_number":29,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" | default false -}}"},{"line_number":30,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" | default false -}}"},{"line_number":31,"context_line":"{{- $serviceUserPretty :\u003d $serviceUser | replace \"_\" \"-\" -}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceUserPretty \"ks-user\" }}"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_f442cbaa","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":77},"in_reply_to":"7faddb67_39e5be09","updated":"2019-07-16 20:49:32.000000000","message":"This defaults to a boolean because I didn\u0027t want to default it to 0.  0 is a valid value (means its disabled) and this function would insert \"activeDeadlineSeconds: 0\" into the chart\u0027s values, when it doesn\u0027t need to be there at all. So the user should pass \"false\" if they don\u0027t want to see the value at all, or specifies a specific value if they want to override.  My goal was to avoid changing the rendering of existing charts that use this function, if possible.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"f9d5d4d1585392896a8166447d873f918f0386ed","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{- $serviceUser :\u003d index . \"serviceUser\" | default $serviceName -}}"},{"line_number":28,"context_line":"{{- $secretBin :\u003d index . \"secretBin\" | default false -}}"},{"line_number":29,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" | default false -}}"},{"line_number":30,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" | default false -}}"},{"line_number":31,"context_line":"{{- $serviceUserPretty :\u003d $serviceUser | replace \"_\" \"-\" -}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceUserPretty \"ks-user\" }}"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_f7b05545","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":77},"in_reply_to":"7faddb67_f442cbaa","updated":"2019-07-19 18:29:16.000000000","message":"After thinking about it some more and doing some more testing, I removed the boolean false values as defaults, since gotpl will evaluate {{- if $backoffLimit }} to false if the parameter is not provided.  In the case of activeDeadlineSeconds, if the argument is not provided, or is provided with a value of 0, then {{- if $activeDeadlineSeconds }} evaluates to false, which is ok too.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{- if $backoffLimit }}"},{"line_number":98,"context_line":"  backoffLimit: {{ $backoffLimit }}"},{"line_number":99,"context_line":"{{- end }}"},{"line_number":100,"context_line":"{{- if $activeDeadlineSeconds }}"},{"line_number":101,"context_line":"  activeDeadlineSeconds: {{ $activeDeadlineSeconds }}"},{"line_number":102,"context_line":"{{- end }}"},{"line_number":103,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_f9eac6d5","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":53},"updated":"2019-07-16 19:09:57.000000000","message":"one is an integer and another is a boolean?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{- if $backoffLimit }}"},{"line_number":98,"context_line":"  backoffLimit: {{ $backoffLimit }}"},{"line_number":99,"context_line":"{{- end }}"},{"line_number":100,"context_line":"{{- if $activeDeadlineSeconds }}"},{"line_number":101,"context_line":"  activeDeadlineSeconds: {{ $activeDeadlineSeconds }}"},{"line_number":102,"context_line":"{{- end }}"},{"line_number":103,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_b41a13c9","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":53},"in_reply_to":"7faddb67_f9eac6d5","updated":"2019-07-16 20:49:32.000000000","message":"See explanation to your comment on line 30.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"}],"postgresql/templates/bin/_backup_postgresql.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export PGPASSFILE\u003d/etc/postgresql/admin_user.conf"},{"line_number":20,"context_line":"PG_DUMPALL_OPTIONS\u003d$POSTGRESQL_BACKUP_PG_DUMPALL_OPTIONS"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_19d1e223","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2019-07-16 19:09:57.000000000","message":"-e?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export PGPASSFILE\u003d/etc/postgresql/admin_user.conf"},{"line_number":20,"context_line":"PG_DUMPALL_OPTIONS\u003d$POSTGRESQL_BACKUP_PG_DUMPALL_OPTIONS"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_54ce3f2d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"7faddb67_19d1e223","updated":"2019-07-16 20:49:32.000000000","message":"I don\u0027t want to use -e because if one of the steps fails, I want to have the opportunity to issue a log statement of the proper format so that elasticsearch will pick it up and Nagios will be able to gather from elasticsearch logs that something failed.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"8bbb1dbc5bc827e4ef82c00a7d4357c92417a308","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      if [ \"$(days_difference $ARCHIVE_DATE)\" -gt \"$POSTGRESQL_BACKUP_DAYS_TO_KEEP\" ]"},{"line_number":91,"context_line":"      then"},{"line_number":92,"context_line":"        log INFO postgresql_backup \"Deleting file $ARCHIVE_FILE.\""},{"line_number":93,"context_line":"        rm -rf $ARCHIVE_FILE || log_backup_error_exit \"Cannot remove $ARCHIVE_FILE\""},{"line_number":94,"context_line":"      else"},{"line_number":95,"context_line":"        log INFO postgresql_backup \"Keeping file $ARCHIVE_FILE.\""},{"line_number":96,"context_line":"      fi"}],"source_content_type":"text/x-smarty","patch_set":56,"id":"7faddb67_14cab64e","line":93,"range":{"start_line":93,"start_character":32,"end_line":93,"end_character":53},"updated":"2019-07-22 20:10:00.000000000","message":"We could log the error and continue processing the rest of the archive files here","commit_id":"b34e37303b4851797f2e9b7be6f0c4be7d7ee14f"}],"postgresql/templates/bin/_common_backup_restore.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5b6971969c27a097d723cb118db7ae7e49c9ff27","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  SERVICE\u003d$2"},{"line_number":38,"context_line":"  MSG\u003d$3"},{"line_number":39,"context_line":"  DEST\u003d$4"},{"line_number":40,"context_line":"  #DATE\u003d$(date +\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":41,"context_line":"  DATE\u003d$(date +\"%m-%d-%y %H:%M:%S\")"},{"line_number":42,"context_line":"  if [ -z \"$DEST\" ]"},{"line_number":43,"context_line":"  then"}],"source_content_type":"text/x-smarty","patch_set":75,"id":"7faddb67_795c967c","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":37},"updated":"2019-08-19 15:17:51.000000000","message":"can probably remove","commit_id":"7a3e317f290cdd8378dc0aae54f55a7cf67c8b42"}],"postgresql/templates/bin/_remote_retrieve_postgresql.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6150637dc683b76dc36d8424a3b58a1ac5f38065","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":"RESTORE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/restore"},{"line_number":19,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"ffb9cba7_dc96ff3e","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":6},"updated":"2019-04-29 06:20:35.000000000","message":"xe?","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8bffbdbed4914a1306c5322ebea2b0f0ebfc28ce","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":"RESTORE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/restore"},{"line_number":19,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"ffb9cba7_4f4ecc97","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":6},"in_reply_to":"ffb9cba7_dc96ff3e","updated":"2019-04-29 12:54:19.000000000","message":"Fixed.","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RESTORE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/restore"},{"line_number":20,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_f9c3a655","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2019-07-16 19:09:57.000000000","message":"-e?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RESTORE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/restore"},{"line_number":20,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_d4fa2f41","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"7faddb67_f9c3a655","updated":"2019-07-16 20:49:32.000000000","message":"Cannot use -e because this script waits in a while loop for the next command from the other container.  If one command fails, it should not fail the container...it should be able to try to process the next command.  Also, the restore pod is an interactive pod; the user can execute multiple commands from the pod\u0027s terminal; that would be the reason for the while loop.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"03e045d7e85c14fa114b0eba40fb66d3161076fa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      if [[ $? !\u003d 0 ]]"},{"line_number":48,"context_line":"      then"},{"line_number":49,"context_line":"        echo \"Container object listing could not be obtained.\" \u003e\u003e $RESTORE_DIR/archive_list_error"},{"line_number":50,"context_line":"      else     "},{"line_number":51,"context_line":"        echo \"Archive listing successfully retrieved.\""},{"line_number":52,"context_line":"      fi"},{"line_number":53,"context_line":"    else"}],"source_content_type":"text/x-smarty","patch_set":99,"id":"1f493fa4_712292a6","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":15},"updated":"2020-04-22 14:32:59.000000000","message":"whitespace - causing the lint to fail","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a5c86968bd28eb9392ee028d8738469a68fc53f6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      if [[ $? !\u003d 0 ]]"},{"line_number":48,"context_line":"      then"},{"line_number":49,"context_line":"        echo \"Container object listing could not be obtained.\" \u003e\u003e $RESTORE_DIR/archive_list_error"},{"line_number":50,"context_line":"      else     "},{"line_number":51,"context_line":"        echo \"Archive listing successfully retrieved.\""},{"line_number":52,"context_line":"      fi"},{"line_number":53,"context_line":"    else"}],"source_content_type":"text/x-smarty","patch_set":99,"id":"1f493fa4_3763da1c","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":15},"in_reply_to":"1f493fa4_712292a6","updated":"2020-04-22 15:59:28.000000000","message":"Done","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"}],"postgresql/templates/bin/_remote_store_postgresql.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6150637dc683b76dc36d8424a3b58a1ac5f38065","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":"BACKUPS_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/current"},{"line_number":19,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"ffb9cba7_3c963b41","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2019-04-29 06:20:35.000000000","message":"should this be set -xe?","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8bffbdbed4914a1306c5322ebea2b0f0ebfc28ce","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":"BACKUPS_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/current"},{"line_number":19,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"ffb9cba7_6f539040","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"ffb9cba7_3c963b41","updated":"2019-04-29 12:54:19.000000000","message":"Fixed.","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BACKUPS_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/current"},{"line_number":20,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_19a482a5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2019-07-16 19:09:57.000000000","message":"set -xe?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BACKUPS_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/current"},{"line_number":20,"context_line":"ARCHIVE_DIR\u003d${POSTGRESQL_BACKUP_BASE_DIR}/db/${POSTGRESQL_POD_NAMESPACE}/postgres/archive"}],"source_content_type":"text/x-smarty","patch_set":52,"id":"7faddb67_74a1fb45","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"7faddb67_19a482a5","updated":"2019-07-16 20:49:32.000000000","message":"Cannot set -e here because of the same reasons given before - for proper error logging to elasticsearch/nagios.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"8bbb1dbc5bc827e4ef82c00a7d4357c92417a308","unresolved":false,"context_lines":[{"line_number":113,"context_line":"      if [ \"$(days_difference $ARCHIVE_DATE)\" -gt \"$POSTGRESQL_BACKUP_DAYS_TO_KEEP\" ]"},{"line_number":114,"context_line":"      then"},{"line_number":115,"context_line":"        log INFO postgresql_backup \"Deleting file $ARCHIVE_FILE from the RGW\""},{"line_number":116,"context_line":"        openstack object delete $CONTAINER_NAME $ARCHIVE_FILE || log_backup_error_exit \"Cannot delete container object $ARCHIVE_FILE!\""},{"line_number":117,"context_line":"      fi"},{"line_number":118,"context_line":"    done"},{"line_number":119,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":56,"id":"7faddb67_b7796494","line":116,"range":{"start_line":116,"start_character":65,"end_line":116,"end_character":86},"updated":"2019-07-22 20:10:00.000000000","message":"We could log and continue processing the rest of archive files","commit_id":"b34e37303b4851797f2e9b7be6f0c4be7d7ee14f"}],"postgresql/templates/configmap-bin.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  set_password.sh: {{ tuple \"bin/_set_password.sh.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc }}"},{"line_number":45,"context_line":"  patroni_conversion.sh: {{ tuple \"bin/_patroni_conversion.sh.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc }}"},{"line_number":46,"context_line":"{{- end }}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_99de320f","line":47,"updated":"2019-07-16 19:09:57.000000000","message":"extra line","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"}],"postgresql/templates/cron-job-backup-postgres.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  annotations:"},{"line_number":28,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"{{- if .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":31,"context_line":"  backoffLimit: {{ .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_59e43ae0","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":52},"updated":"2019-07-16 19:09:57.000000000","message":"is this .backoffLimit a bool or an integer?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  annotations:"},{"line_number":28,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"{{- if .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":31,"context_line":"  backoffLimit: {{ .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_f4a5eb47","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":52},"in_reply_to":"7faddb67_59e43ae0","updated":"2019-07-16 20:49:32.000000000","message":"If the user wants this value to be included in the chart, he passes an integer value. If not, he passes false value.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{- if .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":31,"context_line":"  backoffLimit: {{ .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"},{"line_number":34,"context_line":"  activeDeadlineSeconds: {{ .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"  schedule: {{ .Values.jobs.backup_postgresql.cron | quote }}"},{"line_number":37,"context_line":"  successfulJobsHistoryLimit: {{ .Values.jobs.backup_postgresql.history.success }}"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_19d24201","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":83},"updated":"2019-07-16 19:09:57.000000000","message":"should this be checking for existence instead of if 0?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{- if .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":31,"context_line":"  backoffLimit: {{ .Values.jobs.backup_postgresql.backoffLimit }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"},{"line_number":34,"context_line":"  activeDeadlineSeconds: {{ .Values.jobs.backup_postgresql.activeDeadlineSeconds }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"  schedule: {{ .Values.jobs.backup_postgresql.cron | quote }}"},{"line_number":37,"context_line":"  successfulJobsHistoryLimit: {{ .Values.jobs.backup_postgresql.history.success }}"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_746fbbfb","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":83},"in_reply_to":"7faddb67_19d24201","updated":"2019-07-16 20:49:32.000000000","message":"See previous comments from the helm-toolkit function definition.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"}],"postgresql/templates/job-ks-user.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_d9d7caed","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2019-07-16 19:09:57.000000000","message":"2019","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_1e50e50a","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"in_reply_to":"7faddb67_d9d7caed","updated":"2019-07-16 20:49:32.000000000","message":"Will fix.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"}],"postgresql/templates/secret-rgw.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_f9d406eb","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2019-07-16 19:09:57.000000000","message":"2019","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_7e16b94b","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"in_reply_to":"7faddb67_f9d406eb","updated":"2019-07-16 20:49:32.000000000","message":"Will fix.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"03e045d7e85c14fa114b0eba40fb66d3161076fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_adcb201c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"updated":"2020-04-22 14:32:59.000000000","message":"think Gage removed all these non existing (c).","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a5c86968bd28eb9392ee028d8738469a68fc53f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2019 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_374c7a9d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"1f493fa4_adcb201c","updated":"2020-04-22 15:59:28.000000000","message":"removed this as well","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"}],"postgresql/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  configmap_bin: true"},{"line_number":476,"context_line":"  configmap_etc: true"},{"line_number":477,"context_line":"  job_image_repo_sync: true"},{"line_number":478,"context_line":"  job_ks_user: true"},{"line_number":479,"context_line":"  secret_admin: true"},{"line_number":480,"context_line":"  secret_replica: true"},{"line_number":481,"context_line":"  secret_etc: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_d9458ab5","line":478,"range":{"start_line":478,"start_character":15,"end_line":478,"end_character":19},"updated":"2019-07-16 19:09:57.000000000","message":"should this be the other way round: where it is overwritten as true for the backup/restore job and default to false?","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  configmap_bin: true"},{"line_number":476,"context_line":"  configmap_etc: true"},{"line_number":477,"context_line":"  job_image_repo_sync: true"},{"line_number":478,"context_line":"  job_ks_user: true"},{"line_number":479,"context_line":"  secret_admin: true"},{"line_number":480,"context_line":"  secret_replica: true"},{"line_number":481,"context_line":"  secret_etc: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_74481b86","line":478,"range":{"start_line":478,"start_character":15,"end_line":478,"end_character":19},"in_reply_to":"7faddb67_d9458ab5","updated":"2019-07-16 20:49:32.000000000","message":"Yes, you\u0027re right. Should be false. Good catch.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":490,"context_line":"      job_user_create: true"},{"line_number":491,"context_line":"      secret_etc: true"},{"line_number":492,"context_line":"      service_exporter: true"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_19fb2279","line":493,"updated":"2019-07-16 19:09:57.000000000","message":"extra line","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":490,"context_line":"      job_user_create: true"},{"line_number":491,"context_line":"      secret_etc: true"},{"line_number":492,"context_line":"      service_exporter: true"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_1e02250b","line":493,"in_reply_to":"7faddb67_19fb2279","updated":"2019-07-16 20:49:32.000000000","message":"Will fix.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5b6971969c27a097d723cb118db7ae7e49c9ff27","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          memory: \"128Mi\""},{"line_number":121,"context_line":"          cpu: \"100m\""},{"line_number":122,"context_line":"        limits:"},{"line_number":123,"context_line":"          memory: \"128Mi\""},{"line_number":124,"context_line":"          cpu: \"2000m\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# using dockerhub patroni: https://hub.docker.com/r/openstackhelm/patroni/tags/"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"7faddb67_f98ac6b9","line":123,"range":{"start_line":123,"start_character":18,"end_line":123,"end_character":25},"updated":"2019-08-19 15:17:51.000000000","message":"should the limit be 1024Mi like the others?","commit_id":"7a3e317f290cdd8378dc0aae54f55a7cf67c8b42"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5b6971969c27a097d723cb118db7ae7e49c9ff27","unresolved":false,"context_lines":[{"line_number":177,"context_line":"          - endpoint: node"},{"line_number":178,"context_line":"            service: local_image_registry"},{"line_number":179,"context_line":"  static:"},{"line_number":180,"context_line":"    backup_postgresql:"},{"line_number":181,"context_line":"      jobs:"},{"line_number":182,"context_line":"        - postgresql-ks-user"},{"line_number":183,"context_line":"    tests:"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"7faddb67_99307209","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":22},"updated":"2019-08-19 15:17:51.000000000","message":"should this be static or dynamic depending if someone wants to use this backup? If someone want to use this chart without OpenStack and keystone, what would happen?","commit_id":"7a3e317f290cdd8378dc0aae54f55a7cf67c8b42"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"290d61c1fd7f79f69db806b10321335dd4eea268","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          memory: \"128Mi\""},{"line_number":121,"context_line":"          cpu: \"100m\""},{"line_number":122,"context_line":"        limits:"},{"line_number":123,"context_line":"          memory: \"128Mi\""},{"line_number":124,"context_line":"          cpu: \"2000m\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# using dockerhub patroni: https://hub.docker.com/r/openstackhelm/patroni/tags/"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"7faddb67_73510ad9","line":123,"range":{"start_line":123,"start_character":19,"end_line":123,"end_character":24},"updated":"2019-08-19 21:01:53.000000000","message":"Should be 1024Mi to match the other job limits for memory.","commit_id":"cb2b6e3c7ff0ee774d45dc2c6764374241e49706"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"7e9d9d5b24d997b3cdc0e00cb5da8018461494bb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          memory: \"128Mi\""},{"line_number":121,"context_line":"          cpu: \"100m\""},{"line_number":122,"context_line":"        limits:"},{"line_number":123,"context_line":"          memory: \"128Mi\""},{"line_number":124,"context_line":"          cpu: \"2000m\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# using dockerhub patroni: https://hub.docker.com/r/openstackhelm/patroni/tags/"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"7faddb67_c6ffcc63","line":123,"range":{"start_line":123,"start_character":19,"end_line":123,"end_character":24},"in_reply_to":"7faddb67_73510ad9","updated":"2019-08-20 15:05:04.000000000","message":"good catch.  will correct this.","commit_id":"cb2b6e3c7ff0ee774d45dc2c6764374241e49706"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ea521bb0f3ab7628437c75c83c62a9e6051ad8e1","unresolved":false,"context_lines":[{"line_number":179,"context_line":"  static:"},{"line_number":180,"context_line":"    backup_postgresql:"},{"line_number":181,"context_line":"      jobs:"},{"line_number":182,"context_line":"        - postgresql-ks-user"},{"line_number":183,"context_line":"    tests:"},{"line_number":184,"context_line":"      services:"},{"line_number":185,"context_line":"        - endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"7faddb67_fe9b7e13","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":28},"updated":"2019-08-20 03:19:24.000000000","message":"Should this be dynamic dependency? Postgresql generally does not depend on the keystone user","commit_id":"cb2b6e3c7ff0ee774d45dc2c6764374241e49706"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"b16352bd73fcd14003b69199ffa30ef098f9596a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"  static:"},{"line_number":180,"context_line":"    backup_postgresql:"},{"line_number":181,"context_line":"      jobs:"},{"line_number":182,"context_line":"        - postgresql-ks-user"},{"line_number":183,"context_line":"    tests:"},{"line_number":184,"context_line":"      services:"},{"line_number":185,"context_line":"        - endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"7faddb67_e2450d70","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":28},"in_reply_to":"7faddb67_fe9b7e13","updated":"2019-08-20 20:01:37.000000000","message":"I\u0027m not entirely sure. I cannot find any documentation on what the difference would be. If you know of anything that explains it, please let me know. I would like to avoid making a deployment-related change without knowing the effect of the change and knowing that what is in the current patch set works fine for both cases (ks-user required versus not required).","commit_id":"cb2b6e3c7ff0ee774d45dc2c6764374241e49706"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"03e045d7e85c14fa114b0eba40fb66d3161076fa","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    postgresql: \"docker.io/openstackhelm/patroni:latest-ubuntu_xenial\""},{"line_number":132,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":133,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":134,"context_line":"    ks_user: docker.io/openstackhelm/heat:ocata"},{"line_number":135,"context_line":"    prometheus_postgresql_exporter: docker.io/wrouesnel/postgres_exporter:v0.4.6"},{"line_number":136,"context_line":"    prometheus_postgresql_exporter_create_user: \"docker.io/postgres:9.5\""},{"line_number":137,"context_line":"    postgresql_remote_store: docker.io/openstackhelm/heat:ocata"}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_ed608835","line":134,"range":{"start_line":134,"start_character":43,"end_line":134,"end_character":47},"updated":"2020-04-22 14:32:59.000000000","message":"osh has moved to stein as default, we should probably do the same here","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a5c86968bd28eb9392ee028d8738469a68fc53f6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    postgresql: \"docker.io/openstackhelm/patroni:latest-ubuntu_xenial\""},{"line_number":132,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":133,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":134,"context_line":"    ks_user: docker.io/openstackhelm/heat:ocata"},{"line_number":135,"context_line":"    prometheus_postgresql_exporter: docker.io/wrouesnel/postgres_exporter:v0.4.6"},{"line_number":136,"context_line":"    prometheus_postgresql_exporter_create_user: \"docker.io/postgres:9.5\""},{"line_number":137,"context_line":"    postgresql_remote_store: docker.io/openstackhelm/heat:ocata"}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_d756f629","line":134,"range":{"start_line":134,"start_character":43,"end_line":134,"end_character":47},"in_reply_to":"1f493fa4_ed608835","updated":"2020-04-22 15:59:28.000000000","message":"done","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"03e045d7e85c14fa114b0eba40fb66d3161076fa","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    ks_user: docker.io/openstackhelm/heat:ocata"},{"line_number":135,"context_line":"    prometheus_postgresql_exporter: docker.io/wrouesnel/postgres_exporter:v0.4.6"},{"line_number":136,"context_line":"    prometheus_postgresql_exporter_create_user: \"docker.io/postgres:9.5\""},{"line_number":137,"context_line":"    postgresql_remote_store: docker.io/openstackhelm/heat:ocata"},{"line_number":138,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":139,"context_line":"  local_registry:"},{"line_number":140,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_8d4f44bc","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":63},"updated":"2020-04-22 14:32:59.000000000","message":"ditto","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a5c86968bd28eb9392ee028d8738469a68fc53f6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    ks_user: docker.io/openstackhelm/heat:ocata"},{"line_number":135,"context_line":"    prometheus_postgresql_exporter: docker.io/wrouesnel/postgres_exporter:v0.4.6"},{"line_number":136,"context_line":"    prometheus_postgresql_exporter_create_user: \"docker.io/postgres:9.5\""},{"line_number":137,"context_line":"    postgresql_remote_store: docker.io/openstackhelm/heat:ocata"},{"line_number":138,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":139,"context_line":"  local_registry:"},{"line_number":140,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":99,"id":"1f493fa4_37311a0d","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":63},"in_reply_to":"1f493fa4_8d4f44bc","updated":"2020-04-22 15:59:28.000000000","message":"done","commit_id":"4ba2aa9ba037afb15817ac88868a746a2db2d8e6"}],"tools/deployment/backup-restore/backup-restore-tests.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6150637dc683b76dc36d8424a3b58a1ac5f38065","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#!/bin/bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -xe"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"export POSTGRESQL_POD_NAMESPACE\u003dopenstack"},{"line_number":24,"context_line":"export BACKUP_PATH\u003d/var/backup"}],"source_content_type":"text/x-sh","patch_set":11,"id":"ffb9cba7_1c91f747","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":7},"updated":"2019-04-29 06:20:35.000000000","message":"?","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8bffbdbed4914a1306c5322ebea2b0f0ebfc28ce","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#!/bin/bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -xe"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"export POSTGRESQL_POD_NAMESPACE\u003dopenstack"},{"line_number":24,"context_line":"export BACKUP_PATH\u003d/var/backup"}],"source_content_type":"text/x-sh","patch_set":11,"id":"ffb9cba7_cf615c07","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":7},"in_reply_to":"ffb9cba7_1c91f747","updated":"2019-04-29 12:54:19.000000000","message":"removed the extra line and re-ordered the statements.","commit_id":"5ca465e722627880ac65628ea2fa1ab7912f8f73"}],"tools/deployment/backup-restore/postgresql-backup-restore-tests.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9ebffa29c2e9295e2625051d53d9edafbbe1d4a6","unresolved":false,"context_lines":[{"line_number":321,"context_line":"fi"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"# List the local and remote archives - there should be just one in each"},{"line_number":324,"context_line":"kubectl exec -it -n $POSTGRESQL_POD_NAMESPACE postgresql-restore -c postgresql-restore -- /bin/bash -x /tmp/restore_postgresql.sh list_archives | grep postgres.$POSTGRESQL_POD_NAMESPACE \u003e /tmp/remote"},{"line_number":325,"context_line":"if [[ $(cat /tmp/remote | wc -l) !\u003d 1 ]]"},{"line_number":326,"context_line":"then"},{"line_number":327,"context_line":"  echo Wrong number of archives in remote storage."}],"source_content_type":"text/x-sh","patch_set":75,"id":"7faddb67_84a482a4","line":324,"range":{"start_line":324,"start_character":12,"end_line":324,"end_character":16},"updated":"2019-08-19 17:27:48.000000000","message":"Do we need interactive -it flags for kubectl, the logs are complaining about TTY. Same applies to all the other kubectl -it instances.","commit_id":"7a3e317f290cdd8378dc0aae54f55a7cf67c8b42"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ef47eb42691ef689b32619e1b2fd4e1dc4ad04c0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - name: postgresql-backup-manual"},{"line_number":50,"context_line":"    command:"},{"line_number":51,"context_line":"    - sleep"},{"line_number":52,"context_line":"    - \"1000000\""},{"line_number":53,"context_line":"    image: ${POSTGRESQL_IMAGE_NAME}"},{"line_number":54,"context_line":"    env:"},{"line_number":55,"context_line":"    - name: POSTGRESQL_BACKUP_USER"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_62a35d44","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":14},"updated":"2019-08-20 19:58:22.000000000","message":"Is this value correct?","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"481aa7bceb0823f0818c59e37d83533dc0e46ea2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - name: postgresql-backup-manual"},{"line_number":50,"context_line":"    command:"},{"line_number":51,"context_line":"    - sleep"},{"line_number":52,"context_line":"    - \"1000000\""},{"line_number":53,"context_line":"    image: ${POSTGRESQL_IMAGE_NAME}"},{"line_number":54,"context_line":"    env:"},{"line_number":55,"context_line":"    - name: POSTGRESQL_BACKUP_USER"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_f87620a4","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":14},"in_reply_to":"7faddb67_62a35d44","updated":"2019-08-20 20:51:28.000000000","message":"it\u0027s about 11.5 days. Should be enough of a sleep to do a backup. It\u0027s an arbitrarily large value that we chose to make sure the container stays up during the duration of these tests.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3d4883f1a31ea0d2bd7a0cd532408be82af87733","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - name: postgresql-backup-manual"},{"line_number":50,"context_line":"    command:"},{"line_number":51,"context_line":"    - sleep"},{"line_number":52,"context_line":"    - \"1000000\""},{"line_number":53,"context_line":"    image: ${POSTGRESQL_IMAGE_NAME}"},{"line_number":54,"context_line":"    env:"},{"line_number":55,"context_line":"    - name: POSTGRESQL_BACKUP_USER"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_4225fec0","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":14},"in_reply_to":"7faddb67_f87620a4","updated":"2019-08-20 22:59:52.000000000","message":"Zuul would not allow something to stay around for 11.5 days - so this will be killed way before this it will remotely hit this.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"}],"tools/deployment/backup-restore/postgresql-local-backup-restore-tests.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"547ea2c6d12cc0f908eaae2a488008343ad1afc4","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# List the local archives - there should be just one archive"},{"line_number":179,"context_line":"kubectl exec -n $POSTGRESQL_POD_NAMESPACE postgresql-restore -c postgresql-restore -- /bin/bash -x /tmp/restore_postgresql.sh list_archives local | grep postgres.$POSTGRESQL_POD_NAMESPACE \u003e /tmp/local"},{"line_number":180,"context_line":"if [[ $(cat /tmp/local | wc -l) !\u003d 1 ]]"},{"line_number":181,"context_line":"then"},{"line_number":182,"context_line":"  echo Wrong number of archives in local storage."},{"line_number":183,"context_line":"  exit 1"},{"line_number":184,"context_line":"fi"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# List the databases in the local archive - should be one database"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_165188d9","line":183,"range":{"start_line":180,"start_character":0,"end_line":183,"end_character":8},"updated":"2019-08-21 04:57:41.000000000","message":"can we not directly check the content of the file instead of just generically checking the count?","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2645e1826296bff9df866d5f6f4bddd5d517aee3","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# List the local archives - there should be just one archive"},{"line_number":179,"context_line":"kubectl exec -n $POSTGRESQL_POD_NAMESPACE postgresql-restore -c postgresql-restore -- /bin/bash -x /tmp/restore_postgresql.sh list_archives local | grep postgres.$POSTGRESQL_POD_NAMESPACE \u003e /tmp/local"},{"line_number":180,"context_line":"if [[ $(cat /tmp/local | wc -l) !\u003d 1 ]]"},{"line_number":181,"context_line":"then"},{"line_number":182,"context_line":"  echo Wrong number of archives in local storage."},{"line_number":183,"context_line":"  exit 1"},{"line_number":184,"context_line":"fi"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# List the databases in the local archive - should be one database"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_5890864e","line":183,"range":{"start_line":180,"start_character":0,"end_line":183,"end_character":8},"in_reply_to":"7faddb67_165188d9","updated":"2019-08-21 14:12:53.000000000","message":"Well, at this point, the file is a zipped tar file. I check the content later after it\u0027s unzipped/untarred. Here, I\u0027m exercising the \"list_archives local\" command to be sure it\u0027s returning the correct output, which should be one file at this point.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"547ea2c6d12cc0f908eaae2a488008343ad1afc4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"# List the databases in the local archive - should be one database"},{"line_number":187,"context_line":"LOCAL_ARCHIVE\u003d`sed \u0027s/\\r//g\u0027 /tmp/local`"},{"line_number":188,"context_line":"kubectl exec -n $POSTGRESQL_POD_NAMESPACE postgresql-restore -c postgresql-restore -- /bin/bash -x /tmp/restore_postgresql.sh list_databases $LOCAL_ARCHIVE local \u003e /tmp/local"},{"line_number":189,"context_line":"sed -i -n \u0027/\u003d\u003d\u003d/,$p\u0027 /tmp/local"},{"line_number":190,"context_line":"sed -i \u00271d\u0027 /tmp/local"},{"line_number":191,"context_line":"if [[ $(cat /tmp/local | wc -l) !\u003d 1 ]]"},{"line_number":192,"context_line":"then"},{"line_number":193,"context_line":"  echo Wrong number of databases in local archive $LOCAL_ARCHIVE."},{"line_number":194,"context_line":"  exit 1"},{"line_number":195,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_5674e067","line":192,"range":{"start_line":189,"start_character":0,"end_line":192,"end_character":4},"updated":"2019-08-21 04:57:41.000000000","message":"can we not extract and compare the database name created instead of doing a count match, also why do we need these seds for comparison?","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2645e1826296bff9df866d5f6f4bddd5d517aee3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"# List the databases in the local archive - should be one database"},{"line_number":187,"context_line":"LOCAL_ARCHIVE\u003d`sed \u0027s/\\r//g\u0027 /tmp/local`"},{"line_number":188,"context_line":"kubectl exec -n $POSTGRESQL_POD_NAMESPACE postgresql-restore -c postgresql-restore -- /bin/bash -x /tmp/restore_postgresql.sh list_databases $LOCAL_ARCHIVE local \u003e /tmp/local"},{"line_number":189,"context_line":"sed -i -n \u0027/\u003d\u003d\u003d/,$p\u0027 /tmp/local"},{"line_number":190,"context_line":"sed -i \u00271d\u0027 /tmp/local"},{"line_number":191,"context_line":"if [[ $(cat /tmp/local | wc -l) !\u003d 1 ]]"},{"line_number":192,"context_line":"then"},{"line_number":193,"context_line":"  echo Wrong number of databases in local archive $LOCAL_ARCHIVE."},{"line_number":194,"context_line":"  exit 1"},{"line_number":195,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":79,"id":"7faddb67_33412b3a","line":192,"range":{"start_line":189,"start_character":0,"end_line":192,"end_character":4},"in_reply_to":"7faddb67_5674e067","updated":"2019-08-21 14:12:53.000000000","message":"Here I am exercising/testing the \"list_databases local\" command, to be sure that it returns one database. There are multiple output lines, so these seds remove the output lines before the line starting with \"\u003d\u003d\u003d\", and then the \"\u003d\u003d\u003d\" line itself, so that the only remaining lines are the lines containing database names.  Then I count those to be sure there are 1.  Next step is to verify database restoration, which verifies the content of the database archive.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"}],"tools/deployment/multinode/150-postgresql.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"547ea2c6d12cc0f908eaae2a488008343ad1afc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"7faddb67_5622a053","updated":"2019-08-21 04:57:41.000000000","message":"I don\u0027t think any of the existing gate job runs this script.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2645e1826296bff9df866d5f6f4bddd5d517aee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"7faddb67_d86316b0","in_reply_to":"7faddb67_5622a053","updated":"2019-08-21 14:12:53.000000000","message":"I added this job to the openstack-helm-infra job, which gets used when the multi-node jobs run.","commit_id":"602ff75270fbd7cecd3f4612b6ee814e18cf9e27"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"45e1595a13f44d408c766849680d514465d5053a","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        - ./tools/deployment/openstack-support/100-ceph-radosgateway.sh"},{"line_number":441,"context_line":"        - ./tools/deployment/backup-restore/130-postgresql.sh"},{"line_number":442,"context_line":"        - ./tools/deployment/backup-restore/backup-restore-tests.sh"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_1929e2e4","line":443,"range":{"start_line":443,"start_character":0,"end_line":443,"end_character":0},"updated":"2019-07-16 19:09:57.000000000","message":"extra line","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"c67e718ea400b1b13e96a5c555dda1c4a9a63e79","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        - ./tools/deployment/openstack-support/100-ceph-radosgateway.sh"},{"line_number":441,"context_line":"        - ./tools/deployment/backup-restore/130-postgresql.sh"},{"line_number":442,"context_line":"        - ./tools/deployment/backup-restore/backup-restore-tests.sh"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_340ce33f","line":443,"range":{"start_line":443,"start_character":0,"end_line":443,"end_character":0},"in_reply_to":"7faddb67_1929e2e4","updated":"2019-07-16 20:49:32.000000000","message":"Will fix.","commit_id":"b432e95c36cbc0b67b3a47b8ea33793bf5285c54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"db8b36f8ddb4496fec6e8482cd579d101d218587","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      - playbooks/osh-infra-upgrade-host.yaml"},{"line_number":148,"context_line":"      - playbooks/osh-infra-deploy-selenium.yaml"},{"line_number":149,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"},{"line_number":150,"context_line":"    required-projects:"},{"line_number":151,"context_line":"      - openstack/openstack-helm"},{"line_number":152,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":153,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":154,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"7faddb67_2edac4e8","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":32},"updated":"2019-07-25 17:17:36.000000000","message":"Not sure where this came from.  going to remove it","commit_id":"7b267fcc2f4d1efc91ecaada9a14c3ea0965465d"}]}