)]}'
{"mariadb/templates/deployment-error.yaml":[{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"7c2e84fbb682d9b969463b28d03f6d540849ed2a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":60,"context_line":"          command: [\"/bin/sh\", \"-c\"]"},{"line_number":61,"context_line":"          args:"},{"line_number":62,"context_line":"            - cp /server /tmp;"},{"line_number":63,"context_line":"              chown nobody:nobody /tmp/server;"},{"line_number":64,"context_line":"          volumeMounts:"},{"line_number":65,"context_line":"            - name: pod-tmp"},{"line_number":66,"context_line":"              mountPath: /tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_7f1153ac","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":45},"updated":"2019-05-21 16:58:21.000000000","message":"could be mounted as configmap scripts and make the values configuration driven","commit_id":"e36b1f2294d56230be200e16bf9f937dbd1a188c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"d88693bd20637df8829396c02461a19ba8ce3f9d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":60,"context_line":"          command: [\"/bin/sh\", \"-c\"]"},{"line_number":61,"context_line":"          args:"},{"line_number":62,"context_line":"            - cp /server /tmp;"},{"line_number":63,"context_line":"              chown nobody:nobody /tmp/server;"},{"line_number":64,"context_line":"          volumeMounts:"},{"line_number":65,"context_line":"            - name: pod-tmp"},{"line_number":66,"context_line":"              mountPath: /tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_3073c850","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":45},"in_reply_to":"bfb3d3c7_7f1153ac","updated":"2019-08-14 20:45:05.000000000","message":"Done","commit_id":"e36b1f2294d56230be200e16bf9f937dbd1a188c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"cc62c2dcb2509d7c24433519877a12c36c8df597","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            - name: ingress-bin"},{"line_number":66,"context_line":"              mountPath: /tmp/perms_update.sh"},{"line_number":67,"context_line":"              subPath: perms_update.sh"},{"line_number":68,"context_line":"              readOnly: false"},{"line_number":69,"context_line":"      containers:"},{"line_number":70,"context_line":"        - name: ingress-error-pages"},{"line_number":71,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_bdb1d003","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":29},"updated":"2019-08-14 23:01:11.000000000","message":"should this be true, or will perms_update.sh be modified?","commit_id":"8c5d079cf5e0a1f8bfb7236eabdc7305e648c3b8"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"ddf56150fe97efb8ef8280004c01ca1c68abfc65","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            - name: ingress-bin"},{"line_number":66,"context_line":"              mountPath: /tmp/perms_update.sh"},{"line_number":67,"context_line":"              subPath: perms_update.sh"},{"line_number":68,"context_line":"              readOnly: false"},{"line_number":69,"context_line":"      containers:"},{"line_number":70,"context_line":"        - name: ingress-error-pages"},{"line_number":71,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_d8304f58","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":29},"in_reply_to":"7faddb67_bdb1d003","updated":"2019-08-15 15:33:00.000000000","message":"good catch. Done","commit_id":"8c5d079cf5e0a1f8bfb7236eabdc7305e648c3b8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3091bcf10f8f9ed1775d8441811aab1aa37fbde2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      containers:"},{"line_number":57,"context_line":"        - name: ingress-error-pages"},{"line_number":58,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"error_pages\" \"container\" \"server\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          livenessProbe:"},{"line_number":62,"context_line":"            httpGet:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_c9eb4e0f","side":"PARENT","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":160},"updated":"2019-09-05 15:32:37.000000000","message":"why remove this?","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"5c6fe2150f14e5bfee67edf3a0d59da6ff51287d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      containers:"},{"line_number":57,"context_line":"        - name: ingress-error-pages"},{"line_number":58,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"error_pages\" \"container\" \"server\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          livenessProbe:"},{"line_number":62,"context_line":"            httpGet:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_ce70a5df","side":"PARENT","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":160},"in_reply_to":"5faad753_7fafe5e2","updated":"2019-09-11 22:22:43.000000000","message":"Done","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"16c095afe9085be1184eafd378869781011e3e54","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      containers:"},{"line_number":57,"context_line":"        - name: ingress-error-pages"},{"line_number":58,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"error_pages\" \"container\" \"server\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          livenessProbe:"},{"line_number":62,"context_line":"            httpGet:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_e9ee4ab3","side":"PARENT","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":160},"in_reply_to":"7faddb67_c9eb4e0f","updated":"2019-09-05 16:27:44.000000000","message":"This is removed because the container [0] already runs as nobody.\n\n[0] https://github.com/kubernetes/ingress-gce/blob/master/Dockerfile.404-server-with-metrics#L18","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c849fa69801732924daf6045a901b64261badf0d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      containers:"},{"line_number":57,"context_line":"        - name: ingress-error-pages"},{"line_number":58,"context_line":"{{ tuple $envAll \"error_pages\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":59,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"error_pages\" \"container\" \"server\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.error_pages | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          livenessProbe:"},{"line_number":62,"context_line":"            httpGet:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_7fafe5e2","side":"PARENT","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":160},"in_reply_to":"7faddb67_e9ee4ab3","updated":"2019-09-11 17:20:46.000000000","message":"this can affect a lot more than just the user that to the container is run as. Also, it explicitly defines the values rather than relying on defaults backed into the image, it would be much better to restore this.","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3091bcf10f8f9ed1775d8441811aab1aa37fbde2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            timeoutSeconds: 5"},{"line_number":68,"context_line":"          ports:"},{"line_number":69,"context_line":"            - containerPort: 8080"},{"line_number":70,"context_line":"          command:"},{"line_number":71,"context_line":"            - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":72,"context_line":"            - start"},{"line_number":73,"context_line":"          lifecycle:"},{"line_number":74,"context_line":"            preStop:"},{"line_number":75,"context_line":"              exec:"},{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                  - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":78,"context_line":"                  - stop"},{"line_number":79,"context_line":"          volumeMounts:"},{"line_number":80,"context_line":"            - name: pod-tmp"},{"line_number":81,"context_line":"              mountPath: /tmp"},{"line_number":82,"context_line":"            - name: ingress-bin"},{"line_number":83,"context_line":"              mountPath: /tmp/mariadb-ingress-error-pages.sh"},{"line_number":84,"context_line":"              subPath: mariadb-ingress-error-pages.sh"},{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"      volumes:"},{"line_number":87,"context_line":"        - name: pod-tmp"},{"line_number":88,"context_line":"          emptyDir: {}"},{"line_number":89,"context_line":"        - name: ingress-bin"},{"line_number":90,"context_line":"          configMap:"},{"line_number":91,"context_line":"            name: mariadb-bin"},{"line_number":92,"context_line":"            defaultMode: 0555"},{"line_number":93,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_09888668","side":"PARENT","line":92,"range":{"start_line":70,"start_character":0,"end_line":92,"end_character":29},"updated":"2019-09-05 15:32:37.000000000","message":"why remove this?","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"5c6fe2150f14e5bfee67edf3a0d59da6ff51287d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            timeoutSeconds: 5"},{"line_number":68,"context_line":"          ports:"},{"line_number":69,"context_line":"            - containerPort: 8080"},{"line_number":70,"context_line":"          command:"},{"line_number":71,"context_line":"            - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":72,"context_line":"            - start"},{"line_number":73,"context_line":"          lifecycle:"},{"line_number":74,"context_line":"            preStop:"},{"line_number":75,"context_line":"              exec:"},{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                  - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":78,"context_line":"                  - stop"},{"line_number":79,"context_line":"          volumeMounts:"},{"line_number":80,"context_line":"            - name: pod-tmp"},{"line_number":81,"context_line":"              mountPath: /tmp"},{"line_number":82,"context_line":"            - name: ingress-bin"},{"line_number":83,"context_line":"              mountPath: /tmp/mariadb-ingress-error-pages.sh"},{"line_number":84,"context_line":"              subPath: mariadb-ingress-error-pages.sh"},{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"      volumes:"},{"line_number":87,"context_line":"        - name: pod-tmp"},{"line_number":88,"context_line":"          emptyDir: {}"},{"line_number":89,"context_line":"        - name: ingress-bin"},{"line_number":90,"context_line":"          configMap:"},{"line_number":91,"context_line":"            name: mariadb-bin"},{"line_number":92,"context_line":"            defaultMode: 0555"},{"line_number":93,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_6e7731d6","side":"PARENT","line":92,"range":{"start_line":70,"start_character":0,"end_line":92,"end_character":29},"in_reply_to":"5faad753_dff619fa","updated":"2019-09-11 22:22:43.000000000","message":"Done","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"16c095afe9085be1184eafd378869781011e3e54","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            timeoutSeconds: 5"},{"line_number":68,"context_line":"          ports:"},{"line_number":69,"context_line":"            - containerPort: 8080"},{"line_number":70,"context_line":"          command:"},{"line_number":71,"context_line":"            - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":72,"context_line":"            - start"},{"line_number":73,"context_line":"          lifecycle:"},{"line_number":74,"context_line":"            preStop:"},{"line_number":75,"context_line":"              exec:"},{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                  - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":78,"context_line":"                  - stop"},{"line_number":79,"context_line":"          volumeMounts:"},{"line_number":80,"context_line":"            - name: pod-tmp"},{"line_number":81,"context_line":"              mountPath: /tmp"},{"line_number":82,"context_line":"            - name: ingress-bin"},{"line_number":83,"context_line":"              mountPath: /tmp/mariadb-ingress-error-pages.sh"},{"line_number":84,"context_line":"              subPath: mariadb-ingress-error-pages.sh"},{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"      volumes:"},{"line_number":87,"context_line":"        - name: pod-tmp"},{"line_number":88,"context_line":"          emptyDir: {}"},{"line_number":89,"context_line":"        - name: ingress-bin"},{"line_number":90,"context_line":"          configMap:"},{"line_number":91,"context_line":"            name: mariadb-bin"},{"line_number":92,"context_line":"            defaultMode: 0555"},{"line_number":93,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_2c947043","side":"PARENT","line":92,"range":{"start_line":70,"start_character":0,"end_line":92,"end_character":29},"in_reply_to":"7faddb67_09888668","updated":"2019-09-05 16:27:44.000000000","message":"There is no need to exec a command to start/stop the server with this image [0]. The server that runs with this image [0] takes args, starts and also handles a graceful shutdown so no need for the preStop/stop, and volume mounts, etc.\n\n[0] https://github.com/kubernetes/ingress-gce/blob/master/Dockerfile.404-server-with-metrics","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c849fa69801732924daf6045a901b64261badf0d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            timeoutSeconds: 5"},{"line_number":68,"context_line":"          ports:"},{"line_number":69,"context_line":"            - containerPort: 8080"},{"line_number":70,"context_line":"          command:"},{"line_number":71,"context_line":"            - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":72,"context_line":"            - start"},{"line_number":73,"context_line":"          lifecycle:"},{"line_number":74,"context_line":"            preStop:"},{"line_number":75,"context_line":"              exec:"},{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                  - /tmp/mariadb-ingress-error-pages.sh"},{"line_number":78,"context_line":"                  - stop"},{"line_number":79,"context_line":"          volumeMounts:"},{"line_number":80,"context_line":"            - name: pod-tmp"},{"line_number":81,"context_line":"              mountPath: /tmp"},{"line_number":82,"context_line":"            - name: ingress-bin"},{"line_number":83,"context_line":"              mountPath: /tmp/mariadb-ingress-error-pages.sh"},{"line_number":84,"context_line":"              subPath: mariadb-ingress-error-pages.sh"},{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"      volumes:"},{"line_number":87,"context_line":"        - name: pod-tmp"},{"line_number":88,"context_line":"          emptyDir: {}"},{"line_number":89,"context_line":"        - name: ingress-bin"},{"line_number":90,"context_line":"          configMap:"},{"line_number":91,"context_line":"            name: mariadb-bin"},{"line_number":92,"context_line":"            defaultMode: 0555"},{"line_number":93,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_dff619fa","side":"PARENT","line":92,"range":{"start_line":70,"start_character":0,"end_line":92,"end_character":29},"in_reply_to":"7faddb67_2c947043","updated":"2019-09-11 17:20:46.000000000","message":"again, it would be best to retain the explicit declaration of the commands, both to ensure that control is maintained, and we maintain consistency will all other charts within osh-infra.","commit_id":"49c8c744acf5671e053a83ac6c6d73b34c941600"}],"mariadb/values.yaml":[{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"7c2e84fbb682d9b969463b28d03f6d540849ed2a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          runAsUser: 99"},{"line_number":86,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":87,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":88,"context_line":"        ingress-error-pages-perms-init:"},{"line_number":89,"context_line":"          runAsUser: 0"},{"line_number":90,"context_line":"    prometheus_mysql_exporter:"},{"line_number":91,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_5f356f45","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":38},"updated":"2019-05-21 16:58:21.000000000","message":"This should match the container name in the deployment yaml ?","commit_id":"e36b1f2294d56230be200e16bf9f937dbd1a188c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"d88693bd20637df8829396c02461a19ba8ce3f9d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          runAsUser: 99"},{"line_number":86,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":87,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":88,"context_line":"        ingress-error-pages-perms-init:"},{"line_number":89,"context_line":"          runAsUser: 0"},{"line_number":90,"context_line":"    prometheus_mysql_exporter:"},{"line_number":91,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_907abc21","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":38},"in_reply_to":"bfb3d3c7_5f356f45","updated":"2019-08-14 20:45:05.000000000","message":"Done. This was fixed in the deployment yaml.","commit_id":"e36b1f2294d56230be200e16bf9f937dbd1a188c"}]}