)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"1b12a9341f9a177cc1e604662c6084ed17bb9f7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Krishna Venkata \u003ckvenkata986@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-17 22:00:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parameterize updateStrategy values for "},{"line_number":8,"context_line":"Ceph components. Making it customizable for future."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bfb3d3c7_6f4a3381","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"updated":"2019-05-17 22:05:52.000000000","message":"Remove space","commit_id":"c25362fdb754093883642e562743bcd1e9ca25d2"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"20528a06079d976e48717a60348ab01ffd7d2a70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Krishna Venkata \u003ckvenkata986@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-17 22:00:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parameterize updateStrategy values for "},{"line_number":8,"context_line":"Ceph components. Making it customizable for future."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bfb3d3c7_2160cfce","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"in_reply_to":"bfb3d3c7_6f4a3381","updated":"2019-05-17 22:34:14.000000000","message":"Done","commit_id":"c25362fdb754093883642e562743bcd1e9ca25d2"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"63e8564c569ba3634f2090cf78dd249fba7d060b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Krishna Venkata \u003ckvenkata986@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-22 19:43:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from default values being populated "},{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_75901296","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"updated":"2019-05-29 15:14:56.000000000","message":"Extra space","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"2066c39709c2f95dfd473725d7e22cd29a9edac7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Krishna Venkata \u003ckvenkata986@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-22 19:43:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from default values being populated "},{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_95710647","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"in_reply_to":"bfb3d3c7_75901296","updated":"2019-05-29 15:22:02.000000000","message":"Done","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"63e8564c569ba3634f2090cf78dd249fba7d060b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch from default values being populated "},{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "},{"line_number":11,"context_line":"upgrade strategy parameters to ceph Components "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_35ecda28","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":41},"updated":"2019-05-29 15:14:56.000000000","message":"Extra space","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"2066c39709c2f95dfd473725d7e22cd29a9edac7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch from default values being populated "},{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "},{"line_number":11,"context_line":"upgrade strategy parameters to ceph Components "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_35929a4d","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":41},"in_reply_to":"bfb3d3c7_35ecda28","updated":"2019-05-29 15:22:02.000000000","message":"Done","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"63e8564c569ba3634f2090cf78dd249fba7d060b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "},{"line_number":11,"context_line":"upgrade strategy parameters to ceph Components "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_f5f16202","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":47},"updated":"2019-05-29 15:14:56.000000000","message":"Extra space","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"2066c39709c2f95dfd473725d7e22cd29a9edac7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"for upgrade strategy for ceph components"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This PS uses HelmToolKit function to add "},{"line_number":11,"context_line":"upgrade strategy parameters to ceph Components "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54e71d2a52bd639b3e93fc899c1bf2cd075b5396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_5595ce31","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":47},"in_reply_to":"bfb3d3c7_f5f16202","updated":"2019-05-29 15:22:02.000000000","message":"Done","commit_id":"dde88e29110eb43998c6f8d33f4e117fee6e3b24"}],"ceph-client/templates/deployment-mds.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"603946a5747768c737492ed400b2d65c9549df44","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"ceph\" \"mds\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  updateStrategy:"},{"line_number":37,"context_line":"    type: {{ .Values.pod.updateStrategy.mds.type }}"},{"line_number":38,"context_line":"    rollingUpdate:"},{"line_number":39,"context_line":"      maxSurge: {{ .Values.pod.updateStrategy.mds.rollingUpdate.maxSurge }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_840df791","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"updated":"2019-05-20 15:19:18.000000000","message":"Are you sure that Deployment kind has `updateStrategy` field? I may miss something, but looking at the docs [1] I only can see this field for Daemonsets and Statefulsets.\n\n[1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#daemonset-v1-apps","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"9f2d24b998f1aea7b9afe0238c5ff251e387f43d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"ceph\" \"mds\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  updateStrategy:"},{"line_number":37,"context_line":"    type: {{ .Values.pod.updateStrategy.mds.type }}"},{"line_number":38,"context_line":"    rollingUpdate:"},{"line_number":39,"context_line":"      maxSurge: {{ .Values.pod.updateStrategy.mds.rollingUpdate.maxSurge }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_dfd17859","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"in_reply_to":"bfb3d3c7_840df791","updated":"2019-05-20 15:41:52.000000000","message":"updateStrategy also works, was able to generate yaml and deploy GF/BF. anyways i am updating it to strategy","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"}],"ceph-client/templates/deployment-mgr.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"603946a5747768c737492ed400b2d65c9549df44","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"ceph\" \"mgr\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  strategy:"},{"line_number":37,"context_line":"    type: {{ .Values.pod.updateStrategy.mgr.type }}"},{"line_number":38,"context_line":"  template:"},{"line_number":39,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_4455bf4f","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":10},"updated":"2019-05-20 15:19:18.000000000","message":"It may make sense to extracted this into a snippet analogues to how it is done for daemonsets (helm-toolkit.snippets.kubernetes_upgrades_daemonset)?","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"9f2d24b998f1aea7b9afe0238c5ff251e387f43d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"ceph\" \"mgr\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  strategy:"},{"line_number":37,"context_line":"    type: {{ .Values.pod.updateStrategy.mgr.type }}"},{"line_number":38,"context_line":"  template:"},{"line_number":39,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_7f708c73","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":10},"in_reply_to":"bfb3d3c7_4455bf4f","updated":"2019-05-20 15:41:52.000000000","message":"checking on this","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"0e4ae405f5f1fa8d4eb118dbcd77abfefa5b0032","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"ceph\" \"mgr\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  strategy:"},{"line_number":37,"context_line":"    type: {{ .Values.pod.updateStrategy.mgr.type }}"},{"line_number":38,"context_line":"  template:"},{"line_number":39,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_7ff5ecca","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":10},"in_reply_to":"bfb3d3c7_7f708c73","updated":"2019-05-20 15:43:27.000000000","message":"I\u0027ve just found out that this snippet is already implemented `helm-toolkit.snippets.kubernetes_upgrades_deployment`.","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"}],"ceph-client/values.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"c187df0950148de1d4f9ab580320eee7efcf43ae","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        rolling_update:"},{"line_number":107,"context_line":"          max_surge: 25%"},{"line_number":108,"context_line":"          max_unavailable: 25%"},{"line_number":109,"context_line":"  updateStrategy:"},{"line_number":110,"context_line":"    mgr:"},{"line_number":111,"context_line":"      type: Recreate"},{"line_number":112,"context_line":"  affinity:"},{"line_number":113,"context_line":"    anti:"},{"line_number":114,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_569f9c02","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":20},"updated":"2019-05-21 15:10:19.000000000","message":"I\u0027m wondering how hard it would be to have two parameters subtrees mds and mdr for lifecycle and then using some gotemplate magic (e.g. using dict) to use correct context for `kubernetes_upgrades_deployment` snippet.","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"37ce2ca06a075ec007fd3434779ea16472e3dd5b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        rolling_update:"},{"line_number":107,"context_line":"          max_surge: 25%"},{"line_number":108,"context_line":"          max_unavailable: 25%"},{"line_number":109,"context_line":"  updateStrategy:"},{"line_number":110,"context_line":"    mgr:"},{"line_number":111,"context_line":"      type: Recreate"},{"line_number":112,"context_line":"  affinity:"},{"line_number":113,"context_line":"    anti:"},{"line_number":114,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_b9504b0c","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":20},"in_reply_to":"bfb3d3c7_569f9c02","updated":"2019-05-21 15:19:08.000000000","message":"The reason for this question, is it would be impossible to change it to e.g. `RollingUpdate` with some custom max_surge override.","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"f1bc12d7c0232de4af7b4dd9d5dd8b871987f8eb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        rolling_update:"},{"line_number":107,"context_line":"          max_surge: 25%"},{"line_number":108,"context_line":"          max_unavailable: 25%"},{"line_number":109,"context_line":"  updateStrategy:"},{"line_number":110,"context_line":"    mgr:"},{"line_number":111,"context_line":"      type: Recreate"},{"line_number":112,"context_line":"  affinity:"},{"line_number":113,"context_line":"    anti:"},{"line_number":114,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_6f34c5de","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":20},"in_reply_to":"bfb3d3c7_842b9e2e","updated":"2019-05-29 14:02:58.000000000","message":"I see, if this is something that requires a refactoring, it may make sense to do it in a separate patchset, let\u0027s see what other reviewers think about this.","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"1ee3c80c97f6b3030646684851d2c4e0ba5a3229","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        rolling_update:"},{"line_number":107,"context_line":"          max_surge: 25%"},{"line_number":108,"context_line":"          max_unavailable: 25%"},{"line_number":109,"context_line":"  updateStrategy:"},{"line_number":110,"context_line":"    mgr:"},{"line_number":111,"context_line":"      type: Recreate"},{"line_number":112,"context_line":"  affinity:"},{"line_number":113,"context_line":"    anti:"},{"line_number":114,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bfb3d3c7_842b9e2e","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":20},"in_reply_to":"bfb3d3c7_b9504b0c","updated":"2019-05-21 16:01:17.000000000","message":"yes, We could have that, I wrote the code for that, but it was failing with other charts since they don\u0027t have component in values.yaml. all existing charts using this  helm-toolkit.snippets.kubernetes_upgrades_deployment should be modified to include new component variable. when i did, \nsample code \n{{- $component :\u003d index . 1 -}}\n{{- $upgradeMap :\u003d index $envAll.Values.pod.lifecycle.upgrades.deployments $component -}}\n{{- with $upgradeMap -}}","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"}],"ceph-mon/templates/daemonset-mon.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"603946a5747768c737492ed400b2d65c9549df44","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  selector:"},{"line_number":60,"context_line":"    matchLabels:"},{"line_number":61,"context_line":"{{ tuple $envAll \"ceph\" \"mon\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":62,"context_line":"  updateStrategy:"},{"line_number":63,"context_line":"    type: {{ .Values.pod.updateStrategy.type }}"},{"line_number":64,"context_line":"    rollingUpdate:"},{"line_number":65,"context_line":"      maxUnavailable: {{ .Values.pod.updateStrategy.rollingUpdate.maxUnavailable }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_2418cb1b","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":16},"updated":"2019-05-20 15:19:18.000000000","message":"Can we use helm-toolkit.snippets.kubernetes_upgrades_daemonset snippet here? Same for all other daemonsets that you change.","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"9f2d24b998f1aea7b9afe0238c5ff251e387f43d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  selector:"},{"line_number":60,"context_line":"    matchLabels:"},{"line_number":61,"context_line":"{{ tuple $envAll \"ceph\" \"mon\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":62,"context_line":"  updateStrategy:"},{"line_number":63,"context_line":"    type: {{ .Values.pod.updateStrategy.type }}"},{"line_number":64,"context_line":"    rollingUpdate:"},{"line_number":65,"context_line":"      maxUnavailable: {{ .Values.pod.updateStrategy.rollingUpdate.maxUnavailable }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_df0418c9","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":16},"in_reply_to":"bfb3d3c7_2418cb1b","updated":"2019-05-20 15:41:52.000000000","message":"will update","commit_id":"32a14b7098d4844aa14fb305c0e6f3efa8c25f35"}],"helm-toolkit/templates/snippets/_kubernetes_upgrades_deployment.tpl":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"c187df0950148de1d4f9ab580320eee7efcf43ae","unresolved":false,"context_lines":[{"line_number":20,"context_line":"revisionHistoryLimit: {{ .revision_history }}"},{"line_number":21,"context_line":"strategy:"},{"line_number":22,"context_line":"  {{- if eq .pod_replacement_strategy \"RollingUpdate\" }}"},{"line_number":23,"context_line":"  type: {{ .pod_replacement_strategy }}"},{"line_number":24,"context_line":"  rollingUpdate:"},{"line_number":25,"context_line":"    maxUnavailable: {{ .rolling_update.max_unavailable }}"},{"line_number":26,"context_line":"    maxSurge: {{ .rolling_update.max_surge }}"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"bfb3d3c7_f3fd82b1","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":39},"updated":"2019-05-21 15:10:19.000000000","message":"Can you please clarify what was the purpose to move this into `if` and duplicate it below? Both of these cases would be handled if `type` stayed outside of the `if`.","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"},{"author":{"_account_id":29132,"name":"Krishna Venkata","email":"kvenkata986@gmail.com","username":"kvenkata986"},"change_message_id":"1ee3c80c97f6b3030646684851d2c4e0ba5a3229","unresolved":false,"context_lines":[{"line_number":20,"context_line":"revisionHistoryLimit: {{ .revision_history }}"},{"line_number":21,"context_line":"strategy:"},{"line_number":22,"context_line":"  {{- if eq .pod_replacement_strategy \"RollingUpdate\" }}"},{"line_number":23,"context_line":"  type: {{ .pod_replacement_strategy }}"},{"line_number":24,"context_line":"  rollingUpdate:"},{"line_number":25,"context_line":"    maxUnavailable: {{ .rolling_update.max_unavailable }}"},{"line_number":26,"context_line":"    maxSurge: {{ .rolling_update.max_surge }}"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"bfb3d3c7_e4c93a78","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":39},"in_reply_to":"bfb3d3c7_f3fd82b1","updated":"2019-05-21 16:01:17.000000000","message":"yes, no difference.","commit_id":"2f97b04f894ee20ae310deef3422df96644696ef"}]}