)]}'
{"rabbitmq/templates/statefulset.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"527b8a4494485cd81d64e868ea93c189607273f3","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_ec52153b","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"updated":"2019-05-28 16:40:58.000000000","message":"Can we handle this with similar keys to the mariadb chart?  While I think this behavior is a value add overall, I\u0027m worried about the potential for key sprawl between charts here.  It\u0027d be nice to standardize on a specific key to use that\u0027s applicable across all charts","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"6405e5c928ee6fb1c58ed8e6f5b8477486c2135d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_e175eacd","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_2ecd4584","updated":"2019-05-31 22:37:54.000000000","message":"That make it much clear. first simple fix, then followup story to refactor it for more global consistency. thanks for giving a good opinion.","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"b7761ce31d5d4aea6542a2db50bdc1634e0a6450","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_a72aaa8d","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_2ecd4584","updated":"2019-05-31 16:24:06.000000000","message":"That\u0027s a fair ask.  I\u0027ll remove my -1 and +1 this change then","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1461fed7842d9bc4c766c190ccfdd0426be78025","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_63284796","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_52e72bad","updated":"2019-05-30 15:40:15.000000000","message":"I\u0027m wondering if it makes sense to restructure the .Values.volume (or .Values.storage) key to accommodate this behavior.  In my mind, it\u0027d be clean to do something like .Values.storage.volume.foo and .Values.storage.host_path.foo.  This way these checks ultimately become:\n\n        {{- if not $envAll.Values.storage.volume.enabled }}\n        - name: rabbitmq-data\n        {{- if .Values.storage.host_path.enabled }}\n          hostPath:\n            path:  {{ .Values.storage.host_path.path }}\n            type: DirectoryOrCreate\n        {{- else }}\n          emptyDir: {}\n        {{- end }}\n        {{- end }}\n{{- if $envAll.Values.storage.volume.enabled }}\n  volumeClaimTemplates:\n    - metadata:\n        name: rabbitmq-data\n      spec:\n        accessModes: [ \"ReadWriteOnce\" ]\n        resources:\n          requests:\n            storage: {{ $envAll.Values.storage.volume.size }}\n        storageClassName: {{ $envAll.Values.storage.volume.class_name }}\n{{- end }}\n{{ end }}\n\nOr something along those lines.  I think this approach makes the storage interface for charts cleaner and more readable, and would be a good way for someone to contribute a change across all charts to standardize the way we handle this interface","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"8d058a3737db4bdcfc67ae55baf04dce151ffe47","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_2ecd4584","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_63284796","updated":"2019-05-31 09:53:56.000000000","message":"I guess if this needs to be a really big refactor, this should be done in another patch. Here this provides a simple fix, and what you are proposing could deserve a better \"global way\" to do things, which sound a great follow-up item.","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"4bc004339cc080e8f9962776efe3c8f504e06574","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_52e72bad","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_77b4a1d1","updated":"2019-05-29 09:10:25.000000000","message":"In one production case at my company, we are using hostpath for both mariadb and rabbitmq since there is no external storage available. but, we confirmed that all the ha stuff is working well. having said that, IMHO, it will probably make sense to change mariadb var less specific. :)","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"6442863aba495c4edfa98ed5bd5fe78c3353e150","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_fcedd8b6","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_ec52153b","updated":"2019-05-29 07:07:08.000000000","message":"I agree on key sprawl. \nmariadb uses \"use_local_path_for_single_pod_cluster\" and rabbitmq uses \"use_local_path\". In my opinion, since this is not really only for single pod cluster, more generic name would be good. \n\nSteve, do you have any suggestion?","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5bf3bd6df3c90fb2dd8db0e94982409f2aac1a61","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_1cb0ec42","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_ec52153b","updated":"2019-05-29 06:34:42.000000000","message":"good that helm3 will have a schema validator... ahem.\nElse I agree on key sprawl with Steve. Steve, in those case, can you propose an alternative?","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"a117a1ee2a1b77abc7cb2bea51aa9a5902f020f0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            defaultMode: 0444"},{"line_number":248,"context_line":"        {{- if not $envAll.Values.volume.enabled }}"},{"line_number":249,"context_line":"        - name: rabbitmq-data"},{"line_number":250,"context_line":"        {{- if .Values.volume.use_local_path.enabled }}"},{"line_number":251,"context_line":"          hostPath:"},{"line_number":252,"context_line":"            path:  {{ .Values.volume.use_local_path.host_path }}"},{"line_number":253,"context_line":"            type: DirectoryOrCreate"},{"line_number":254,"context_line":"        {{- else }}"},{"line_number":255,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_77b4a1d1","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":64},"in_reply_to":"bfb3d3c7_fcedd8b6","updated":"2019-05-29 08:02:10.000000000","message":"Agreed, this is similar but different use case. Maybe we should instead change the mariadb var to make it less specific instead?","commit_id":"9ddc98746c64ca5dd980dabb04ccaa8928b4215d"}]}