)]}'
{"id":"openstack%2Fopenstack-helm-infra~662603","triplet_id":"openstack%2Fopenstack-helm-infra~master~I786ff6c7aa5fb6b08b54d2e21878551e5e1e3818","project":"openstack/openstack-helm-infra","branch":"master","topic":"hugepages-htk","hashtags":[],"change_id":"I786ff6c7aa5fb6b08b54d2e21878551e5e1e3818","subject":"Enable hugepage support in HTK resources snippet","status":"MERGED","created":"2019-06-01 07:41:00.000000000","updated":"2019-06-11 23:41:57.000000000","submitted":"2019-06-11 23:41:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662603-1560296517159-91b8215b","meta_rev_id":"96fbb8d37cffecd5cf102e5ffbab6da2f948706f","_number":662603,"virtual_id_number":662603,"owner":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-06-11 13:49:22.000000000","_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2019-06-11 23:41:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"all":[{"value":0,"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"},{"value":2,"date":"2019-06-05 09:50:28.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},{"value":1,"date":"2019-06-05 12:47:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-05 14:52:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},{"value":2,"date":"2019-06-11 22:06:42.000000000","_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"all":[{"value":0,"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},{"value":0,"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},{"value":1,"date":"2019-06-11 22:06:42.000000000","_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"},{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},{"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},{"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-01 07:42:53.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-06-01 07:43:06.000000000","updated_by":{"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"},"reviewer":{"_account_id":17966,"name":"Steven Wilkerson","email":"srwilkers@outlook.com","username":"srwilker"},"state":"REVIEWER"},{"updated":"2019-06-01 08:10:23.000000000","updated_by":{"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"},"reviewer":{"_account_id":30329,"name":"Om Prakash","email":"op317q@att.com","username":"op317q"},"state":"REVIEWER"},{"updated":"2019-06-02 04:14:55.000000000","updated_by":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"reviewer":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"state":"REVIEWER"},{"updated":"2019-06-03 08:03:50.000000000","updated_by":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"reviewer":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"state":"REVIEWER"},{"updated":"2019-06-05 09:50:28.000000000","updated_by":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"reviewer":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"state":"REVIEWER"},{"updated":"2019-06-05 12:47:20.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-06-05 14:52:01.000000000","updated_by":{"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},"reviewer":{"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},"state":"REVIEWER"},{"updated":"2019-06-11 22:06:42.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2019-06-11 23:41:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"105c375176d03b2e64a3bc9c1a17a730f0765df0","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-01 07:41:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a9ba2f42001b0a6971dce6de4975c3e90e0ec1b","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-01 08:11:48.000000000","message":"Patch Set 1: Code-Review-1\n\nThinking about this, I\u0027d like to correct my previous statement. One purpose of the checks is to sanitize the resource which should be considered by K8s. Without the checks, non-sensical / non-existing resoures can end up in this section, resulting in pod remaining in pending state. In case of a typo in the resource definition (e.g., hugepages-2M instead of hugepages-2Mi), the pod remains in pending state until hugepages-2M become available which will never be the case. With checks in place, the hugepage config would still be wrong, but it would prevent a wrong resource blocking instantiation of the pod (which would crash at a later time due to missing hugepage limits). We can argue which one is the better failure case. Input welcome.","accounts_in_message":[],"_revision_number":1},{"id":"8638d72c8eb445726d5014d909c2cf87d625109c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-01 08:32:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/03/662603/1/check/openstack-tox-docs/e47d31f/html/ : SUCCESS in 5m 16s\n- openstack-helm-lint http://logs.openstack.org/03/662603/1/check/openstack-helm-lint/b8572a7/ : SUCCESS in 1m 10s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-aio-logging/998dfb3/ : SUCCESS in 40m 23s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-aio-monitoring/d868b42/ : SUCCESS in 34m 04s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-aio-network-policy/0445966/ : FAILURE in 28m 37s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-openstack-support/b906628/ : SUCCESS in 38m 04s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-kubernetes-keystone-auth/4f6ecb5/ : SUCCESS in 46m 43s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-airship-divingbell/4d972d6/ : SUCCESS in 12m 07s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-aio-podsecuritypolicy/2721a0f/ : FAILURE in 21m 52s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/03/662603/1/check/openstack-helm-infra-apparmor/8894d6c/ : FAILURE in 25m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f93260779a9361b7492a252150c174044a4e3b7f","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-01 20:23:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"53850d64481ae03abe7919ee874dc6a6d7d13f36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-01 21:13:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/03/662603/2/check/openstack-tox-docs/3a7ec6f/html/ : SUCCESS in 3m 53s\n- openstack-helm-lint http://logs.openstack.org/03/662603/2/check/openstack-helm-lint/51052fd/ : SUCCESS in 1m 31s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-aio-logging/c38241f/ : SUCCESS in 38m 35s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-aio-monitoring/feb0b2e/ : SUCCESS in 30m 22s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-aio-network-policy/bf9165a/ : FAILURE in 27m 21s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-openstack-support/9c6c451/ : SUCCESS in 37m 50s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-kubernetes-keystone-auth/a2b971b/ : SUCCESS in 48m 01s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-airship-divingbell/070ee5f/ : SUCCESS in 10m 21s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-aio-podsecuritypolicy/5c13c36/ : SUCCESS in 10m 38s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/03/662603/2/check/openstack-helm-infra-apparmor/14d4458/ : FAILURE in 22m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"485e8ba6ec30795e3fbc440668709467ccb9b695","author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"date":"2019-06-02 04:14:55.000000000","message":"Patch Set 2:\n\n\u003e Thinking about this, I\u0027d like to correct my previous statement. One\n \u003e purpose of the checks is to sanitize the resource which should be\n \u003e considered by K8s. Without the checks, non-sensical / non-existing\n \u003e resoures can end up in this section, resulting in pod remaining in\n \u003e pending state. In case of a typo in the resource definition (e.g.,\n \u003e hugepages-2M instead of hugepages-2Mi), the pod remains in pending\n \u003e state until hugepages-2M become available which will never be the\n \u003e case. With checks in place, the hugepage config would still be\n \u003e wrong, but it would prevent a wrong resource blocking instantiation\n \u003e of the pod (which would crash at a later time due to missing\n \u003e hugepage limits). We can argue which one is the better failure\n \u003e case. Input welcome.\n\nAs a user, my input is:\n```\nlimits:\n  cpu: 1000m\n  memory: 1000Mi\n  hugepages-2M: 1Gi\n```\n\nAs you can see, I miss an \u0027i\u0027 there. It should be \u0027hugepages-2Mi\u0027 instead of \u0027hugepage-2M\u0027. After the check, it turns out to be the following lines:(it removes my hugepage configuration without my awareness)\n```\nlimits:\n  cpu: 1000m\n  memory: 1000Mi\n```\n\nIf I type some words wrong, I am supposed to be reminded. Otherwise, I will not be able to find this mistake until my application reports \u0027no hugepages available\u0027. I think this is not an application level mistake, so I would prefer reporting the error at k8s level.","accounts_in_message":[],"_revision_number":2},{"id":"e26fb17e44defc3a031b71fa8e412fc97a9c6aaa","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-02 14:44:16.000000000","message":"Patch Set 2:\n\n\u003e \u003e Thinking about this, I\u0027d like to correct my previous statement.\n \u003e One\n \u003e \u003e purpose of the checks is to sanitize the resource which should be\n \u003e \u003e considered by K8s. Without the checks, non-sensical /\n \u003e non-existing\n \u003e \u003e resoures can end up in this section, resulting in pod remaining\n \u003e in\n \u003e \u003e pending state. In case of a typo in the resource definition\n \u003e (e.g.,\n \u003e \u003e hugepages-2M instead of hugepages-2Mi), the pod remains in\n \u003e pending\n \u003e \u003e state until hugepages-2M become available which will never be the\n \u003e \u003e case. With checks in place, the hugepage config would still be\n \u003e \u003e wrong, but it would prevent a wrong resource blocking\n \u003e instantiation\n \u003e \u003e of the pod (which would crash at a later time due to missing\n \u003e \u003e hugepage limits). We can argue which one is the better failure\n \u003e \u003e case. Input welcome.\n \u003e \n \u003e As a user, my input is:\n \u003e ```\n \u003e limits:\n \u003e cpu: 1000m\n \u003e memory: 1000Mi\n \u003e hugepages-2M: 1Gi\n \u003e ```\n \u003e \n \u003e As you can see, I miss an \u0027i\u0027 there. It should be \u0027hugepages-2Mi\u0027\n \u003e instead of \u0027hugepage-2M\u0027. After the check, it turns out to be the\n \u003e following lines:(it removes my hugepage configuration without my\n \u003e awareness)\n \u003e ```\n \u003e limits:\n \u003e cpu: 1000m\n \u003e memory: 1000Mi\n \u003e ```\n \u003e \n \u003e If I type some words wrong, I am supposed to be reminded.\n \u003e Otherwise, I will not be able to find this mistake until my\n \u003e application reports \u0027no hugepages available\u0027. I think this is not\n \u003e an application level mistake, so I would prefer reporting the error\n \u003e at k8s level.\n\nThanks for your feedback. Based on your example, I do see the benefit of handling (containing) the error on k8s level instead of application level. Interestingly, this means removing checks.\n\nMoreover, I didn\u0027t find a good method of validating values in helm charts, for instance, throwing an error if both 1Gi and 2Mi hugepages are defined simultaneously.","accounts_in_message":[],"_revision_number":2},{"id":"a14d94ba27f69957464b7df761dae8b0d819fe60","author":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"date":"2019-06-03 08:03:50.000000000","message":"Patch Set 2:\n\n\u003e \u003e \u003e Thinking about this, I\u0027d like to correct my previous statement.\n \u003e \u003e One\n \u003e \u003e \u003e purpose of the checks is to sanitize the resource which should\n \u003e be\n \u003e \u003e \u003e considered by K8s. Without the checks, non-sensical /\n \u003e \u003e non-existing\n \u003e \u003e \u003e resoures can end up in this section, resulting in pod remaining\n \u003e \u003e in\n \u003e \u003e \u003e pending state. In case of a typo in the resource definition\n \u003e \u003e (e.g.,\n \u003e \u003e \u003e hugepages-2M instead of hugepages-2Mi), the pod remains in\n \u003e \u003e pending\n \u003e \u003e \u003e state until hugepages-2M become available which will never be\n \u003e the\n \u003e \u003e \u003e case. With checks in place, the hugepage config would still be\n \u003e \u003e \u003e wrong, but it would prevent a wrong resource blocking\n \u003e \u003e instantiation\n \u003e \u003e \u003e of the pod (which would crash at a later time due to missing\n \u003e \u003e \u003e hugepage limits). We can argue which one is the better failure\n \u003e \u003e \u003e case. Input welcome.\n \u003e \u003e\n \u003e \u003e As a user, my input is:\n \u003e \u003e ```\n \u003e \u003e limits:\n \u003e \u003e cpu: 1000m\n \u003e \u003e memory: 1000Mi\n \u003e \u003e hugepages-2M: 1Gi\n \u003e \u003e ```\n \u003e \u003e\n \u003e \u003e As you can see, I miss an \u0027i\u0027 there. It should be \u0027hugepages-2Mi\u0027\n \u003e \u003e instead of \u0027hugepage-2M\u0027. After the check, it turns out to be the\n \u003e \u003e following lines:(it removes my hugepage configuration without my\n \u003e \u003e awareness)\n \u003e \u003e ```\n \u003e \u003e limits:\n \u003e \u003e cpu: 1000m\n \u003e \u003e memory: 1000Mi\n \u003e \u003e ```\n \u003e \u003e\n \u003e \u003e If I type some words wrong, I am supposed to be reminded.\n \u003e \u003e Otherwise, I will not be able to find this mistake until my\n \u003e \u003e application reports \u0027no hugepages available\u0027. I think this is not\n \u003e \u003e an application level mistake, so I would prefer reporting the\n \u003e error\n \u003e \u003e at k8s level.\n \u003e \n \u003e Thanks for your feedback. Based on your example, I do see the\n \u003e benefit of handling (containing) the error on k8s level instead of\n \u003e application level. Interestingly, this means removing checks.\n \u003e \n \u003e Moreover, I didn\u0027t find a good method of validating values in helm\n \u003e charts, for instance, throwing an error if both 1Gi and 2Mi\n \u003e hugepages are defined simultaneously.\n\nI did not find anything either, we should ask the Airship guys as they work with yaml a lot. Not checking the resources that are passed is a very easy way to introduce bugs and problems to the system, I would be surprised there is no \"schema\" or something to be able to check that the input is correct","accounts_in_message":[],"_revision_number":2},{"id":"ee7740f5587656e4502cc419093d7f70930ac503","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-05 09:38:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cb820099c78e429cbd6feba439a85bcf17671b98","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-05 09:42:26.000000000","message":"Patch Set 3:\n\nUpdated as discussed in http://eavesdrop.openstack.org/meetings/openstack_helm/2019/openstack_helm.2019-06-04-15.00.log.html","accounts_in_message":[],"_revision_number":3},{"id":"4726ec922a7055c161de1bd044d563ecb03f227c","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-06-05 09:50:28.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"59d48f4dd56206d132983336f39e6f668919d5f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 10:58:55.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/03/662603/3/check/openstack-tox-docs/9e7ee38/html/ : SUCCESS in 3m 43s\n- openstack-helm-lint http://logs.openstack.org/03/662603/3/check/openstack-helm-lint/3569896/ : SUCCESS in 1m 32s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-aio-logging/37b2672/ : SUCCESS in 58m 54s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-aio-monitoring/268352b/ : SUCCESS in 36m 00s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-aio-network-policy/5e5cb5a/ : FAILURE in 31m 45s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-openstack-support/6c82bca/ : SUCCESS in 40m 18s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-kubernetes-keystone-auth/8e53ed1/ : SUCCESS in 45m 24s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-airship-divingbell/98ab82b/ : SUCCESS in 10m 47s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-aio-podsecuritypolicy/4062233/ : FAILURE in 14m 41s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/03/662603/3/check/openstack-helm-infra-apparmor/6eb1b6c/ : FAILURE in 25m 31s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"570650557eee332dcd5107ac07a91c20da65d42b","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-06-05 12:47:20.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"5287bd0b8dd4350dd920b53924289f75628be27a","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-06-05 12:48:43.000000000","message":"Patch Set 3:\n\nthis is done conforming to our latest community meeting.\n\nNo need for a release note, as this doesn\u0027t effectively change something for deployers.","accounts_in_message":[],"_revision_number":3},{"id":"809358f66a13eac6bc54e1df442a8b7a84d184ea","author":{"_account_id":30220,"name":"Rihab Banday","email":"rihab.banday@ericsson.com","username":"rihabbanday"},"date":"2019-06-05 14:52:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"dc5e6735a8b060e88c867abf1346bcb2a617b514","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-10 20:12:53.000000000","message":"Patch Set 3:\n\nHi all. This patch has been up for review for about a week and is just missing a workflow label. I would appreciate reviews from cores and a corresponding label. Thank you","accounts_in_message":[],"_revision_number":3},{"id":"337544049257f2c3276e25a970cebbb3a452a211","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-06-11 07:20:36.000000000","message":"Patch Set 3:\n\nalso missing another core +2\n\nGeorg, can you bring this patch up in today\u0027s meeting? I will try to bring it up as well.","accounts_in_message":[],"_revision_number":3},{"id":"0558821a8c2ea9e2fa262f6f49eab8ba99072235","author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"date":"2019-06-11 13:49:22.000000000","message":"Patch Set 3:\n\n\u003e also missing another core +2\n \u003e \n \u003e Georg, can you bring this patch up in today\u0027s meeting? I will try\n \u003e to bring it up as well.\n\nRight, thank you. I\u0027ll put it on the agenda for today.","accounts_in_message":[],"_revision_number":3},{"id":"5c6206cb7d340d266be5befe4db81e63c00f0bce","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2019-06-11 22:06:42.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"39e096b8afd8f0dd0fef9291a00230e9e8236e7e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 22:06:55.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"09a36fc43ca7e072d4f80a4e60c0360da777437f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 23:41:56.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/03/662603/3/gate/openstack-tox-docs/36bb369/html/ : SUCCESS in 3m 45s\n- openstack-helm-lint http://logs.openstack.org/03/662603/3/gate/openstack-helm-lint/a9a8ac5/ : SUCCESS in 1m 28s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/03/662603/3/gate/openstack-helm-infra-aio-logging/f9120e4/ : SUCCESS in 38m 23s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/03/662603/3/gate/openstack-helm-infra-aio-monitoring/3094520/ : SUCCESS in 30m 55s\n- openstack-helm-infra-openstack-support http://logs.openstack.org/03/662603/3/gate/openstack-helm-infra-openstack-support/a1838e7/ : SUCCESS in 50m 41s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/03/662603/3/gate/openstack-helm-infra-kubernetes-keystone-auth/7eff1d9/ : SUCCESS in 46m 09s","accounts_in_message":[],"_revision_number":3},{"id":"94324eac2baa947bb13b9d6acda191b04f92c7f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 23:41:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5596247f3fff381b5d29fe16cd94a1589b11e59e","revisions":{"230535747eb24d3ab3eeb873313468726d67d9a1":{"kind":"REWORK","_number":1,"created":"2019-06-01 07:41:00.000000000","uploader":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"ref":"refs/changes/03/662603/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/03/662603/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/1"}}},"commit":{"parents":[{"commit":"c34dbeeec81ca0ab12370f108a7645ef2bca9386","subject":"Merge \"mariadb: fix hostpath values\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/c34dbeeec81ca0ab12370f108a7645ef2bca9386"}]}],"author":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-05-31 22:24:19.000000000","tz":120},"committer":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-06-01 07:33:07.000000000","tz":120},"subject":"Enable hugepage support in HTK resources snippet","message":"Enable hugepage support in HTK resources snippet\n\nThis patch simplifies the resource snippet in helm-toolkit to allow for\nspecifying hugepage limits. Specifically, this patch replaces the\nindividual checks for specific system resources (e.g., cpu, memory) by\njust copying over the entire resource component as defined in a\nvalues.yaml or a corresponding overwrite.\n\nThe background for this change is that hugepage limits are defined as\neither \"hugepages-1Gi\" or \"hugepages-2Mi\" in K8s manifests [1]. Applying\nthe same type of checks to these attributes as to the cpu and memory\nresources does not work because the dash \"-\" in hugepages-\u003csize\u003e is not\nallowed by the helm linter. So, we could either rename those attributes\nto hugepages_\u003csize\u003e in values files or skip these checks and just copy\nthe entire resource component as done here.\n\nThis change is a prerequisite for enable hugepage handling in other\ncharts such as openvswitch or postgresql.\n\n[1] https://kubernetes.io/docs/tasks/manage-hugepages/scheduling-hugepages/\n\nChange-Id: I786ff6c7aa5fb6b08b54d2e21878551e5e1e3818\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/230535747eb24d3ab3eeb873313468726d67d9a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/230535747eb24d3ab3eeb873313468726d67d9a1"}]},"branch":"refs/heads/master"},"cfc16d54b308eb94418a781ef82b1bd7fe40a622":{"kind":"REWORK","_number":2,"created":"2019-06-01 20:23:34.000000000","uploader":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"ref":"refs/changes/03/662603/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/03/662603/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/2"}}},"commit":{"parents":[{"commit":"c34dbeeec81ca0ab12370f108a7645ef2bca9386","subject":"Merge \"mariadb: fix hostpath values\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/c34dbeeec81ca0ab12370f108a7645ef2bca9386"}]}],"author":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-05-31 22:24:19.000000000","tz":120},"committer":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-06-01 20:19:33.000000000","tz":120},"subject":"Enable hugepage support in HTK resource handling","message":"Enable hugepage support in HTK resource handling\n\nAdding support for handling 1Gi and 2Mi hugepage resource limits and\nrequests to helm-toolkit. This change is a prerequisite for enabling\nhugepage handling in other charts such as openvswitch or postgresql.\n\nChange-Id: I786ff6c7aa5fb6b08b54d2e21878551e5e1e3818\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/cfc16d54b308eb94418a781ef82b1bd7fe40a622"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/cfc16d54b308eb94418a781ef82b1bd7fe40a622"}]},"branch":"refs/heads/master"},"5596247f3fff381b5d29fe16cd94a1589b11e59e":{"kind":"REWORK","_number":3,"created":"2019-06-05 09:38:15.000000000","uploader":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"ref":"refs/changes/03/662603/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/03/662603/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/03/662603/3"}}},"commit":{"parents":[{"commit":"b7f0fd8dff5e451edd953d1588ed77b8616ac19b","subject":"Merge \"Replace git.openstack.org URLs with opendev.org URLs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b7f0fd8dff5e451edd953d1588ed77b8616ac19b"}]}],"author":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-05-31 22:24:19.000000000","tz":120},"committer":{"name":"Georg Kunz","email":"georg.kunz@ericsson.com","date":"2019-06-05 09:37:43.000000000","tz":120},"subject":"Enable hugepage support in HTK resources snippet","message":"Enable hugepage support in HTK resources snippet\n\nThis patch simplifies the resource snippet in helm-toolkit to allow for\nspecifying hugepage limits. Specifically, this patch replaces the\nindividual checks for specific system resources (e.g., cpu, memory) by\njust copying over the entire resource component as defined in a\nvalues.yaml or a corresponding overwrite.\n\nThis change is a prerequisite for enable hugepage handling in other\ncharts such as openvswitch or postgresql.\n\nChange-Id: I786ff6c7aa5fb6b08b54d2e21878551e5e1e3818\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5596247f3fff381b5d29fe16cd94a1589b11e59e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5596247f3fff381b5d29fe16cd94a1589b11e59e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}