)]}'
{"id":"openstack%2Fopenstack-helm-infra~667022","triplet_id":"openstack%2Fopenstack-helm-infra~master~I0afb0b32ab80456aa3439b4221f2a95ca05ddf24","project":"openstack/openstack-helm-infra","branch":"master","topic":"fix-daemonset_overrides_incorrectly_overwrites","hashtags":[],"change_id":"I0afb0b32ab80456aa3439b4221f2a95ca05ddf24","subject":"fix host-specific overrides incorrectly overwriting previous values","status":"MERGED","created":"2019-06-24 06:43:24.000000000","updated":"2019-07-23 05:52:48.000000000","submitted":"2019-06-26 09:44:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667022-1561542270366-e8d46088","meta_rev_id":"ff3462be8d2b6357506e078cc276c9e98c15cd3b","_number":667022,"virtual_id_number":667022,"owner":{"_account_id":30038,"name":"Jugwan Eom","email":"zugwan@gmail.com","username":"zugwan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":0,"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":2,"date":"2019-06-26 09:44:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"},{"value":2,"date":"2019-06-25 02:37:29.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":2,"date":"2019-06-26 08:52:20.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"all":[{"value":0,"date":"2019-06-25 16:02:31.000000000","_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":1,"date":"2019-06-26 08:52:20.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-25 16:02:39.000000000","_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},{"_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-24 06:54:10.000000000","updated_by":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"reviewer":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"state":"REVIEWER"},{"updated":"2019-06-25 02:37:29.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-06-25 16:02:31.000000000","updated_by":{"_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"},"reviewer":{"_account_id":29937,"name":"Stephen Taylor","email":"steve@taylor.zapto.org","username":"steveftaylor"},"state":"REVIEWER"},{"updated":"2019-06-25 16:02:39.000000000","updated_by":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"reviewer":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"state":"REVIEWER"},{"updated":"2019-06-26 08:52:20.000000000","updated_by":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"reviewer":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"state":"REVIEWER"},{"updated":"2019-06-26 09:44:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"44c7703e37bf4447533a23289c7d37150355fa26","author":{"_account_id":30038,"name":"Jugwan Eom","email":"zugwan@gmail.com","username":"zugwan"},"date":"2019-06-24 06:43:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f5d6305cd22d20069e94c747136af0cfe712938","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 08:02:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/22/667022/1/check/openstack-tox-docs/9c9fa31/html/ : SUCCESS in 6m 12s\n- openstack-helm-lint http://logs.openstack.org/22/667022/1/check/openstack-helm-lint/b24c49b/ : SUCCESS in 1m 35s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-aio-logging/309985f/ : FAILURE in 1h 06m 53s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-aio-monitoring/ec97a49/ : FAILURE in 36m 10s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-aio-network-policy/8d74ac1/ : FAILURE in 28m 02s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-openstack-support/9ac67c6/ : SUCCESS in 47m 35s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-kubernetes-keystone-auth/e82770b/ : SUCCESS in 45m 54s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-airship-divingbell/b7a3df4/ : FAILURE in 10m 37s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-aio-podsecuritypolicy/c2f8cc7/ : FAILURE in 12m 51s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/22/667022/1/check/openstack-helm-infra-apparmor/79a6af1/ : SUCCESS in 31m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7b061748df1b6fe94799777b41d0c597153e34a2","author":{"_account_id":30038,"name":"Jugwan Eom","email":"zugwan@gmail.com","username":"zugwan"},"date":"2019-06-25 02:34:02.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"63df750f4e4bdc4d045068da9c62cbc1c1acd8b2","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-06-25 02:37:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3d1db947e93bab2082f89befeed1513639d0da51","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 03:25:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/667022/2/check/openstack-tox-docs/7809f1d/html/ : SUCCESS in 2m 44s\n- openstack-helm-lint http://logs.openstack.org/22/667022/2/check/openstack-helm-lint/16aa90d/ : SUCCESS in 3m 41s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-aio-logging/42c3451/ : SUCCESS in 46m 28s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-aio-monitoring/23c9b08/ : SUCCESS in 31m 42s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-aio-network-policy/bf0d4e5/ : FAILURE in 27m 48s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-openstack-support/1090bdd/ : SUCCESS in 43m 30s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-kubernetes-keystone-auth/89a9ef0/ : SUCCESS in 44m 38s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-airship-divingbell/9ab4f43/ : FAILURE in 11m 25s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-aio-podsecuritypolicy/4e0ed86/ : SUCCESS in 13m 22s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/22/667022/2/check/openstack-helm-infra-apparmor/a8fa91c/ : SUCCESS in 31m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f5f6fecb9d7791cfd5d3fbceb1983b7f15755da5","author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"date":"2019-06-26 08:52:20.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8b0079e25f35d529e37dc550069550982b63f33a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 08:52:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"368608a3c3ec9039987918d9ae4149740d2e99da","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 09:44:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c7a676b1bb59a9d4f746bb15bdcf54880fb05630","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-26 09:44:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/22/667022/2/gate/openstack-tox-docs/6a08724/html/ : SUCCESS in 3m 21s\n- openstack-helm-lint http://logs.openstack.org/22/667022/2/gate/openstack-helm-lint/dfa3565/ : SUCCESS in 1m 33s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/22/667022/2/gate/openstack-helm-infra-aio-logging/158b434/ : SUCCESS in 50m 21s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/22/667022/2/gate/openstack-helm-infra-aio-monitoring/fbc76a8/ : SUCCESS in 35m 11s","accounts_in_message":[],"_revision_number":2},{"id":"0ff4524d2549abeb64c21b734200bca475e7d69d","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2019-07-20 00:52:07.000000000","message":"Patch Set 2:\n\nThis PS broke the override functionality (openstack-helm-infra-airship-divingbell gate failure).\nIf there was some problem observed with previous (working) behavior, then a test should be written to detect the undesired output. Then when both tests are passing, we will know it\u0027s fine to merge.","accounts_in_message":[],"_revision_number":2},{"id":"565cceceaba113f2074653325021c03477c51bf6","author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"date":"2019-07-23 05:49:11.000000000","message":"Patch Set 2:\n\nWe believed that this fixes \"wrong behavior of host-specific override\". I am not sure what \"openstack-helm-infra-airship-divingbell\" does, however, airship is one of downstream users of openstack-helm. I did not think passing \"openstack-helm-infra-airship-divingbell\" is mandatory. We will be happy to discuss whether this PS presented a wrong fix (openstack-helm perspective) as Craig metioned or airship divingbell needs to be corrected based on this new fix.","accounts_in_message":[],"_revision_number":2},{"id":"608b04209a43b4584a3cdfe97c8e38d2c9ac95d9","author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"date":"2019-07-23 05:52:48.000000000","message":"Patch Set 2:\n\nhttps://review.opendev.org/#/c/671875/ \u003e\u003e I just saw this now. I will followup with this PS. Big thanks for providing alternative for us to review. :)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"833d426da8e4b049277ca9847830f6e6beee40c3","revisions":{"5af7d16e29b143dc4cbc3859f751a72f04b04f00":{"kind":"REWORK","_number":1,"created":"2019-06-24 06:43:24.000000000","uploader":{"_account_id":30038,"name":"Jugwan Eom","email":"zugwan@gmail.com","username":"zugwan"},"ref":"refs/changes/22/667022/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/22/667022/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/1"}}},"commit":{"parents":[{"commit":"3d3f74de6929fc3d2f632125b37e4bfda8c59e4c","subject":"Merge \"[Ceph] Update helm tests for ceph-provisioners\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/3d3f74de6929fc3d2f632125b37e4bfda8c59e4c"}]}],"author":{"name":"Jugwan Eom","email":"zugwan@gmail.com","date":"2019-06-24 06:33:11.000000000","tz":0},"committer":{"name":"Jugwan Eom","email":"zugwan@gmail.com","date":"2019-06-24 06:34:30.000000000","tz":0},"subject":"fix host-specific overrides incorrectly overwriting previous values","message":"fix host-specific overrides incorrectly overwriting previous values\n\nroot_conf area is used for host-specific configuration and overwritten in\neach round of loop. It causes that all hosts will share same properties.\nThis makes use each host\u0027s own area in the loop.\n\nTask: 34282\nStory: 2005936\n\nChange-Id: I0afb0b32ab80456aa3439b4221f2a95ca05ddf24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5af7d16e29b143dc4cbc3859f751a72f04b04f00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5af7d16e29b143dc4cbc3859f751a72f04b04f00"}]},"branch":"refs/heads/master"},"833d426da8e4b049277ca9847830f6e6beee40c3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-06-25 02:34:02.000000000","uploader":{"_account_id":30038,"name":"Jugwan Eom","email":"zugwan@gmail.com","username":"zugwan"},"ref":"refs/changes/22/667022/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/22/667022/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/22/667022/2"}}},"commit":{"parents":[{"commit":"9e95a497c04206767c3c469c7e010aeebac453d5","subject":"Merge \"Trivial typo fixes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9e95a497c04206767c3c469c7e010aeebac453d5"}]}],"author":{"name":"Jugwan Eom","email":"zugwan@gmail.com","date":"2019-06-24 06:33:11.000000000","tz":0},"committer":{"name":"Jugwan Eom","email":"zugwan@gmail.com","date":"2019-06-25 02:34:02.000000000","tz":0},"subject":"fix host-specific overrides incorrectly overwriting previous values","message":"fix host-specific overrides incorrectly overwriting previous values\n\nroot_conf area is used for host-specific configuration and overwritten in\neach round of loop. It causes that all hosts will share same properties.\nThis makes use each host\u0027s own area in the loop.\n\nTask: 34282\nStory: 2005936\n\nChange-Id: I0afb0b32ab80456aa3439b4221f2a95ca05ddf24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/833d426da8e4b049277ca9847830f6e6beee40c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/833d426da8e4b049277ca9847830f6e6beee40c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}