)]}'
{"id":"openstack%2Fopenstack-helm-infra~667152","triplet_id":"openstack%2Fopenstack-helm-infra~master~I23f0f03824eec5b142d3f2e8e42e8d07cddfe618","project":"openstack/openstack-helm-infra","branch":"master","topic":"fluentd-log-mount","hashtags":[],"change_id":"I23f0f03824eec5b142d3f2e8e42e8d07cddfe618","subject":"Fluentd: Remove readOnly flag from /var/log mount","status":"MERGED","created":"2019-06-24 16:12:40.000000000","updated":"2019-06-25 19:57:58.000000000","submitted":"2019-06-25 19:57:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667152-1561492678052-de56cdb0","meta_rev_id":"b17ea298a4568f376e26210723883e644819ebbc","_number":667152,"virtual_id_number":667152,"owner":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"date":"2019-06-25 12:55:49.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"value":0,"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":2,"date":"2019-06-25 19:57:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2019-06-25 19:57:26.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-06-25 19:00:43.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":1,"date":"2019-06-25 16:06:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"value":1,"date":"2019-06-25 16:46:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-25 18:13:20.000000000","_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":1,"date":"2019-06-25 16:09:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2019-06-25 19:57:26.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2019-06-25 19:00:43.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"value":0,"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-25 16:06:05.000000000","updated_by":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"reviewer":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"state":"REVIEWER"},{"updated":"2019-06-25 16:09:32.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"REVIEWER"},{"updated":"2019-06-25 16:46:01.000000000","updated_by":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"reviewer":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"state":"REVIEWER"},{"updated":"2019-06-25 18:13:20.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2019-06-25 19:00:43.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-06-25 19:57:26.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-06-25 19:57:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c0c641245af14bdfcab1f5a839cddf9196afba65","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-06-24 16:12:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f7cd59a9c454641601cecd52c1ab95cadc9d54cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 17:12:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/52/667152/1/check/openstack-tox-docs/cb2faa4/html/ : SUCCESS in 4m 35s\n- openstack-helm-lint http://logs.openstack.org/52/667152/1/check/openstack-helm-lint/3a3b535/ : SUCCESS in 1m 38s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-aio-logging/9bb8d2a/ : SUCCESS in 42m 45s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-aio-monitoring/c40e00a/ : SUCCESS in 32m 34s\n- openstack-helm-infra-aio-network-policy http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-aio-network-policy/02cf32d/ : FAILURE in 28m 54s (non-voting)\n- openstack-helm-infra-openstack-support http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-openstack-support/ffe05c7/ : SUCCESS in 43m 20s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-kubernetes-keystone-auth/87b1b4c/ : SUCCESS in 48m 43s\n- openstack-helm-infra-airship-divingbell http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-airship-divingbell/a97fce1/ : SUCCESS in 11m 22s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-aio-podsecuritypolicy/221b315/ : FAILURE in 12m 58s (non-voting)\n- openstack-helm-infra-apparmor http://logs.openstack.org/52/667152/1/check/openstack-helm-infra-apparmor/5b50c18/ : SUCCESS in 29m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ccbc686b06ef5cb7092f9474bd9a975550bb0331","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-06-25 02:47:28.000000000","message":"Patch Set 1:\n\nif fluentd is reading logs ... why does it need write?","accounts_in_message":[],"_revision_number":1},{"id":"47919a07333d6f7de8200187fc55e15c2e81ea56","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-06-25 12:55:49.000000000","message":"Patch Set 1:\n\n\u003e if fluentd is reading logs ... why does it need write?\n\nOne of the options for the tail input plugin is the ability to define a file for Fluentd to write the current location (line number) of the files it\u0027s tailing.  This is typically written to /var/log/ on the host so upon restarts, Fluentd can resume tailing the files at the last known location instead of starting over from the head of the file.  For us to provide this as an option, we should remove the readOnly declaration from /var/log volume mount","accounts_in_message":[],"_revision_number":1},{"id":"aaab68ef9909656450402e59356356e0ad4afddc","author":{"_account_id":28025,"name":"Randeep Jalli","email":"rj2083@att.com","username":"randeep.jalli"},"date":"2019-06-25 16:06:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"08efb9c623ec935eeb4818a3d55602c88c715877","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2019-06-25 16:09:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7a9e7d819ab2fbcfdac176fb7dbd7416fb191b1b","author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"date":"2019-06-25 16:46:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e6843692f5c81d8b8affafa07e988f5051419508","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2019-06-25 18:13:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a0b0c0b939c9eea995c34c8f44aa6bb9f57e16b1","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-06-25 19:00:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fde21f804b40cc7462efad7156fe2b3449e96f00","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 19:00:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0cb6815deaf4e6804905f246fa88944006b3a5db","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-06-25 19:57:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c3cc93df24e573122223cecd9029801d814a3d98","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 19:57:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/52/667152/1/gate/openstack-tox-docs/2a132ee/html/ : SUCCESS in 2m 32s\n- openstack-helm-lint http://logs.openstack.org/52/667152/1/gate/openstack-helm-lint/32b90eb/ : SUCCESS in 1m 38s\n- openstack-helm-infra-aio-logging http://logs.openstack.org/52/667152/1/gate/openstack-helm-infra-aio-logging/bf91563/ : SUCCESS in 40m 39s\n- openstack-helm-infra-aio-monitoring http://logs.openstack.org/52/667152/1/gate/openstack-helm-infra-aio-monitoring/49c2f72/ : SUCCESS in 31m 42s\n- openstack-helm-infra-openstack-support http://logs.openstack.org/52/667152/1/gate/openstack-helm-infra-openstack-support/b82101d/ : SUCCESS in 45m 48s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/52/667152/1/gate/openstack-helm-infra-kubernetes-keystone-auth/af3e032/ : SUCCESS in 47m 02s","accounts_in_message":[],"_revision_number":1},{"id":"46998a04760d9bd3f3054dbf51200a9e4fd271b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 19:57:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1df9cee5c127befd27500153a3323cfc6054a943","revisions":{"1df9cee5c127befd27500153a3323cfc6054a943":{"kind":"REWORK","_number":1,"created":"2019-06-24 16:12:40.000000000","uploader":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"ref":"refs/changes/52/667152/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/52/667152/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/52/667152/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/52/667152/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/52/667152/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/52/667152/1"}}},"commit":{"parents":[{"commit":"3d3f74de6929fc3d2f632125b37e4bfda8c59e4c","subject":"Merge \"[Ceph] Update helm tests for ceph-provisioners\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/3d3f74de6929fc3d2f632125b37e4bfda8c59e4c"}]}],"author":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2019-06-24 16:11:52.000000000","tz":-300},"committer":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2019-06-24 16:11:52.000000000","tz":-300},"subject":"Fluentd: Remove readOnly flag from /var/log mount","message":"Fluentd: Remove readOnly flag from /var/log mount\n\nThis removes the readOnly flag from the /var/log mount for the\nfluentd pod to allow for using the file buffer mechanism when\ndesired\n\nChange-Id: I23f0f03824eec5b142d3f2e8e42e8d07cddfe618\nSigned-off-by: Steve Wilkerson \u003csw5822@att.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/1df9cee5c127befd27500153a3323cfc6054a943"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/1df9cee5c127befd27500153a3323cfc6054a943"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}