)]}'
{"ceph-client/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cd781176247c4e8d32b1f2c04d9634925b44b01b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if [ $EXPECTED_OSDS \u003d\u003d 1 ]; then"},{"line_number":42,"context_line":"    MIN_EXPECTED_OSDS\u003d$EXPECTED_OSDS"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    MIN_EXPECTED_OSDS\u003d$(($EXPECTED_OSDS*$REQUIRED_PER_OF_OSDs/100))"},{"line_number":45,"context_line":"  fi"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_EXPECTED_OSDS}\"  ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fb8cfa7_01f655d8","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":65},"updated":"2019-06-26 20:21:19.000000000","message":"I\u0027m not sure if this is too loose. A required percent of 1.6 and expected value of 2 yields 0.12 mininum expected OSDs.\n\nShould we be rounding this or providing better guidance? Entering 1.6 is not necessarily an operator error, because I should be able to expect 1.6% of my OSDs to be a valid amount.","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"fb28a9e6e6e0200928d6f58e879604d63d1d1942","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if [ $EXPECTED_OSDS \u003d\u003d 1 ]; then"},{"line_number":42,"context_line":"    MIN_EXPECTED_OSDS\u003d$EXPECTED_OSDS"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    MIN_EXPECTED_OSDS\u003d$(($EXPECTED_OSDS*$REQUIRED_PER_OF_OSDs/100))"},{"line_number":45,"context_line":"  fi"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_EXPECTED_OSDS}\"  ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fb8cfa7_68c3718a","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":65},"in_reply_to":"9fb8cfa7_01f655d8","updated":"2019-06-26 22:29:50.000000000","message":"yes ,now rounding and also accepts floating percentages.","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"e469070ae5cf43913c77fe80c0b48d7577644af1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if [ $EXPECTED_OSDS \u003d\u003d 1 ]; then"},{"line_number":42,"context_line":"    MIN_EXPECTED_OSDS\u003d$EXPECTED_OSDS"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    MIN_EXPECTED_OSDS\u003d$(awk \"BEGIN { pc\u003d$EXPECTED_OSDS*$REQUIRED_PERCENTAGE_OF_OSDs/100; i\u003dint(pc); print (pc-i\u003c0.5)?i:i+1 }\")"},{"line_number":45,"context_line":"  fi"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_EXPECTED_OSDS}\"  ]; then"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"9fb8cfa7_f0b2bfe4","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":125},"updated":"2019-06-28 19:53:04.000000000","message":"This seems like much too complicated of a computation for a Helm test or bash script.\n\nI would suggest using your old calculation and retaining floating arithmetic support by rounding.","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"dae5c78d47e64ff2ed761fe26c45f6b85665a542","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if [ $EXPECTED_OSDS \u003d\u003d 1 ]; then"},{"line_number":42,"context_line":"    MIN_EXPECTED_OSDS\u003d$EXPECTED_OSDS"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    MIN_EXPECTED_OSDS\u003d$(awk \"BEGIN { pc\u003d$EXPECTED_OSDS*$REQUIRED_PERCENTAGE_OF_OSDs/100; i\u003dint(pc); print (pc-i\u003c0.5)?i:i+1 }\")"},{"line_number":45,"context_line":"  fi"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_EXPECTED_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_EXPECTED_OSDS}\"  ]; then"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"9fb8cfa7_b3f531cd","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":125},"in_reply_to":"9fb8cfa7_f0b2bfe4","updated":"2019-06-28 20:53:15.000000000","message":"Done","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"}],"ceph-client/templates/pod-helm-tests.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cd781176247c4e8d32b1f2c04d9634925b44b01b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          value: {{ .Release.Namespace }}"},{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PER_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.reuired_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_01c3b58a","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":36},"updated":"2019-06-26 20:21:19.000000000","message":"nit: let\u0027s keep this consistent with other env variables:\n\n  REQUIRED_PER_OF_OSDS\n\nI\u0027ll also throw in that \"PER\" is not a universal abbreviation for \"percent\". It may be worth considering the extra characters to spell it out.","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"fb28a9e6e6e0200928d6f58e879604d63d1d1942","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          value: {{ .Release.Namespace }}"},{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PER_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.reuired_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_08bc3504","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":36},"in_reply_to":"9fb8cfa7_01c3b58a","updated":"2019-06-26 22:29:50.000000000","message":"Done","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cd781176247c4e8d32b1f2c04d9634925b44b01b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PER_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.reuired_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"},{"line_number":52,"context_line":"        - name: MGR_COUNT"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_613711b2","line":49,"range":{"start_line":49,"start_character":45,"end_line":49,"end_character":52},"updated":"2019-06-26 20:21:19.000000000","message":"\"required\"","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"fb28a9e6e6e0200928d6f58e879604d63d1d1942","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PER_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.reuired_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"},{"line_number":52,"context_line":"        - name: MGR_COUNT"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_28b9f913","line":49,"range":{"start_line":49,"start_character":45,"end_line":49,"end_character":52},"in_reply_to":"9fb8cfa7_613711b2","updated":"2019-06-26 22:29:50.000000000","message":"Done","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"e469070ae5cf43913c77fe80c0b48d7577644af1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          value: {{ .Release.Namespace }}"},{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PERCENTAGE_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.required_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_70becfae","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":43},"updated":"2019-06-28 19:53:04.000000000","message":"This was acknowledged as \"Done\" but it is still inconsistent with other environment variables.","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"dae5c78d47e64ff2ed761fe26c45f6b85665a542","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          value: {{ .Release.Namespace }}"},{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PERCENTAGE_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.required_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_530075ab","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":43},"in_reply_to":"9fb8cfa7_70becfae","updated":"2019-06-28 20:53:15.000000000","message":"Done","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"e469070ae5cf43913c77fe80c0b48d7577644af1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PERCENTAGE_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.required_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"},{"line_number":52,"context_line":"        - name: MGR_COUNT"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_b0c8c754","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":83},"updated":"2019-06-28 19:53:04.000000000","message":"I would suggest rounding this number here.\n\n  {{ .Values.conf.pool.target.required_percentage_of_osds | ceil | quote }}","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"dae5c78d47e64ff2ed761fe26c45f6b85665a542","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        - name: EXPECTED_OSDS"},{"line_number":47,"context_line":"          value: {{ .Values.conf.pool.target.osd | quote }}"},{"line_number":48,"context_line":"        - name: REQUIRED_PERCENTAGE_OF_OSDs"},{"line_number":49,"context_line":"          value: {{ .Values.conf.pool.target.required_percentage_of_osds | quote }}"},{"line_number":50,"context_line":"        - name: EXPECTED_CRUSHRULE"},{"line_number":51,"context_line":"          value: {{ .Values.conf.pool.default.crush_rule | default \"replicated_rule\" | quote }}"},{"line_number":52,"context_line":"        - name: MGR_COUNT"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_1330bd9e","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":83},"in_reply_to":"9fb8cfa7_b0c8c754","updated":"2019-06-28 20:53:15.000000000","message":"Done","commit_id":"c7d892e3771ad6f21d460cf408f674a8a094ebe3"}],"ceph-client/values.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cd781176247c4e8d32b1f2c04d9634925b44b01b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"      osd: 5"},{"line_number":221,"context_line":"      # This is  just for helm tests to proceed the deployment if  we have mentioned % of"},{"line_number":222,"context_line":"      # osds are up and running ."},{"line_number":223,"context_line":"      reuired_percentage_of_osds: 80"},{"line_number":224,"context_line":"      pg_per_osd: 100"},{"line_number":225,"context_line":"      protected: true"},{"line_number":226,"context_line":"      #NOTE(st053q): target quota should be set to the overall cluster full percentage"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_41420d11","line":223,"range":{"start_line":223,"start_character":6,"end_line":223,"end_character":13},"updated":"2019-06-26 20:21:19.000000000","message":"\"required\"","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"fb28a9e6e6e0200928d6f58e879604d63d1d1942","unresolved":false,"context_lines":[{"line_number":220,"context_line":"      osd: 5"},{"line_number":221,"context_line":"      # This is  just for helm tests to proceed the deployment if  we have mentioned % of"},{"line_number":222,"context_line":"      # osds are up and running ."},{"line_number":223,"context_line":"      reuired_percentage_of_osds: 80"},{"line_number":224,"context_line":"      pg_per_osd: 100"},{"line_number":225,"context_line":"      protected: true"},{"line_number":226,"context_line":"      #NOTE(st053q): target quota should be set to the overall cluster full percentage"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_c837fdaf","line":223,"range":{"start_line":223,"start_character":6,"end_line":223,"end_character":13},"in_reply_to":"9fb8cfa7_41420d11","updated":"2019-06-26 22:29:50.000000000","message":"Done","commit_id":"bfbfc0cb83102fca6dfc5457a68b95d01055b93c"}]}