)]}'
{"rabbitmq/templates/bin/_rabbitmq-password-hash.py.tpl":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cb357cc970d6f0588c5deb7f407afaf565a06915","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    output.update({\u0027vhosts\u0027: []})"},{"line_number":54,"context_line":"    output.update({\u0027permissions\u0027: []})"},{"line_number":55,"context_line":"    users_creds \u003d json.loads(os.environ[\u0027RABBITMQ_USERS\u0027])"},{"line_number":56,"context_line":"    for user, creds in users_creds.items():"},{"line_number":57,"context_line":"        for key, val in creds.items():"},{"line_number":58,"context_line":"            if key \u003d\u003d \u0027path\u0027:"},{"line_number":59,"context_line":"                vhost \u003d re.sub(\"^/\", \"\", val)"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_9b9c9f6b","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":12},"updated":"2019-07-22 10:28:31.000000000","message":"nit: you don\u0027t seem to be using this, you can make it _","commit_id":"30705aaf4010a39bac44aadc6d9cf5f38c939088"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"1d7ff5de4a3f897dc0e0280cbc5df6dbee668f6f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    output.update({\u0027vhosts\u0027: []})"},{"line_number":54,"context_line":"    output.update({\u0027permissions\u0027: []})"},{"line_number":55,"context_line":"    users_creds \u003d json.loads(os.environ[\u0027RABBITMQ_USERS\u0027])"},{"line_number":56,"context_line":"    for user, creds in users_creds.items():"},{"line_number":57,"context_line":"        for key, val in creds.items():"},{"line_number":58,"context_line":"            if key \u003d\u003d \u0027path\u0027:"},{"line_number":59,"context_line":"                vhost \u003d re.sub(\"^/\", \"\", val)"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_662fc3a7","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":12},"in_reply_to":"7faddb67_9b9c9f6b","updated":"2019-07-22 14:38:24.000000000","message":"Thanks a lot for the review!","commit_id":"30705aaf4010a39bac44aadc6d9cf5f38c939088"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cb357cc970d6f0588c5deb7f407afaf565a06915","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                               \"read\": \".*\""},{"line_number":83,"context_line":"                              }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        output[\u0027vhosts\u0027].append(vhost_struct)"},{"line_number":86,"context_line":"        output[\u0027users\u0027].append(user_struct)"},{"line_number":87,"context_line":"        output[\u0027permissions\u0027].append(perm_struct)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_db7bf726","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":44},"updated":"2019-07-22 10:28:31.000000000","message":"nit: wouldn\u0027t ```{\"name\": re.sub(\"^/\", \"\",cred[\u0027path\u0027])}``` be simpler at the end, rather than having to loop, check key, and extract value? (assuming cred var whose content is equivalent users_creds.items().items()","commit_id":"30705aaf4010a39bac44aadc6d9cf5f38c939088"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"1d7ff5de4a3f897dc0e0280cbc5df6dbee668f6f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                               \"read\": \".*\""},{"line_number":83,"context_line":"                              }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        output[\u0027vhosts\u0027].append(vhost_struct)"},{"line_number":86,"context_line":"        output[\u0027users\u0027].append(user_struct)"},{"line_number":87,"context_line":"        output[\u0027permissions\u0027].append(perm_struct)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_e622d3ba","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":44},"in_reply_to":"7faddb67_db7bf726","updated":"2019-07-22 14:38:24.000000000","message":"Agree, it could reduce the code a little.","commit_id":"30705aaf4010a39bac44aadc6d9cf5f38c939088"}],"rabbitmq/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"35bc177bc3b751583dee9f271f85acd62dcab54c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"# (ohryhorov): define users in the section below which have to be"},{"line_number":175,"context_line":"#              created by rabbitmq at start up stage through definitions.json"},{"line_number":176,"context_line":"#              file and enable job_users_create manifest."},{"line_number":177,"context_line":"#  users:"},{"line_number":178,"context_line":"#    keystone_service:"},{"line_number":179,"context_line":"#      auth:"},{"line_number":180,"context_line":"#        keystone_username:"},{"line_number":181,"context_line":"#          username: keystone"},{"line_number":182,"context_line":"#          password: password"},{"line_number":183,"context_line":"#      path: /keystone"},{"line_number":184,"context_line":"#    glance_service:"},{"line_number":185,"context_line":"#      auth:"},{"line_number":186,"context_line":"#        glance_username:"},{"line_number":187,"context_line":"#          username: glance"},{"line_number":188,"context_line":"#          password: password"},{"line_number":189,"context_line":"#      path: /glance"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"dependencies:"},{"line_number":192,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0787c2d9","line":189,"range":{"start_line":177,"start_character":0,"end_line":189,"end_character":20},"updated":"2019-07-24 14:42:36.000000000","message":"Would it make sense to define this in the endpoints section?  Maybe a services: key under .Values.endpoints.oslo_messaging.auth, and then consume the services: key to create the users.  The functionality should be the same, but it adheres to the standard of defining user credentials and vhost paths in the endpoints section","commit_id":"0fd813e9bbee1916d98f8183b1165fd8a56b98c6"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"b175232f9cff4346c09756b39b0525b371f2344b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"# (ohryhorov): define users in the section below which have to be"},{"line_number":175,"context_line":"#              created by rabbitmq at start up stage through definitions.json"},{"line_number":176,"context_line":"#              file and enable job_users_create manifest."},{"line_number":177,"context_line":"#  users:"},{"line_number":178,"context_line":"#    keystone_service:"},{"line_number":179,"context_line":"#      auth:"},{"line_number":180,"context_line":"#        keystone_username:"},{"line_number":181,"context_line":"#          username: keystone"},{"line_number":182,"context_line":"#          password: password"},{"line_number":183,"context_line":"#      path: /keystone"},{"line_number":184,"context_line":"#    glance_service:"},{"line_number":185,"context_line":"#      auth:"},{"line_number":186,"context_line":"#        glance_username:"},{"line_number":187,"context_line":"#          username: glance"},{"line_number":188,"context_line":"#          password: password"},{"line_number":189,"context_line":"#      path: /glance"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"dependencies:"},{"line_number":192,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_fd71cb45","line":189,"range":{"start_line":177,"start_character":0,"end_line":189,"end_character":20},"in_reply_to":"7faddb67_0787c2d9","updated":"2019-07-25 12:36:43.000000000","message":"The idea is to keep the same structure like it already is in .Values.endpoint.oslo_messaging to use like a template\nwith the same structure/data in both places .Values.endpoints.oslo_messaging and .Values.conf.users.auth. In addition \nthis approach drastically useful if values.yaml is generated by a metadata server or similar.","commit_id":"0fd813e9bbee1916d98f8183b1165fd8a56b98c6"}]}