)]}'
{"helm-toolkit/templates/manifests/_job-bootstrap.tpl":[{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"ac371f072e19d1e552e95ca974940ebe639e8609","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $logConfigFile :\u003d index . \"logConfigFile\" | default (printf \"/etc/%s/logging.conf\" $serviceName ) -}}"},{"line_number":32,"context_line":"{{- $keystoneUser :\u003d index . \"keystoneUser\" | default $serviceName -}}"},{"line_number":33,"context_line":"{{- $openrc :\u003d index . \"openrc\" | default \"true\" -}}"},{"line_number":34,"context_line":"{{- $secretBin :\u003d index . \"secretBin\" -}}"},{"line_number":35,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" -}}"},{"line_number":36,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" -}}"},{"line_number":37,"context_line":"{{- $serviceNamePretty :\u003d $serviceName | replace \"_\" \"-\" -}}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"7faddb67_9d717479","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":40},"updated":"2019-07-30 16:09:11.000000000","message":"Do we have the use case in where we need to encode the executable script?","commit_id":"8b72dc4505e9a5276442a8be79db22ab844b780a"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"abdbc5cbc1befd87030923c8283e8533a430dc58","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $logConfigFile :\u003d index . \"logConfigFile\" | default (printf \"/etc/%s/logging.conf\" $serviceName ) -}}"},{"line_number":32,"context_line":"{{- $keystoneUser :\u003d index . \"keystoneUser\" | default $serviceName -}}"},{"line_number":33,"context_line":"{{- $openrc :\u003d index . \"openrc\" | default \"true\" -}}"},{"line_number":34,"context_line":"{{- $secretBin :\u003d index . \"secretBin\" -}}"},{"line_number":35,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" -}}"},{"line_number":36,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" -}}"},{"line_number":37,"context_line":"{{- $serviceNamePretty :\u003d $serviceName | replace \"_\" \"-\" -}}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"7faddb67_e0a6bb0f","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":40},"in_reply_to":"7faddb67_9d717479","updated":"2019-07-30 16:56:40.000000000","message":"Yes, the use case is the postgresql backup/restore enhancements: https://review.opendev.org/#/c/655231/71/postgresql/templates/job-ks-user.yaml\n\nIn this case the keystone user creation shell script is contained in a secret rather than a configMap. This is because Postgresql was recently converted to use Secret for its scripts instead of ConfigMap: https://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dpostgresql/templates/configmap-bin.yaml;h\u003df5c931ea54ebf3ff47982704c90a9cfad9f31911;hb\u003drefs/heads/master","commit_id":"8b72dc4505e9a5276442a8be79db22ab844b780a"}],"helm-toolkit/templates/manifests/_job-ks-service.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"55d7f1ca2b4165bd1068b2b6fab8872ca75fc183","unresolved":false,"context_lines":[{"line_number":82,"context_line":"{{- if $secretBin }}"},{"line_number":83,"context_line":"          secret:"},{"line_number":84,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":85,"context_line":"            defaultMode: 0555"},{"line_number":86,"context_line":"{{- else }}"},{"line_number":87,"context_line":"          configMap:"},{"line_number":88,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7faddb67_581caa12","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":29},"updated":"2019-07-25 15:26:54.000000000","message":"444","commit_id":"0208dc4ed7673bbc999f919eb71bfba08cb17cdf"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"59831e7c85a55aff9d2b3f55499f9a4b54c463b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"{{- if $secretBin }}"},{"line_number":83,"context_line":"          secret:"},{"line_number":84,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":85,"context_line":"            defaultMode: 0555"},{"line_number":86,"context_line":"{{- else }}"},{"line_number":87,"context_line":"          configMap:"},{"line_number":88,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7faddb67_d8917a48","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":29},"in_reply_to":"7faddb67_581caa12","updated":"2019-07-25 15:33:01.000000000","message":"Fixed.","commit_id":"0208dc4ed7673bbc999f919eb71bfba08cb17cdf"}],"helm-toolkit/templates/manifests/_job-ks-user.yaml.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6231d68e6f302840d53f860cf90521e14fd979a2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{- if $secretBin }}"},{"line_number":89,"context_line":"          secret:"},{"line_number":90,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":91,"context_line":"            defaultMode: 0555"},{"line_number":92,"context_line":"{{- else }}"},{"line_number":93,"context_line":"          configMap:"},{"line_number":94,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_c3650c1f","line":91,"range":{"start_line":91,"start_character":21,"end_line":91,"end_character":29},"updated":"2019-07-25 14:25:40.000000000","message":"should this be 4XX? Does it make sense to have the execute bit set for a secret?","commit_id":"5f2c2e134195d5ea30159d69fd6a0b7d3f770bb7"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"bc0ec6d9e99643b540b31ed5ddd072487eea8778","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{- if $secretBin }}"},{"line_number":89,"context_line":"          secret:"},{"line_number":90,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":91,"context_line":"            defaultMode: 0555"},{"line_number":92,"context_line":"{{- else }}"},{"line_number":93,"context_line":"          configMap:"},{"line_number":94,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_086eca95","line":91,"range":{"start_line":91,"start_character":21,"end_line":91,"end_character":29},"in_reply_to":"7faddb67_350d373e","updated":"2019-07-26 20:27:24.000000000","message":"Actually, I researched this, and 444 is not the right value either. https://v1-13.docs.kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-files-from-a-pod\n\nThe defaultValue 0555 when converted to octal becomes: 1053. But the decimal value 365 converts to 555, which I believe is what we want (we DO want the execute bit because it\u0027s an executable script).\n\nIf the bash script is specified in a configMap, it should also be the same decimal value: 365. See latest patchset for this change.","commit_id":"5f2c2e134195d5ea30159d69fd6a0b7d3f770bb7"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"f9743bea02e5cfaa53a5b02b6f533bcf8d6be947","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{- if $secretBin }}"},{"line_number":89,"context_line":"          secret:"},{"line_number":90,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":91,"context_line":"            defaultMode: 0555"},{"line_number":92,"context_line":"{{- else }}"},{"line_number":93,"context_line":"          configMap:"},{"line_number":94,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_350d373e","line":91,"range":{"start_line":91,"start_character":21,"end_line":91,"end_character":29},"in_reply_to":"7faddb67_c3650c1f","updated":"2019-07-25 15:09:55.000000000","message":"I think you\u0027re right.  Probably should be 444","commit_id":"5f2c2e134195d5ea30159d69fd6a0b7d3f770bb7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"55d7f1ca2b4165bd1068b2b6fab8872ca75fc183","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{- if $secretBin }}"},{"line_number":89,"context_line":"          secret:"},{"line_number":90,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":91,"context_line":"            defaultMode: 0555"},{"line_number":92,"context_line":"{{- else }}"},{"line_number":93,"context_line":"          configMap:"},{"line_number":94,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7faddb67_78272666","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":29},"updated":"2019-07-25 15:26:54.000000000","message":"444","commit_id":"0208dc4ed7673bbc999f919eb71bfba08cb17cdf"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"59831e7c85a55aff9d2b3f55499f9a4b54c463b3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{- if $secretBin }}"},{"line_number":89,"context_line":"          secret:"},{"line_number":90,"context_line":"            secretName: {{ $secretBin | quote }}"},{"line_number":91,"context_line":"            defaultMode: 0555"},{"line_number":92,"context_line":"{{- else }}"},{"line_number":93,"context_line":"          configMap:"},{"line_number":94,"context_line":"            name: {{ $configMapBin | quote }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7faddb67_78988669","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":29},"in_reply_to":"7faddb67_78272666","updated":"2019-07-25 15:33:01.000000000","message":"Fixed.","commit_id":"0208dc4ed7673bbc999f919eb71bfba08cb17cdf"}],"helm-toolkit/templates/manifests/_job-rabbit-init.yaml.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"097cf602e1d2f036e16228e98432dc6282820fcc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            name: {{ $configMapBin | quote }}"},{"line_number":89,"context_line":"            defaultMode: 0555"},{"line_number":90,"context_line":"{{- end }}"},{"line_number":91,"context_line":"  backoffLimit: {{ $backoffLimit }}"},{"line_number":92,"context_line":"{{- if $activeDeadlineSeconds }}"},{"line_number":93,"context_line":"  activeDeadlineSeconds: {{ $activeDeadlineSeconds }}"},{"line_number":94,"context_line":"{{- end }}"},{"line_number":95,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"7faddb67_e6730f7f","line":94,"range":{"start_line":91,"start_character":0,"end_line":94,"end_character":10},"updated":"2019-08-01 14:09:59.000000000","message":"nit: if a future patch is required, can we move this up to  after spec: so they are consistent with the other changes?","commit_id":"124de142a66f83a38b3717fb69a3e0d74f10d338"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"fdbe1ff3e3e6b70031460ce3119d2db9c64cace7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            name: {{ $configMapBin | quote }}"},{"line_number":89,"context_line":"            defaultMode: 0555"},{"line_number":90,"context_line":"{{- end }}"},{"line_number":91,"context_line":"  backoffLimit: {{ $backoffLimit }}"},{"line_number":92,"context_line":"{{- if $activeDeadlineSeconds }}"},{"line_number":93,"context_line":"  activeDeadlineSeconds: {{ $activeDeadlineSeconds }}"},{"line_number":94,"context_line":"{{- end }}"},{"line_number":95,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"7faddb67_e67d4f1c","line":94,"range":{"start_line":91,"start_character":0,"end_line":94,"end_character":10},"in_reply_to":"7faddb67_e6730f7f","updated":"2019-08-01 14:20:53.000000000","message":"I\u0027ll move it up now. I wanted it it to be at the top to be more clear that these are \"job\" parameters, not to be confused with the \"pod spec\" level parameters.  Thanks for catching this.","commit_id":"124de142a66f83a38b3717fb69a3e0d74f10d338"}]}