)]}'
{"ceph-rgw/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"352f24bcb7ec77e5a0bda06f69c8ee3062fe35e6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ $RGW_TEST_TYPE \u003d\u003d RGW_KS ];"},{"line_number":149,"context_line":"then"},{"line_number":150,"context_line":"  echo \"--\u003e Keystone is enabled. Calling function to test keystone based auth \""},{"line_number":151,"context_line":"  rgw_keystone_bucket_validation"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_0e04b67d","line":148,"range":{"start_line":148,"start_character":5,"end_line":148,"end_character":30},"updated":"2019-08-09 20:13:42.000000000","message":"one minor thing: can we put these things in quotes - in case where $RGW_TEST_TYPE isn\u0027t set we will get \n\n   if [ \u003d\u003d RGW_KS ]; \n\nthis will cause this shell script to fail.","commit_id":"62342178852fe008e01d85159ad5b6e029dcc98d"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"d9b149ec765279257e1bfbdf6a50966cf48092d5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ $RGW_TEST_TYPE \u003d\u003d RGW_KS ];"},{"line_number":149,"context_line":"then"},{"line_number":150,"context_line":"  echo \"--\u003e Keystone is enabled. Calling function to test keystone based auth \""},{"line_number":151,"context_line":"  rgw_keystone_bucket_validation"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_91c3d038","line":148,"range":{"start_line":148,"start_character":5,"end_line":148,"end_character":30},"in_reply_to":"7faddb67_0e04b67d","updated":"2019-08-12 17:29:31.000000000","message":"Done","commit_id":"62342178852fe008e01d85159ad5b6e029dcc98d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"352f24bcb7ec77e5a0bda06f69c8ee3062fe35e6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  rgw_keystone_bucket_validation"},{"line_number":152,"context_line":"fi"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"if [ $RGW_TEST_TYPE \u003d\u003d RGW_S3 ];"},{"line_number":155,"context_line":"then"},{"line_number":156,"context_line":"  echo \"--\u003e S3 is enabled. Calling function to test S3 based auth \""},{"line_number":157,"context_line":"  rgw_s3_bucket_validation"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_ee027a6f","line":154,"range":{"start_line":154,"start_character":4,"end_line":154,"end_character":19},"updated":"2019-08-09 20:13:42.000000000","message":"ditto","commit_id":"62342178852fe008e01d85159ad5b6e029dcc98d"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"d9b149ec765279257e1bfbdf6a50966cf48092d5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  rgw_keystone_bucket_validation"},{"line_number":152,"context_line":"fi"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"if [ $RGW_TEST_TYPE \u003d\u003d RGW_S3 ];"},{"line_number":155,"context_line":"then"},{"line_number":156,"context_line":"  echo \"--\u003e S3 is enabled. Calling function to test S3 based auth \""},{"line_number":157,"context_line":"  rgw_s3_bucket_validation"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7faddb67_b1be0cac","line":154,"range":{"start_line":154,"start_character":4,"end_line":154,"end_character":19},"in_reply_to":"7faddb67_ee027a6f","updated":"2019-08-12 17:29:31.000000000","message":"Done","commit_id":"62342178852fe008e01d85159ad5b6e029dcc98d"}],"ceph-rgw/templates/pod-helm-tests.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cc4d79adca057c05517c4cc8fc0a2d0c46857e9b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"              name: {{ $.Values.secrets.identity.user_rgw }}"},{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: rgw_ks_enabled"},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: rgw_s3_enabled"},{"line_number":58,"context_line":"          value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_493593d9","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":30},"updated":"2019-07-29 14:46:41.000000000","message":"This should probably be in all caps, as it\u0027s an environment variable.","commit_id":"38c2542ead8b11a29b48cea3b11e5352b751331e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cc4d79adca057c05517c4cc8fc0a2d0c46857e9b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: rgw_ks_enabled"},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: rgw_s3_enabled"},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_094d5b71","line":57,"range":{"start_line":57,"start_character":16,"end_line":57,"end_character":30},"updated":"2019-07-29 14:46:41.000000000","message":"Same here.","commit_id":"38c2542ead8b11a29b48cea3b11e5352b751331e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cc4d79adca057c05517c4cc8fc0a2d0c46857e9b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"{{- end }}"},{"line_number":87,"context_line":"        - name: RGW_HOST"},{"line_number":88,"context_line":"          value: {{ tuple \"ceph_object_store\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup\" }}"},{"line_number":89,"context_line":"        - name: rgw_s3_enabled"},{"line_number":90,"context_line":"          value: \"true\""},{"line_number":91,"context_line":"        - name: rgw_ks_enabled"},{"line_number":92,"context_line":"          value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_89694bbf","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":30},"updated":"2019-07-29 14:46:41.000000000","message":"Same here.","commit_id":"38c2542ead8b11a29b48cea3b11e5352b751331e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"cc4d79adca057c05517c4cc8fc0a2d0c46857e9b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          value: {{ tuple \"ceph_object_store\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup\" }}"},{"line_number":89,"context_line":"        - name: rgw_s3_enabled"},{"line_number":90,"context_line":"          value: \"true\""},{"line_number":91,"context_line":"        - name: rgw_ks_enabled"},{"line_number":92,"context_line":"          value: \"false\""},{"line_number":93,"context_line":"      command:"},{"line_number":94,"context_line":"        - /tmp/helm-tests.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_496353dd","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":30},"updated":"2019-07-29 14:46:41.000000000","message":"Same here.","commit_id":"38c2542ead8b11a29b48cea3b11e5352b751331e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"22e57a40ceeb8fba268afc2117d2a051bd52f393","unresolved":false,"context_lines":[{"line_number":52,"context_line":"              name: {{ $.Values.secrets.identity.user_rgw }}"},{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_f63b8c98","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":31},"updated":"2019-08-05 21:59:17.000000000","message":"Please capitalize ENV variables as outlined in previous review.","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"2296cb41007c0977d4a3e3d836bef60cc56248a0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"              name: {{ $.Values.secrets.identity.user_rgw }}"},{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_7c8c362e","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":31},"in_reply_to":"7faddb67_f63b8c98","updated":"2019-08-07 18:09:58.000000000","message":"Done","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0fa34093577fd7e86a1c89caf07a43340fab1ef3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_913822ee","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":23},"updated":"2019-08-06 01:32:37.000000000","message":"can we make this value driven by Values.yaml - so in case someone want to use rgw_s3_enabled, they can override the value instead of having to change this file. The behavior before allows for this, but this is now hard coded into this yaml.","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"2296cb41007c0977d4a3e3d836bef60cc56248a0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_dc71aa46","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":23},"in_reply_to":"7faddb67_913822ee","updated":"2019-08-07 18:09:58.000000000","message":"Tin, it\u0027s already done - please, take a look at lines #37 and #79.","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"22e57a40ceeb8fba268afc2117d2a051bd52f393","unresolved":false,"context_lines":[{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_963ed888","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":31},"updated":"2019-08-05 21:59:17.000000000","message":"Same here.","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"2296cb41007c0977d4a3e3d836bef60cc56248a0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_9c91f249","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":31},"in_reply_to":"7faddb67_963ed888","updated":"2019-08-07 18:09:58.000000000","message":"Done","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0fa34093577fd7e86a1c89caf07a43340fab1ef3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"},{"line_number":61,"context_line":"      volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_b13bdee7","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":23},"updated":"2019-08-06 01:32:37.000000000","message":"ditto","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0fa34093577fd7e86a1c89caf07a43340fab1ef3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"{{- end }}"},{"line_number":87,"context_line":"        - name: RGW_HOST"},{"line_number":88,"context_line":"          value: {{ tuple \"ceph_object_store\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup\" }}"},{"line_number":89,"context_line":"        - name: \"rgw_s3_enabled\""},{"line_number":90,"context_line":"          value: \"true\""},{"line_number":91,"context_line":"        - name: \"rgw_ks_enabled\""},{"line_number":92,"context_line":"          value: \"false\""},{"line_number":93,"context_line":"      command:"},{"line_number":94,"context_line":"        - /tmp/helm-tests.sh"},{"line_number":95,"context_line":"      volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_51262ad0","line":92,"range":{"start_line":89,"start_character":0,"end_line":92,"end_character":24},"updated":"2019-08-06 01:32:37.000000000","message":"ditto","commit_id":"852b392ed44c215558b107f82f3f5ecc83190a97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8007c168cb9e2ab2002306a0227b49839c7d81a0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"              name: {{ $.Values.secrets.identity.user_rgw }}"},{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"RGW_KS_ENABLED\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"RGW_S3_ENABLED\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"},{"line_number":61,"context_line":"      volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_480c0dec","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":24},"updated":"2019-08-08 02:46:00.000000000","message":"Would there be new type of thing to be added later besides rgw_ks and rgw_s3, would that make more sense to have this variable same:\n\n   - name: \"RGW_TEST_TYPE\"\n     value: \"RGW_KS\"\n\n(note that\u0027s suggestion, probably not greatly named), and then in the shell script do a match? this reduces the number of variables to toggle. What do you think of that approach?","commit_id":"ebc45aa45455fc3e1ede61d6f49544bfed8b37ce"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"15d10c4bbde690f22213eb4b249d960055fb1fb5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"              name: {{ $.Values.secrets.identity.user_rgw }}"},{"line_number":53,"context_line":"              key: OS_TENANT_NAME"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: \"RGW_KS_ENABLED\""},{"line_number":56,"context_line":"          value: \"true\""},{"line_number":57,"context_line":"        - name: \"RGW_S3_ENABLED\""},{"line_number":58,"context_line":"          value: \"false\""},{"line_number":59,"context_line":"      command:"},{"line_number":60,"context_line":"        - /tmp/helm-tests.sh"},{"line_number":61,"context_line":"      volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_fed0052e","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":24},"in_reply_to":"7faddb67_480c0dec","updated":"2019-08-08 17:17:03.000000000","message":"Thanks, Tin. I like it. I\u0027ll update the PS.","commit_id":"ebc45aa45455fc3e1ede61d6f49544bfed8b37ce"}]}