)]}'
{"mariadb/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4d2264ef19a2a370e528227c14f1cde90e9c729b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        limits:"},{"line_number":181,"context_line":"          memory: \"1024Mi\""},{"line_number":182,"context_line":"          cpu: \"2000m\""},{"line_number":183,"context_line":"      ks_user:"},{"line_number":184,"context_line":"        requests:"},{"line_number":185,"context_line":"          memory: \"128Mi\""},{"line_number":186,"context_line":"          cpu: \"100m\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"dependencies:"},{"line_number":190,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_94d1175a","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":0},"updated":"2019-08-19 15:26:39.000000000","message":"should there be a limits: here?","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"67c224b9b1d36240acbfa87f298d2bc4637f6227","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        limits:"},{"line_number":181,"context_line":"          memory: \"1024Mi\""},{"line_number":182,"context_line":"          cpu: \"2000m\""},{"line_number":183,"context_line":"      ks_user:"},{"line_number":184,"context_line":"        requests:"},{"line_number":185,"context_line":"          memory: \"128Mi\""},{"line_number":186,"context_line":"          cpu: \"100m\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"dependencies:"},{"line_number":190,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_54e2bfd5","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":0},"in_reply_to":"7faddb67_94d1175a","updated":"2019-08-19 15:39:55.000000000","message":"Yes.","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4d2264ef19a2a370e528227c14f1cde90e9c729b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      success: 3"},{"line_number":263,"context_line":"      failed: 1"},{"line_number":264,"context_line":"  ks_user:"},{"line_number":265,"context_line":"    backoffLimit: 1024"},{"line_number":266,"context_line":"    activeDeadlineSeconds: 14400"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"conf:"},{"line_number":269,"context_line":"  tests:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_b46453ba","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":32},"updated":"2019-08-19 15:26:39.000000000","message":"is there a reason why the values for the postgresql\n\n   ks_user:\n     # activeDeadlineSeconds \u003d\u003d 0 means no deadline\n     activeDeadlineSeconds: 0\n     backoffLimit: 6\n\nWhile the mariadDB default 1024/14400? Should there be such parity?","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"331c086f413a2ac8534c50d5b7027bbd4d0b0d76","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      success: 3"},{"line_number":263,"context_line":"      failed: 1"},{"line_number":264,"context_line":"  ks_user:"},{"line_number":265,"context_line":"    backoffLimit: 1024"},{"line_number":266,"context_line":"    activeDeadlineSeconds: 14400"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"conf:"},{"line_number":269,"context_line":"  tests:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_74d1fbcb","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":32},"in_reply_to":"7faddb67_54fb9f79","updated":"2019-08-19 15:42:01.000000000","message":"Thanks for the explanation","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"67c224b9b1d36240acbfa87f298d2bc4637f6227","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      success: 3"},{"line_number":263,"context_line":"      failed: 1"},{"line_number":264,"context_line":"  ks_user:"},{"line_number":265,"context_line":"    backoffLimit: 1024"},{"line_number":266,"context_line":"    activeDeadlineSeconds: 14400"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"conf:"},{"line_number":269,"context_line":"  tests:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_54fb9f79","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":32},"in_reply_to":"7faddb67_b46453ba","updated":"2019-08-19 15:39:55.000000000","message":"The reason for this disparity is postgresql database is not a dependency to keystone. Keystone will have already been provision. In mariadb\u0027s case keystone depend on mariadb so we want to delay the keystone job until keystone is provisioned.","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"43d6aec07af271286c6f01c6c2280c67d23687c8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          cpu: \"2000m\""},{"line_number":183,"context_line":"      ks_user:"},{"line_number":184,"context_line":"        requests:"},{"line_number":185,"context_line":"          memory: \"128Mi\""},{"line_number":186,"context_line":"          cpu: \"100m\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_a422de50","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":21},"updated":"2019-08-19 17:22:31.000000000","message":"limits: is still missing","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"828dcf0c6a22b0e45bf6d6d677bb7607c90d61fc","unresolved":false,"context_lines":[{"line_number":232,"context_line":"      services:"},{"line_number":233,"context_line":"        - endpoint: internal"},{"line_number":234,"context_line":"          service: oslo_db"},{"line_number":235,"context_line":"      jobs:"},{"line_number":236,"context_line":"        - mariadb-ks-user"},{"line_number":237,"context_line":"    tests:"},{"line_number":238,"context_line":"      services:"},{"line_number":239,"context_line":"        - endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_7b4c80c7","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":25},"updated":"2019-08-20 01:38:29.000000000","message":"should this dependency be dynamic and not static since mariadb generally doesn\u0027t depend on keystone?","commit_id":"96845acf6ba465a66d5493090d35750e909dcb7a"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4672346365d590a1d127a936dbaf1e2eee8c6fa1","unresolved":false,"context_lines":[{"line_number":232,"context_line":"      services:"},{"line_number":233,"context_line":"        - endpoint: internal"},{"line_number":234,"context_line":"          service: oslo_db"},{"line_number":235,"context_line":"      jobs:"},{"line_number":236,"context_line":"        - mariadb-ks-user"},{"line_number":237,"context_line":"    tests:"},{"line_number":238,"context_line":"      services:"},{"line_number":239,"context_line":"        - endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_e9409808","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":25},"in_reply_to":"7faddb67_7b4c80c7","updated":"2019-08-20 19:06:11.000000000","message":"Done","commit_id":"96845acf6ba465a66d5493090d35750e909dcb7a"}],"tools/deployment/backup-restore/070-mariadb.sh":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"9d337eaaa0b9a899da18a9769eedf61ab38d4e9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Lint and package chart"},{"line_number":20,"context_line":"make mariadb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":25,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"    --set pod.replicas.server\u003d1 \\"},{"line_number":27,"context_line":"    --set manifests.cron_job_mariadb_backup\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.pvc_backup\u003dtrue \\"},{"line_number":29,"context_line":"    --set conf.backup.remote_backup.enabled\u003dtrue \\"},{"line_number":30,"context_line":"    --set manifests.job_ks_user\u003dtrue \\"},{"line_number":31,"context_line":"    --set manifests.secret_mariadb_backup_ks\u003dtrue \\"},{"line_number":32,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS} \\"},{"line_number":33,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#NOTE: Wait for deploy"},{"line_number":36,"context_line":"./tools/deployment/backup-restore/wait-for-pods.sh openstack 600 mariadb-ks-user mariadb-ks"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#NOTE: Validate Deployment info"},{"line_number":39,"context_line":"helm status mariadb"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"#NOTE: Validate the deployment"},{"line_number":42,"context_line":"helm test mariadb"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7faddb67_0648ab2a","line":42,"range":{"start_line":1,"start_character":0,"end_line":42,"end_character":17},"updated":"2019-08-01 14:05:58.000000000","message":"We don\u0027t need this file nor the other ones in the backup-restore directory, since we won\u0027t have a specific backup-restore job any more as originally planned. So I suggest to just keep the backup/restore test scripts and scrap the 070-mariadb.sh, and other ###-component.sh scripts.","commit_id":"dc468addc828d15f59d85459c3696a11997861c1"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4fc2118e237917a41a1b0fbfdd9ccead85d30f65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Lint and package chart"},{"line_number":20,"context_line":"make mariadb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":25,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"    --set pod.replicas.server\u003d1 \\"},{"line_number":27,"context_line":"    --set manifests.cron_job_mariadb_backup\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.pvc_backup\u003dtrue \\"},{"line_number":29,"context_line":"    --set conf.backup.remote_backup.enabled\u003dtrue \\"},{"line_number":30,"context_line":"    --set manifests.job_ks_user\u003dtrue \\"},{"line_number":31,"context_line":"    --set manifests.secret_mariadb_backup_ks\u003dtrue \\"},{"line_number":32,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS} \\"},{"line_number":33,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#NOTE: Wait for deploy"},{"line_number":36,"context_line":"./tools/deployment/backup-restore/wait-for-pods.sh openstack 600 mariadb-ks-user mariadb-ks"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#NOTE: Validate Deployment info"},{"line_number":39,"context_line":"helm status mariadb"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"#NOTE: Validate the deployment"},{"line_number":42,"context_line":"helm test mariadb"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7faddb67_b19a305f","line":42,"range":{"start_line":1,"start_character":0,"end_line":42,"end_character":17},"in_reply_to":"7faddb67_0648ab2a","updated":"2019-08-01 17:38:40.000000000","message":"There is only one file that is intended to be removed. All the other files are used.","commit_id":"dc468addc828d15f59d85459c3696a11997861c1"}],"tools/deployment/backup-restore/mariadb-backup-pvc-test.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"144fd0727a9b500e8b61ee08c809d4225c38b357","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":18,"id":"7faddb67_8d134501","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":16},"updated":"2019-08-19 19:23:31.000000000","message":"9","commit_id":"c12eaad502479cacb023e0ea914daf5a03bb0f5a"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4672346365d590a1d127a936dbaf1e2eee8c6fa1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":18,"id":"7faddb67_581e6d70","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":16},"in_reply_to":"7faddb67_8d134501","updated":"2019-08-20 19:06:11.000000000","message":"Done","commit_id":"c12eaad502479cacb023e0ea914daf5a03bb0f5a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"144fd0727a9b500e8b61ee08c809d4225c38b357","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export MARIADB_POD_NAMESPACE\u003d$1"},{"line_number":20,"context_line":"export BACKUP_PATH\u003d/var/backup"}],"source_content_type":"text/x-sh","patch_set":18,"id":"7faddb67_6d18491d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2019-08-19 19:23:31.000000000","message":"can we set this to -xe so we don\u0027t silently swallow error?","commit_id":"c12eaad502479cacb023e0ea914daf5a03bb0f5a"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4672346365d590a1d127a936dbaf1e2eee8c6fa1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export MARIADB_POD_NAMESPACE\u003d$1"},{"line_number":20,"context_line":"export BACKUP_PATH\u003d/var/backup"}],"source_content_type":"text/x-sh","patch_set":18,"id":"7faddb67_f810795b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"7faddb67_6d18491d","updated":"2019-08-20 19:06:11.000000000","message":"Done","commit_id":"c12eaad502479cacb023e0ea914daf5a03bb0f5a"}],"tools/deployment/backup-restore/mariadb-backup-remote-test.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"828dcf0c6a22b0e45bf6d6d677bb7607c90d61fc","unresolved":false,"context_lines":[{"line_number":416,"context_line":"if [ \"${result}\" \u003d\u003d \"Verify Backup\" ]"},{"line_number":417,"context_line":"then"},{"line_number":418,"context_line":"  cleanup"},{"line_number":419,"context_line":"  echo \"Database restore successfull\""},{"line_number":420,"context_line":"  exit 0"},{"line_number":421,"context_line":"else"},{"line_number":422,"context_line":"  cleanup"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7faddb67_5b666453","line":419,"range":{"start_line":419,"start_character":25,"end_line":419,"end_character":36},"updated":"2019-08-20 01:38:29.000000000","message":"successful","commit_id":"96845acf6ba465a66d5493090d35750e909dcb7a"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4672346365d590a1d127a936dbaf1e2eee8c6fa1","unresolved":false,"context_lines":[{"line_number":416,"context_line":"if [ \"${result}\" \u003d\u003d \"Verify Backup\" ]"},{"line_number":417,"context_line":"then"},{"line_number":418,"context_line":"  cleanup"},{"line_number":419,"context_line":"  echo \"Database restore successfull\""},{"line_number":420,"context_line":"  exit 0"},{"line_number":421,"context_line":"else"},{"line_number":422,"context_line":"  cleanup"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7faddb67_a06958f8","line":419,"range":{"start_line":419,"start_character":25,"end_line":419,"end_character":36},"in_reply_to":"7faddb67_5b666453","updated":"2019-08-20 19:06:11.000000000","message":"Done","commit_id":"96845acf6ba465a66d5493090d35750e909dcb7a"}],"tools/deployment/keystone-auth/070-keystone.sh":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e61946bf5123ac62d2765e042ea45023d945ded","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_LDAP}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":33,"context_line":"./tools/deployment/backup-restore/wait-for-pods.sh openstack 600 mariadb-ks-user mariadb-ks"},{"line_number":34,"context_line":"sleep 150"},{"line_number":35,"context_line":"helm status ldap"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"helm upgrade --install keystone ${OSH_PATH}/keystone \\"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7faddb67_27ea700e","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":9},"updated":"2019-08-19 18:00:20.000000000","message":"Is this needed both before deploying keystone and after?","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"034aabdc7539326405676cba9f7899cb99d60031","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_LDAP}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":33,"context_line":"./tools/deployment/backup-restore/wait-for-pods.sh openstack 600 mariadb-ks-user mariadb-ks"},{"line_number":34,"context_line":"sleep 150"},{"line_number":35,"context_line":"helm status ldap"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"helm upgrade --install keystone ${OSH_PATH}/keystone \\"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7faddb67_8d47c5a3","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":9},"in_reply_to":"7faddb67_27ea700e","updated":"2019-08-19 20:04:03.000000000","message":"This is existing code that I only add option to the wait-for-pods.sh script.","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"}],"tools/deployment/osh-infra-monitoring/045-mariadb.sh":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e61946bf5123ac62d2765e042ea45023d945ded","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":25,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":26,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue \\"},{"line_number":27,"context_line":"    --set manifests.cron_job_mariadb_backup\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.pvc_backup\u003dtrue \\"},{"line_number":29,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS} \\"},{"line_number":30,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"7faddb67_678e287a","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":37},"updated":"2019-08-19 18:00:20.000000000","message":"I don\u0027t think the AIO monitoring has keystone.","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"034aabdc7539326405676cba9f7899cb99d60031","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":25,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":26,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue \\"},{"line_number":27,"context_line":"    --set manifests.cron_job_mariadb_backup\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.pvc_backup\u003dtrue \\"},{"line_number":29,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS} \\"},{"line_number":30,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"7faddb67_4d99cd1c","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":37},"in_reply_to":"7faddb67_678e287a","updated":"2019-08-19 20:04:03.000000000","message":"There are two version of the backup: one that uses pvc and one that uses swift. The one that use pvc does not need keystone.","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c6ddb11de70d54b4c7606e19ccb627b12f39af07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7faddb67_4c321af4","updated":"2019-08-20 17:56:30.000000000","message":"Can we create a new test job for this instead of modifying all of the default gate scripts?\n\nThis can be done via dynamic dependencies and/or creating separate gate scripts.","commit_id":"5ab5e7e0f559375ca9d4eb840e5649ec57371a54"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4672346365d590a1d127a936dbaf1e2eee8c6fa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7faddb67_47faf342","in_reply_to":"7faddb67_4c321af4","updated":"2019-08-20 19:06:11.000000000","message":"That was what we had and the community ask that we integrate it into the current gates.","commit_id":"5ab5e7e0f559375ca9d4eb840e5649ec57371a54"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"5e0966861e8a2a43b63b1407adf0f1a374a3c688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7faddb67_a765e7e2","in_reply_to":"7faddb67_4c321af4","updated":"2019-08-20 18:38:25.000000000","message":"We originally had a separate job for this validation (for both mariadb and postgresql), but then some of the core approvers, in a openstack-helm meeting, gave us the feedback that they\u0027d like to see these backup restore scripts a part of the already existing gates instead of creating new gate jobs.","commit_id":"5ab5e7e0f559375ca9d4eb840e5649ec57371a54"}],"zuul.d/project.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"9d337eaaa0b9a899da18a9769eedf61ab38d4e9e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        - openstack-helm-infra-elastic-beats"},{"line_number":58,"context_line":"        - openstack-helm-infra-armada-deploy"},{"line_number":59,"context_line":"        - openstack-helm-infra-armada-update-uuid"},{"line_number":60,"context_line":"        - openstack-helm-infra-armada-update-passwords"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_66e95f18","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":54},"updated":"2019-08-01 14:05:58.000000000","message":"I think all that\u0027s added here is some whitespace.","commit_id":"dc468addc828d15f59d85459c3696a11997861c1"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bd32ef4b512c84fc1a8d9e8ab0490ea70cc11c9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7faddb67_8d4d853c","updated":"2019-08-02 15:36:41.000000000","message":"Why is this file deleted?","commit_id":"534bf6c7ead2b0e52bc0cc8a41b4de6b7e198fd8"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"7e7a92a1d48fa4401d1786c415f1af85f80a0c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7faddb67_a8438c3e","in_reply_to":"7faddb67_8d4d853c","updated":"2019-08-02 19:16:57.000000000","message":"I just remove it from my PS since I did not need to change it anymore.","commit_id":"534bf6c7ead2b0e52bc0cc8a41b4de6b7e198fd8"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"4df5ccf7061fd8d2577c6f2ebe74760d974b9ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7faddb67_99ef1286","in_reply_to":"7faddb67_a8438c3e","updated":"2019-08-19 15:09:47.000000000","message":"Need to fix this.  If this PS is merged, it will delete the file and cause gate issues.","commit_id":"534bf6c7ead2b0e52bc0cc8a41b4de6b7e198fd8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4d2264ef19a2a370e528227c14f1cde90e9c729b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7faddb67_94e83716","updated":"2019-08-19 15:26:39.000000000","message":"This file shouldn\u0027t be removed.","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"67c224b9b1d36240acbfa87f298d2bc4637f6227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7faddb67_74833bcc","in_reply_to":"7faddb67_94e83716","updated":"2019-08-19 15:39:55.000000000","message":"ok","commit_id":"4a3ab6443c5079ad9e1f770395c1d8017dc75b54"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e61946bf5123ac62d2765e042ea45023d945ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7faddb67_2785905a","updated":"2019-08-19 18:00:20.000000000","message":"unneeded file change","commit_id":"28f1de553c4e386223cdd1eaecb0562593cac7c5"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c6ddb11de70d54b4c7606e19ccb627b12f39af07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7faddb67_8c13325c","updated":"2019-08-20 17:56:30.000000000","message":"unneeded file change","commit_id":"5ab5e7e0f559375ca9d4eb840e5649ec57371a54"},{"author":{"_account_id":28875,"name":"Koffi Nogbe","email":"kn4078@att.com","username":"kn4078"},"change_message_id":"4fbd8be66c417737b4a929dafde0f7fe9a6c2a38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7faddb67_5d2646cd","in_reply_to":"7faddb67_8c13325c","updated":"2019-08-20 20:46:35.000000000","message":"I have not change this file at all and there is no space nor empty line in the file.","commit_id":"5ab5e7e0f559375ca9d4eb840e5649ec57371a54"}]}