)]}'
{"mariadb/templates/bin/_mariadb-ingress-controller.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"e2bf2299a00440498cad78b9bc2fbc970903048e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      --ingress-class\u003d${INGRESS_CLASS} \\"},{"line_number":30,"context_line":"      --default-backend-service\u003d${POD_NAMESPACE}/${ERROR_PAGE_SERVICE} \\"},{"line_number":31,"context_line":"      --configmap\u003d${POD_NAMESPACE}/mariadb-ingress-conf \\"},{"line_number":32,"context_line":"      {{ include \"helm-toolkit.utils.joinListWithSpace\" $.Values.conf.ingress_ctrl_params }} \\"},{"line_number":33,"context_line":"      --tcp-services-configmap\u003d${POD_NAMESPACE}/mariadb-services-tcp"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"7faddb67_1cfdb43a","line":32,"range":{"start_line":32,"start_character":56,"end_line":32,"end_character":89},"updated":"2019-08-12 22:23:43.000000000","message":"Shouldn\u0027t this be \".Values.conf.ingress_ctrl_params\" ?","commit_id":"bd3f61e0314f74b2ab4d413ac7da2e98c4daf436"}],"mariadb/templates/configmap-etc.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"06400f6470379fc0aa850c62b6a748e1b5115518","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  99-force.cnf: |"},{"line_number":32,"context_line":"{{ tuple \"etc/_99-force.cnf.tpl\" $envAll | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":33,"context_line":"{{- if $envAll.Values.conf.ingress }}"},{"line_number":34,"context_line":"  nginx.tmpl: |"},{"line_number":35,"context_line":"{{ $envAll.Values.conf.ingress | indent 4 }}"},{"line_number":36,"context_line":"{{- else if $envAll.Values.conf.custom_tmpl }}"},{"line_number":37,"context_line":"{{ ( $envAll.Files.Glob \"files/nginx.tmpl\" ).AsConfig | indent 2 }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_85b94ecc","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"updated":"2019-08-12 15:23:19.000000000","message":"If this key gets orphaned, will the empty rendering cause failures?","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"08fefbba27999499697205ee0d3007caa216ed0c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  99-force.cnf: |"},{"line_number":32,"context_line":"{{ tuple \"etc/_99-force.cnf.tpl\" $envAll | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":33,"context_line":"{{- if $envAll.Values.conf.ingress }}"},{"line_number":34,"context_line":"  nginx.tmpl: |"},{"line_number":35,"context_line":"{{ $envAll.Values.conf.ingress | indent 4 }}"},{"line_number":36,"context_line":"{{- else if $envAll.Values.conf.custom_tmpl }}"},{"line_number":37,"context_line":"{{ ( $envAll.Files.Glob \"files/nginx.tmpl\" ).AsConfig | indent 2 }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_86607137","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"7faddb67_85b94ecc","updated":"2019-08-12 20:02:19.000000000","message":"If we don\u0027t have a nginx.tmpl defined (and also don\u0027t include the one under files/nginx.tmpl, the default one in the image will be used. If we have $envAll.Values.conf.ingress set, we need to provide the complete nginx.tmpl.","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"e2bf2299a00440498cad78b9bc2fbc970903048e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"{{ $envAll.Values.conf.ingress | indent 4 }}"},{"line_number":36,"context_line":"{{- else if $envAll.Values.conf.include_ingress_config_tmpl }}"},{"line_number":37,"context_line":"{{ ( $envAll.Files.Glob \"files/nginx.tmpl\" ).AsConfig | indent 2 }}"},{"line_number":38,"context_line":"{{- end }}"},{"line_number":39,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_1c8294a6","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":10},"updated":"2019-08-12 22:23:43.000000000","message":"Shouldn\u0027t we have a final \"else\" clause to catch the cases where include_ingress_config_tmpl is false?","commit_id":"bd3f61e0314f74b2ab4d413ac7da2e98c4daf436"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"3c9695f3d69c247e2c0ccb87810fa27e0fba06f9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"{{ $envAll.Values.conf.ingress | indent 4 }}"},{"line_number":36,"context_line":"{{- else if $envAll.Values.conf.include_ingress_config_tmpl }}"},{"line_number":37,"context_line":"{{ ( $envAll.Files.Glob \"files/nginx.tmpl\" ).AsConfig | indent 2 }}"},{"line_number":38,"context_line":"{{- end }}"},{"line_number":39,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_bca90025","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":10},"in_reply_to":"7faddb67_1c8294a6","updated":"2019-08-12 22:26:16.000000000","message":"Nevermind.  I know why you left that out, nothing is to be done if it\u0027s false.  Disregard the question.","commit_id":"bd3f61e0314f74b2ab4d413ac7da2e98c4daf436"}],"mariadb/templates/deployment-ingress.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f6b108d67a6d325c6b2ed788b64aac53f9d2c383","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ tuple $envAll \"ingress\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: rbac.authorization.k8s.io/v1beta1"},{"line_number":26,"context_line":"kind: ClusterRole"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":29,"context_line":"rules:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_1ebecf64","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"updated":"2019-08-15 17:07:07.000000000","message":"why do we need this?","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"f964ccc01264e8fafd9673f21e9c88697d27492f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ tuple $envAll \"ingress\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: rbac.authorization.k8s.io/v1beta1"},{"line_number":26,"context_line":"kind: ClusterRole"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":29,"context_line":"rules:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_b9f6b58e","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"7faddb67_1ebecf64","updated":"2019-08-15 17:55:00.000000000","message":"during the startup of the mariadb ingress controller of the updated version, it needs to access the node, which needs a clusterrole. Let me test out the minimum access needed and make the changes.","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4f17793a2e4c915b2b76cf0d9c4a27c4a3490718","unresolved":false,"context_lines":[{"line_number":259,"context_line":"              mountPath: /tmp/mariadb-ingress-controller.sh"},{"line_number":260,"context_line":"              subPath: mariadb-ingress-controller.sh"},{"line_number":261,"context_line":"              readOnly: true"},{"line_number":262,"context_line":"            {{- if or $envAll.Values.conf.ingress.tmpl_override $envAll.Values.conf.ingress.include_tmpl_file }}"},{"line_number":263,"context_line":"            - name: mariadb-etc"},{"line_number":264,"context_line":"              mountPath: /etc/nginx/template/nginx.tmpl"},{"line_number":265,"context_line":"              subPath: nginx.tmpl"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_9e3e3f27","line":262,"range":{"start_line":262,"start_character":92,"end_line":262,"end_character":109},"updated":"2019-08-15 17:01:33.000000000","message":"we need to update this name","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c810cc068e7c6277bbdf8b29d90fe7d931d18f52","unresolved":false,"context_lines":[{"line_number":259,"context_line":"              mountPath: /tmp/mariadb-ingress-controller.sh"},{"line_number":260,"context_line":"              subPath: mariadb-ingress-controller.sh"},{"line_number":261,"context_line":"              readOnly: true"},{"line_number":262,"context_line":"            {{- if or $envAll.Values.conf.ingress.tmpl_override $envAll.Values.conf.ingress.include_tmpl_file }}"},{"line_number":263,"context_line":"            - name: mariadb-etc"},{"line_number":264,"context_line":"              mountPath: /etc/nginx/template/nginx.tmpl"},{"line_number":265,"context_line":"              subPath: nginx.tmpl"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_611f1f6c","line":262,"range":{"start_line":262,"start_character":92,"end_line":262,"end_character":109},"in_reply_to":"7faddb67_9e3e3f27","updated":"2019-08-15 20:57:20.000000000","message":"good catch, missed this - will update.","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4f17793a2e4c915b2b76cf0d9c4a27c4a3490718","unresolved":false,"context_lines":[{"line_number":272,"context_line":"          configMap:"},{"line_number":273,"context_line":"            name: mariadb-bin"},{"line_number":274,"context_line":"            defaultMode: 0555"},{"line_number":275,"context_line":"        {{- if or $envAll.Values.conf.ingress.tmpl_override $envAll.Values.conf.ingress.include_tmpl_file }}"},{"line_number":276,"context_line":"        - name: mariadb-etc"},{"line_number":277,"context_line":"          configMap:"},{"line_number":278,"context_line":"            name: mariadb-etc"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_fe0e538a","line":275,"range":{"start_line":275,"start_character":88,"end_line":275,"end_character":105},"updated":"2019-08-15 17:01:33.000000000","message":"pls update this name","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c810cc068e7c6277bbdf8b29d90fe7d931d18f52","unresolved":false,"context_lines":[{"line_number":272,"context_line":"          configMap:"},{"line_number":273,"context_line":"            name: mariadb-bin"},{"line_number":274,"context_line":"            defaultMode: 0555"},{"line_number":275,"context_line":"        {{- if or $envAll.Values.conf.ingress.tmpl_override $envAll.Values.conf.ingress.include_tmpl_file }}"},{"line_number":276,"context_line":"        - name: mariadb-etc"},{"line_number":277,"context_line":"          configMap:"},{"line_number":278,"context_line":"            name: mariadb-etc"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_0110ab58","line":275,"range":{"start_line":275,"start_character":88,"end_line":275,"end_character":105},"in_reply_to":"7faddb67_fe0e538a","updated":"2019-08-15 20:57:20.000000000","message":"Done","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"}],"mariadb/values.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"06400f6470379fc0aa850c62b6a748e1b5115518","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_a2aa406e","line":274,"range":{"start_line":273,"start_character":0,"end_line":274,"end_character":41},"updated":"2019-08-12 15:23:19.000000000","message":"I think a list of params makes more sense in the ingress_conf dictionary rather than its own section.","commit_id":"ae8b53965d31949cd834b63d36b1f7b803884a06"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b97f7c6066eca21a5ae3529c882233d9744df28c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_85906e44","line":272,"range":{"start_line":272,"start_character":2,"end_line":272,"end_character":13},"updated":"2019-08-12 15:21:23.000000000","message":"can we change this name to be more indicative of what this custom template is for? a custom_tmpl under conf: for a mariadb chart seems kind of generic.","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"08fefbba27999499697205ee0d3007caa216ed0c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_86c5d10c","line":272,"range":{"start_line":272,"start_character":2,"end_line":272,"end_character":13},"in_reply_to":"7faddb67_85906e44","updated":"2019-08-12 20:02:19.000000000","message":"This value indicates if we want to use the file/nginx.tmpl file as the customized ingress nginx template. I\u0027ll change it to include_ingress_config_tmpl","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"06400f6470379fc0aa850c62b6a748e1b5115518","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_c5a506a1","line":274,"range":{"start_line":273,"start_character":0,"end_line":274,"end_character":41},"updated":"2019-08-12 15:23:19.000000000","message":"Should we move these under the ingress_conf section? It seems redundant to have a separate param section.","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"08fefbba27999499697205ee0d3007caa216ed0c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_86ee3189","line":274,"range":{"start_line":273,"start_character":0,"end_line":274,"end_character":41},"in_reply_to":"7faddb67_c5a506a1","updated":"2019-08-12 20:02:19.000000000","message":"This is the additional options that we can add for the nginx-ingress-controller. The mariadb-ingress-conf is another option (--confimap) of the nginx-ingress-controller","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"649dfd8cdb1d33b9bce6636db11eca4f3ae5f093","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  custom_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_852cee01","line":274,"range":{"start_line":273,"start_character":0,"end_line":274,"end_character":41},"in_reply_to":"7faddb67_c5a506a1","updated":"2019-08-12 15:28:04.000000000","message":"was thinking these ingress things should probably be all consolidated as well.","commit_id":"6c7e89ddc01ae9aa5e96d738c9877b23427199d8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"22ee0ee83022ad344cec7be51a498b37283ea9d7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"      - --number-of-queries\u003d1000"},{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  include_ingress_config_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"},{"line_number":278,"context_line":"    enabled: true"},{"line_number":279,"context_line":"    base_path: /var/backup"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_3198b573","line":276,"range":{"start_line":271,"start_character":0,"end_line":276,"end_character":28},"updated":"2019-08-14 14:16:17.000000000","message":"Now there are like 4 parameters related to the mariadb ingress - do you think it would make sense we refactor pull them all under 1 centralized key in this yaml?","commit_id":"7df99f9b94b8ebdff0e8dc57202c3019dfd5d520"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ea864bff913e2476928844218db421b9860bcc94","unresolved":false,"context_lines":[{"line_number":268,"context_line":"      - --number-of-queries\u003d1000"},{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress: null"},{"line_number":272,"context_line":"  include_ingress_config_tmpl: true"},{"line_number":273,"context_line":"  ingress_ctrl_params:"},{"line_number":274,"context_line":"    - --enable-ssl-chain-completion\u003dfalse"},{"line_number":275,"context_line":"  ingress_conf:"},{"line_number":276,"context_line":"    worker-processes: \"auto\""},{"line_number":277,"context_line":"  backup:"},{"line_number":278,"context_line":"    enabled: true"},{"line_number":279,"context_line":"    base_path: /var/backup"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_96ee3c1f","line":276,"range":{"start_line":271,"start_character":0,"end_line":276,"end_character":28},"in_reply_to":"7faddb67_3198b573","updated":"2019-08-14 15:28:22.000000000","message":"\u003e Now there are like 4 parameters related to the mariadb ingress - do\n \u003e you think it would make sense we refactor pull them all under 1\n \u003e centralized key in this yaml?\n\nI pointed this out on a previous PS. I agree that we should consider a refactor, perhaps in a change that this one depends on.","commit_id":"7df99f9b94b8ebdff0e8dc57202c3019dfd5d520"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"d1fdd0978f5a4eb3cdaca302ed6f4aa088d89017","unresolved":false,"context_lines":[{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    ingress_tmpl_override: null"},{"line_number":273,"context_line":"    include_ingress_tmpl_file: true"},{"line_number":274,"context_line":"    ingress_ctrl_params:"},{"line_number":275,"context_line":"      - --enable-ssl-chain-completion\u003dfalse"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_1946ff51","line":272,"range":{"start_line":272,"start_character":27,"end_line":272,"end_character":31},"updated":"2019-08-14 15:46:01.000000000","message":"It might be simpler to understand if this was a boolean value, with the default being \"false\".","commit_id":"67b65869d190e7401b8d1eb009448590cd61c7d0"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"16e00e96041179dfeb5149c7f21da67ae41787ec","unresolved":false,"context_lines":[{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    ingress_tmpl_override: null"},{"line_number":273,"context_line":"    include_ingress_tmpl_file: true"},{"line_number":274,"context_line":"    ingress_ctrl_params:"},{"line_number":275,"context_line":"      - --enable-ssl-chain-completion\u003dfalse"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_59cb1752","line":272,"range":{"start_line":272,"start_character":27,"end_line":272,"end_character":31},"in_reply_to":"7faddb67_1946ff51","updated":"2019-08-14 16:02:55.000000000","message":"This is the nginx.tmpl override. Basically, we have 3 options now: use the nginx.tmpl 1) from the files directory, 2) from the raw data of this key value and 3) use the default from the image. Yes, you are right, I have missed one code to update in the configmap-etc. Updated below :)","commit_id":"67b65869d190e7401b8d1eb009448590cd61c7d0"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ee564a1602acb59224ba30750a911c42b729ff01","unresolved":false,"context_lines":[{"line_number":268,"context_line":"      - --number-of-queries\u003d1000"},{"line_number":269,"context_line":"      - --number-char-cols\u003d1"},{"line_number":270,"context_line":"      - --number-int-cols\u003d1"},{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    ingress_tmpl_override: null"},{"line_number":273,"context_line":"    include_ingress_tmpl_file: true"},{"line_number":274,"context_line":"    ingress_ctrl_params:"},{"line_number":275,"context_line":"      - --enable-ssl-chain-completion\u003dfalse"},{"line_number":276,"context_line":"    ingress_conf:"},{"line_number":277,"context_line":"      worker-processes: \"auto\""},{"line_number":278,"context_line":"  backup:"},{"line_number":279,"context_line":"    enabled: true"},{"line_number":280,"context_line":"    base_path: /var/backup"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_b95c8b7d","line":277,"range":{"start_line":271,"start_character":0,"end_line":277,"end_character":30},"updated":"2019-08-14 16:10:15.000000000","message":"This is better, but can we reduce the amount of references to \"ingress\".\n\nCould we change it to something like this:\n\n  ingress:\n    tmpl_format:\n      enabled: true # replaces null value\n      data:\n        # dict containing tmpl_override data\n    params:\n      # dict containing params\n    ingress.conf:\n      # raw data for config file\n\nSome interpretation of the above would also suffice.","commit_id":"431abc61ee6a3f3a71e43104d952cc709d798f76"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"5810bb841cb3e9696136f5247d7d9f7d686fd2f1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    # Indicate if we want to override nginx template. If this is set to"},{"line_number":273,"context_line":"    # false, we will be using the one that comes with the image."},{"line_number":274,"context_line":"    enabled_override: true"},{"line_number":275,"context_line":"    # The nginx.tmpl raw data file used to replace files/nginx.tmpl, if"},{"line_number":276,"context_line":"    # sets to null, we will use the one in files/nginx.tmpl that comes with the chart."},{"line_number":277,"context_line":"    tmpl_override: null"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_7e97c346","line":274,"range":{"start_line":274,"start_character":4,"end_line":274,"end_character":20},"updated":"2019-08-15 16:52:20.000000000","message":"The tmpl_override is the raw nginx.tmpl, which has more than 1000 lines of data","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"be03b8e8dc23f716ae3320da45c3d68424bc05d1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    # Indicate if we want to override nginx template. If this is set to"},{"line_number":273,"context_line":"    # false, we will be using the one that comes with the image."},{"line_number":274,"context_line":"    enabled_override: true"},{"line_number":275,"context_line":"    # The nginx.tmpl raw data file used to replace files/nginx.tmpl, if"},{"line_number":276,"context_line":"    # sets to null, we will use the one in files/nginx.tmpl that comes with the chart."},{"line_number":277,"context_line":"    tmpl_override: null"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_9ea2bf99","line":274,"range":{"start_line":274,"start_character":4,"end_line":274,"end_character":20},"in_reply_to":"7faddb67_7e97c346","updated":"2019-08-15 16:55:36.000000000","message":"this is just a rename of the include_tmpl_file variable before","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"be03b8e8dc23f716ae3320da45c3d68424bc05d1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  ingress:"},{"line_number":272,"context_line":"    # Indicate if we want to override nginx template. If this is set to"},{"line_number":273,"context_line":"    # false, we will be using the one that comes with the image."},{"line_number":274,"context_line":"    enabled_override: true"},{"line_number":275,"context_line":"    # The nginx.tmpl raw data file used to replace files/nginx.tmpl, if"},{"line_number":276,"context_line":"    # sets to null, we will use the one in files/nginx.tmpl that comes with the chart."},{"line_number":277,"context_line":"    tmpl_override: null"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_7e702341","line":274,"range":{"start_line":274,"start_character":4,"end_line":274,"end_character":20},"in_reply_to":"7faddb67_7e97c346","updated":"2019-08-15 16:55:36.000000000","message":"this is just the toggle","commit_id":"9c1ea439d69f03848814cd615336523f5bfb6b70"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9fdff9252403e614fdc152facf10257b8bae52b3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    mariadb: docker.io/openstackhelm/mariadb:10.2.18"},{"line_number":25,"context_line":"    ingress: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0"},{"line_number":26,"context_line":"    error_pages: gcr.io/google_containers/defaultbackend:1.0"},{"line_number":27,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.2.13"},{"line_number":28,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_e470fd74","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":81},"updated":"2019-08-15 21:21:26.000000000","message":"please update this.","commit_id":"59f7908e29e844428ec68e16f932216ec73ada30"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"a6ca63a639170f5d64c082d5f8184af630e34b02","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    mariadb: docker.io/openstackhelm/mariadb:10.2.18"},{"line_number":25,"context_line":"    ingress: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0"},{"line_number":26,"context_line":"    error_pages: gcr.io/google_containers/defaultbackend:1.0"},{"line_number":27,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.2.13"},{"line_number":28,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_ffc72a97","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":81},"in_reply_to":"7faddb67_e470fd74","updated":"2019-08-15 22:18:46.000000000","message":"Updated to 0.21.0, set enabled_override to false and also added comment to files/nginx.tmpl indicating the template is for version 0.9.0","commit_id":"59f7908e29e844428ec68e16f932216ec73ada30"}]}