)]}'
{"ceph-osd/templates/bin/osd/_common.sh.tpl":[{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"e2a7fd9dac3e631a3077493375ce849b831e5300","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"function crush_create_or_move {"},{"line_number":83,"context_line":"  local crush_location\u003d${1}"},{"line_number":84,"context_line":"  ceph_cmd_retry cluster \"${CLUSTER}\" --name\u003d\"osd.${OSD_ID}\" --keyring\u003d\"${OSD_KEYRING}\" \\"},{"line_number":85,"context_line":"    osd crush create-or-move -- \"${OSD_ID}\" \"${OSD_WEIGHT}\" ${crush_location}"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_5652bc3c","line":84,"range":{"start_line":84,"start_character":16,"end_line":84,"end_character":17},"updated":"2019-09-26 19:15:02.000000000","message":"Please, add \"--\"","commit_id":"1c66f5a4ab22d72ff93edb76de68f5be7955be89"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"10e328fcdeab0beccfb82eb6c23f6eb381559894","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"function ceph_cmd_retry() {"},{"line_number":65,"context_line":"  cnt\u003d0"},{"line_number":66,"context_line":"  while true; do"},{"line_number":67,"context_line":"    \"ceph\" \"$@\""},{"line_number":68,"context_line":"    ret\u003d$?"},{"line_number":69,"context_line":"    cnt\u003d$((cnt+1))"},{"line_number":70,"context_line":"    if [[ \"$ret\" -ne \"0\" ]]; then"},{"line_number":71,"context_line":"      if [[ \"$cnt\" -lt \"6\" ]]; then"},{"line_number":72,"context_line":"        sleep 10"},{"line_number":73,"context_line":"      else"},{"line_number":74,"context_line":"        return 1"},{"line_number":75,"context_line":"      fi"},{"line_number":76,"context_line":"    else"},{"line_number":77,"context_line":"      break"},{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":"  done"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"function crush_create_or_move {"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_c497c139","line":79,"range":{"start_line":66,"start_character":0,"end_line":79,"end_character":6},"updated":"2019-09-27 18:13:17.000000000","message":"Why not simplify this to something like the following?\n\nuntil \"ceph\" \"$@\" || [ $cnt -ge 6 ]; do\n  sleep 10\n  ((cnt++))\ndone\n\n[ $cnt -ge 6 ]\n\nThe last line is optional to get a return value of 1 if the timeout was reached and 0 otherwise.","commit_id":"2eca814e654bc3dc8c0fd1253b64c4a913762c81"}]}