)]}'
{"openvswitch/templates/daemonset-ovs-vswitchd.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"f27100c6be24043de456ed513420b9052eb6aec8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027! /usr/bin/ovs-vsctl show | grep -q error: \u0026\u0026 [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized) \u003d\u003d true ]\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_9ef2039a","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":52},"updated":"2019-10-06 23:06:58.000000000","message":"What errors will this find, and is it advantageous to have the pod in a Not Ready state if those errors occur? Maybe this check should be removed.","commit_id":"86d034f2e49ca6f599cc4721d7cc2e833346febd"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"a2f5da8809260be5f0eeb9eac49fd4f7c34c1569","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027! /usr/bin/ovs-vsctl show | grep -q error: \u0026\u0026 [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized) \u003d\u003d true ]\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d35e2c44","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":52},"in_reply_to":"3fa7e38b_9ef2039a","updated":"2019-10-07 14:54:17.000000000","message":"I\u0027m not sure what the original intention was but removing it should not cause an issue to me. We could probably remove just \"grep -q error\" and leave the rest of the command to make sure OVS is ready at least.\n\n\u0027! /usr/bin/ovs-vsctl show \u0026\u0026 [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized) \u003d\u003d true ]\u0027","commit_id":"86d034f2e49ca6f599cc4721d7cc2e833346febd"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"97dfeadd1425cf60de01ebd61f649ad80b8f8314","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  command:"},{"line_number":27,"context_line":"    - /bin/bash"},{"line_number":28,"context_line":"    - -c"},{"line_number":29,"context_line":"    - \u0027! /usr/bin/ovs-vsctl show\u0027"},{"line_number":30,"context_line":"{{- else }}"},{"line_number":31,"context_line":"exec:"},{"line_number":32,"context_line":"  command:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3bdc3645","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":9},"updated":"2019-10-07 16:01:31.000000000","message":"remove?","commit_id":"433c8a925b4c70b572a30281aaaa8b4bbd149729"}]}
