)]}'
{"helm-toolkit/templates/manifests/_ingress.tpl":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"87c225371381e03058a0f684baa91a96a8e30c73","unresolved":false,"context_lines":[{"line_number":247,"context_line":"{{- $hostName :\u003d tuple $backendServiceType $endpoint $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":248,"context_line":"{{- $hostNameFull :\u003d tuple $backendServiceType $endpoint $envAll | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}"},{"line_number":249,"context_line":"---"},{"line_number":250,"context_line":"{{- if or ( gt $envAll.Capabilities.KubeVersion.Major \"1\" ) ( and (eq $envAll.Capabilities.KubeVersion.Major \"1\") (gt $envAll.Capabilities.KubeVersion.Minor \"15\") ) }}"},{"line_number":251,"context_line":"apiVersion: networking.k8s.io/v1beta1"},{"line_number":252,"context_line":"{{- else }}"},{"line_number":253,"context_line":"apiVersion: extensions/v1beta1"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_b4b005ff","line":250,"range":{"start_line":250,"start_character":114,"end_line":250,"end_character":162},"updated":"2019-11-17 03:50:11.000000000","message":"Should be a numeric comparison.\n\n    (gt (int $envAll.Capabilities.KubeVersion.Minor) 15)","commit_id":"f78d541729e80d584e05fcce8672692094f02e7c"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"b011f18b8ce481efea08bd77258b282e99dcbb16","unresolved":false,"context_lines":[{"line_number":247,"context_line":"{{- $hostName :\u003d tuple $backendServiceType $endpoint $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":248,"context_line":"{{- $hostNameFull :\u003d tuple $backendServiceType $endpoint $envAll | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}"},{"line_number":249,"context_line":"---"},{"line_number":250,"context_line":"{{- if or ( gt $envAll.Capabilities.KubeVersion.Major \"1\" ) ( and (eq $envAll.Capabilities.KubeVersion.Major \"1\") (gt $envAll.Capabilities.KubeVersion.Minor \"15\") ) }}"},{"line_number":251,"context_line":"apiVersion: networking.k8s.io/v1beta1"},{"line_number":252,"context_line":"{{- else }}"},{"line_number":253,"context_line":"apiVersion: extensions/v1beta1"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_9fb94817","line":250,"range":{"start_line":250,"start_character":114,"end_line":250,"end_character":162},"in_reply_to":"3fa7e38b_b4b005ff","updated":"2019-11-19 17:37:30.000000000","message":"Done","commit_id":"f78d541729e80d584e05fcce8672692094f02e7c"}],"ingress/templates/deployment-ingress.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"c2cfa83aeb5739d5b7ea7228d792e63c80e04b7b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      - watch"},{"line_number":61,"context_line":"  - apiGroups:"},{"line_number":62,"context_line":"      - \"extensions\""},{"line_number":63,"context_line":"      {{- if or ( gt (int .Capabilities.KubeVersion.Major) 1) ( and (eq (int .Capabilities.KubeVersion.Major) 1) (gt (int .Capabilities.KubeVersion.Minor) 15) ) }}"},{"line_number":64,"context_line":"      - \"networking.k8s.io\""},{"line_number":65,"context_line":"      {{- end }}"},{"line_number":66,"context_line":"    resources:"},{"line_number":67,"context_line":"      - ingresses"},{"line_number":68,"context_line":"    verbs:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_7f17aca4","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":16},"updated":"2019-11-19 17:53:08.000000000","message":"It might be better to allow this unconditionally (as in lines 79-81), for example, in case a cluster is upgraded with existing resources, and they start showing up in a different place?","commit_id":"668326244d1f233cf45200595fce025904308412"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d2dc70012a04bee45ff48e5300bf7da183681d33","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      - watch"},{"line_number":61,"context_line":"  - apiGroups:"},{"line_number":62,"context_line":"      - \"extensions\""},{"line_number":63,"context_line":"      {{- if or ( gt (int .Capabilities.KubeVersion.Major) 1) ( and (eq (int .Capabilities.KubeVersion.Major) 1) (gt (int .Capabilities.KubeVersion.Minor) 15) ) }}"},{"line_number":64,"context_line":"      - \"networking.k8s.io\""},{"line_number":65,"context_line":"      {{- end }}"},{"line_number":66,"context_line":"    resources:"},{"line_number":67,"context_line":"      - ingresses"},{"line_number":68,"context_line":"    verbs:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_d539dfd7","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":16},"in_reply_to":"3fa7e38b_7f17aca4","updated":"2019-11-19 19:17:00.000000000","message":"Curious if we should just have a wholesale deployment-ingress-v${VERSION}.yaml (and use the values.yaml to target the version) instead of these if-else all over the place. We would need to add/modify these logic everywhere if things change again. Want other folks to chime in.","commit_id":"668326244d1f233cf45200595fce025904308412"}]}