)]}'
{"grafana/templates/bin/_selenium-tests.py.tpl":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6bc3d8b1a954a20f8fef4d39954bf92066a8d194","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_20f6be5e","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"updated":"2019-10-15 19:06:50.000000000","message":"This change should just make this script Python 3 compatible, not make it strictly supported by Python 3.","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"873cdb07624ab503c3359c61d4696664a913d46a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_690a6126","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_20f6be5e","updated":"2019-10-15 21:55:46.000000000","message":"The change which this would depend on replaces the osh-selenium image with one that only has python3 installed. I talked with lamt about the idea of aliasing python3 to just python, but that\u0027s not implemented in the new image yet. Do you think we should? \n\nhttps://review.opendev.org/#/c/688436/","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1a0b43dde76bd32010f94bfb0f8bbdc0df7744f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_e6198cd0","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_3157e35a","updated":"2019-10-16 18:48:20.000000000","message":"I discussed this with srwilkers Monday, and the conclusion was that we would drop the xenial image once a suitable bionic image is ready. I was about to say, only the nagios and grafana chart in osh-infra use this image - but I\u0027ve just noticed that the horizon chart in osh does too. I\u0027ll prepare a similar change for that chart in the meantime. \n\nIs there another reason we should continue to support the xenial based image?","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"7fd329602edb11bcca35928c27b6fcfbb174a57e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_3157e35a","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_690a6126","updated":"2019-10-16 13:49:52.000000000","message":"\u003e The change which this would depend on replaces the osh-selenium\n \u003e image with one that only has python3 installed. I talked with lamt\n \u003e about the idea of aliasing python3 to just python, but that\u0027s not\n \u003e implemented in the new image yet. Do you think we should?\n \u003e \n \u003e https://review.opendev.org/#/c/688436/\n\nAre we removing the xenial image? I am not aware of any plans to remove xenial support yet, so I assume it is. In that case, I would say we should just make this python, since Python 2 is the default interpreter on Ubuntu Xenial.","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"3ede6143cb364c34b24c003d213e8c775bbb5721","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2019 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_8663f841","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_e6198cd0","updated":"2019-10-16 18:51:02.000000000","message":"\u003e I discussed this with srwilkers Monday, and the conclusion was that\n \u003e we would drop the xenial image once a suitable bionic image is\n \u003e ready. I was about to say, only the nagios and grafana chart in\n \u003e osh-infra use this image - but I\u0027ve just noticed that the horizon\n \u003e chart in osh does too. I\u0027ll prepare a similar change for that chart\n \u003e in the meantime.\n \u003e \n \u003e Is there another reason we should continue to support the xenial\n \u003e based image?\n\nOutside of a courtesy deprecation period for those producing downstream artifacts, I don\u0027t think so. As I am not a core reviewer, I\u0027ll defer that decision to Steve.\n\nThese are things that should probably be covered in the weekly IRC meeting, though.","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6bc3d8b1a954a20f8fef4d39954bf92066a8d194","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_variable(env_var):"},{"line_number":44,"context_line":"    if env_var in os.environ:"},{"line_number":45,"context_line":"        logger.info(\u0027Found \"{}\"\u0027.format(env_var))"},{"line_number":46,"context_line":"        return os.environ[env_var]"},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        logger.critical(\u0027Variable \"{}\" is not defined!\u0027.format(env_var))"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_83069c1b","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":49},"updated":"2019-10-15 19:06:50.000000000","message":"Why is this info? Purely historical reasons? This logging message is not relevant to day-to-day operations and would only be used when debugging/troubleshooting.","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"873cdb07624ab503c3359c61d4696664a913d46a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_variable(env_var):"},{"line_number":44,"context_line":"    if env_var in os.environ:"},{"line_number":45,"context_line":"        logger.info(\u0027Found \"{}\"\u0027.format(env_var))"},{"line_number":46,"context_line":"        return os.environ[env_var]"},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        logger.critical(\u0027Variable \"{}\" is not defined!\u0027.format(env_var))"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_09572d28","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":49},"in_reply_to":"3fa7e38b_83069c1b","updated":"2019-10-15 21:55:46.000000000","message":"Good observation and yes -  I haven\u0027t adjusted the log level here yet. I can make another pass for that.","commit_id":"eae2b63e9df23c27ca89c56f2ed3f43bd4cd6491"}]}