)]}'
{"openvswitch/templates/daemonset-ovs-vswitchd.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"80773a14de2a15699d53712c9fc8fabd7b909d99","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027/usr/bin/ovs-vsctl show \u0026\u0026 if ! [ ovs-vsctl get Open_vSwitch . dpdk_initialized 2\u003e /dev/null ]; then true; else [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized ) \u003d\u003d true ]; fi;\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_667efc6a","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":101},"updated":"2019-10-16 18:26:41.000000000","message":"I think the brackets need to be removed here. As written, this check passes when dpdk_initialized \u003d false.\n\nIn general, the expression is getting sort of unwieldy. Something like the following might be easier to read .. fail if the dpdk_initialized field is present in the database and is false.\n\n    bash -c \u0027ovs-vsctl show \u0026\u0026 ! ovs-vsctl list Open_vSwitch | grep -q dpdk_initialized.*false\u0027\n\n(Also for consistency, we could either always use or always not use the full path to /usr/bin/ovs-vsctl)","commit_id":"e993f7279b5d3ba5076230cc51f9d7036ae6978a"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"2e5b5df7203a6bbe4ce49daf216ce03d6b11d43e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027/usr/bin/ovs-vsctl show \u0026\u0026 if ! [ ovs-vsctl get Open_vSwitch . dpdk_initialized 2\u003e /dev/null ]; then true; else [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized ) \u003d\u003d true ]; fi;\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_36e839e0","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":101},"updated":"2019-10-16 12:51:47.000000000","message":"The intention behind adding the check was to prevent Neutron OVS agent start prematurely. I\u0027m afraid this brings the problem back.","commit_id":"e993f7279b5d3ba5076230cc51f9d7036ae6978a"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"31a8e0a22df066d1a66caa2da12fe0200aa1a7bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027/usr/bin/ovs-vsctl show \u0026\u0026 if ! [ ovs-vsctl get Open_vSwitch . dpdk_initialized 2\u003e /dev/null ]; then true; else [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized ) \u003d\u003d true ]; fi;\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_13d5e1e5","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":101},"in_reply_to":"3fa7e38b_362919e5","updated":"2019-10-18 18:42:56.000000000","message":"Upon discussing within the team, I\u0027m fine with the change.","commit_id":"e993f7279b5d3ba5076230cc51f9d7036ae6978a"},{"author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"change_message_id":"8e20269b15eb84b7cb38275e3cbf3e466cf7d832","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027/usr/bin/ovs-vsctl show \u0026\u0026 if ! [ ovs-vsctl get Open_vSwitch . dpdk_initialized 2\u003e /dev/null ]; then true; else [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized ) \u003d\u003d true ]; fi;\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_362919e5","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":101},"in_reply_to":"3fa7e38b_36e839e0","updated":"2019-10-16 13:02:36.000000000","message":"ok, I wasn\u0027t aware of issues resulting from neutron-agent starting early - at least I haven\u0027t encountered those before. I would be intersted to find out more about this.\n\nIf we want to use the pod readiness as a means to sync neutron-agent and OVS, then we should instead think about a more \"version neutral\" test, which might not be as clean as querying the database, but which works across older versions as well, e.g., by checking the vswitchd logs.\n\nBionic ships OVS 2.9.2 and I suppose you use a newer version in your labs? However, I think we should have a working solution for the default version of OVS when running the default bionic images.","commit_id":"e993f7279b5d3ba5076230cc51f9d7036ae6978a"},{"author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"change_message_id":"42cc9915c483358afd0654dfef398fce4d382087","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command:"},{"line_number":33,"context_line":"    - /bin/bash"},{"line_number":34,"context_line":"    - -c"},{"line_number":35,"context_line":"    - \u0027/usr/bin/ovs-vsctl show \u0026\u0026 if ! [ ovs-vsctl get Open_vSwitch . dpdk_initialized 2\u003e /dev/null ]; then true; else [ $(ovs-vsctl get Open_vSwitch . dpdk_initialized ) \u003d\u003d true ]; fi;\u0027"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_bf4e1994","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":101},"in_reply_to":"3fa7e38b_667efc6a","updated":"2019-10-18 12:28:16.000000000","message":"looks great, I like the simplified check.\n\nWe also need the same modification in the neutron-ovs-agent: https://review.opendev.org/#/c/675555/","commit_id":"e993f7279b5d3ba5076230cc51f9d7036ae6978a"}]}