)]}'
{"tools/gate/selenium/grafanaSelenium.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f97f6750d7f987fc87223a485a0ca24c81ddfff9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027panel-plugin-graph/grafana-panel/div/div[2]\u0027)"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    )"},{"line_number":53,"context_line":"    st.take_screenshot(\u0027Grafana Nodes\u0027)"},{"line_number":54,"context_line":"except TimeoutException:"},{"line_number":55,"context_line":"    st.logger.error(\u0027Failed to load Nodes dashboard\u0027)"},{"line_number":56,"context_line":"    st.browser.quit()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4961a504","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":39},"updated":"2019-10-15 21:48:19.000000000","message":"Curious if these selenium tests should do some assert\u0027s or other automated checks to validate things than just time outs. Taking screenshot is great, but that involves person to check.","commit_id":"9136e16ec2dcea72a929b16ebabdf7cfbacb4f0e"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"28da4f7c1544429c9f306e5294a42b8574ba644a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027panel-plugin-graph/grafana-panel/div/div[2]\u0027)"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    )"},{"line_number":53,"context_line":"    st.take_screenshot(\u0027Grafana Nodes\u0027)"},{"line_number":54,"context_line":"except TimeoutException:"},{"line_number":55,"context_line":"    st.logger.error(\u0027Failed to load Nodes dashboard\u0027)"},{"line_number":56,"context_line":"    st.browser.quit()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7196bb40","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":39},"in_reply_to":"3fa7e38b_4961a504","updated":"2019-10-16 13:42:53.000000000","message":"This is a good point. I suppose the thought is, if the script exits early, then something isn\u0027t working right. However I\u0027ve noticed that when these scripts get run by Zuul, they\u0027re run || true.\n\nIn the other selenium scripts we have, the ones in the nagios and grafana charts, the tests are run as a part of the chart deployment. If those tests exit early, the failure is more disruptive than these.\n\nThis makes me wonder if these gate scripts are worthwhile as they are used currently. Perhaps this work would be better suited to live in the osh-selenium image, and all charts which could be tested by selenium be updated to use it (Ie, kibana and prometheus)?","commit_id":"9136e16ec2dcea72a929b16ebabdf7cfbacb4f0e"}],"tools/gate/selenium/seleniumtester.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f97f6750d7f987fc87223a485a0ca24c81ddfff9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                )"},{"line_number":87,"context_line":"            self.browser.quit()"},{"line_number":88,"context_line":"            sys.exit(1)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c9bfd55e","line":89,"updated":"2019-10-15 21:48:19.000000000","message":"extra EOF line","commit_id":"9136e16ec2dcea72a929b16ebabdf7cfbacb4f0e"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f97f6750d7f987fc87223a485a0ca24c81ddfff9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.browser.quit()"},{"line_number":88,"context_line":"            sys.exit(1)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_09908dec","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":4},"updated":"2019-10-15 21:48:19.000000000","message":"whitespace","commit_id":"9136e16ec2dcea72a929b16ebabdf7cfbacb4f0e"}]}