)]}'
{"tools/deployment/apparmor/020-ceph.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":202,"context_line":"    --namespace\u003dceph \\"},{"line_number":203,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":204,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":205,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":206,"context_line":"done"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_17951b32","line":204,"range":{"start_line":204,"start_character":31,"end_line":204,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"looks like this snuck in","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":202,"context_line":"    --namespace\u003dceph \\"},{"line_number":203,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":204,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":205,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":206,"context_line":"done"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_728d7d2f","line":204,"range":{"start_line":204,"start_character":31,"end_line":204,"end_character":33},"in_reply_to":"3fa7e38b_17951b32","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/apparmor/050-libvirt.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":171,"context_line":"  --values\u003d/tmp/libvirt.yaml \\"},{"line_number":172,"context_line":"  --set network.backend\u003d\"null\" \\"},{"line_number":173,"context_line":"  ${OSH_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":174,"context_line":"  ${OSH_EXTRA_HELM_ARGS_LIBVIRT}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"#NOTE: Validate Deployment info"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_d7a2239a","line":173,"range":{"start_line":173,"start_character":23,"end_line":173,"end_character":25},"updated":"2019-11-21 16:42:49.000000000","message":"Ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":171,"context_line":"  --values\u003d/tmp/libvirt.yaml \\"},{"line_number":172,"context_line":"  --set network.backend\u003d\"null\" \\"},{"line_number":173,"context_line":"  ${OSH_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":174,"context_line":"  ${OSH_EXTRA_HELM_ARGS_LIBVIRT}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"#NOTE: Validate Deployment info"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_32838505","line":173,"range":{"start_line":173,"start_character":23,"end_line":173,"end_character":25},"in_reply_to":"3fa7e38b_d7a2239a","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/common/env-variables.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f71dd0704d09e7a150aa17ef94e384e04ded9b9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#  License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#  under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"export API_ADDR\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].addresses[0].ip\u0027)"},{"line_number":16,"context_line":"export API_PORT\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].ports[0].port\u0027)"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_6e76f9da","line":14,"updated":"2019-11-21 19:22:37.000000000","message":"nit - would be nice to see \u0027set -e\u0027 here.","commit_id":"6a6ed9b5f0cf8e6520316606200b67f944cb2fd2"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7134092330ef805b55aa9d16cd839f28d2e649e0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#  License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#  under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"export API_ADDR\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].addresses[0].ip\u0027)"},{"line_number":16,"context_line":"export API_PORT\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].ports[0].port\u0027)"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_d16eacc6","line":14,"in_reply_to":"3fa7e38b_4e50dd2c","updated":"2019-11-21 19:35:14.000000000","message":"will add - they are used by the egress netpol to target the api-server.","commit_id":"6a6ed9b5f0cf8e6520316606200b67f944cb2fd2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9549dace27d7fc800fe472aa65a1bd18ad5a8094","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#  License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#  under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"export API_ADDR\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].addresses[0].ip\u0027)"},{"line_number":16,"context_line":"export API_PORT\u003d$(kubectl get endpoints kubernetes -o json | jq -r \u0027.subsets[0].ports[0].port\u0027)"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_4e50dd2c","line":14,"in_reply_to":"3fa7e38b_6e76f9da","updated":"2019-11-21 19:23:19.000000000","message":"also - where are these vars used?","commit_id":"6a6ed9b5f0cf8e6520316606200b67f944cb2fd2"}],"tools/deployment/common/get-values-overrides.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f71dd0704d09e7a150aa17ef94e384e04ded9b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  echo \"${OVERRIDE_ARGS}\""},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"echoerr"},{"line_number":65,"context_line":"source ${HELM_CHART_ROOT_PATH}/tools/deployment/common/env-variables.sh"},{"line_number":66,"context_line":"override_file_args \"${OSH_INFRA_FEATURE_MIX}\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_0e4f4592","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":7},"updated":"2019-11-21 19:22:37.000000000","message":"whats this doing?\n\nsee the file where this is copied from: https://github.com/openstack/openstack-helm/blob/master/tools/deployment/common/get-values-overrides.sh#L70","commit_id":"6a6ed9b5f0cf8e6520316606200b67f944cb2fd2"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7134092330ef805b55aa9d16cd839f28d2e649e0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  echo \"${OVERRIDE_ARGS}\""},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"echoerr"},{"line_number":65,"context_line":"source ${HELM_CHART_ROOT_PATH}/tools/deployment/common/env-variables.sh"},{"line_number":66,"context_line":"override_file_args \"${OSH_INFRA_FEATURE_MIX}\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_d1554cfa","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":7},"in_reply_to":"3fa7e38b_0e4f4592","updated":"2019-11-21 19:35:14.000000000","message":"looks like the last part got deleted by accident, will fix.","commit_id":"6a6ed9b5f0cf8e6520316606200b67f944cb2fd2"}],"tools/deployment/keystone-auth/060-mariadb.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":25,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":26,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":27,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":28,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":29,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_97a82b78","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":25,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":26,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":27,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":28,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":29,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_f2788d2b","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":33},"in_reply_to":"3fa7e38b_97a82b78","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/multinode/030-ceph.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":103,"context_line":"    --namespace\u003dceph \\"},{"line_number":104,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":105,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":106,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_57b873c6","line":105,"range":{"start_line":105,"start_character":31,"end_line":105,"end_character":34},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":103,"context_line":"    --namespace\u003dceph \\"},{"line_number":104,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":105,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":106,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_b26e9561","line":105,"range":{"start_line":105,"start_character":31,"end_line":105,"end_character":34},"in_reply_to":"3fa7e38b_57b873c6","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/multinode/035-ceph-ns-activate.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":48,"context_line":"helm upgrade --install ceph-osh-infra-config ./ceph-provisioners \\"},{"line_number":49,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":50,"context_line":"  --values\u003d/tmp/ceph-osh-infra-config.yaml \\"},{"line_number":51,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":52,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_NS_ACTIVATE}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_77bb2fc3","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":32},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":48,"context_line":"helm upgrade --install ceph-osh-infra-config ./ceph-provisioners \\"},{"line_number":49,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":50,"context_line":"  --values\u003d/tmp/ceph-osh-infra-config.yaml \\"},{"line_number":51,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":52,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_NS_ACTIVATE}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_528f2122","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":32},"in_reply_to":"3fa7e38b_77bb2fc3","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/openstack-support/050-libvirt.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install libvirt ./libvirt \\"},{"line_number":25,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"  --set network.backend\u003d\"null\" \\"},{"line_number":27,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":28,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS_LIBVIRT}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Please be aware that a network backend might affect"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_37b137e1","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7a6faf887a029f2b3fa9b3868913e7563269167","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install libvirt ./libvirt \\"},{"line_number":25,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"  --set network.backend\u003d\"null\" \\"},{"line_number":27,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":28,"context_line":"  ${OSH_INFRA_EXTRA_HELM_ARGS_LIBVIRT}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Please be aware that a network backend might affect"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_32986567","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3fa7e38b_37b137e1","updated":"2019-11-21 16:59:56.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/osh-infra-logging/020-ceph.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":193,"context_line":"    --namespace\u003dceph \\"},{"line_number":194,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":195,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":196,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_f7c63f49","line":195,"range":{"start_line":195,"start_character":31,"end_line":195,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/osh-infra-monitoring/045-mariadb.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":26,"context_line":"helm upgrade --install mariadb ./mariadb \\"},{"line_number":27,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":28,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue \\"},{"line_number":29,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":30,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_MARIADB}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_979a6b6c","line":29,"range":{"start_line":29,"start_character":31,"end_line":29,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"Looks like this snuck in","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/osh-infra-monitoring/130-postgresql.sh":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"6451b4722ab5cc9a6492102454b5661fdde10525","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    --set storage.pvc.enabled\u003dtrue \\"},{"line_number":32,"context_line":"    --set pod.replicas.server\u003d3 \\"},{"line_number":33,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS} \\"},{"line_number":34,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_POSTGRESQL}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#NOTE: Wait for deploy"},{"line_number":37,"context_line":"./tools/deployment/common/wait-for-pods.sh osh-infra"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_b42250a2","line":34,"range":{"start_line":34,"start_character":32,"end_line":34,"end_character":42},"updated":"2019-10-25 13:43:03.000000000","message":"good catch!","commit_id":"d53914fa0dcebcf3ca01c708e1989d2c6244fa7a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e5cec1dbdcee9ecd2e4e099dea797fcd54f067b4","unresolved":false,"context_lines":[{"line_number":23,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS_POSTGRESQL:\u003d\"$(./tools/deployment/common/get-values-overrides.sh postgresql)\"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"helm upgrade --install postgresql ./postgresql \\"},{"line_number":28,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":29,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_96a2743e","line":26,"updated":"2019-11-21 13:01:14.000000000","message":"extra newline","commit_id":"f30c2db54f989add0c7ef78f5dbacdaf34ee3a81"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ecc169ca64a7bc1b9f4d2679df3e3279aad99627","unresolved":false,"context_lines":[{"line_number":23,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":": ${OSH_INFRA_EXTRA_HELM_ARGS_POSTGRESQL:\u003d\"$(./tools/deployment/common/get-values-overrides.sh postgresql)\"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"helm upgrade --install postgresql ./postgresql \\"},{"line_number":28,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":29,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_86180376","line":26,"in_reply_to":"3fa7e38b_96a2743e","updated":"2019-11-21 14:30:03.000000000","message":"Done","commit_id":"f30c2db54f989add0c7ef78f5dbacdaf34ee3a81"}],"tools/deployment/tenant-ceph/030-ceph.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":120,"context_line":"    --namespace\u003dceph \\"},{"line_number":121,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":122,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":123,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_778d6f2f","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"61428b1e7d7286f4866d0819f8da5168e955a531","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  helm upgrade --install ${CHART} ./${CHART} \\"},{"line_number":120,"context_line":"    --namespace\u003dceph \\"},{"line_number":121,"context_line":"    --values\u003d/tmp/ceph.yaml \\"},{"line_number":122,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":123,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_12e3e9d9","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":33},"in_reply_to":"3fa7e38b_778d6f2f","updated":"2019-11-21 17:00:19.000000000","message":"Done","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}],"tools/deployment/tenant-ceph/040-tenant-ceph.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e5cec1dbdcee9ecd2e4e099dea797fcd54f067b4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    --values\u003d/tmp/tenant-ceph.yaml \\"},{"line_number":149,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":150,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  #NOTE: Wait for deploy"},{"line_number":154,"context_line":"  ./tools/deployment/common/wait-for-pods.sh tenant-ceph 1200"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_16b76487","line":151,"updated":"2019-11-21 13:01:14.000000000","message":"Looks like an extra newline","commit_id":"f30c2db54f989add0c7ef78f5dbacdaf34ee3a81"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ecc169ca64a7bc1b9f4d2679df3e3279aad99627","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    --values\u003d/tmp/tenant-ceph.yaml \\"},{"line_number":149,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":150,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  #NOTE: Wait for deploy"},{"line_number":154,"context_line":"  ./tools/deployment/common/wait-for-pods.sh tenant-ceph 1200"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_e63697e7","line":151,"in_reply_to":"3fa7e38b_16b76487","updated":"2019-11-21 14:30:03.000000000","message":"Done","commit_id":"f30c2db54f989add0c7ef78f5dbacdaf34ee3a81"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"dbdf40b2db09ae44d65e0a9773f465f0700484df","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  helm upgrade --install tenant-${CHART} ./${CHART} \\"},{"line_number":147,"context_line":"    --namespace\u003dtenant-ceph \\"},{"line_number":148,"context_line":"    --values\u003d/tmp/tenant-ceph.yaml \\"},{"line_number":149,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS:\u003d} \\"},{"line_number":150,"context_line":"    ${OSH_INFRA_EXTRA_HELM_ARGS_CEPH_DEPLOY:-$(./tools/deployment/common/get-values-overrides.sh ${CHART})}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  #NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_37837705","line":149,"range":{"start_line":149,"start_character":31,"end_line":149,"end_character":33},"updated":"2019-11-21 16:42:49.000000000","message":"ditto","commit_id":"ed579e20690a61e5c84fb516614b8f0b788d5e11"}]}