)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"8ce52cee108fe8dd95957cdb9f0539e595719ecb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: ceph-osd AppArmor profiles not applied"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AppArmor annotations require the container name to be applied properly."},{"line_number":10,"context_line":"Before this change, when overrides are not used, the container name is"},{"line_number":11,"context_line":"ceph-osd-default. When overrides are used, the container name is of the"},{"line_number":12,"context_line":"form ceph-osd-HOSTNAME-SHA, but with an identical HOSTNAME and SHA for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_abf1fb6c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":71},"updated":"2019-11-07 01:14:32.000000000","message":"AFAICT there\u0027s not a reason to auto-gen the container name, so I think the proposed change is fine. But keep in mind the pod (daemonset) name will continue to by dynamically generated, as this is central to current overrides implementation. You may have to make an additional/future consideration for how to handle that scenario if apparmor also requires fixed pod/daemonset name(s).","commit_id":"938c6d9bb92a37a9702e8205aa6ab259bf3f39f5"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"d36b9e6029562f5ce7f1bba3db820a9c782428de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: ceph-osd AppArmor profiles not applied"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AppArmor annotations require the container name to be applied properly."},{"line_number":10,"context_line":"Before this change, when overrides are not used, the container name is"},{"line_number":11,"context_line":"ceph-osd-default. When overrides are used, the container name is of the"},{"line_number":12,"context_line":"form ceph-osd-HOSTNAME-SHA, but with an identical HOSTNAME and SHA for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_0e78538d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":71},"in_reply_to":"3fa7e38b_abf1fb6c","updated":"2019-11-07 17:46:17.000000000","message":"No Craig, we did check for daemon set and we did get it static.","commit_id":"938c6d9bb92a37a9702e8205aa6ab259bf3f39f5"}],"ceph-osd/templates/daemonset-osd.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"8ce52cee108fe8dd95957cdb9f0539e595719ecb","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              mountPath: /var/lib/ceph/journal"},{"line_number":213,"context_line":"              readOnly: false"},{"line_number":214,"context_line":"      containers:"},{"line_number":215,"context_line":"        - name: ceph-osd-default"},{"line_number":216,"context_line":"{{ tuple $envAll \"ceph_osd\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":217,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.osd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":218,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"osd\" \"container\" \"osd_pod\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_2bd42bbb","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":32},"updated":"2019-11-07 01:14:32.000000000","message":"you could also change the pod name apparmor is looking for now that you know it will match what\u0027s here, although either way works. In the future, maybe a more robust way would be to take something from this chart as input to the apparmor chart - otherwise someone could change the container name again and break apparmor (and do so silently?)","commit_id":"938c6d9bb92a37a9702e8205aa6ab259bf3f39f5"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"d36b9e6029562f5ce7f1bba3db820a9c782428de","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              mountPath: /var/lib/ceph/journal"},{"line_number":213,"context_line":"              readOnly: false"},{"line_number":214,"context_line":"      containers:"},{"line_number":215,"context_line":"        - name: ceph-osd-default"},{"line_number":216,"context_line":"{{ tuple $envAll \"ceph_osd\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":217,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.osd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":218,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"osd\" \"container\" \"osd_pod\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_ee97f79b","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":32},"in_reply_to":"3fa7e38b_2babcb1e","updated":"2019-11-07 17:46:17.000000000","message":"Thank You","commit_id":"938c6d9bb92a37a9702e8205aa6ab259bf3f39f5"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"d720aefc1827778c39885eb780a422160bc51d0d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              mountPath: /var/lib/ceph/journal"},{"line_number":213,"context_line":"              readOnly: false"},{"line_number":214,"context_line":"      containers:"},{"line_number":215,"context_line":"        - name: ceph-osd-default"},{"line_number":216,"context_line":"{{ tuple $envAll \"ceph_osd\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":217,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.osd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":218,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"osd\" \"container\" \"osd_pod\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_2babcb1e","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":32},"in_reply_to":"3fa7e38b_2bd42bbb","updated":"2019-11-07 01:36:30.000000000","message":"It looks like you would also have to update nova\u0027s container name to add \"-default\" suffix, so it would probably be better to lead this pod name as-is and just update the apparmor reference to exclude the \"-default\" suffix.","commit_id":"938c6d9bb92a37a9702e8205aa6ab259bf3f39f5"}],"ceph-osd/templates/utils/_osd_daemonset_overrides.tpl":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"8ce52cee108fe8dd95957cdb9f0539e595719ecb","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    {{- if not $context.Values.__daemonset_yaml.metadata.name }}{{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" dict }}{{- end }}"},{"line_number":231,"context_line":"    {{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" $current_dict.dns_1123_name }}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    {{/* set container names and add to the list of containers for the pod */}}"},{"line_number":234,"context_line":"    {{- $_ :\u003d set $context.Values \"__containers_list\" ( list ) }}"},{"line_number":235,"context_line":"    {{- range $container :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":236,"context_line":"    {{- if eq $container.name \"osd-pod\" }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3fa7e38b_4bcde72e","side":"PARENT","line":233,"range":{"start_line":233,"start_character":0,"end_line":233,"end_character":79},"updated":"2019-11-07 01:14:32.000000000","message":"AFAICT , setting the container name doesn\u0027t serve a purpose and is fine to remove.","commit_id":"81d2d687c8d12bf1490944e73432851eb86974a6"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"d36b9e6029562f5ce7f1bba3db820a9c782428de","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    {{- if not $context.Values.__daemonset_yaml.metadata.name }}{{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" dict }}{{- end }}"},{"line_number":231,"context_line":"    {{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" $current_dict.dns_1123_name }}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    {{/* set container names and add to the list of containers for the pod */}}"},{"line_number":234,"context_line":"    {{- $_ :\u003d set $context.Values \"__containers_list\" ( list ) }}"},{"line_number":235,"context_line":"    {{- range $container :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":236,"context_line":"    {{- if eq $container.name \"osd-pod\" }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3fa7e38b_8ea8c3d9","side":"PARENT","line":233,"range":{"start_line":233,"start_character":0,"end_line":233,"end_character":79},"in_reply_to":"3fa7e38b_4bcde72e","updated":"2019-11-07 17:46:17.000000000","message":"Thanks Craig","commit_id":"81d2d687c8d12bf1490944e73432851eb86974a6"}]}