)]}'
{"rabbitmq/templates/monitoring/prometheus/exporter-deployment.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"ce4001e910bbc906356d83f3aa3402e8564fdb67","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{{ dict \"envAll\" $envAll \"component\" \"prometheus_rabbitmq_exporter\" \"container\" \"rabbitmq_exporter\" \"type\" \"liveness\" \"probeTemplate\" (include \"exporterProbeTemplate\" $envAll | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | trim | indent 10 }}"},{"line_number":62,"context_line":"          ports:"},{"line_number":63,"context_line":"            - name: metrics"},{"line_number":64,"context_line":"              containerPort: {{ $envAll.Values.network.prometheus_rabbitmq_exporter.port }}"},{"line_number":65,"context_line":"          env:"},{"line_number":66,"context_line":"          - name: RABBIT_URL"},{"line_number":67,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_5d8cbbd6","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":91},"updated":"2019-11-08 02:24:30.000000000","message":"Somewhat off topic from the probes, but this caught my attention.\n\nI see the port number is duplicated twice in values.yaml. Outside of this file, I only found this Value.network sub-key  referenced in exporter-service.yaml\n\nCould/Should these direct values references be replaced with HTK endpoint port lookup calls, and the duplicate port number be removed from values.yaml?","commit_id":"15edd49d9fdd1cad89a42b0fb0cbfd29b3fbd19d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"ce4001e910bbc906356d83f3aa3402e8564fdb67","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          - name: RABBIT_CAPABILITIES"},{"line_number":73,"context_line":"            value: {{ include \"helm-toolkit.utils.joinListWithComma\" $envAll.Values.conf.prometheus_exporter.capabilities | quote }}"},{"line_number":74,"context_line":"          - name: PUBLISH_PORT"},{"line_number":75,"context_line":"            value: {{ $envAll.Values.network.prometheus_rabbitmq_exporter.port | quote }}"},{"line_number":76,"context_line":"          - name: LOG_LEVEL"},{"line_number":77,"context_line":"            value: {{ $envAll.Values.conf.prometheus_exporter.log_level | quote }}"},{"line_number":78,"context_line":"          - name: SKIPVERIFY"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_9d59d35c","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":89},"updated":"2019-11-08 02:24:30.000000000","message":"Highlighting for the same reason.","commit_id":"15edd49d9fdd1cad89a42b0fb0cbfd29b3fbd19d"}],"rabbitmq/values.yaml":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"6eeb84b105de98dc43f2f2a4d076f53b7ffa1a7a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          enabled: true"},{"line_number":56,"context_line":"          params:"},{"line_number":57,"context_line":"            initialDelaySeconds: 30"},{"line_number":58,"context_line":"            periodSeconds: 15"},{"line_number":59,"context_line":"            timeoutSeconds: 65"},{"line_number":60,"context_line":"        liveness:"},{"line_number":61,"context_line":"          enabled: true"},{"line_number":62,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_b2fd1208","line":59,"range":{"start_line":58,"start_character":12,"end_line":59,"end_character":30},"updated":"2020-02-14 15:48:11.000000000","message":"This setting triggers probe before the current one times out. We\u0027ll have probes running in parallel, which caused a few  problems. Can you set the timeoutSeconds less than periodSeconds?","commit_id":"35354e56b258ceb9fd26c207cc1237da702b3df2"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"898c2add3bd191eaf0dc49649244006ba2a5024d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          enabled: true"},{"line_number":56,"context_line":"          params:"},{"line_number":57,"context_line":"            initialDelaySeconds: 30"},{"line_number":58,"context_line":"            periodSeconds: 15"},{"line_number":59,"context_line":"            timeoutSeconds: 65"},{"line_number":60,"context_line":"        liveness:"},{"line_number":61,"context_line":"          enabled: true"},{"line_number":62,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_2c575e2b","line":59,"range":{"start_line":58,"start_character":12,"end_line":59,"end_character":30},"in_reply_to":"3fa7e38b_b2fd1208","updated":"2020-02-18 16:35:36.000000000","message":"Agreed. I\u0027ve increased the period a little bit in order to lower the timeout to a value smaller than the period.","commit_id":"35354e56b258ceb9fd26c207cc1237da702b3df2"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"6eeb84b105de98dc43f2f2a4d076f53b7ffa1a7a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          params:"},{"line_number":63,"context_line":"            initialDelaySeconds: 120"},{"line_number":64,"context_line":"            periodSeconds: 90"},{"line_number":65,"context_line":"            timeoutSeconds: 70"},{"line_number":66,"context_line":"  security_context:"},{"line_number":67,"context_line":"    exporter:"},{"line_number":68,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_120e6632","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":30},"updated":"2020-02-14 15:48:11.000000000","message":"If the probe template is same for both liveness and readiness probes, why the periodSeconds and timeoutSeconds differ?","commit_id":"35354e56b258ceb9fd26c207cc1237da702b3df2"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3303aafc542d11d678e61e74e7af5b8b40e4c1e6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          params:"},{"line_number":63,"context_line":"            initialDelaySeconds: 120"},{"line_number":64,"context_line":"            periodSeconds: 90"},{"line_number":65,"context_line":"            timeoutSeconds: 70"},{"line_number":66,"context_line":"  security_context:"},{"line_number":67,"context_line":"    exporter:"},{"line_number":68,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8d18e9ce","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":30},"in_reply_to":"3fa7e38b_120e6632","updated":"2020-02-17 14:21:11.000000000","message":"Liveness probes are almost always set to have longer initial delays, periods of execution, and occasionally timeouts. The reason being a liveness probe will forcefully kill the process if the probe fails as it\u0027s assumed the process is truly borked and has been unready/unresponsive for some period of time, whereas the readiness probe just indicates the process is unready but has the potential to recover. It does not make sense to have these two probes that serve two very different purposes have the same execution periods and timeouts.","commit_id":"35354e56b258ceb9fd26c207cc1237da702b3df2"}]}