)]}'
{"mariadb/templates/configmap-ingress-etc.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"56052e97f837182e01c94b392df9cc58a9b215c5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: mariadb-ingress-etc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_0a3694b5","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":14},"updated":"2019-11-18 03:29:39.000000000","message":"this would need to be guarded by something like:\n\n   {{- if .Values.manifests.configmap_ingress_etc }}\n\nto be consistent.","commit_id":"8dac11d46e1b095b6f54f1d04a4347147d7ba8c5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bee48060de2c7a6e3e70c9215018629b3643a8de","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: mariadb-ingress-etc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e5cb29a1","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"3fa7e38b_0a3694b5","updated":"2019-11-18 07:39:06.000000000","message":"the condition you\u0027ve mentioned will be dead, as it is not possible to deploy ingress without having conafigmaps with configuration, any reason to add dead flags to helm charts?\nIMO we have to remove them.","commit_id":"8dac11d46e1b095b6f54f1d04a4347147d7ba8c5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3467d0b539092975daf3ad5da404c205b9ee9236","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: mariadb-ingress-etc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e0ac7089","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"3fa7e38b_af20ab4a","updated":"2019-11-18 16:57:32.000000000","message":"@Steve @Tin we believe that the flag is useless, because at [1] the configmap is required by deployment. So if we disable configmap using its flag this will lead to deployment failure, because configmap isn\u0027t found\n\n[1] https://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dmariadb/templates/deployment-ingress.yaml;h\u003d5f0bfab64d9e77971c6dc28fe2a8857af7d4ac7a;hb\u003drefs/heads/master#l199","commit_id":"8dac11d46e1b095b6f54f1d04a4347147d7ba8c5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c7a415057d04eefce77c327c290fb56d1b3b5e09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: mariadb-ingress-etc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_5a43f3b0","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"3fa7e38b_af20ab4a","updated":"2019-11-18 15:21:38.000000000","message":"what is the reason to add flags to manifest that control creation of resource, while if flat set to false deployment of helm release will fail?","commit_id":"8dac11d46e1b095b6f54f1d04a4347147d7ba8c5"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3c84697a6601c49d3775b345358fe2ae65f61d16","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: mariadb-ingress-etc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_af20ab4a","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"3fa7e38b_e5cb29a1","updated":"2019-11-18 13:56:38.000000000","message":"I don\u0027t follow your statement Vasyl. The same could be true of every other chart we have. The standard has always been to wrap every object template with a conditional check. The same needs to happen here for this to be considered.","commit_id":"8dac11d46e1b095b6f54f1d04a4347147d7ba8c5"}]}