)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"b44b40717a5edd1c2dc93e7c311342995a23c4af","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change updates the ingress deployment as follows:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adds a 5s sleep before the shutdown of the ingress container in order to"},{"line_number":17,"context_line":"allow the preStop action of the ingress-vip container to run completely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Updates the start action of the ingress-vip-init container to check if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_cd72cc7c","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":15},"updated":"2019-11-18 18:59:37.000000000","message":"seems perfectly reasonable, but if we are looking for more assurances, could communicate completion via e.g. /tmp/ingress_vip_stopped","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"1305da7f41bf124bb9ed704abd1061cbaf92617b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change updates the ingress deployment as follows:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adds a 5s sleep before the shutdown of the ingress container in order to"},{"line_number":17,"context_line":"allow the preStop action of the ingress-vip container to run completely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Updates the start action of the ingress-vip-init container to check if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_3303ab0e","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":15},"in_reply_to":"3fa7e38b_356cf305","updated":"2019-11-19 21:17:03.000000000","message":"No need to follow up from my perspective. Even if we added strict ordering, I assume we\u0027d want an escape hatch to timeout and move on after X seconds.","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"3d16f8ad59e95a6b630fac2ec3512561de111d59","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change updates the ingress deployment as follows:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adds a 5s sleep before the shutdown of the ingress container in order to"},{"line_number":17,"context_line":"allow the preStop action of the ingress-vip container to run completely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Updates the start action of the ingress-vip-init container to check if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_356cf305","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":15},"in_reply_to":"3fa7e38b_cd72cc7c","updated":"2019-11-19 20:10:21.000000000","message":"I went back and forth on this, but I think for now just a simple timer might be safer than potentially introducing some sort of race condition that could hang up the controller container. Can we defer for a possible future enhancement?","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"}],"ingress/templates/deployment-ingress.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"28aa0a16847368629612d383349927903945dc98","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            preStop:"},{"line_number":299,"context_line":"              exec:"},{"line_number":300,"context_line":"                command:"},{"line_number":301,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":302,"context_line":"                  - sleep"},{"line_number":303,"context_line":"                  - \"5\""},{"line_number":304,"context_line":"                  - \"\u0026\u0026\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_b3a55b4a","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":71},"updated":"2019-11-19 22:35:09.000000000","message":"should we just bake this in for everything instead of just this case?","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3f42f6f543de8c2744df0c94fd7134251015f534","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            preStop:"},{"line_number":299,"context_line":"              exec:"},{"line_number":300,"context_line":"                command:"},{"line_number":301,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":302,"context_line":"                  - sleep"},{"line_number":303,"context_line":"                  - \"5\""},{"line_number":304,"context_line":"                  - \"\u0026\u0026\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_fe8b9365","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":71},"in_reply_to":"3fa7e38b_8e2b5880","updated":"2019-11-20 12:47:07.000000000","message":"This seems okay to me, but wondering if it makes sense to just wrap this sleep in a conditional in the actual stop function itself","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"07df4bde138a22f468938bfeb133c86a116112b9","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            preStop:"},{"line_number":299,"context_line":"              exec:"},{"line_number":300,"context_line":"                command:"},{"line_number":301,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":302,"context_line":"                  - sleep"},{"line_number":303,"context_line":"                  - \"5\""},{"line_number":304,"context_line":"                  - \"\u0026\u0026\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8e2b5880","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":71},"in_reply_to":"3fa7e38b_b3a55b4a","updated":"2019-11-19 22:52:39.000000000","message":"This is the same condition that controls whether the ingress-vip container exists - if it doesn\u0027t, a sleep is unnecessary.","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6f3a5ef334f395fc36ea4bfb1b67c753425a1e6b","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            preStop:"},{"line_number":299,"context_line":"              exec:"},{"line_number":300,"context_line":"                command:"},{"line_number":301,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":302,"context_line":"                  - sleep"},{"line_number":303,"context_line":"                  - \"5\""},{"line_number":304,"context_line":"                  - \"\u0026\u0026\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_79e49da8","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":71},"in_reply_to":"3fa7e38b_fe8b9365","updated":"2019-11-20 14:30:49.000000000","message":"I\u0027d think it makes sense - having logic in the yaml template  make it kind of messy.","commit_id":"590d35ebd415298414341ae374f32f79265a1dc1"}]}