)]}'
{"kafka/templates/bin/_generate_acl.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $zookeeper :\u003d (tuple \"zookeeper\" \"internal\" \"client\" $envAll | include \"helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup\") -}}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -ex"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_fde0e099","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":138},"updated":"2019-12-02 19:43:01.000000000","message":"Can we instead define this as an env variable on the pod? Mixing gotpl and shell scripting always looks messy","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $zookeeper :\u003d (tuple \"zookeeper\" \"internal\" \"client\" $envAll | include \"helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup\") -}}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -ex"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_d813b2b6","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":138},"in_reply_to":"3fa7e38b_fde0e099","updated":"2019-12-02 20:13:35.000000000","message":"Totally - It\u0027s actually already in the env haha","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"kafka/templates/configmap-etc.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: kafka-etc"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":27,"context_line":"  jaas.conf: |"},{"line_number":28,"context_line":"{{ tuple \"etc/_jaas.conf.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc | indent 4}}"},{"line_number":29,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3dae782f","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":40},"updated":"2019-12-02 19:43:01.000000000","message":"We could probably remove this and rely on the configmap_etc conditional alone","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: kafka-etc"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":27,"context_line":"  jaas.conf: |"},{"line_number":28,"context_line":"{{ tuple \"etc/_jaas.conf.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc | indent 4}}"},{"line_number":29,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_780abe79","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":40},"in_reply_to":"3fa7e38b_3dae782f","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"kafka/templates/etc/_jaas.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $adminCredentials :\u003d .Values.endpoints.kafka.auth.admin }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $exporter :\u003d .Values.conf.kafka.auth.exporter -}}"},{"line_number":21,"context_line":"{{- $producers :\u003d .Values.conf.kafka.auth.producers -}}"},{"line_number":22,"context_line":"{{- $consumers :\u003d .Values.conf.kafka.auth.consumers -}}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"KafkaServer {"},{"line_number":25,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":26,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":27,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":28,"context_line":"    user_{{ $adminCredentials.username }}\u003d{{ $adminCredentials.password | quote }}"},{"line_number":29,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":30,"context_line":"    user_{{ $exporter.username }}\u003d{{ $exporter.password | quote }}"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"{{- range $producer, $credentials :\u003d $producers }}"},{"line_number":33,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":34,"context_line":"{{- end }}"},{"line_number":35,"context_line":"{{- range $consumer, $credentials :\u003d $consumers }}"},{"line_number":36,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":"    {{- printf \";\" }}"},{"line_number":39,"context_line":"};"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"KafkaClient {"},{"line_number":42,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":43,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":44,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":45,"context_line":"    {{- printf \";\" }}"},{"line_number":46,"context_line":"};"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Client {"},{"line_number":49,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":50,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":51,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":52,"context_line":"    {{- printf \";\" }}"},{"line_number":53,"context_line":"};"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_9d3a0ce4","line":53,"range":{"start_line":17,"start_character":0,"end_line":53,"end_character":2},"updated":"2019-12-02 19:43:01.000000000","message":"Is it possible to define this inline in the values.yaml, similar to what we do with some of the other configuration files? It would eliminate the need to maintain a separate template file and can be customized as needed via values overrides instead of requiring updates to a template file","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $adminCredentials :\u003d .Values.endpoints.kafka.auth.admin }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $exporter :\u003d .Values.conf.kafka.auth.exporter -}}"},{"line_number":21,"context_line":"{{- $producers :\u003d .Values.conf.kafka.auth.producers -}}"},{"line_number":22,"context_line":"{{- $consumers :\u003d .Values.conf.kafka.auth.consumers -}}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"KafkaServer {"},{"line_number":25,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":26,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":27,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":28,"context_line":"    user_{{ $adminCredentials.username }}\u003d{{ $adminCredentials.password | quote }}"},{"line_number":29,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":30,"context_line":"    user_{{ $exporter.username }}\u003d{{ $exporter.password | quote }}"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"{{- range $producer, $credentials :\u003d $producers }}"},{"line_number":33,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":34,"context_line":"{{- end }}"},{"line_number":35,"context_line":"{{- range $consumer, $credentials :\u003d $consumers }}"},{"line_number":36,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":37,"context_line":"{{- end }}"},{"line_number":38,"context_line":"    {{- printf \";\" }}"},{"line_number":39,"context_line":"};"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"KafkaClient {"},{"line_number":42,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":43,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":44,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":45,"context_line":"    {{- printf \";\" }}"},{"line_number":46,"context_line":"};"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Client {"},{"line_number":49,"context_line":"    org.apache.kafka.common.security.plain.PlainLoginModule required"},{"line_number":50,"context_line":"    username\u003d{{ $adminCredentials.username | quote }}"},{"line_number":51,"context_line":"    password\u003d{{ $adminCredentials.password | quote }}"},{"line_number":52,"context_line":"    {{- printf \";\" }}"},{"line_number":53,"context_line":"};"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_18194ad0","line":53,"range":{"start_line":17,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"3fa7e38b_9d3a0ce4","updated":"2019-12-02 20:13:35.000000000","message":"Should be possible, I\u0027ll give it a try in the next PS","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"kafka/templates/job-generate-acl.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c2a42a327fca41d973a5d11eb2600ef72a42b737","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if and (.Values.manifests.job_generate_acl) }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $KafkaUserSecret :\u003d .Values.secrets.kafka.admin }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_7c710445","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":47},"updated":"2019-12-06 21:02:55.000000000","message":"Don\u0027t think we need an \u0027and\u0027 here","commit_id":"13e11218be9078fc9ec3678b85746cde868cfad6"}],"kafka/templates/monitoring/prometheus/bin/_kafka-exporter.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function start () {"},{"line_number":22,"context_line":"  exec /bin/kafka_exporter \\"},{"line_number":23,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":24,"context_line":"{{- $credentials :\u003d .Values.conf.kafka.auth.exporter }}"},{"line_number":25,"context_line":"        --sasl.enabled \\"},{"line_number":26,"context_line":"        --sasl.username\u003d{{ $credentials.username }} \\"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_dd196487","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":40},"updated":"2019-12-02 19:43:01.000000000","message":"We can remove this and just always enable auth by default","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function start () {"},{"line_number":22,"context_line":"  exec /bin/kafka_exporter \\"},{"line_number":23,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":24,"context_line":"{{- $credentials :\u003d .Values.conf.kafka.auth.exporter }}"},{"line_number":25,"context_line":"        --sasl.enabled \\"},{"line_number":26,"context_line":"        --sasl.username\u003d{{ $credentials.username }} \\"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_d87892f8","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":40},"in_reply_to":"3fa7e38b_dd196487","updated":"2019-12-02 20:13:35.000000000","message":"Sounds good","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"kafka/templates/statefulset.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            - name: KAFKA_CREATE_TOPICS"},{"line_number":123,"context_line":"              value: \"{{ include \"helm-toolkit.utils.joinListWithComma\" .Values.conf.kafka.topics }}\""},{"line_number":124,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":125,"context_line":"            - name: KAFKA_OPTS"},{"line_number":126,"context_line":"              value: \"-Djava.security.auth.login.config\u003d/opt/kafka/config/jaas.conf\""},{"line_number":127,"context_line":"{{- end }}"},{"line_number":128,"context_line":"          readinessProbe:"},{"line_number":129,"context_line":"            initialDelaySeconds: 20"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9808da27","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":84},"updated":"2019-12-02 19:43:01.000000000","message":"Can we just make this customizable via values.yaml, with this value being the default?","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            - name: KAFKA_CREATE_TOPICS"},{"line_number":123,"context_line":"              value: \"{{ include \"helm-toolkit.utils.joinListWithComma\" .Values.conf.kafka.topics }}\""},{"line_number":124,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":125,"context_line":"            - name: KAFKA_OPTS"},{"line_number":126,"context_line":"              value: \"-Djava.security.auth.login.config\u003d/opt/kafka/config/jaas.conf\""},{"line_number":127,"context_line":"{{- end }}"},{"line_number":128,"context_line":"          readinessProbe:"},{"line_number":129,"context_line":"            initialDelaySeconds: 20"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5864a24d","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":84},"in_reply_to":"3fa7e38b_9808da27","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"              mountPath: /tmp/kafka-readiness.sh"},{"line_number":157,"context_line":"              subPath: kafka-readiness.sh"},{"line_number":158,"context_line":"              readOnly: true"},{"line_number":159,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":160,"context_line":"            - name: kafka-etc"},{"line_number":161,"context_line":"              mountPath: /opt/kafka/config/jaas.conf"},{"line_number":162,"context_line":"              subPath: jaas.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5d057414","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":40},"updated":"2019-12-02 19:43:01.000000000","message":"We can just remove this conditional and always enforce authentication","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"              mountPath: /tmp/kafka-readiness.sh"},{"line_number":157,"context_line":"              subPath: kafka-readiness.sh"},{"line_number":158,"context_line":"              readOnly: true"},{"line_number":159,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":160,"context_line":"            - name: kafka-etc"},{"line_number":161,"context_line":"              mountPath: /opt/kafka/config/jaas.conf"},{"line_number":162,"context_line":"              subPath: jaas.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_98821ac7","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":40},"in_reply_to":"3fa7e38b_5d057414","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"          configMap:"},{"line_number":174,"context_line":"            name: kafka-bin"},{"line_number":175,"context_line":"            defaultMode: 0555"},{"line_number":176,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":177,"context_line":"        - name: kafka-etc"},{"line_number":178,"context_line":"          secret:"},{"line_number":179,"context_line":"            secretName: kafka-etc"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1dfffc02","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":41},"updated":"2019-12-02 19:43:01.000000000","message":"Can be removed","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":173,"context_line":"          configMap:"},{"line_number":174,"context_line":"            name: kafka-bin"},{"line_number":175,"context_line":"            defaultMode: 0555"},{"line_number":176,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":177,"context_line":"        - name: kafka-etc"},{"line_number":178,"context_line":"          secret:"},{"line_number":179,"context_line":"            secretName: kafka-etc"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3869a625","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":41},"in_reply_to":"3fa7e38b_1dfffc02","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"kafka/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      # - \"mytopic:1:1\""},{"line_number":299,"context_line":"    auth:"},{"line_number":300,"context_line":"      exporter:"},{"line_number":301,"context_line":"        username: kafka-exporter"},{"line_number":302,"context_line":"        password: changeme"},{"line_number":303,"context_line":"      producers:"},{"line_number":304,"context_line":"        region_a:"},{"line_number":305,"context_line":"          username: region-a-producer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_580a621e","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":26},"updated":"2019-12-02 19:43:01.000000000","message":"Can we define these under the endpoints entry for the exporter instead?","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      # - \"mytopic:1:1\""},{"line_number":299,"context_line":"    auth:"},{"line_number":300,"context_line":"      exporter:"},{"line_number":301,"context_line":"        username: kafka-exporter"},{"line_number":302,"context_line":"        password: changeme"},{"line_number":303,"context_line":"      producers:"},{"line_number":304,"context_line":"        region_a:"},{"line_number":305,"context_line":"          username: region-a-producer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f8722e12","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":26},"in_reply_to":"3fa7e38b_580a621e","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      exporter:"},{"line_number":301,"context_line":"        username: kafka-exporter"},{"line_number":302,"context_line":"        password: changeme"},{"line_number":303,"context_line":"      producers:"},{"line_number":304,"context_line":"        region_a:"},{"line_number":305,"context_line":"          username: region-a-producer"},{"line_number":306,"context_line":"          password: changeme"},{"line_number":307,"context_line":"          topic: region-a"},{"line_number":308,"context_line":"      consumers:"},{"line_number":309,"context_line":"        region_a:"},{"line_number":310,"context_line":"          username: region-a-consumer"},{"line_number":311,"context_line":"          password: changeme"},{"line_number":312,"context_line":"          topic: region-a"},{"line_number":313,"context_line":"          group: region-a"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_383d26bc","line":313,"range":{"start_line":303,"start_character":0,"end_line":313,"end_character":25},"updated":"2019-12-02 19:43:01.000000000","message":"If we move to defining the config file inline in the values.yaml, we can then tie these values closer to their intended consumer (see for example: https://github.com/openstack/openstack-helm-infra/blob/master/grafana/values.yaml#L389-L420)","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      exporter:"},{"line_number":301,"context_line":"        username: kafka-exporter"},{"line_number":302,"context_line":"        password: changeme"},{"line_number":303,"context_line":"      producers:"},{"line_number":304,"context_line":"        region_a:"},{"line_number":305,"context_line":"          username: region-a-producer"},{"line_number":306,"context_line":"          password: changeme"},{"line_number":307,"context_line":"          topic: region-a"},{"line_number":308,"context_line":"      consumers:"},{"line_number":309,"context_line":"        region_a:"},{"line_number":310,"context_line":"          username: region-a-consumer"},{"line_number":311,"context_line":"          password: changeme"},{"line_number":312,"context_line":"          topic: region-a"},{"line_number":313,"context_line":"          group: region-a"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f84b0eae","line":313,"range":{"start_line":303,"start_character":0,"end_line":313,"end_character":25},"in_reply_to":"3fa7e38b_383d26bc","updated":"2019-12-02 20:13:35.000000000","message":"I\u0027ll give this a try in the next PS.","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"zookeeper/templates/configmap-etc.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"type: Opaque"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.zookeeper.template \"key\" \"zoo.cfg\" \"format\" \"Secret\") | indent 2 }}"},{"line_number":28,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":29,"context_line":"  jaas.conf: |"},{"line_number":30,"context_line":"{{ tuple \"etc/_jaas.conf.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc | indent 4}}"},{"line_number":31,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1842aa3c","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":40},"updated":"2019-12-02 19:43:01.000000000","message":"This can be removed","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"type: Opaque"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.zookeeper.template \"key\" \"zoo.cfg\" \"format\" \"Secret\") | indent 2 }}"},{"line_number":28,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":29,"context_line":"  jaas.conf: |"},{"line_number":30,"context_line":"{{ tuple \"etc/_jaas.conf.tpl\" . | include \"helm-toolkit.utils.template\" | b64enc | indent 4}}"},{"line_number":31,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d8c65216","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":40},"in_reply_to":"3fa7e38b_1842aa3c","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"zookeeper/templates/etc/_jaas.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if not (empty .Values.conf.zookeeper.auth.kafka) }}"},{"line_number":18,"context_line":"{{- $credentials :\u003d .Values.conf.zookeeper.auth.kafka -}}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Server {"},{"line_number":21,"context_line":"    org.apache.zookeeper.server.auth.DigestLoginModule required"},{"line_number":22,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":23,"context_line":"    {{- printf \";\" }}"},{"line_number":24,"context_line":"};"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_d875f298","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":10},"updated":"2019-12-02 19:43:01.000000000","message":"Same feedback as with kafka config file","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if not (empty .Values.conf.zookeeper.auth.kafka) }}"},{"line_number":18,"context_line":"{{- $credentials :\u003d .Values.conf.zookeeper.auth.kafka -}}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Server {"},{"line_number":21,"context_line":"    org.apache.zookeeper.server.auth.DigestLoginModule required"},{"line_number":22,"context_line":"    user_{{ $credentials.username }}\u003d{{ $credentials.password | quote }}"},{"line_number":23,"context_line":"    {{- printf \";\" }}"},{"line_number":24,"context_line":"};"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_78cdde2e","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":10},"in_reply_to":"3fa7e38b_d875f298","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"zookeeper/templates/statefulset.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"              value: \"{{ .Values.conf.zookeeper.config.data_directory }}\""},{"line_number":154,"context_line":"            - name: ZOO_CLIENT_PORT"},{"line_number":155,"context_line":"              value: \"{{ tuple \"zookeeper\" \"internal\" \"client\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\""},{"line_number":156,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":157,"context_line":"            - name: SERVER_JVMFLAGS"},{"line_number":158,"context_line":"              value: \"-Djava.security.auth.login.config\u003d/conf/jaas.conf\""},{"line_number":159,"context_line":"{{- end }}"},{"line_number":160,"context_line":"          readinessProbe:"},{"line_number":161,"context_line":"            initialDelaySeconds: 20"},{"line_number":162,"context_line":"            periodSeconds: 30"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_786cfecf","line":159,"range":{"start_line":156,"start_character":0,"end_line":159,"end_character":10},"updated":"2019-12-02 19:43:01.000000000","message":"Same as kafka","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"              value: \"{{ .Values.conf.zookeeper.config.data_directory }}\""},{"line_number":154,"context_line":"            - name: ZOO_CLIENT_PORT"},{"line_number":155,"context_line":"              value: \"{{ tuple \"zookeeper\" \"internal\" \"client\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\""},{"line_number":156,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":157,"context_line":"            - name: SERVER_JVMFLAGS"},{"line_number":158,"context_line":"              value: \"-Djava.security.auth.login.config\u003d/conf/jaas.conf\""},{"line_number":159,"context_line":"{{- end }}"},{"line_number":160,"context_line":"          readinessProbe:"},{"line_number":161,"context_line":"            initialDelaySeconds: 20"},{"line_number":162,"context_line":"            periodSeconds: 30"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_98d0daca","line":159,"range":{"start_line":156,"start_character":0,"end_line":159,"end_character":10},"in_reply_to":"3fa7e38b_786cfecf","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            - name: zookeeper-etc"},{"line_number":184,"context_line":"              mountPath: /conf/zoo.cfg"},{"line_number":185,"context_line":"              subPath: zoo.cfg"},{"line_number":186,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":187,"context_line":"            - name: zookeeper-etc"},{"line_number":188,"context_line":"              mountPath: /conf/jaas.conf"},{"line_number":189,"context_line":"              subPath: jaas.conf"},{"line_number":190,"context_line":"{{- end }}"},{"line_number":191,"context_line":"            - name: zookeeper-bin"},{"line_number":192,"context_line":"              mountPath: /tmp/zookeeper.sh"},{"line_number":193,"context_line":"              subPath: zookeeper.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_986f7ac3","line":190,"range":{"start_line":186,"start_character":0,"end_line":190,"end_character":10},"updated":"2019-12-02 19:43:01.000000000","message":"Same as kafka","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            - name: zookeeper-etc"},{"line_number":184,"context_line":"              mountPath: /conf/zoo.cfg"},{"line_number":185,"context_line":"              subPath: zoo.cfg"},{"line_number":186,"context_line":"{{- if .Values.manifests.secret_kafka }}"},{"line_number":187,"context_line":"            - name: zookeeper-etc"},{"line_number":188,"context_line":"              mountPath: /conf/jaas.conf"},{"line_number":189,"context_line":"              subPath: jaas.conf"},{"line_number":190,"context_line":"{{- end }}"},{"line_number":191,"context_line":"            - name: zookeeper-bin"},{"line_number":192,"context_line":"              mountPath: /tmp/zookeeper.sh"},{"line_number":193,"context_line":"              subPath: zookeeper.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_38d766c3","line":190,"range":{"start_line":186,"start_character":0,"end_line":190,"end_character":10},"in_reply_to":"3fa7e38b_986f7ac3","updated":"2019-12-02 20:13:35.000000000","message":"Done","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"}],"zookeeper/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"68f8bb3dd93f9d5ca20123765a2203e9ad7991b7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"      {{- $ensembleCount :\u003d add $podInt 1 }}"},{"line_number":251,"context_line":"      server.{{$ensembleCount}}\u003dzookeeper-{{$podInt}}.{{$domain}}:{{$serverPort}}:{{$electionPort}}:participant;{{$clientPort}}"},{"line_number":252,"context_line":"      {{- end }}"},{"line_number":253,"context_line":"    auth:"},{"line_number":254,"context_line":"      kafka:"},{"line_number":255,"context_line":"        username: admin"},{"line_number":256,"context_line":"        password: changeme"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_586102d4","line":256,"range":{"start_line":253,"start_character":0,"end_line":256,"end_character":26},"updated":"2019-12-02 19:43:01.000000000","message":"Can we instead put this under a config key, similar to: https://github.com/openstack/openstack-helm-infra/blob/master/grafana/values.yaml#L389-L420","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5bfd9d5a1b9982e4152c6677b060fa7c84f57db9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"      {{- $ensembleCount :\u003d add $podInt 1 }}"},{"line_number":251,"context_line":"      server.{{$ensembleCount}}\u003dzookeeper-{{$podInt}}.{{$domain}}:{{$serverPort}}:{{$electionPort}}:participant;{{$clientPort}}"},{"line_number":252,"context_line":"      {{- end }}"},{"line_number":253,"context_line":"    auth:"},{"line_number":254,"context_line":"      kafka:"},{"line_number":255,"context_line":"        username: admin"},{"line_number":256,"context_line":"        password: changeme"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d8ef3284","line":256,"range":{"start_line":253,"start_character":0,"end_line":256,"end_character":26},"in_reply_to":"3fa7e38b_586102d4","updated":"2019-12-02 20:13:35.000000000","message":"Just under conf.zookeeper.config?","commit_id":"7ad31c98b7726448955c6a3b3dad8d3fe85e524d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c2a42a327fca41d973a5d11eb2600ef72a42b737","unresolved":false,"context_lines":[{"line_number":249,"context_line":"      jaasLoginRenew\u003d3600000"},{"line_number":250,"context_line":"      requireClientAuthScheme\u003dsasl"},{"line_number":251,"context_line":"    jaas:"},{"line_number":252,"context_line":"      kafka:"},{"line_number":253,"context_line":"        admin:"},{"line_number":254,"context_line":"          username: admin"},{"line_number":255,"context_line":"          password: changeme"},{"line_number":256,"context_line":"      template: |"},{"line_number":257,"context_line":"        {{- $admin :\u003d .Values.conf.zookeeper.jaas.kafka.admin }}"},{"line_number":258,"context_line":"        Server {"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_bca0dc92","line":255,"range":{"start_line":252,"start_character":0,"end_line":255,"end_character":28},"updated":"2019-12-06 21:02:55.000000000","message":"Any chance we can scope this under the endpoints section instead?","commit_id":"13e11218be9078fc9ec3678b85746cde868cfad6"}]}