)]}'
{"ceph-osd/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"21bbbecbfd14bdeca0763bc271763d59fe3c3d43","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_OSDS}\"  ]; then"},{"line_number":35,"context_line":"    echo \"Required number of OSDs (${MIN_OSDS}) are UP and IN status\""},{"line_number":36,"context_line":"  else"},{"line_number":37,"context_line":"    echo \"Required number of OSDs (${MIN_OSDS}) are NOT UP and IN status. Cluster shows OSD count\u003d${num_osd}, UP\u003d${num_up_osds}, IN\u003d${num_in_osds}\""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3fa7e38b_8077bcd1","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":39},"updated":"2019-12-06 14:40:39.000000000","message":"This isn\u0027t wrong, but given the logic above the only way MIN_OSDS can be greater than num_osd is if REQUIRED_PERCENT_OF_OSDS is greater than 100. That case will also fail the other checks on this line, so maybe this check isn\u0027t necessary.","commit_id":"be095ff4303586f72a290c77ae46a64a7c37068c"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"c0a43fb99a79a83aa255aa0d5295e82d6825a515","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [ \"${num_osd}\" -ge \"${MIN_OSDS}\" ] \u0026\u0026 [ \"${num_in_osds}\" -ge \"${MIN_OSDS}\" ] \u0026\u0026 [ \"${num_up_osds}\" -ge \"${MIN_OSDS}\"  ]; then"},{"line_number":35,"context_line":"    echo \"Required number of OSDs (${MIN_OSDS}) are UP and IN status\""},{"line_number":36,"context_line":"  else"},{"line_number":37,"context_line":"    echo \"Required number of OSDs (${MIN_OSDS}) are NOT UP and IN status. Cluster shows OSD count\u003d${num_osd}, UP\u003d${num_up_osds}, IN\u003d${num_in_osds}\""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3fa7e38b_3b095994","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":39},"in_reply_to":"3fa7e38b_8077bcd1","updated":"2019-12-06 15:23:34.000000000","message":"thanks for the feedback. checking in update to remove this and also adding back check for num_osd equals 0","commit_id":"be095ff4303586f72a290c77ae46a64a7c37068c"}]}