)]}'
{"id":"openstack%2Fopenstack-helm-infra~697749","triplet_id":"openstack%2Fopenstack-helm-infra~master~I9d3d630b53a2f3d828866229a5072bb04440ae15","project":"openstack/openstack-helm-infra","branch":"master","topic":"fix/fg-override","hashtags":[],"change_id":"I9d3d630b53a2f3d828866229a5072bb04440ae15","subject":"Fix feature gate envvar overriding","status":"MERGED","created":"2019-12-07 06:01:18.000000000","updated":"2019-12-09 21:26:45.000000000","submitted":"2019-12-09 21:25:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697749-1575926708848-a6c9ab22","meta_rev_id":"7a93c3d4b9052d5ab575cd7db7130f47bde32df9","_number":697749,"virtual_id_number":697749,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-09 21:25:08.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"recommended":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"all":[{"value":1,"date":"2019-12-09 17:27:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":2,"date":"2019-12-09 20:39:18.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2019-12-09 16:03:41.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2019-12-09 20:26:36.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":1,"date":"2019-12-09 20:39:18.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2019-12-09 20:26:36.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-09 16:03:41.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2019-12-09 17:27:48.000000000","updated_by":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"reviewer":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"state":"REVIEWER"},{"updated":"2019-12-09 20:26:36.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2019-12-09 20:39:18.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2019-12-09 21:25:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5a4584004b9f28bc0c52c4a0d12d3a1cb20146ae","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-12-07 06:01:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21e20539d23519b01b5e37b4fce4e1cfbebd464a","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-12-07 06:02:38.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"2d71faef0fe541f80152318b3acea4c084fda93b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 06:57:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66c431c7520d4c718d5721923df3259c : SUCCESS in 4m 41s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/73d308c0b71f402eb106972e123ae06f : SUCCESS in 2m 32s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/696f14dbcca04dda9278ce30356663de : SUCCESS in 49m 48s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/4395a36761ee4d87acf5ee0a0367327f : SUCCESS in 49m 09s\n- openstack-helm-infra-federated-monitoring https://zuul.opendev.org/t/openstack/build/9cec6f26836e4bc1ab80faf3bdf77e77 : SUCCESS in 31m 02s (non-voting)\n- openstack-helm-infra-kafka https://zuul.opendev.org/t/openstack/build/219a5ec1a7004d73a50c9acf30690c60 : SUCCESS in 34m 39s (non-voting)\n- openstack-helm-infra-aio-network-policy https://zuul.opendev.org/t/openstack/build/85dd7848feb548549e86479684367985 : FAILURE in 45m 03s (non-voting)\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/c53fc7d0ace84a6a87b5fde40763a2c9 : SUCCESS in 47m 53s\n- openstack-helm-infra-kubernetes-keystone-auth https://zuul.opendev.org/t/openstack/build/83c3f1c89eef4c7bbc62732fd7b75854 : SUCCESS in 47m 54s (non-voting)\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/c19d7443500445788648eeb471d08279 : SUCCESS in 13m 56s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy https://zuul.opendev.org/t/openstack/build/065b31d41204486888041485dec1a97d : FAILURE in 15m 50s (non-voting)\n- openstack-helm-infra-apparmor https://zuul.opendev.org/t/openstack/build/a6bdb640ef5949218d0464907b01c5e6 : FAILURE in 42m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"898095ca77975457f253733f65587acab1e01db4","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2019-12-07 18:22:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80ba27cbdac44c9d321e0b55326043844e6ce421","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 19:13:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b9bfec143fa4d66970241be7f94fcf2 : SUCCESS in 2m 53s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/1e0f058714804d668b8d7f424f3a64fc : SUCCESS in 1m 28s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/bfef58c396784e5bb607179a99d69022 : SUCCESS in 45m 36s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/5ef1275770c842e79b4e194d3ecd12cd : SUCCESS in 35m 38s\n- openstack-helm-infra-federated-monitoring https://zuul.opendev.org/t/openstack/build/ba4933e5e6da4debb8188d92b5478d19 : SUCCESS in 32m 30s (non-voting)\n- openstack-helm-infra-kafka https://zuul.opendev.org/t/openstack/build/48c39f827be341e6a07fda52dd500ea6 : SUCCESS in 32m 24s (non-voting)\n- openstack-helm-infra-aio-network-policy https://zuul.opendev.org/t/openstack/build/8f9b0d9996784e138cc3bcffb6ab91e0 : FAILURE in 40m 27s (non-voting)\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/6638ebdf749a41e299d6c9521dc708d2 : SUCCESS in 44m 18s\n- openstack-helm-infra-kubernetes-keystone-auth https://zuul.opendev.org/t/openstack/build/f3fe876f183d4832888782841832f3f3 : SUCCESS in 45m 41s (non-voting)\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/2cf649a9d7564abc831a2ac962e32a4b : SUCCESS in 12m 24s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy https://zuul.opendev.org/t/openstack/build/195f12c388ce4c0ca5974450007deb15 : FAILURE in 12m 30s (non-voting)\n- openstack-helm-infra-apparmor https://zuul.opendev.org/t/openstack/build/eb419f24aa1d4d769da3d6dff0d5b7a6 : FAILURE in 37m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0f978705d0d6909e387ed97e8292d5404e744dc9","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2019-12-09 16:03:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"03ba45ca6f7887743984e1a5394a15458a7c6117","author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"date":"2019-12-09 17:27:48.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f3c539f9bef0dedb3bc302efc7f7a0a8faa7116c","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2019-12-09 20:26:36.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9c21f7618a57656f569d66a075d9ec2eda5fdca4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 20:26:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9b59a5fca0e23eb87cfdb4c70580135ad2969c66","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2019-12-09 20:39:18.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6f76cda4b3ad69e11fade3ca3f6fa7d20f3622d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 21:25:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"8086e5a2e977956f9c6076393b2b358b3e3d0cb0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 21:25:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5a5371f5dc884820bf2748478ebdddbd : SUCCESS in 4m 47s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/3982ad83602541f0b3ea535f8c2d047d : SUCCESS in 1m 44s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/ab064959176e47c7ab3eb6ce58c312d8 : SUCCESS in 52m 09s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/8a234643017b4398907a5203bbc35361 : SUCCESS in 39m 34s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/13fa9fb33e7a42558474c83e285750e9 : SUCCESS in 45m 56s","accounts_in_message":[],"_revision_number":2},{"id":"fb9591faae97cab4d279abadf0125eabb7f40db8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 21:26:45.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/709bc3753c414bdd8d464e766e9a42e3 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ac18e6acf9bbc161147454e6a86bde086c9b8f6d","revisions":{"9df14b174717321d9cf6543a8982ee2e947d5fa6":{"kind":"REWORK","_number":1,"created":"2019-12-07 06:01:18.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/49/697749/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/49/697749/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/1"}}},"commit":{"parents":[{"commit":"d216fbf731a30d9617daa4a324064ca005aba685","subject":"Merge \"Elasticsearch: Remove unnecessary rbac definitions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/d216fbf731a30d9617daa4a324064ca005aba685"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2019-12-07 05:58:44.000000000","tz":-360},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2019-12-07 05:58:44.000000000","tz":-360},"subject":"Fix feature gate envvar overriding","message":"Fix feature gate envvar overriding\n\nCurrently using envsubst to perform substitution of value overrides in\nthe feature gate caused conflicts as gotpl gets templated into those\noverrides. This adds in \u0027%%%REPLACE_${var}%%%\u0027 and uses sed to perform\nthe substitution instead to address the issue.\n\nChange-Id: I9d3d630b53a2f3d828866229a5072bb04440ae15\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9df14b174717321d9cf6543a8982ee2e947d5fa6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9df14b174717321d9cf6543a8982ee2e947d5fa6"}]},"branch":"refs/heads/master"},"ac18e6acf9bbc161147454e6a86bde086c9b8f6d":{"kind":"REWORK","_number":2,"created":"2019-12-07 18:22:29.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/49/697749/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/49/697749/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/49/697749/2"}}},"commit":{"parents":[{"commit":"d216fbf731a30d9617daa4a324064ca005aba685","subject":"Merge \"Elasticsearch: Remove unnecessary rbac definitions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/d216fbf731a30d9617daa4a324064ca005aba685"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2019-12-07 05:58:44.000000000","tz":-360},"committer":{"name":"Tin Lam","email":"tlam@omegaprime.dev","date":"2019-12-07 18:22:16.000000000","tz":-360},"subject":"Fix feature gate envvar overriding","message":"Fix feature gate envvar overriding\n\nCurrently using envsubst to perform substitution of value overrides in\nthe feature gate caused conflicts as gotpl gets templated into those\noverrides. This adds in \u0027%%%REPLACE_${var}%%%\u0027 and uses sed to perform\nthe substitution instead to address the issue.\n\nChange-Id: I9d3d630b53a2f3d828866229a5072bb04440ae15\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ac18e6acf9bbc161147454e6a86bde086c9b8f6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ac18e6acf9bbc161147454e6a86bde086c9b8f6d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}